Teeworlds - development

Assa

@LordSk 🦋 do you have an issue for the editor for me? The last week I am on fire

and I want to do more as long as my motivation is up

I guess I could lay out the plan I have in mind and if you feel like tackling it that would be awesome

00:06

I'll try to open an issue tomorrow

@LordSk 🦋 already added an issue and a PR, you might want to Review it,doesn't take over a Minute

LordSk

[teeworlds/teeworlds] Pull request closed: #3074 Initialze DragMoveOverlayRect to prevent crash

00:10

LordSk

[teeworlds:editor] 2 new commits

3520bec fix: initialze DragMoveOverlayRect to prevent c... - Marvin Winkens 81c95de Merge pull request #3074 from AssassinTee/fix/e... - LordSk

@Assa you'll have to manually close https://github.com/teeworlds/teeworlds/issues/3073 because merging into other branches than master does not automatically close issues

[EditorV2] Client crash when clicking on empty field · Issue #3073 ...

Click here: PS Screenshots are not working >:( Crashlog: Exception: Exception 0x80000003 encountered at address 0xcba8bc Reason: some object is null

AssassinTee

[teeworlds/teeworlds] Issue closed: #3073 [EditorV2] Client crash when clicking on empty field

sometimes I play commit-Tabu: Write a commit message without the words "feature, fix, bug, crash, refactor"

oy

[teeworlds/teeworlds] Issue closed: #1781 Enable map checker

12:15

oy

[teeworlds/teeworlds] Pull request closed: #3044 Enable mapversion sending in versionserver, refactoring

12:16

oy

[teeworlds:master] 4 new commits

39efb8f Mark AddMaplist parameter as const - Robyt3 8fc3405 Enable mapversion sending in versionsrv, improv... - Robyt3 059ed7f Group map version entries by minor version - Robyt3 e31eac1 Merge pull request #3044 from Robyt3/versionserver - oy

oy

[teeworlds/teeworlds] Pull request closed: #3071 Fix chat name autocompletion ending too early, refactor CChat

12:29

oy

[teeworlds:master] 20 new commits

acd2d59 Adjust pointer code style - Robyt3 3d9f8d4 Remove unused COMMAND_CALLBACK - Robyt3 50f2e8d Fix variable name - Robyt3 497ee5d Move method declarations - Robyt3 8c075e4 Remove dead code - Robyt3

Hmm

12:43

PR time

12:46

https://github.com/teeworlds/teeworlds/issues/1732 bump on this issue

Flag on spot is in the air · Issue #1732 · teeworlds/teeworlds

Flag on spot is in the air. Dropped flag is on the ground.

12:48

(it's semi active again)

I had a branch for that, but it's a bit of a nightmare

well thats a oneliner

13:04

i can even tell you what you need to change: items.cpp RenderFlag add Y-offset for AT_FLAGSTAND

ok what is happening

Assa

i can even tell you what you need to change: items.cpp RenderFlag add Y-offset for AT_FLAGSTAND

the issue is more of a discussion on how its hould be done :P

13:04

I proposed map and client toggle

robyt3 reviewed https://github.com/teeworlds/teeworlds/pull/2795 yesterday

Adaptable Marking (No GFX Update) by TsFreddie · Pull Request #2795...

closes #2157 Implemented this by rendering the body colour textures onto stencil buffer to cut marking textures. I did not update any textures so there are no visible changes. Basically, allows you...

13:05

I rebased it and resolved his comment ofc

hopefully oy will look at the PR now

so much was merged in the past two weeks (edited)

TsFreddie

so much was merged in the past two weeks (edited)

I wouldn't look at large code diffs as a positive. The positive are features - code change is always a downside, especially additions.

on the other side large features come with large code diffs

yes, it's an acceptable downside

the other way is not true

btw, have you seen the Dune 2021

yes, but that's offtopic

sorry

13:23

Refactor, refactor, refactor

1

Robyt3

hopefully oy will look at the PR now

Pray to oy, morning and evening.

TsFreddie

[teeworlds/teeworlds] Pull request opened: #3078 CMake: Use /utf-8 for MSVC

Because the good guy microsoft respects the old habit of using local codepages for source code in Asia. (In china and japan MSVC defaults to treating the source code as GBK and SHIFT_JIS encoded still.)

TIL I can't compile teeworlds in china.

TsFreddie

TIL I can't compile teeworlds in china.

oO

yo, does anyone know if the projectile animations are the same as ddnet? because on vanilla it looks more "fluid/smooth" than ddnet

Deleted User

yo, does anyone know if the projectile animations are the same as ddnet? because on vanilla it looks more "fluid/smooth" than ddnet

That could be caused with DDNet's antiping, perhaps?

Stiopa

That could be caused with DDNet's antiping, perhaps?

maybe, but even with antiping disabled it really looks smoother on a vanilla based server

14:51

on a vanilla server the particle seems to have many more frames per second

nobody really knows, there are differences in code, maybe missing updates on both sides

1

Robyt3

[teeworlds/teeworlds] Pull request opened: #3079 Minor refactoring: Replace magic 50 with SERVER_TICK_SPEED

Use SERVER_TICK_SPEED where appropriate. Reuse existing Freq variable instead of querying time_freq multiple times.

Robyt3

[teeworlds/teeworlds] Pull request opened: #3080 Add secure_random_uninit

Robyt3

[teeworlds/teeworlds] Pull request opened: #3081 Adjust windows header usage to fix compilation with VS2019

See #3076. Does this fix all errors and warnings with VS2019 for you @AssassinTee?