Teeworlds - development

oy

[teeworlds/teeworlds] Issue closed: #12 Copy/paste

01:29

oy

[teeworlds/teeworlds] Issue closed: #1851 Text input improvements (part 1 of 2)

01:29

oy

[teeworlds/teeworlds] Issue closed: #2706 Extending CLineInput to be more flexible.

01:29

oy

[teeworlds/teeworlds] Pull request closed: #3055 Text Selection and IME support!

01:29

oy

[teeworlds:master] 5 new commits

fd6c21e Implement text selection, copy, cut, fix utf8 p... - Robyt3 5ddff62 Track active line input globally, add input pri... - Robyt3 3d1e8da Implement IME, candidate window & move textcurs... - TsFreddie 4ba1d62 Fix hidden input selection and IME, move to CLi... - Robyt3 3979d8b Merge pull request #3055 from Robyt3/text-selec... - oy

01:34

oy

[teeworlds/teeworlds] Issue closed: #2687 GH-Actions does not recognize failed tests on Windows

01:34

oy

[teeworlds/teeworlds] Pull request closed: #3057 Fix Windows CI not properly erroring out on errors

01:34

oy

[teeworlds:master] 2 new commits

9ee4a39 Fix Windows CI not properly erroring out on errors - Robyt3 a74fd2f Merge pull request #3057 from Robyt3/CI-Windows... - oy

01:35

oy

[teeworlds/teeworlds] Pull request closed: #3058 Update copyright year

01:35

oy

[teeworlds:master] 2 new commits

1500d03 Update copyright year - Robyt3 54c2ebc Merge pull request #3058 from Robyt3/copyright-... - oy

01:37

oy

[teeworlds/teeworlds] Pull request closed: #3059 Improve macOS performance, explicitly disable notch area on macOS

01:37

oy

[teeworlds:master] 3 new commits

50a2ac1 Improve macOS performance by declaring all thre... - Robyt3 288fc6b Explicitly disable notch area for fullscreen on... - def- e7ba44b Merge pull request #3059 from Robyt3/macos-perf... - oy

oy

[teeworlds/documentation] Pull request closed: #47 Add reason argument to shutdown command documentation

02:50

oy

[documentation:master] 2 new commits

e14bc55 Add reason argument to shutdown command documen... - Robyt3 38eca48 Merge pull request #47 from Robyt3/server-shutd... - oy

oy

[teeworlds/teeworlds] Pull request closed: #3052 Expose Storage in gamecontext

03:33

oy

[teeworlds:master] 2 new commits

cbe7069 Expose Storage in gamecontext - ChillerDragon 74f60fe Merge pull request #3052 from ChillerDragon/pr_... - oy

03:36

oy

[teeworlds/teeworlds] Pull request closed: #3054 Smooth console completion scrolling

03:36

oy

[teeworlds:master] 2 new commits

0856289 Smooth console completion scrolling - Robyt3 fe97d7a Merge pull request #3054 from Robyt3/console-co... - oy

03:37

oy

[teeworlds/teeworlds] Pull request closed: #3049 Close selected server browser filter before opening newly added filter

03:37

oy

[teeworlds:master] 2 new commits

162d32b Close selected server browser filter before ope... - Robyt3 cfadaac Merge pull request #3049 from Robyt3/browser-fi... - oy

03:41

oy

[teeworlds/teeworlds] Pull request closed: #3048 Fix OOB accesses when viewing server demos

03:41

oy

[teeworlds:master] 4 new commits

d434f2e Fix switching to Free-View in server demos - Robyt3 54de243 Fix OOB accesses in CHud due to m_LocalClientID... - Robyt3 24726d4 Fix OOB accesses in CSpectator due to m_LocalCl... - Robyt3 75186b8 Merge pull request #3048 from Robyt3/serverdemo... - oy

03:45

oy

[teeworlds/teeworlds] Pull request closed: #3050 Refactoring: Extract CServerFilterInfo::Set

03:45

oy

[teeworlds:master] 2 new commits

bcec4f9 Extract CServerFilterInfo::Set - Robyt3 94a9e09 Merge pull request #3050 from Robyt3/CServerBro... - oy

so oy couldn't sleep last night, nice progress tho, keep it up man!

and

10:52

a comment on water

10:53

sure, it's not exactly feedback, but at least I know that he just hasn't got the time to get into it!

10:54

a comment which mentions that he wishes there was more general feedback on the water PR... so to whoever is reading this... you know what to do!

@Stiopa do you have some videos about that?

ReiTW

@Stiopa do you have some videos about that?

We have some older videos, but @Zatline plans to record something new later today :)

projectile are slower, but for me it should be a constantly decreasing velocity, until it doesn't move anymore

Stiopa

We have some older videos, but @Zatline plans to record something new later today :)

yeah just saw it, was a bit annoyed by the fact he runs everywere every 2min x)

hehe in that old video I was more trying to show the map less the water but I'll try to do the opposite this time

@Stiopa is the projectile speed the same (just slower) in water?

11:20

or it is as I mentioned?

it is just slower

11:20

done in a rather hacky way

I think it should be the same speed as normal & quickly decrease when it is in water (edited)

whereas when the projectile enters water the "starting point" and "speed" are altered

ReiTW

projectile are slower, but for me it should be a constantly decreasing velocity, until it doesn't move anymore

I do like this idea tho that's what in real life would happen

yeah

but that's also what would happen in air in real life ^^

yah but doubt you would see it

heinrich5991

but that's also what would happen in air in real life ^^

haha ye but it's veery insignificant in air

well I could try make a projectile slow down in water... but the projectile physics are

‍

for me

Stiopa

a comment which mentions that he wishes there was more general feedback on the water PR... so to whoever is reading this... you know what to do!

I will check it out if I find time (so perhaps on the WE), is it ready 2 use? did you add map with it or do I need some config stuff?

Assa

I will check it out if I find time (so perhaps on the WE), is it ready 2 use? did you add map with it or do I need some config stuff?

We have a map but I am not sure if it is linked anywhere

and how can I review images oO github seems to be a bit broken there

lemme put the link here

12:26

ctf_twilight.map

131.02 KB

12:26

and... if your IDE is anything like mine... then it should be buildable

(edited)

CLion should be sufficient

@Stiopa got you some feedback, keep in mind that you are doing a nice job and it's sometimes just constructive criticism, having a nice Review culture is hard

1

Assa

@Stiopa got you some feedback, keep in mind that you are doing a nice job and it's sometimes just constructive criticism, having a nice Review culture is hard

Oh, you made a full on code review?

14:14

Thanks a tonne

But main point was more of a review of how the systems work and interact ingame

code cleanup and related I've left to a future time when there is more feedback about the general features

14:14

I will do some code cleanup afterwards though!

@Assa "dive_gear: I don't think the gear is big enough, I can see the pixels on my 2K Monitor, but proof my wrong" what do you mean there?

Left a few comments, resolved others, will deal with others later

wdym by "I expertise using t/4"

@Assa

15:33

are you recommending me to swap out t/2 for t/4 there? (I won't lie that after so much time I have no idea what that is even for!)

As i wrote, m_Direction and m_DirectionVertical have always the same value

15:34

like (1, 1) or (-1, -1), what about other combinations

yeah I see that xD

Do I know what I am doing? no. Will I do it? Better than an outdated branch!

16:04

Do I have a back up branch in case of anything? I do so I am not too stressed out (edited)

16:06

sigh it did not go too well, let's see if I can fix it up

16:10

oh. oops. Well, temporary chaos

16:10

ensues

16:11

hopefully-at-the-end-it-will-be-okay

there's always git reflog if you mess up too much

1

well judging by the amount of differences i think I managed to "save" it

16:19

of course the history is a mess, but I never intended on merging the draft PR, but splitting it into several if the stuff ends up getting liked :)

heinrich5991

there's always git reflog if you mess up too much

git reset --hard origin master

origin/master

16:27

but that doesn't give you back your work

16:27

in fact, it erases it if you haven't done any commits

yes exactly

anyhow. I updated the water PR and resolved a few of the conversations

16:29

but Assa, I think you should focus more about how it plays out ingame than the code, I have taken no steps to clean it up yet lol

I did that on phone while sitting at the hair people

16:32

dresser*

hair dresser or the hair people

16:33

same person!

Robyt3

[teeworlds/teeworlds] Pull request opened: #3060 Minor refactoring: Move base/hash.h include from shared to kernel engine interface

So src/engine/mapchecker.h can be included standalone. Otherwise SHA256_DIGEST would not be defined when only including this header.

Robyt3

[teeworlds/teeworlds] Pull request opened: #3061 Use default Visual Studio version in GitHub workflows

Visual Studio 16 2019 will eventually be deprecated (https://github.com/actions/virtual-environments/issues/4856). However, not all github workflow servers work with Visual Studio 17 2022 yet. I don't think we depend on any VS version specific behavior so we can leave the version unspecified and let the workflow use whatever works.

Robyt3

[teeworlds/teeworlds] Pull request opened: #3062 Increase maximum length of console command name and help texts

Increase maximum length of command names from 31 to to 47 characters.

The command name player_use_custom_color_decoration would be too long otherwise and not show correctly in the local console.

Increase maximum length of command help from 95 to 127 characters. The help texts of the following commands would otherwise be too long and get truncated:

add_favorite
sv_countdown
sv_tournament_mode
sv_player_ready_mode
sv_inactivekick

The commands are packed and u...

Robyt3

[teeworlds/teeworlds] Pull request opened: #3063 Fix console scrolling sometimes flashing lines of text from other page

Closes #2810. The rendered page will only be changed after the log has already been rendered, to ensure that the page can be clamped correctly.

22:05

Robyt3

[teeworlds/teeworlds] Pull request closed: #2930 Improve completion in console: render map candidates, enable for change_map, smooth scrolling

Robyt3

[teeworlds/teeworlds] Pull request opened: #3064 Show console command help and syntax at the same time as completions

I think it's useful to see the help already while scrolling through the completion options. This also adds a bit of space between the help and the syntax.

Before

!o1 !o2 ![o3](https://user-images.githubusercontent.com/23437060/153299296-4e5d7fcd-6a2b-4ee3-afa2-cc6ab9c7e754...