Teeworlds - bridge

can someone explain this black magic? https://github.com/teeworlds/teeworlds/blob/f35da54b6f2c5f9fd4bbd4559f887ccf8f8cc526/src/engine/shared/netban.cpp#L619-L625

teeworlds/netban.cpp at f35da54b6f2c5f9fd4bbd4559f887ccf8f8cc526 · ...

A retro multiplayer shooter. Contribute to teeworlds/teeworlds development by creating an account on GitHub.

11:20

image.png

11:20

vscode does not even highlight template

11:21

/Users/runner/work/teeworlds/teeworlds/src/engine/shared/netban.cpp:625:89: error: expected ')'
template int CNetBan::Ban<CNetBan::CBanPool<NETADDR, 1>>(CNetBan::CBanPool<NETADDR, 1> *pBanPool, const NETADDR *pData, int Seconds, const char *pReason);                                                                                        ^

after reordering some includes i get this error and i am not sure what could cause it

ChillerDragon: that generates implementations for those templates with the given types. you either need to do that for a few known types (and then can only use the template for those types; calling those functions with other types will compile but throw a linker error), or have the template function's body in the header.

ok i somewhat understood that but still have no idea how to fix the error ._. i just run clang-forma

chillerdragon: it's just include reordering? try to isolate which include order change causes it

15:48

(includes are very much not commutative in C and C++, remember that they just include all the text from that file at the location of the #include)

i think thats all breaking changes clang-format does

19:13

its a bit tidous to bisect since linux works i dont have any windows and my mac does not build so i have to push pieces of the big clang format diff to the slow github ci

well, you could try doing everything except the include reorder

19:24

if you think that's at fault

19:24

so you know whether your theory is true

right good idea