Guild icon
Teeworlds
discord.gg/teeworlds / development
For discussions around the development of the official Teeworlds
Between 2021-07-02 00:00:00Z and 2021-07-03 00:00:00Z
Avatar
GitHub BOT 2021-07-02 15:52:47Z
Author icon
Robyt3
[teeworlds/teeworlds] Pull request opened: #2905 Fix text render vertical centering when text is truncated due to max. line count, use unicode ellipsis
  • Entirely prevent lines from being added above maximum line count instead of retroactively removing them, which causes some properties to be inconsistent, resulting in incorrect vertical centering. Closes #2896.
  • Replace three dots ... with actual unicode ellipsis …
Avatar
Teectac 2021-07-02 16:48:58Z
Image attachment
16:50
Polymorphism makes it hard to find where this method is called for instance @heinrich5991
16:51
Could be any of these 20 references
16:58
Is it worth going through this maze just so that a list of 20 similar calls can be reduced to a loop of 2 lines ?
Avatar
jxsl13 2021-07-02 17:59:07Z
looking at the folder, is not vanilla related
17:59
is it?
Avatar
Assa 2021-07-02 18:00:09Z
looks like client side code to me
Avatar
jxsl13 2021-07-02 18:05:56Z
I see, 0.6
18:08
0.6 is end of life, please move on to 0.7 😀
Avatar
Deleted User 2021-07-02 19:31:42Z
if you dont use polymorphism you have 20 calls xd
19:32
and that everytime you call components
Avatar
Teectac 2021-07-02 19:55:26Z
Most of these calls go to empty methods anyway
Exported 13 message(s)