i mean the file called tuning.h

hi

oy

[teeworlds/teeworlds] Pull request closed: #2813 Align voting control UI, hide vote after time elapsed, refactoring

08:34

oy

[teeworlds:master] 4 new commits

c4362a6 add voting constants, align UI elements, refact... - Robyt3 1499cd9 remove unnecessary empty space, improve corners... - Robyt3 5bb6d47 fix inconsistent listbox background alpha, fix ... - Robyt3 a3ba7da Merge pull request #2813 from Robyt3/votingIssues - oy

oy

[teeworlds/teeworlds] Issue closed: #730 Demo player loads demo too long when length of demo is huge

08:44

oy

[teeworlds/teeworlds] Pull request closed: #2816 Add demo loading popup, minor refactoring

08:44

oy

[teeworlds:master] 3 new commits

4839a1e use bytes_be_to_uint for demo data - Robyt3 c6bdeab add demo loading popup - Robyt3 1f1fef5 Merge pull request #2816 from Robyt3/issue730 - oy

08:45

oy

[teeworlds/teeworlds] Pull request closed: #2821 Fix CMake deprecation warning for old CMake versions

08:45

oy

[teeworlds:master] 4 new commits

15dbf34 Bump minimum CMake version from 2.8 to 2.8.12 - heinrich5991 c210627 Manually patch gtest to allow CMake version 2.8... - heinrich5991 cd506ff Revert "added missing policy for legacy opengl" - heinrich5991 23f3351 Merge pull request #2821 from heinrich5991/pr_c... - oy

oy

[teeworlds/teeworlds] Pull request closed: #2815 KISSify TextRender and Increase Number of Lines in MOTD

08:53

oy

[teeworlds:master] 8 new commits

c4da3fc motd and textrender KISSify - TsFreddie 0467d04 more lessy code - TsFreddie 73f4957 Prevent zero length mem_alloc - TsFreddie e7f9705 fix style - TsFreddie 826977b include zero image quad but not draw them - TsFreddie

08:54

oy

[teeworlds/teeworlds] Pull request closed: #2820 Separator typo

08:54

oy

[teeworlds:master] 2 new commits

47ec1d5 Separator typo - ChillerDragon 05db043 Merge pull request #2820 from ChillerDragon/pr_... - oy

08:56

oy

[teeworlds/teeworlds] Pull request closed: #2823 Disable console (Windows)

oy

[teeworlds/teeworlds] Issue closed: #2817 Mangohud doesn't work

oy

[teeworlds/teeworlds] Issue closed: #2819 Port to libretro? :D

Robyt3

[teeworlds/teeworlds] Pull request opened: #2825 UI & Input Refactoring: implement text selection, implement tooltips, fix various issues

Text selection and input

!grafik !grafik Implement keyboard-based text selection for console, chat and editboxes. Implement mouse-based selection for editboxes. Basically does everything that #2521 does (paste, cut, select all etc.) but with the new text render and with rend...

@P. use cmake-gui instead (or do it in console)

13:55

integrated cmake system sucks on visual studio

Learath2

[teeworlds/teeworlds] Pull request closed: #2521 Implement selections in CLineInput

The mad lad actually did everything I wanted.

15:32

it should be trivial to implement IME with this CLineInput

he came, rewrote the game from scratch within one year and hopefully never left: Robyt3

2

For real, the codebase looks completely different now even from 0.7.5

is that a good thing?

debatable

16:37

even subjective maybe

definitely subjective, since it's about comparing code quality

16:38

I'd say change is objectively a slight negative, so it's all about outweighting with benefits

But I guess for ppl don't care much about imputing or text, it's like changing a bunch of stuff for nothing.

why is change a slight negative?

@Learath2 because it makes maintaining harder and others have to re-learn a few things

hm, there is a time cost associated with change, true

I think refactoring in general has risks of putting ppl out of the loop and breaking perfectly functional code

All the changes from 0.7.5 to now I quite like though. Most of the code that got worked on was rotting

16:41

Rotting since matricks last touched it even

Teeworlds is heavily modified and other projects have to catch up/merge any refactoring

But robert actually made the CLineInput really good to work with IME now.

16:41

I guess it's all about how much you like matricks code style

Well not only that, but also there are things that were flat out broken and TextRender I don't think even matricks liked

Aren't features and fixes almost orthogonal to refactors?

I distinctly remember a "foolish" comment there

16:42

orthogonal in what way? what are the axes?

the feature/fix axis, and the refactoring axis

16:43

probably the textrendering is the best case for refactoring, since that seemed to have fundamental flaws

Personally I still think textrender is both a refactor and a feature update (with the auto ellipsis and text alignment feature)

Ah, but changes don't just lie on the axes. e.g. the refactoring for textrender also fixed a lot of alignment issues

that realsmiley emote scares me. Anyway, let us hope Robyt never leaves us

I don't understand you @Learath2

Robyt3 madlad

Well you said features and fixes are orthogonal to refactors. Most changes are a bit of both though

it depends, but sometimes the refactoring and the features/fixes are very independent things

Refactoring arcane code can often fix bugs

Doesn't it rather introduce bugs?

16:47

Since old code is well tested?

I think the recent refactors are motivated by fixing issues. Which is nice.

Not always, e.g. tl/algorithm

and most UI fixes

We did a bit of cleanup in ddnet recently and started to use binary search which is part of tl and very old code

16:49

turns out it wasn't ever tested because the binary search in tl/algorithms wasn't even binary search

I have a very different policy when doing fixes/features, not to touch code that doesn't have to be touched, so it's interesting to see the difference in philosophy

16:49

@Learath2 that sounds rare though, dead code

Learath2

turns out it wasn't ever tested because the binary search in tl/algorithms wasn't even binary search

Hold up, tl's binary search was all over the new textrender

@TsFreddie 0.7 fixed it a month or so before us

Thank god

16:50

Almost had a heart attack

1

Why thank god? It was linear search. If it was broken in vanilla too you'd get free optimization

Oh. I thought you mean it was outright broken in before fix

@Dune Ah I see what you mean. Yes I agree that fixes and features should touch the minimum amount of code possible

16:52

But I also see great value in refactoring old code that's badly designed. TextRender e.g. was awful

~~It still is a little wack tbh.~~

16:55

I don't like the required cursor clearing on each frame but I really don't have any better idea.

Well it's a consequence of how UI is done in teeworlds

And now you have to consider whether your text is changing or not. Which is more work when using the textcursor for the sake of optimization.

(One might say the entire UI desperately needs a refactor, everyone migrated to either stateful retained mode uis or hybrid polling uis)

~~Robert might just do it~~

retained mode ui brings with it a whoooole host of problems, ever wonder why there are like 50000 js web frameworks or things like MVC?

16:59

The UI state falling out of sync with the actual state is absolutely awful to deal with, so many issues that takes hours to debug because your UI is lying to you