Teeworlds - bridge

lol, nodes is beimg remade for 0.7

10:32

being

10:35

hm, last commit in July.

oh fun

you didnt know either? u guys live under rocks man

15:19

didnt that start around the time 0.7 rlsd or even earlier or di di confuse something

also @heinrich5991 pls stap spreading fake news about me on github :/

15:27

https://github.com/TeeworldsDB/irclogs/blob/master/ddnet/2020-10-09.log#L600

TeeworldsDB/irclogs

Mirror of https://ddnet.tw/irclogs/. Contribute to TeeworldsDB/irclogs development by creating an account on GitHub.

15:27

https://github.com/TeeworldsDB/irclogs/blob/master/teeworlds/2020-10-11.log#L29

TeeworldsDB/irclogs

Mirror of https://ddnet.tw/irclogs/. Contribute to TeeworldsDB/irclogs development by creating an account on GitHub.

15:28

Dune and Learath2 recommended hacktoberfest i only pointed out it might lower quality

oh true, it was Learath2, sorry about that

also guys if you are concerned about the quality of my prs you can tell me

wtf

15:30

it says directly in the rules of hacktoberfest to not do what you do

yeah please don't

well I guess its not to annoy proj owners

15:30

if you dislike my prs you could have told me earlier

you can reopen that PR when not in october to not appear like you do it just for the hacktoberfest

or if u want to please hacktoberfest gods i dont add the tag or tell me to wait until its over

I think people would be less annoyed by that

and by "the people" you referr to ur self?

yes

15:31

but I think I also heard Dune and Learath2

and the reason is to not make digitalocean mad or what?

no, us

^

i dont get it

15:33

so you have a problem with the pr?

15:33

or with the pr in october?

the PR is probably fine outside of hacktoberfest

but?

currently it just looks like you spam the repo for getting a repo

yes?

15:33

it always is

15:33

no matter what time of the year

imo this kind of PR is pure spam regardless of the month. style PRs are fine but batch them into one

thats all i have

outside of october, we probably wouldn't have reacted so badly

15:34

I guess(?)

i guess too

15:34

cuz its not my first pr

15:34

im just trying to understand why u all guys so pissed all of a sudden

it's not in spirit for hacktoberfest and it's annoying for teeworlds

k ill guess i stop contributing then if its annoying :/ sorry

you are misconstruing what heinrich & I are saying very much in this sentence

how?

you can reopen the PR outside of october to get a nicer response

15:38

or do something more substantial now

"and it's annoying for teeworlds" does not sound like a cotober thing

yea, Dune and I have a bit differing views there

15:39

seem to have

yea

I'm okayish with small contributions from new contributors if that is what gets them started

everything larger tends to get declined

the last page of PRs only has one closed PR

15:41

all others are merged

what page?

you haven't had a PR rejected on teeworlds throughout the last year

bcs i learnt on ddnet what sizes and types of pr are worth a try

maybe ddnet is different - I don't see large prs get rejected at all, though I think it's good to split into independent features when possible

also have been waiting on crucial prs to be merged for my workflow for month

15:43

to then get rejected

15:43

everything bigger than a 1liner is usually no fun

https://github.com/teeworlds/teeworlds/pulls?q=is%3Apr+is%3Aclosed this is probably the page heinrich was speaking of - it's all purple

teeworlds/teeworlds

A retro multiplayer shooter. Contribute to teeworlds/teeworlds development by creating an account on GitHub.

ah

although the problem could also be non-rejected PRs, ofc

15:46

12 out of 20 open PRs are half a year old or older

yea thats annoying bcs i still am afraight of putting it in a fork if there is a potential upstream merge

that's a good sign - there have been over 250PRs throughout the last year. few recent PRs remain open

it is not a good sign when PRs stall without explanation

15:54

or if PRs that are not going to be accepted either way stay open

15:55

(but in other areas, teeworlds did well this year, I agree. lots of PRs getting looked at)

@ChillerDragon: i guess https://github.com/TeeworldsDB/mapres has name duplicate mapres (because winrar said this. as i know, windows thinks aA.png == aa.png)

I can look into it if it makes trouble on windows

yeah, thanks