Teeworlds - development

Teeworlds

discord.gg/teeworlds / development

For discussions around the development of the official Teeworlds

Between 2020-09-22 00:00:00Z and 2020-09-23 00:00:00Z

You can set the tab count to 5

10:08

Splitting tasks into different PRs is usually a good idea, so large parts don't get blocked by small issues

did it

i need things to do thonk

thonk

There is an essential protocol update required for ddnet

16:02

There is editor2 lying around suffering bitrot

what is the editor2 thing

16:04

i see

[teeworlds/teeworlds] Issue closed: #2583 Merge Player and Tee settings tab

16:55

[teeworlds/teeworlds] Pull request closed: #2754 Merge Player and Tee Settings Tab

16:55

[teeworlds:master] 5 new commits

c2d1d60 merge player and tee settings - TsFreddie aa816a3 remove a unused variable - TsFreddie 0130b88 interactive elements - TsFreddie 301fcad remove tbd tab - TsFreddie 2772593 Merge pull request #2754 from TsFreddie/0.7-mer... - oy

tuesday merges!

wuhmm

sounds illegal

sounds awesome

16:59

I support notion of 24/7 merges

I support a healthy lifestyle of oy

16:59

in case he is no merge bot.

what if he is?

then we need to establish some bot rights. like 23/6

[teeworlds/teeworlds] Pull request closed: #2750 Fix envelopes resetting to time 0 on demo/world pause

17:00

[teeworlds:master] 2 new commits

71e83b1 fix envelopes resetting to time 0 when demo/wor... - Robyt3 de02ff8 Merge pull request #2750 from Robyt3/envelopePa... - oy

17:01

[teeworlds/teeworlds] Issue closed: #2736 A ghost kill message shows up when viewing a demo for the second time.

17:01

[teeworlds/teeworlds] Pull request closed: #2749 DemoPlayer: Prevent Messages Being Processed Before Snaps

17:01

[teeworlds:master] 2 new commits

1d6714c prevent messages being processed before any snaps - TsFreddie f7823f7 Merge pull request #2749 from TsFreddie/0.7-dem... - oy

17:01

[teeworlds/teeworlds] Issue closed: #2739 Wording problem for menu transparency

17:01

[teeworlds/teeworlds] Pull request closed: #2748 Change "Menu background transparency" to "opacity"

17:01

[teeworlds:master] 2 new commits

8463242 change wording of menu alpha settings - TsFreddie 4d30b17 Merge pull request #2748 from TsFreddie/0.7-men... - oy

my inbox exploded a little bit

Great stuff, thanks @TsFreddie!

your inbox exploded with love, I wish I were you! (edited)

i don't know what can be done in editor2. but i tried to pull master into the editor branch

[teeworlds/teeworlds] Issue closed: #2738 Demo browser layout

17:05

[teeworlds/teeworlds] Pull request closed: #2747 Various Improvements of Demo Browser

17:05

[teeworlds:master] 3 new commits

5d00b39 various improvements of demo browser - TsFreddie e82a338 reviewed changes - TsFreddie 96c5089 Merge pull request #2747 from TsFreddie/0.7-dem... - oy

woah, editor2 is pretty cool ngl

what about RFC? (edited)

that is still in review, kinda.

17:06

it is a pretty large change

fair enough

(edited)

17:06

https://github.com/teeworlds/teeworlds/issues/2634

In survival, players may all spawn in one spot because of randomiza...

Related to issue #2138 and PR #2182 Discord user Stiopa#2095 reported Issue: Teeworlds respawning all tees in one spot ocassionaly. Gamemode: LTS Map: lts1 Description: The respawns in the gamemode...

17:06

what about this?

rfc = request for comments

but nobody commented for the APi design. they reviewed some of my code.

17:07

thonk

so...

17:07

i don't know

17:07

do i assume they are good with it?

weekend and beyond

17:07

people might have a daily job

@TsFreddie you can filter editor2 issues

ok

https://github.com/teeworlds/teeworlds/issues?q=is%3Aissue+is%3Aopen+label%3Aeditor2

teeworlds/teeworlds

A retro multiplayer shooter. Contribute to teeworlds/teeworlds development by creating an account on GitHub.

but there seems to be some branching issue that editor and master has some different implementation for the same thing.

17:42

should i cherry pick some changes so the editor doesn't get too hard to merge

huh, it's supposed to replace, not merge?

17:42

usually the editor doesn't use functions from the rest of Teeworlds. am I wrong?

i know. but they both added fileinfo fetching in system.c (edited)

if it does, you should cherry-pick imo, yeah

17:43

oh yeah, then there should be some cherry picking :)

i'll do that

https://github.com/teeworlds/teeworlds/pull/2602 was a draft on its way to fix https://github.com/teeworlds/teeworlds/issues/2577, which was the last big issue

17:43

ask @Learath2 the status of that before possibly continuing that work

ok

17:44

for the cherry picks, i need to find the commit first tho. never done this, but i know the idea. i'll try not to break anything.

you can find the commit using git blame -nu

17:44

it's good training :)

17:44

this will give you the last commit affecting each line number of a file

thanks

@TsFreddie https://github.com/teeworlds/teeworlds/blame/master/src/base/system.c

teeworlds/teeworlds

A retro multiplayer shooter. Contribute to teeworlds/teeworlds development by creating an account on GitHub.

magic

17:47

found it. thanks

1

why does teeworlds require cursors to be static? saw the request change in https://github.com/teeworlds/teeworlds/pull/2704 doesnt that only remove performance, bcs the variable probs isnt cached, and also need to be mapped(allocated) once at runtime and probs has a check if its already allocated

the quad array inside cursors is reused by each cursor

ph it has a quad array now

ph?

oh*

oh

havent looked to deep inside ur changes, but want to understand it a bit

yeah, i kinda avoided the Container idea. and just made every cursor cached

ah interesting

thonk

if you want to take a look, please do nitpick. can still change the textrender APIs. even if it is just a method name that you don't like.

i am the wrong guy for nitpicking about function names xD i am actually more cursious about the performance, bcs ur changes will improve that alot

thonk

then take a look at TextDeferred probably. I nuked TextEx and wrote a new one.

yeah, sounds like the best thing todo, i never liked that, tho i prefer just dont allow text streamed at all

18:24

for CPu and gpu its just annoying

18:24

even just comparing changes

18:24

but way too much work, and u do it without changed like half teeworlds

18:24

so yours is deffs interesting

i used a int64 for version keeping

18:25

since the changes of text usually just some numbers and localization

18:25

you can combine the number and localization version to tell the cursor to clear it's cache

18:25

without str_comp i guess

18:26

for something like chat you'll never need to clear cache anyway.

18:26

thonk

although i haven't optimize chat and nameplates yet.

well chat is buffered anyway already

18:27

for ddnet

18:27

server browser and console are the biggest problems

well

18:27

isn't console basically the same as chat

18:28

i didn't do anything with server browser sadly. UI stuff in general is not really compatible with the new textrender design

18:28

saddog

well i dunno for console, i just now that chat only had like 1 entry point for text change, so ez to keep track of

why does it have 1. thought i would be 0

18:30

thonk

i think i might be stupid

18:30

anyway.

well what i mean is, u know when a new line is added

18:31

but as said, could be same for console, not sure rn

ok

18:31

wuhmm

probably wait till you see the changes. since i can't really tell what can be done rn with vanilla.

your approach is good too, its also some kind of buffered, and teeworlds doesnt have GPU buffering anyway

18:32

well urs is better in fact generally

18:32

bcs u have alot more buffered now

18:32

atleast cpu side

ye, but it is a hard to keep track of changes without comparing strings.

18:33

as you said. even with most of the cursor being static, many of them still clears cache everyframe

18:33

(without freeing the allocation ofc)

yeah

tbh, since the text align feature is now baked in textrender. it is probably possible to nuke DoLabel and just use static cursor to cache UI text. (edited)

18:36

but that's too much work. doggo_lol

doggo_lol

well redix had some text cache, maybe that would be very effecient compared to now already

thonk

from what we heared, he's doing str_comp every frame. i might be wrong or he might found another way

[teeworlds/teeworlds] Pull request opened: #2755 Cherrypicking duplicated methods from editor branch.

master implemented a function in system.c which is already implemented before in the editor branch under a different name. Cherrypicked the implementation from editor branch, so it won't cause more trouble down the line when the branch merges.

oh, you're doing editor2 -> master? I thought you were doing the opposite @TsFreddie

yeah, the editor one came before the master one

18:44

and it is better imo

ok

okay seems like someone didn't do a great job of formatting in the editor branch

18:45

doggo_lol

yeah, people using different tools sometimes creates some whitespace diff

@TsFreddie probs, but comparing is still better then rebuilding probs

well probably

18:48

although i think comparing int might be enough for most cases

18:50

but yeah. maybe comparing string is easier to manage and probably more useful to cache all text.

18:56

i might need to pull the entire cherrypicked master back in editor as well. some UI stuff are changed by robyte.

19:00

Image attachment

19:00

hey it worked

i haven't actually seen the new editor yet. looking good!

i haven't too

19:03

pretty cool.

19:03

let's solve some issues doggo_lol

doggo_lol

have fun

19:03

I am trying to implement zatline's bar

bar?

oxygen bar for water i think.

@TsFreddie that's why I'm against unncessary refactoring

a stupid question: is axblk and redix the same guy

but editor UI tends to be split away from main UI

19:19

those are details that should probably not be programmed before later

19:19

yes

19:19

axblk is @redix 's github handle

okay mystery solved. was wondering for weeks

teeworlds gameplay is very carefully engineered to be as simple as possible. iirc at some point they were considering having large health pickups and small ones and went with all the same for maximum simpliity

but having a prototype of different idea should be good for play testing.

[teeworlds/teeworlds] Issue opened: #2756 Exclusion filter for server names and IP addresses

There needs to be a way to exclude server names and IP addresses within the server browser. Since DDNet added support for version 0.7, most active servers disconnect "bad users" after they try to connect. What exactly are "bad users"? Well, anyone who is detected as a VPN by their DNSBL, including false positives, of course. I'm sure I'm not the only one who is affected by this. Screenshot 1 Screenshot 2 Note that th...

can always KISS it down after we know what is not essential

have u ever discussed a solution for australia and other parts of the earth where seasons are different, heinrich came up with it https://github.com/teeworlds/teeworlds/pull/2695 just wondering

Add 'auto' theme based on season by Robyt3 · Pull Request #2695 · t...

Setting the menu map to auto will choose one of the themes based on the current season. For simplicity, all seasons are 3 months long, with Winter starting in December. Season to theme-mapping: Sp...

speaking of auto theme... it's autumn ^^

but editor UI tends to be split away from main UI

@Dune yeah, but things like cursor was still sharing with main UI

19:32

and robyte did change a lot of cursor stuff

I see, gotta port some master changes then

also textrender might be a problem too.

19:34

19:34

i don't know anymore.

what do you not know?

do i wait for textrender be merged or merge it with editor later or something.

if it's not in master yet, don't cherry pick it?

right. have to merge sooner or later, i guess better later in this case.

Image attachment

20:20

things like this. if you add more than 64(MAX_GROUP_LAYERS) layers, it will just crash by assert. Is it suppose to have a check later? didn't see anything in the issue or comments mentioning this will be handled in the future (edited)

20:25

thonk

okay i get it. seems like most dbg_assert are there just to be handled in the future.

the editor2 code has a lot of asserts to ensure stability

20:26

if something fails, it tends to hit an assert instead of crashing

isn't assert just a forced crash

yes, but it happens earlier and is general a more controlled way of failing

20:29

without asserts, sometimes things just don't crash, but you end up with unexpected/corrupt states

make sense

20:30

so they are going to be checked in the future tho right?

20:30

now it just crashes when you do simple things like pressing space bar on a quad layer

depends which assert, there might be some "todo implement this"

20:31

otherwise, I don't believe the code is supposed to hit them

20:31

so if they do, you should report that

yeah, but there aren't any comments of TODO

20:31

i found three of them already

I'm no expert but it sounds like you found a bug

whenwwseeachild

20:32

i mean i can fix them straight up

yeah, you can open an issue or PR a fix

20:33

if that fix does not entail removing the assert

of course

20:33

i'll look a bit more just in case i'm missing something. like a popup or tooltip system for these kind of things (edited)

there are no error popups afaik

yeah, that's why I assumed some of the asserts are expected to be handled when popups are implemented

20:34

but you can't really tell, because there were no comments.

I'm a bit surprised you got 3 crashed, I never got any

well, adding a quad layer to a empty group, pressing space bar on a quad layer

20:35

forgot the 3rd one

quads creation isn't implemented yet

oh

it's a big blocker for the editor2 release

but still. there aren't any comments blobfacepalm

blobfacepalm

teeworlds code is generally light in comments

20:36

some people see that as a good thing

i guess

you can still open an issue and ask if that's an expected assert failure

20:37

might not be

sure. just don't want a lot of them. i'll keep notes and maybe open an issue later to compile ones that i've hit.

plenty of separate issues is fine

20:38

this way the irrelevant ones can be closed quickly :)

right

20:39

is quad creation not designed at all?

20:39

because lordsk is busy or something like that?

no, afaik lordsk is aiming for a different design than the editor1 for quad creation

20:40

and yeah, lordsk got very busy

i already forgot how to use editor1 for better or worse

haven't used it much tbh

i don't know if i can design a system like that without the project starter.

I think it's most reasonable to wait for @LordSk 🦋's input on quads, specifically. iirc he had something in mind

sure.

but in general, you can open issues to propose a design for anything the editor is missing

thonk

we'll see. i might have trouble expressing my idea in terms of proposal.

maybe you can propose code drafts like a class instead if you prefer

20:44

I don't know what you have in mind

i don't know either at least for now.

keyboard shortcuts would be nice, automap features too

20:46

(among things it's missing from v1)

[teeworlds/teeworlds] Issue opened: #2757 EditorV2: cannot create quad layer in an empty group

hits assertion: https://github.com/teeworlds/teeworlds/blob/1167a84b5ec5bb404fa5548672d21402ec35e58b/src/game/editor/ed2_actions.cpp#L196 Does not seems to be related to unimplemented quad creation since creating layer happens before creating quads anyway.

[teeworlds/teeworlds] Issue opened: #2758 EditorV2: context menu for managing groups/layers

Actual properties of layers are implemented with panels (in contrary to v1 where layer properties are in the context menu), which leave us a free UI/UX element to use. I think right click context menu should be built for the sole purpose of organizing layers/groups. Actions like creating new layer (above/below selected layer), deleting layers/groups can be moved into a context menu. Also, we can add additional organizing features like colour coding layers/groups without adding more clutter...

[teeworlds/teeworlds] Issue opened: #2759 EditorV2: "solo" view of layers

Currently you can show/hide each individual layers. An "only show this group/layer" button would be nice. Especially for background layers where you just want to design the background without manually untick everything else. the _solo term is from music production DAWs, don't know if there's similar term in graphic design_

[teeworlds/teeworlds] Issue opened: #2760 EditorV2: tools/layers change should be recorded in history

When you switch to another layer, make some changes then undo, it reset your focus to the layer before you switched. This makes doing repeated minor adjustment really annoying.

whenwwseeachild

21:39

by the way, since we're talking about open issues, there is also the 0.7.6 milestone (https://github.com/teeworlds/teeworlds/issues?q=is%3Aopen+is%3Aissue+milestone%3A0.7.6), especially since we were targeting a release soon

teeworlds/teeworlds

A retro multiplayer shooter. Contribute to teeworlds/teeworlds development by creating an account on GitHub.

21:41

EeveeShy

TextRender got taken out of 0.7.6.

21:41

but yeah, it got huge.

did it?

oh wait it didn't

21:42

is:issue *

yeah :D

21:43

btw avoid merging master into your branch (https://github.com/teeworlds/teeworlds/pull/2704/commits/af8f76c28a20e36e3df0e7049167847dfa074694) it fucks a bit with the git history imo

21:44

if you want to update your branch, use rebase

21:44

git rebase master

can i reset it and force push it for practice

git co 0.7-textrender-fontfallbacks
git reset --hard e8c2aa2
git rebase master

oh does rebasing means i have to solve conflict for each commit

yes

21:53

it rewrites your PR on top of master

https://github.com/teeworlds/teeworlds/issues/2242

Callvote options that cannot be called · Issue #2242 · teeworlds/te...

Suggestion: a lot of servers use callvote options as section labels, for example: Those could be flagged by the server and rendered differently client-side, as well as not be callable. It should be...

22:15

how do you do oy's suggestion in 0.7.6 without protocol change tho

22:15

thonk

22:16

or it is just suppose to detect some pattern in description for seperators

tbh I think oy's suggestion should be split from the issue

22:17

I had a PR going on where any callvote line starting with # was marked with a black background

22:17

that's already much better for a lot of use cases

yeah, it is quite confusing just by looking at the issue. (edited)

and a lot of servers are already using # before vote menus headers

22:18

the idea is just marking headers

22:18

the reason this wasn't fixed exactly one year ago is because the PR I wrote had a bug I couldn't find (edited)

22:19

and also because my job started 7 days after :D

do you still have the branch

yeah probably

22:20

https://github.com/Dune-jr/teeworlds/commit/fab61ca6ddd4df6602835f2e0bc4f0bf4b88e4bf

exp · Dune-jr/teeworlds@fab61ca

22:20

wrote that in the train

watermeron

you're probably better off rewriting the thing than finding the bug, given the (small) size of the work (edited)

ah. i should keep an eye for jobs. always forget.. can't get any motivations while i'm stuck here away from home.

it's not so easy to find jobs remotely

22:21

I change city for every job

how many jobs have you had

though with corona I can stay cosy at my hometown

doggo_lol

22:22

corona locked me here. i don't even know if my flight next month can take off

huh... two, three if you count phd

I like the moving every couple of years thing

22:23

you want to go home?

well at least for a while

22:23

it's been a shitty year

financially?

well mostly mentally

22:24

this year isn't a good year for study abroad

right, it can be tough

22:24

how does it impact studies?

22:24

less motivation?

well abroad is the important part.

what does it change?

studies are fine. just don't like how things when down. i booked three flight already all of them got cancelled

can you work remotely from china or firewall gets annoying?

well depends if I can find a job anywhere else than china.

22:27

but the firewall is not a big deal imo

22:27

been bypassing that for ages.

22:29

thonk

~~maybe i'm just depressed~~

social isolation can be draining. I find a good workaround is outdoor sports

whenwwseeachild

we don't have any teeworlds sports mod anymore

gotta modernize it to 0.7

remember soccer mod that was fun ^^ (edited)

https://github.com/teeworlds/teeworlds/pull/2517

Implement vote subheaders by Learath2 · Pull Request #2517 · teewor...

This patch introduces subheaders with varying depth, it doesn't really look the best on older clients though. We could remove the depth component and make it only depth 1. This could also b...

22:32

there was this

oh yeah right

22:33

that's all I needed, gotta remind oy

22:34

do you know oy personally

no one does :D

thonk

figured

we had some physical meetup plans long ago but brexit and covid got us good

rly

there was another dev meetup something like 8 years ago too

Dev meetups are usually quite awkward anyway

thonk

i must be a kid compared to you guys then.

oh I wasn't in that one, it was with the swedish folks

oh

22:37

~~why are all the good things swedish~~

@Learath2 oh really? well you don't have to sit around PCs

i'd imagine it would be just hanging out having lunch or something.

22:39

~~unless you are awkward in nature like me (social anxiety gang)~~ (edited)

minecraft from sweden, teeworlds from sweden, paradox games from sweden

Every programmer I've met has been awkward in social situations

i always thought it would get better after been in some work environment.

22:45

but i haven't got a job yet so i wouldn't actually know EeveeShy

EeveeShy

Exported 320 message(s)