Guild icon
Teeworlds
discord.gg/teeworlds / development
For discussions around the development of the official Teeworlds
Between 2020-09-10 00:00:00Z and 2020-09-11 00:00:00Z
Avatar
GitHub BOT 2020-09-10 19:26:36Z
Author icon
Robyt3
[teeworlds/teeworlds] Pull request opened: #2728 Fix hotkeys and scrolling being enabled when console is open
Generalize the mouse-enabled state to full UI-enabled state and add proxy methods KeyPress and KeyIsPressed to check the enabled state, to avoid scrolling and other menu hotkeys being active while the local/remote console is open.
Avatar
TsFreddie 2020-09-10 22:05:22Z
Image attachment
22:05
Fourth*
Avatar
Dune 2020-09-10 22:27:12Z
What is the point?
Avatar
TsFreddie 2020-09-10 22:27:45Z
the old textrender can't properly center multiline
Avatar
Dune 2020-09-10 22:29:31Z
Oh, you mean it doesn't center vertically?
22:29
That sounds like a feature rather than a bug that it doesn't overflow vertically
Avatar
TsFreddie 2020-09-10 22:30:11Z
no i mean horizontally. let me grab a screenshot of old textrender
22:30
and yes. i'm moving features into textrender so we can free up cluters in other places.
22:35
Image attachment
22:37
the old one can only center the entire left aligned rect based on the width of last line.
22:38
the new textrender should free up a lot of text related codes in broadcast.cpp and make chat.cpp a little bit faster.
Avatar
Dune 2020-09-10 22:38:55Z
I think you should focus on having a working baseline first (a rework that includes CJK for example) and add pull requests on top of that for more improvements (such as including vertical text centering)
Avatar
TsFreddie 2020-09-10 22:40:51Z
Didn't I submit a texture rework already?
22:41
We don't technically need the rewrite i'm currently working on. But it will make text selection and unifying editbox / lineinput much easier.
22:44
so I might as well just make it right in the beginning since we can just not change anything, and my last PR is enough to at least display CJK and have some performance improvements.
22:47
And btw vertical text centering is working already thanks to bounding box. i didn't set the flag for that in that screenshot since it is not the point (edited)
Exported 17 message(s)