Teeworlds - bridge

https://lgtm.com/projects/g/teeworlds/teeworlds/?mode=list

bruh

No c++ errors

i like the design on lgtm :) @jxsl13 we could fix the errrors and then add it to the CI

08:49

ok well looking closer at the issues they dont really provide a fix do they? Porbably annoying to fix

08:52

08:52

thats funny :D

08:53

oh they were bought by github

oof does one have the dependencies compiled for this https://github.com/teeworlds/teeworlds/blob/master/scripts/dmg.py#L88

teeworlds/teeworlds

A retro multiplayer shooter. Contribute to teeworlds/teeworlds development by creating an account on GitHub.

I worked on the SDL_StartTextInput thing for a bit, but got distracted with macOS sdl bugs

:D we all will never forgot Learath2 heroic macos debugging journey!

12:27

btw @heinrich5991 did you mean UX or actually UI in ur issue comment?

I wanted to say that it is a bad user interface to let them specify indices

isnt UI more about looks and UX more about the feel? And your right this is way too technical so its bad UX imo

There are editor commands now, which would be a perfect place to hide this :)

12:39

And maybe a bucket tool if we want UI for it?

bucket tool is different from what ChillerDragon wanted I think

I was finally able to reproduce #2669 @fokkonaut , even with the vanilla server and sometimes even without rcon login. Actually it only happens with gcc 6.3 (on Debian 9) in release mode. Even in release with debug info there is no issue =\

lol

undefined behaviour? :D

can you try in release with debug info?

"Even in release with debug info there is no issue ="

oops

I think I also found the reason for the errornous client id thing. The client id is correct but the server is still sending packets although the client is offline. Happens for example when the server is still sending rcon stuff or votes

good job @redix :)

@fokkonaut try this: https://github.com/axblk/teeworlds/tree/fix/token_cache

18:46

Seems like this failed because of 2 uninitialized padding bytes at the end of NETADDR: https://github.com/teeworlds/teeworlds/blob/1846c74467e8a95a44c1ba972455e4da15083e66/src/engine/shared/network_token.cpp#L238

THUMBS UP

Teeworlds is full of these

19:17

Assuming paddings, alignments and sizeof stuff all over the place

19:20

@redix how did you diagnose it? Just found a net_addr_comp that gives the wrong result?

Added a ton of log messages... Result was that GetToken doesn't work when doing the heartbeat after rcon login. After fixing net_addr_comp it's working for me

Alright, let me check it later

20:15

If it works, which I assume, you are the master✌️❤️

20:15

Thanks for looking into it