Guild icon
Teeworlds
discord.gg/teeworlds / development
For discussions around the development of the official Teeworlds
Between 2020-06-21 00:00:00Z and 2020-06-22 00:00:00Z
Avatar
This is an out of bounds access caused by a broken curve type value in a map. In this case on ctf8, the 6th and 7th envelope have such a broken value (2752512 and 527 respectively), valid values are 1-5. I've heard that the old editor shouldn't get much attention anymore, but i think ctf8, being an official map, should be fixed. ``` Thread 1 "teeworlds" received signal SIGBUS, Bus error. 0x0000555555671a0c in CEditor::RenderEnvelopeEditor (this=0x555555935dd0, View=...) at src/game/edit...
Avatar
Those values are not clamped: https://github.com/teeworlds/teeworlds/blob/ab384e4838fe808ccfebd0707f505e247eb50cb5/src/game/variables.h#L30-L31 This is particularly a problem when you put a negative value. They should be clamped between 1 and something sane, like 2000
Avatar
no dc era
Avatar
justabutterflier 2020-06-21 23:00:25Z
hi developers
23:00
want to ask
23:00
if i increase max health from 10 to 20
23:00
camera in teeworlds works strange
23:00
how can i fix this?
23:01
Avatar
you did something wrong elsewhere most likely, can't know
Avatar
justabutterflier 2020-06-21 23:01:58Z
it's in the character.cpp
23:02
ok than do you know how to make this rightly?
Avatar
probably it's unrelated to the code piece you showed
Avatar
justabutterflier 2020-06-21 23:04:24Z
when i type >= 10 and m_Health+Amount, 0, 10
23:04
it fixes
23:04
"fixes"
Avatar
justabutterflier 2020-06-21 23:18:01Z
@Dune I just recorded 5min video
23:18
May i ask you watch this?
23:18
you can watch this on 2x speed, no matter
Avatar
sure if you point out the part that matters
Avatar
justabutterflier 2020-06-21 23:18:49Z
i show there that this bool is matter
23:19
it processing
23:22
@Dune
Avatar
ah well it's not a camera bug, it just doesn't accept it as a valid packet or so
23:28
it seems like you have to clamp it to 10 and handle it internally, e.g. send "10" as long as health is >=10
23:28
nothing else you can do afaik
Avatar
justabutterflier 2020-06-21 23:31:47Z
hmm
23:31
what is afaik?
23:32
ah googled
23:33
wdym "send 10 as long as health is >=10"?
23:34
where is the limitation?
23:34
camera drops
Exported 35 message(s)