This is the same fix the ddnet client uses. It doesnt set the local character when we also get the spec info from the server. This is a fix for a /pause command for example, so the client doesnt re...
12:21
doesn't that mean players can look around during, say, a paused vanilla game?
use vanilla 0.7.4 and go on abddrace server and say /pause, while your viewpos is nearby your character it will render hearts, ammo, and not the spectator hud. When you leave your tee (due to network clipping) it is normal. Try the same with F-Client or latest master and the spec HUD is also while your tee is nearby
12:25
it does not impact vanilla, because such a situation cant happen in vanilla (your local character + specinfo)
12:28
specinfo is an object of CPlayer::Snap, which gets sent while you are spectator (or in ddrace /pause)
This was supposed to fix #2573, but turns out the server doesn't even handle command messages at all. I don't think a fallback to a chat message is desirable here, but it's ...
13:06
Yeah and I doubt anyone uses Steam to host servers
13:07
I put up the changelog
13:07
I parse PRs for that, so I might have missed some of the things you did on your own, Oy
Okay, do you think it would be okay to not include this fallback? the command stuff is only used by mods and the two mods that we discovered using it are both willing to just fix it themselves
I got the patch into SDL but it wasn't released yet
13:16
btw we've been building ddnet on a single linux machine for a while and it's been pretty stable so far, you might want to consider doing cross builds too
hm, it's not trivial to detect how the failure in parsing occured, do you think maybe we should just not even register commands with malformed argument lists?
you could maybe output the debug message once for every type of unknown object? you wouldnt need to get ddrace specific or do the extended netobjects patch, but it'd fix the issue with thousands of log messages