Teeworlds - bridge

hey @Learath2, sorry to bother you again with this pesky issue

10:02

https://github.com/teeworlds/teeworlds/pull/2575 breaks @Fudgy's server commands for some reason

Add a fallback for broken servers by Learath2 · Pull Request #2575 ...

This was supposed to fix #2573, but turns out the server doesn't even handle command messages at all. I don't think a fallback to a chat message is desirable here, but it's ...

what mod is that?

10:03

Race, worked fine before PR

and what command did you try?

all

10:04

/help, /rank Dune

is the source public

(actually /help works fine because it's not a registered command, /info does not)

I'm guessing he also used pArguments as the whole command string

at least based on https://github.com/axblk/teeworlds/tree/race

axblk/teeworlds

A retro multiplayer shooter. Contribute to axblk/teeworlds development by creating an account on GitHub.

why was this even released with the command string being passed as arguments

I don't know, ask ryozukki

idk what to do tbh, do you want to keep sending the entire string?

10:08

What a pointless feature this whole thing has been, I keep having to rollback things just to keep compatible with 0.7.4

I agree, should have kept it simple and not done argument parsing imo

I disagree, it should have never been committed without the argument parsing

has it?

10:10

I mean, there was only one release with server-side argument parsing, 0.7.4

10:10

commands*

0.7.4 had no argument parsing at any side, it just passed the entire chat line as "arguments" to the server, without even stripping the /

oh, argument parsing was introduced later? okay

yeah, this server also expects the entire chat line in pArgs

I'd argue more complexity is more bug-prone

10:11

which makes sense, since that's how 0.7.4 works, right

idk what we can do about it tbh, we can just not check arguments at all and send the entire chat line like 0.7.4

sounds most reasonable to me

10:13

constantly changing the protocol is irresponsible

This is why I don't like working with vanilla, for ddnet we'd have wrapped this up in a version check, or an extended protocol message

we can do version checks

10:13

but then you just have stacks of backwards compatibility crap, don't you?

10:14

I mean, sounds rich to me to blame vanilla for that, which is usually light in this aspect

it's the only way things can evolve, if the protocol is stagnant, then we can't improve anything

see https://github.com/teeworlds/teeworlds/blob/master/src/game/server/gamecontext.h#L132

teeworlds/teeworlds

A retro multiplayer shooter. Contribute to teeworlds/teeworlds development by creating an account on GitHub.

such a shame it was released the way ryozuki first commited it

we lack testers a lot

do we get the server version any time during the protocol (not including serverinfo)?

oh, good question

okay fixed that, it also breaks @Trafalgar Law and @fokkonaut's servers, but they are following master, that's expected

what do you break?

the messages arguments will now include the entire chat line including the / because ryozuki first coded it that way