Teeworlds - bridge

@Dune what do you mean you couldn't get /w to work at all?

11:02

can you check the console output, see whether the command is being called at all

/whisper works not /w

11:02

Im eating, later

well, fwiw works for me

@Learath2 it just sends it to the server

11:29

[chat-command]: calling 'w' with args ''

@Dune well /w requires arguments

11:41

and that line doesn't mean it's sent to the server

It is though

11:42

It goes to the chat

@Learath2 I have difficulties reproducing, sorry, could have been on the wrong branch or something

11:51

/w does go to the chat though...

11:51

[2020-04-15 13:49:20][chat-command]: calling 'w' with args '' [2020-04-15 13:49:20][chat]: 1: Dune: /w

you just write /w and press enter?

yeah. that's a bug

oh indeed

11:55

@Dune if we are typing a command, even if parsing fails don't send it?

yes, anything that starts with a / must not be sent, unless escape is pressed, that's a security

11:55

ideally, autocompletion/validation of commands should be changed to space/tab only, to make return presses safer

11:56

(it's very tricky stuff I know)

I don't quite get how it used to work before tbh, I don't see that behaviour there

you can check 0.7.3 for that

11:58

or you mean in the code?

@Dune try the new commit

12:01

Yeah I meant in the code

ok

12:05

ah, there is one difference with behaviour from previous versions there, and I see I wrote the specifications wrong: it should not send it as long as there is an active commands menus. Escape closes the menus, so it's supposed to be intuitive that you have to close menus to send the command

12:05

you may disagree on that though

12:06

otherwise works fine

did I somewhere along the way break something about the commands?

12:07

Is the menu supposed to be active after you hit space?

for example, when you type /\ssa: hi there should be (and there is no) menus

12:08

but the message still doesn't get sent before you press escape to exit from some hypothetical invisible menus: that's the thing that changed

hmm, idk how to encode this behaviour in terms of the variables we have

12:10

@Dune currently, there is no menu, but the code still wont send it before you esc out of the non existant menu?

yes

12:11

try to send /\ssa: hi

however when typing a command the menu does indeed disappear after the initial part of the command

it's weird

12:11

huh, lemme test

12:12

this is another change in behaviour

12:12

this was not the case in 0.7.3

ah, now it makes sense

12:13

I guess we lost that behaviour along the way

most likely yes, it's hard to regression test this because there are a lot of cases :)

Instead of filtering chat commands according to the entire input string, maybe I should do it with only the initial token

so hard to replicate :/

@Dune I think I got it this time

12:52

it's not always so easy to put these concepts we can easily imagine into concrete logic on the variables we have access to

I agree @Learath2 , especially since there was very little abstraction around this feature, it's all hacked into the chat code

13:15

@Learath2 doesn't work, once I exit the menus once I can't seem to get commands working again

?

13:18

You type a command, you exit the menu, you can never use commands again?

13:23

In the subset of things I tried. It works fine, so you'll need to tell me how to reproduce this

1) start to type a command

13:35

2) type escape

13:35

3) open chat again, try to type a command

Hmm, works fine for me, do you get out of chat with escape too?

yes

13:37

wait, maybe I did not pull the last commit

"start typing command, escape, escape, open chat, type /" is exactly what I'm doing

I can still reproduce

maybe it depends on the command and how much of the command you typed?

yes it does

13:39

in order: T, /mu, escape, escape, T, /

works completely fine for me, that means undefined behaviour

same procedure with /w works fine...

oh I got it to happen somehow

13:41

T + /, + esc + esc + t + / works for me

you mean, works or reprodcues the bug?

yeah, reproduces it and I fixed it

13:45

I was having an issue with cirular logic

13:45

IsTypingCommand would be stuck false because there were no commands rendered, because handle commands wouldn't run unless IsTypingCommand

13:47

@Dune Okay this time, for sure

13:47

hopefully(tm)

It would be good if you could test it extensively

13:51

Now if I try to whisper someone, and I tab, it erases it

13:51

/whisper Lea<TAB> --> /whisper instead of /whisper Learath

how do you even come up with these testcases?

I just enter a server and try random commands

I try like 50 things before pushing it, you find the 1 thing that breaks it

ha ok, bad luck :D

This was going to be a small pr, now it'll need to be squished :/

Okay, I tested this commit for 10 minutes and the only thing I can come up with isn't in the scope of this PR

14:29

(add a way to signify parsing failure to the user (maybe a red background flash?))

sounds like a nice feature to do in another PR :)

14:43

though I'm more concerned about signalling that the user is out of command mode (and will send a command as raw text)

14:43

I wanted to write a GUI where the command is part of the chat mode header (where it says "All") but that branch got stale :P

Did apt rename the server binary from teeworlds_srv to teeworlds-server? And why?

17:40

I really liked the teeworlds_srv binary name but i noticed after installing it via apt it seemed to have teeworlds-server there.

17:41

I wonder if there is some styleguide for linux binarys? I mean i can not think of any binary including underscores. All use dashes.

i always try to write teeworlds-srv because im used to - on linux

yea seems like its a more common style to use dashes i could not find anything about it online tho

17:56

im not sure about srv vs server

hi chillerdragon

yo

Are you online rn on a srv?

17:56

I need you for smth :D

no :D

Come on

pm me on irc or get wire

I pm you to get discord

:troll:

oh btw you can use https://zillyhuhn.com/TeeStalker/ tee see when im online

17:58

oh well might be 0.6 only so thats probably useless

Wow you troll

17:59

Could you come online for few minutes?

ok ill join zcatch real quick but please do not use this public irc to contact me in the future :/

We will see!

18:07

Where are you ChillerDragon

sorry had a different identity im on now

I have to use now quakenet because of ChillerDragon, help

lol its funny when you search "multiplayer game" on rubygems there are only 19 hits and there is no quake, minecraft, roblox or any other game id expect there. But a teeworlds related gem :D nice

18:37

https://rubygems.org/search?utf8=%E2%9C%93&query=multiplayer+game