Teeworlds - development

Well not clamping the fields that dont actually have a limitation would be the first half

07:07

To complete it when we do clamp fields due to a limitatiom in the map format or the editor itself, we refer to a constant defined in the respective one

Sonix-

[teeworlds/teeworlds] Pull request opened: #2546 Fix jungle_midground bug (closes #2485)

Fixed, optimized and tested ingame. Before: !2485_before After: !2485_after

LordSk

[teeworlds:editor] 65 new commits

a04a33e Add command usage - Learath2 c366b3f Handle new type argument strings in commands - Learath2 60fbcf9 Truncate the helptext to fit - Learath2 2165d99 Get rid of the evil goto - Learath2 2fc4a0d Usage for commands, make whisper consistent - Learath2

12:09

Sonix-

[teeworlds/teeworlds] Issue opened: #2547 Add option to snap / align quads

Basically a feature that snaps automatically a quad to another quad's corner in the same layer. As it is now I find it difficult sometimes to align the quads properly without having some visible 1px space between them or some edges going off. When the cornes of both quads are close enough the quad you're moving should automatically snap to the closest corner

LordSk

[teeworlds/teeworlds] Issue closed: #2526 Editor2: Implement 'has unsaved data' behaviour

3

Sonix-

[teeworlds/teeworlds] Pull request opened: #2548 Update and fix jungle_background

As mentioned in #1911 this tileset had an assymetrical issue which when repeated in a map resulted in displaying an unnatural pattern. This should improve the visual appeal of it. Optimized and tested in game. Before: !jungle_background_fix_before After: ![jungle_background_fix_after](https://user-images.githubusercontent.com/2030615/79043951-c4196980-7c02-11ea-8683-049296b761ac.jp...

LordSk

[teeworlds/teeworlds] Issue opened: #2549 Editor2: Map saved indicator

Signal when the map has been successfully saved. Something like this: !image Have it pop up and hide after a moment. Could also be used for error reporting? If the map fails to save for example. This is useful now since we don't have a save icon to save the map and indicate that it is saved by disabling the icon, but it could be redundant later.

LordSk

[teeworlds/teeworlds] Issue opened: #2550 [Editor2] Asset manager: add image with file explorer

Part 1 Extract the important part from the DoFileSelect() function. !image Basically remove the preview and bottom part. Have it return true when selecting a new file. Then update the RenderPopupMapLoad() and RenderPopupMapSave() accordingly (move the code from the DoFileSelect() function). Part 2 Make an "Add Image" popup in the Asset Manager, to load and add an im...

Can anyone confirm that the none background on master is broken?

i think it always needed cl_show_menu_map 0

on 0.7.4 it works just by clicking on the thing, for me

16:37

not on master

@LordSk 🦋 Why do you want to abstract away a weird partition of the file selection dialog?

It is more flexible this way, it only does the file selection. Then we can do whatever we want with it. It is either this or build a "general" thing. Like how do you tell it to preview maps instead of images?

Well at the end of the day all previews will be images, (preferably cached in a hashmap). So what's displayed will always be an image

Dune-jr

[teeworlds/teeworlds] Pull request opened: #2551 Improved the inline server info text outline

The bright text outline looks a bit ugly on the inline server info, so I tweaked that. Before/After: !screenshot_2020-04-11_18-25-36 !screenshot_2020-04-11_18-21-50

Will they though? We could render a tiny portion of the map (say the flag area) as the preview.

I'm not even sure the map rendering code is efficient enough to be doing this

16:49

I was thinking an asychronous job that builds a preview image and that job can decide how to build a preview for a given file

Could be the way. But until we know, I think splitting up the file explorer a bit and only keep the part that likely won't change is a good solution.

Can one of you check no-theme master?

sure

16:52

eh whatever, I need something to code to distract myself, I'll just do whatever you want

@LordSk 🦋 thanks, I guess the Robyte fast-loading thing broke it

How do you want to resize the common part when you want to insert a preview there, or will there always be space left for a preview?

probably pass a rect to the DoFileSelect and work from there?

The region you highlighted is not a rect

Yeah that's true hmm

Dune-jr

[teeworlds/teeworlds] Issue opened: #2552 The (none) theme is broken

If you select the (none) theme, the grid background no longer loads. 0.7.4 was fine ![](https://cdn.discordapp.com/attachments/510879693982007316/698576213270331502/unknown.png) This is probably related to https://github.com/teeworlds/teeworlds/pull/2459, so cc @Robyt3

Move the search to the left side and eat up a bit of the path string rect thing?

16:57

It does not have to be pretty for now

That, or we could pass a CUIRect pointer DoFileSelect can assign to, if the pointer is null don't leave space for a preview, if the pointer is not null assign the preview rect to it?

16:58

Tbh I don't quite get your design goals with this new editor: The code doesn't have to be pretty, the ui doesn't have to be pretty. We already have an editor lacking in both

I did not say the code does not have to be pretty. The UI is temporary.

code that is more general is not always prettier

using as little abstractions as possible should be a goal by itself

I guess

@David - SFM got any updates on https://github.com/teeworlds/teeworlds/issues/2388 ?

Add race sounds · Issue #2388 · teeworlds/teeworlds

Add sounds for events (start, finish, record, checkpoint?) in race.

@Learath2 do the issue however you like if you have a better solution

Learath2

[teeworlds/teeworlds] Pull request opened: #2553 Handle adding assets

If you prefer we could revert the change to ed2_map and instead strip mapres from the beginning before calling EditAddImage. The background checkers for the preview are also scaled for assets that aren't square, we could fix that if you want. Closes #2550

Learath2

[teeworlds/teeworlds] Pull request opened: #2554 Fix background rendering with theme "none"

@Robyt3 what was the intention with moving the clear out of RenderBackground anyway? Closes #2552

oh, nice find @Learath2

@Dune what kinda worries me is that it was working for robyt

maybe he had gfx_clear 1?

23:13

that would explain why it looks yellow like this

23:13

I'm surprised robyte wouldn't have noticed a change in color of his menus....

ah, that would indeed explain it

23:24

https://github.com/teeworlds/teeworlds/blob/master/src/game/editor/io.cpp#L168

teeworlds/teeworlds

A retro multiplayer shooter. Contribute to teeworlds/teeworlds development by creating an account on GitHub.

23:26

Loading the map files is undefined behaviour, the only reason it's not been an issue is that sane modern compilers just don't put random padding between ints. But they are completely free to, thus you are not allowed to assume the object representation of a struct

That's an issue in editor v1 and v2, and not ingame, right @Learath2

Well we save the quad layers without serialization. Thus whenever we load them we assume the object representation of struct CQuad in the map file matches the running clients representation. So its not isolated to the editors

Ah. Well at least it does not seem exploitable

Or I am not intepreting the standard correctly, but even if the compiler werent allowed to pad it, the ints themselves are not guaranteed to be compatible

23:34

But yes, not exploitable at all