Teeworlds - bridge

Teeworlds

IRC / bridge

One-way IRC channel bridge. If you want to be able to send messages to IRC, contact @Dune or @heinrich5991. https://www.teeworlds.com/?page=docs&wiki=rules/irc_rules

Between 2020-03-24 00:00:00Z and 2020-03-25 00:00:00Z

@LordSk 🦋 feel free to take a look at #2509, I'll finish it up but I need to take a day or two

oh, doesn't look bad :)

When I did the listbox I wasn't really thinking forward and now I want a way to add icons to the left and a way to return a key instead of the index of the selected entry

heinrich5991: Re:serverinfo I think that's unintentionally what I was doing aswell. The entry exists before the main packet

13:16

I don't get why 2492 keeps failing to compile, that variable is not unused

2509 fails for teeworlds\src\game\editor\ed2_ui.cpp(522,52): warning C4305: 'argument': truncation from 'double' to 'T' [D:\a\teeworlds\teeworlds\debug\teeworlds.vcxproj]

I have no idea what that even means

2492 only fails with cmake, somehow

13:25

Learath2: he doesn't know if he should use float or double I think?

13:26

you have to specify the .f

13:26

const vec4 ButtonColorLight(0.162f, 0.1, 0.29f, 1);

oh, I was going so quick throwing the colors out there I missed that :P

13:26

yeah, 0.1 indeed is a double

I'll go for a meeting and have a look

Idk who has access to the settings of the repo but you should disable circleCI

Learath2: tried disabling it, no idea if it works

14:17

didn't really find it

heinrich5991 are you here?

kinda but not really

heinrich5991 what do you think about using findfreetype that is bundled from cmake instead of our own

14:40

it is there since 3.0.3 iirc

14:40

maybe earlier

14:40

there is also a warning in cmake rn

I'd like to not use cmake-specific Find* for the most part

why not

it makes things harder to debug when they fail

are you sure

pretty sure, I'd need to find the version of their Find* script before starting to debug it

14:42

is there a motivation to use them here?

14:42

if there is, we can consider changing to them

no u go to /usr/share/cmake and ur set

these change from cmake version to cmake version

i would relly more on it and also we got a warning, due to having our freetype named ownfreetype

14:42

and we cant use freetype as is cuz it says a warning about shadowing their script

because of FindOpenGL I guess

14:43

we could patch that out, I didn't like that in the first place

?

14:43

what about findopengl

we use cmake's FindOpenGL

14:43

I'd guess it's causing the warning

14:43

because it also looks for freetype

no its not

where does the other freetype come from?

i think you should check the warning beforehand

14:44

you may be confusing things

can you paste it?

ec

14:44

sec

14:45

CMake Warning (dev) at /usr/share/cmake-3.17/Modules/FindPackageHandleStandardArgs.cmake:272 (message):

14:45

The package name passed to find_package_handle_standard_args (Freetype)

14:45

does not match the name of the calling package (OwnFreetype). This can

14:45

lead to problems in calling code that expects find_package result

14:45

variables (e.g., _FOUND) to follow a certain pattern.

14:45

Call Stack (most recent call first):

14:45

cmake/FindOwnFreetype.cmake:23 (find_package_handle_standard_args)

14:45

CMakeLists.txt:312 (find_package)

14:45

This warning is for project developers. Use -Wno-dev to suppress it.

14:45

this is cuz we have ownfreetype.cmake to not shadow cmake one

14:46

oh

14:46

it may be because opengl at the end

14:46

when i rename our findownfreetype to findfreetype i get this

14:46

CMake Warning (dev) at /usr/share/cmake-3.17/Modules/FindX11.cmake:207 (find_package):

14:46

File /usr/share/cmake-3.17/Modules/FindX11.cmake includes

14:46

/home/ryozuki/Documents/teeworlds/cmake/FindFreetype.cmake (found via

14:46

CMAKE_MODULE_PATH) which shadows

14:46

/usr/share/cmake-3.17/Modules/FindFreetype.cmake. This may cause errors

14:47

later on .

14:47

Policy CMP0017 is not set: Prefer files from the CMake module directory

yea

when including from there. Run "cmake --help-policy CMP0017" for policy

14:47

details. Use the cmake_policy command to set the policy and suppress this

14:47

warning.

14:47

Call Stack (most recent call first):

14:47

CMakeLists.txt:412 (find_package)

14:47

This warning is for project developers. Use -Wno-dev to suppress it.

14:47

still, using bundled freetype script solves the issue fast

no, you still have to care about using the fallback for ourselves

14:48

maybe we can just use our own opengl thing

14:48

then we can rename freetype back

14:50

@Ryozuki or to quickly fix it, you can use cmake_policy(SET CMP0017 NEW) and rename freetype back

ok

are you against using macros?

wdym?

i notice a common pattern, its even documented, in cscrollregion you always init it the same way

15:24

so i thought why not make a macro

15:25

menus.h L184

15:25

even adding a rect is repetitive

15:30

nevermind

Changing the defaults would be more sound, but I thought it's not worth it to break mods, so I didn't do it

ecdsa or rsa?

For?

ecdsa is more efficient IIRC

i see

Exported 93 message(s)