Teeworlds - bridge

I created a bugreport upstream https://bugzilla.libsdl.org/show_bug.cgi?id=5046 hopefully they'll fix it so we don't have to work around it

doesnt seem to be possible to upvote issues on bugzilla hm?

09:27

wait u even provided a patch? nice

That's great, Learath2. Does this cover https://github.com/teeworlds/teeworlds/issues/1659 though? Should probably link the bugzilla ticket there if it does :)

Unable to change resolution on macOS · Issue #1659 · teeworlds/teew...

I realized the game looks pretty pixalated so i went to the graphics settings and i wonderd why the resoltion is so low. Then I tried to increase it. But after restart the same option was selected ...

09:47

the ticket seems to be specifically about the crash though

@LordSk 🦋 https://github.com/teeworlds/teeworlds/issues/2499 can u describe exactly how it should look?

10:17

oh

10:18

i think this issue is fixed already

10:18

10:18

here it has the right border

yeah the right border should not be clipped

but its already fixed

10:21

isnt it?

hum well I did not do anything in that regard, let me check

10:22

it is still broken on my end, what window/screen resolution do you use ?

i am on arch linux using i3-gaps resolution is 1080

10:24

this is how all looks

how about the history tab?

huh.

u can notice tho

10:24

right border is smaller

10:25

than left

yes but that could be a number of things

10:25

I don't pixel align borders for example

10:26

looks like that for me

10:26

(linux 1080)

i am compiling with cmake and ninja btw g++ is

g++ -v
Using built-in specs.
COLLECT_GCC=g++
COLLECT_LTO_WRAPPER=/usr/lib/gcc/x86_64-pc-linux-gnu/9.3.0/lto-wrapper
Target: x86_64-pc-linux-gnu
Configured with: /build/gcc/src/gcc/configure --prefix=/usr --libdir=/usr/lib --libexecdir=/usr/lib --mandir=/usr/share/man --infodir=/usr/share/info --with-pkgversion='Arch Linux 9.3.0-1' --with-bugurl=https://bugs.archlinux.org/ --enable-languages=c,c++,ada,fortran,go,lto,objc,obj-c++,d --enable-shared --enable-threads=posix --with-system-zlib --with-isl --enable-__cxa_atexit --disable-libunwind-exceptions --enable-clocale=gnu --disable-libstdcxx-pch --disable-libssp --enable-gnu-unique-object --enable-linker-build-id --enable-lto --enable-plugin --enable-install-libiberty --with-linker-hash-style=gnu --enable-gnu-indirect-function --enable-multilib --disable-werror --enable-checking=release --enable-default-pie --enable-default-ssp --enable-cet=auto gdc_include_dir=/usr/include/dlang/gdc
Thread model: posix
gcc version 9.3.0 (Arch Linux 9.3.0-1)

10:27

sdl 2.0.12

well thank you for your report, I did not expect to have a different behaviours on different machines

maybe pixel aligning fixes it

I use the same resolution as you and so does @Dune, so I doubt it would fix it

do u see the right border if u set editor2.cpp line 1647 1 to 4?

yes

10:37

isnt that a floating value thing

I mean it definitely worked at some point, I just don't know when I broke it

looks like subpixels

left border looks bigger

10:39

i think on my end too

I think this is a scroll region issue to be honest

10:41

and I may have broken it when I updated the editor's scrollregion code to match the teeworlds one

:o

@LordSk 🦋 do you mind if I do a couple things with the editor? I know some people don't like contributors on major rewrites like these so wanted to ask

Learath2: https://github.com/teeworlds/teeworlds/issues/2486

11:43

TL;DR: as long as you make an issue first and we agree on it, you can totally contribute

Yo guis @Robyyy had the idea to collect some tw history and create a timeline image. So i quickly spun up a simple github repo where we are currently collecting some dates of tw historic events. If you want to contribute feel free to pullrequest or ping me and ill happily give you push access https://github.com/TeeworldsDB/history/blob/master/timeline.md

might add the reason why it was renamed to teeworlds, it was some copyright/brand name claim, I guess