Teeworlds - bridge

Teeworlds

IRC / bridge

One-way IRC channel bridge. If you want to be able to send messages to IRC, contact @Dune or @heinrich5991. https://www.teeworlds.com/?page=docs&wiki=rules/irc_rules

Between 2020-03-15 00:00:00Z and 2020-03-16 00:00:00Z

might make sense to push the c++ version to c++11 before starting to do the extensive work?

03:16

on the editor

teeworlds isn't on ≥11 yet

yet

Meh ./teeworlds „cl_editor 1“ does not open editor :/ can we do something about that?

10:41

Especially since the new gnome removed the ctrl+shift+e shortcut it’s really annoying to click on editor using mouse

The editor does not need it

11:05

@ChillerDragon isn't there a different command ?

@ChillerDragon cl_editor 1 works to me

The editor does not need it

@Dune What?

that was for jxsl13

Ah

11:35

What am I doing wrong then?

11:35

How did you do it?

try it ingame

11:36

f1->cl_editor 1

Well no

11:36

I want it to start with editor open

11:36

Pass it as command on launch

also works

For me it does not

"teeworlds.exe "cl_editor 1""

I did

11:37

Did not work

copy paste the command?

No handwritten

copypaste the handwritten command?

Image attachment

hmm :/

you should clean your laptop one day

does ./teeworlds quit work, @ChillerDragon

Yes

11:40

Also connect

11:40

And all the other stuff

11:40

It’s maybe config vs command

does cl_editor 1 work ingame?

Yes

that's odd

is the client supposed to start with the editor on?

11:42

with this command

Yes

can confirm, doesn't work vor me either

I would prefer to even directly open a map but I guess I have to wait for the new editor api

I mean, I don't type anything and it opens the editor straight up

11:46

couldn't find what triggers that

11:48

ah, found it

11:49

client.cpp:1975 forces a start with the editor

11:49

so even if you don't pass cl_editor 1 it should work, @ChillerDragon

?

?

So I can open the editor without cl_editor 1?

at start it should open

How?

magically, without you doing anything

I get to the menu when I start teeworlds?

are you sure you're on the right branch?

Yes

11:51

But trolls aside are you telling me no matter what you do every time you start teeworlds it opens the editor?

11:52

Could you send a link to the line you found?

yes

11:52

sed -n 1975p src/engine/client/client.cpp

11:52

I wrote it 10 lines above

Meh no sed on iOS

11:53

I mean a GitHub link

11:53

Well I can check it later when I’m back on laptop

you have the file and the line

11:54

you should be able to find it

Your not very supportive today •.•

11:56

lmao it says never start with editor

11:56

So how is that opening the editor for you?

11:57

Did you change that to 1 in the code?

I added an issue in bad english for mapvotes at the end of the game. What do you think?

12:11

btw why are there no community guidelines for issues?

pls no

@jxsl13 pls no to what?

no guidlines.

you don't have to follow them, they can just provide a bracelet for writing better issues

12:13

1. I have got a bug 2. This happens 3. This is supposed to happen 4. reproduction steps 5. system information

I think the code guidelines are intransparent as can be. issue guidelines seem to make this worse.. if not enforced it's ok.

12:14

if it helps

12:15

hopefully they are somewhere central and not all over the place, at least.

the code guidelines aren't intransparent https://github.com/teeworlds/documentation/blob/master/nomenclature.md

12:19

it really helps reading everything in teeworlds/documentation

12:20

but i would rename nomenclature.md to code_guidelines.md because I searched way to long

12:23

teeworlds uses the hungarian notation if this helps you: https://de.wikipedia.org/wiki/Ungarische_Notation

guidelines seem only to apply to C++ code

12:33

might be extended to capture those base files

12:34

written in C

@ChillerDragon so what does it say at that line?

12:41

@jxsl13 they apply to C code as well

CamelCase

Can you quote teeworlds C files that do not abide by the nomenclature?

the str_format stuff, like most of system.c

ah well that's a lib, kinda

that used underscore

12:42

uses

yeah, baselib is out of this

sometimes one has to kinda add some functionaility there.

12:46

src/base has camelcase and underscore naming conventions. ._.

yeah, baselib is out of this

@ChillerDragon you are on the master branch, right? I think @Dune meant the editor branch directly opens the editor and loads a map.

Ah thanks for clearing it up @LordSk 🦋

14:26

Ofc I am on master yes

14:26

https://github.com/teeworlds/teeworlds/blob/master/src/engine/client/client.cpp#L1975

14:26

And it’s forced to 0

14:26

I wonder why tho

So users won't make a mistake I assume?

14:28

I'm not quite sure

What kind of mistake?

14:31

Like putting cl_editor 1 in config? Still better than putting quit in config

14:31

Also why would one do that?

Probably dates from before we had flags for saving in configs

14:32

could be removed now

Ah so all were saved by default?

14:32

Ya that’s unlucky if you close Client with open editor

14:32

Then people can get confused

I don't really see why you'd want the editor to be saved

14:32

it's just a click or a key away anywa

Ye makes no sense

14:33

And think about noobs opening editor by accident. They expect the game to work properly after restart

Doesn't it?

It does

14:38

I mean it does close after restart and that’s good

14:38

But I guess we can savley remove the hardcodet line that prohibits opening editor on launch directly

We could but I don't really see the point ^^

It would drastically improve my automapper workflow

14:42

And also it just makes sense imo

just type e?

Oh that’s a shortcut too?

14:45

Thanks

14:46

But still I think it’s a good idea

Didn't you introduce that? :D

14:47

or was it @fokkonaut

what

oh it was @Fudgy, my bad

;)

docs and key bindings.

15:13

hidden keys everywhere :0

so my next mapgenerator will run directly on teeworlds with console calls

hey oy

17:48

should we close this then? https://github.com/teeworlds/teeworlds/issues/552

Editor: undo/redo function · Issue #552 · teeworlds/teeworlds

Add undo/redo functionality to the editor.

hey

When existing editor issues are already fixed in the new one they can be closed

the new editor already supports it right?

@LordSk 🦋

17:49

yeah it does

17:49

it's built with that in mind afaik

hey :)

yeah, think we can close it then

what about https://github.com/teeworlds/teeworlds/issues/1301 ?

Redo the editor · Issue #1301 · teeworlds/teeworlds

Redo the editor by using the client ui and clean it up or use something else.

hey Oy

closed that too

17:54

heinrich5991: about the whisper. how about adding a log entry without the text? so you just know there was a whisper for moderation. in case someone complains about spam/insults

Oy: before you go, it'd be nice if you could give 2495 a quick merge

done

ty

btw, https://github.com/teeworlds/teeworlds/pull/2474 does not improve the server list loading for me

Fix high LAN latency (maybe also server list loading poorly) on fir...

I can't test whether this fixes #2285 in general, as I never had any problems with the server list loading poorly on startup, even when setting br_max_request to 100. However this definitel...

17:56

just to clear that up

@fokkonaut there you go

thanks

I have some fairly high packet loss rates on some popular servers (very low ping though), so that might be the issue...

17:57

especially since you can't reproduce

17:57

first load is always much worse though

hm, that's odd. as there should be requests in order. have to investigate when i have more time

we tried a lot of things already, and I heard no one else complain about this

there was someone else right?

17:59

who created the issue

so it could be my connection being somehow shitty. I'm moving to the countryside to escape the pandemy, let's see if that changes something :)

18:00

Oh, I don't remember that

ah i see u opened it, but quoted others who have it https://github.com/teeworlds/teeworlds/issues/2285

Server list loads poorly on startup · Issue #2285 · teeworlds/teewo...

Dune the server list I get on first load usually only has half servers; any refresh afterwards works fine. Anyone got the same? Assa yes gerdoe the server list I get on first load usually only has ...

ah, I completely forgot

I have a unreal high ping on startup like 300ms and after a refresh the browser shows the correct pings.

18:02

an

that's true, ping is also affected

higher pings could be caused by the initialization, shouldn't lead to losses though

could pin https://github.com/teeworlds/teeworlds/issues/2486, with github defaults it'll get buried fast

teeworlds/teeworlds

A retro multiplayer shooter. Contribute to teeworlds/teeworlds development by creating an account on GitHub.

18:04

or make a pr with that branch

done

do you know anything about this, Oy? https://github.com/teeworlds/teeworlds/blob/54cf6d11315dea13bb40611c8e22eaf14b2cf1ac/src/engine/client/client.cpp#L1975

teeworlds/teeworlds

A retro multiplayer shooter. Contribute to teeworlds/teeworlds development by creating an account on GitHub.

18:05

we were talking with @ChillerDragon

18:05

I see no reason to force cl_editor at 0

18:06

surely this is an artifact from before we had the CFGFLAG_SAVE stuff to prevent variables from being writte in settings.cfg?

18:06

@ChillerDragon likes to have a shortcut to "./teeworlds cl_editor 1" and this breaks it

very old. probably sth broke in the past. cause lots of initialization had been done within the "normal" client on first render

ah

when everything works smoothly it could be removed

well editor2 branch forces it to 1 and it seems to go fine

any other issue that need to be pinned? while on it

not afaik

I finally remembered why I wanted to write a hashmap, I wanted to implement #2224, and the best way to implement that is to use a hashmap to handle caching the images

:0

18:43

reminds me of the factory design pattern.

hm

19:22

#2496: we already have a note under whispers to explain how to change chat recipient

19:24

I guess we could add something short there. Press Tab to cycle between chat recipients. [...]

19:24

Whispers may be logged by the server?

19:25

Server admins may log whispers?

19:25

Whisper privacy may be compromised by server modifications?

Whispers aren't private and might be logged by the server?

aren't secured*?

yeah

or secure

19:26

or encrypted

encrypted +1

:)

19:28

https://github.com/teeworlds/teeworlds/issues/2497

Option to disable whisper feature · Issue #2497 · teeworlds/teeworl...

Make it possible to disable the whisper feature within the client and block all linked communication.

19:28

about this, we have a "friends-only" chat option

19:28

this should probably only accept whispers from friends too

19:28

that would solve 2497?

hm, i personally would disable whispers in general

so there would be a use case between "friends-only" and "all chat"

19:30

things getting packed in the settings, it would be nice to have a discrete scrollbarOption that has a label associated

like checkboxes?

hold on, I screenshot something

19:37

Embedded image

19:38

make a DoScrollbarOptionList or LabeledOption or something

19:38

that shows a label instead of a number?

19:39

or probably handle that outside of the doscrollbaroption function

19:39

could help with https://github.com/teeworlds/teeworlds/issues/2293

Chat options · Issue #2293 · teeworlds/teeworlds

It seems like there is some demand for chat options, at least select chat categories to disable sounds for: #2277 select chat categories to disable entirely: #2289 Those options must be consistent ...

19:40

e.g @chillerdragon wants to hide server messages as well...

ah yeah, that could be useful

19:40

shouldn't be hard to do

still hard to design something that would cover everyone's use case

yeah

and not be a "select 10 boxes for each imaginable scenario of chat"

About the whisper discussion: My server crashed today, so I went to check the logs. It was an assert, errornous client id. I checked the core dump and this happened because someone wrote a whisper message to a person, that left the server exactly 1 second before. Now I would sit here like an idiot thinking why it should crash if that commit was in my mod already. I am AGAINST removing the logs, but we should indeed censor it, Maybe something like only the client ids, who sent a msg to who?

run your server in gdb

19:57

it has no overhead

19:58

@fokkonaut or create coredumps, then you can check it after the fact

ulimit -c unlimited

Can anyone explain why the whisper msg even came through?

19:58

It doesnt make sense

19:59

if i select person A in whisper, that guy leaves, my selected person is gone too

19:59

even if, shouldnt the server check too before trying to send to the recipient? (edited)

(edit in bridge is bad, as the whole messages is resent :D)

20:01

message*

Dune: sth like that?

Oy: oh, cleaner than I thought

20:21

can't do out of bounds check though

20:24

Oy: it behaves really poorly if you drag and drop around 0.5

20:25

variable label width should not be possible

20:25

oh, wrong branch, sorry

20:26

scrollbar width is messed up

20:26

background has double the alpha it should have

20:27

maybe we should keep this tiny scroller and remove the rounding: https://puu.sh/FkWJq/fc8edf0697.png

Embedded image

20:28

or make it a circle

yeah, smaller one probably looks better

https://youtu.be/mL9khZWcrS8 That’s odd isn’t it?

@ChillerDragon missed unhook input I think

i suggest stop using bots :P (edited)

So it’s just a lag and the Client predicts locally until the server snaps it back?

probably

it looks like that @ChillerDragon

Exported 253 message(s)