Teeworlds
IRC / bridge
One-way IRC channel bridge. If you want to be able to send messages to IRC, contact
@Dune
or
@heinrich5991
.
https://www.teeworlds.com/?page=docs&wiki=rules/irc_rules
Between 2020-02-29 00:00:00Z and 2020-03-01 00:00:00Z
fokkonaut
2020-02-29 10:01:11Z
why is there a check whether client is ingame and not quitting in the loop BUT NOT for a single send? this could remove all the checks from where we call SendPackMsg and would be nicer in general
https://github.com/teeworlds/teeworlds/blob/master/src/engine/server/server.cpp#L519-L527
jxsl13
2020-02-29 11:01:23Z
you can tell me the isbn
11:02
ISBN
11:03
opening an issue leads to better results, as discussions here don't seem to lead to any change of such small, but imo important refactoring changes.
Dune
2020-02-29 11:14:37Z
Probably because packet.m_clientid has a sane value if SendMsg is called
11:15
Additional checks wouldn't hurt ig
fokkonaut
2020-02-29 11:18:53Z
it doesnt have to have a sane value
11:19
can pass any client id you want
Dune
2020-02-29 13:36:04Z
but it assumes it is sane
fokkonaut
2020-02-29 13:42:33Z
yes
Exported 10 message(s)