Teeworlds - development

[teeworlds/teeworlds] Issue opened: #2442 Add option to filter master server output

When a teeworlds server is running without players for some time it is really annoying to read the logs since they are spammed with master server information: ``` [...] [2020-01-28 10:01:58][register]: fetching server counts [2020-01-28 10:01:58][register]: chose 'master2.teeworlds.com' as master, sending heartbeats [2020-01-28 10:01:59][register]: no firewall/nat problems detected [2020-01-28 10:01:59][register]: server registered [2020-01-28 10:32:00][engine/mastersrv]: refreshing ...

@ChillerDragon ./teeworlds_srv | grep -v "[register]" is probably as fast as ./teeworlds_srv "sv_some_obscure_option 0"

yes but i use logfile @Dune

12:03

there is no pipe

12:04

and it should be

egrep -v '^\[.{19}\]\[register\]' |
    egrep -v '^\[.{19}\]\[engine/mastersrv\]'

ChillerDragon

[teeworlds/teeworlds] Issue closed: #2435 Increase editor ui layer button size

@ChillerDragon ah, well yeah, not so easy indeed

14:29

I'm a bit chilly with putting options for logging, defaults should be sane and easy to filter

there should be no useless spam imo that everyone has to filter

14:31

one success message is fine

that sounds better to me

thats literally what i wrote as option 1 in my issue

I mean, not as an option

if the connection is lost, one error message, if it's found again, one message

might be confusing for server hosters who are used to see heartbeats though?

like who

15:19

there are maybe 10 server hoster

15:19

12 of them are on this discord

connection to masterserver established
connection to masterserver lost
connection to masterserver re-established

sounds clear yeah

maybe with specific master server

it's probably good to keep the spam when it fails though

usually nobody connects maybe to the server except for people who have that server as favourite

15:23

-maybe

what

usually, as the server cannot be found in the server list, nobody plays on it

15:24

except for those that have that server favorited.

unless the connection was lost, which happens

so usually the last message in the logs will be the error

15:25

one simple message would be enough, as in this case, it would spam again. I guess a masterserver prefix might highlight those master server heartbeat messages enough to find them in the logs

15:26

usual prefix is [chat] or [game]

15:26

as [masterserver] is way longer

engine/mastersrv

ChillerDragon

[teeworlds/teeworlds] Pull request opened: #2443 Stop server on logfile error

It is save to assume that a server hoster who manually set the logfile config wants his logging to work. The new log system does not allow absolute paths or anything outside of the teeworlds/dumps directory. So when updating to the new system with old path configs there is a small silent error somewhere in the beginning of the server log. This change fails loudly and shows directly what went wrong: ``` $ ./teeworlds_srv "logfile /a" [2020-01-28 17:44:55][engine]: running on unix-l...

Dune-jr

[teeworlds/teeworlds] Issue opened: #2444 Sanitize max player/client count in server browser

Example: !image

Dune-jr

[teeworlds/teeworlds] Issue opened: #2445 Remove the need for Enter presses in client-side chat commands

Space should put in effect the command. It makes typos less scary, and is generally smoother: Input /team hi⏎ is more convenient than /team⏎hi⏎ [All] /team -> [Team] -> [Team] hi⏎ Input /whisper Dune hey⏎ is more convenient and less scary than /whisper Dune⏎ hey⏎ [All] /whisper -> [All] -> /whisper Dune -> [Whisper: Dune] -> [Whisper: Dune] hey⏎ Same with /r, etc. Minor drawback: it is not possible to message Chiller Dragon if there is a player name...

oy

[teeworlds/teeworlds] Pull request closed: #2441 Add some stylistic changes to `CJsonWriter`