Teeworlds - bridge

@heinrich5991 destructor of a member variable? Is it anywhere else mentioned? Smart Pointer?

16:35

Looks like a good use case for a shared pointer for me <.<

@Assa yea, but I'm not allowed to use a shared pointer ^^

then write one yourself

18:30

https://www.geeksforgeeks.org/how-to-implement-user-defined-shared-pointers-in-c/

18:30

this is not that hard, you prob. don#t need most of this

yea, would be a nullable unique pointer then

18:32

what I ended up using was a bare pointer: https://github.com/teeworlds/teeworlds/pull/2441/files#diff-afc2033986e85049284a0a67b2ca5c75R26-R28

fastest gun in the west

19:52

20s from pull request to merge

:)

20:10

Dune: don't get https://github.com/teeworlds/teeworlds/issues/2445

Remove the need for Enter presses in client-side chat commands · ...

Space should put in effect the command. It makes typos less scary, and is generally smoother: Input /team hi⏎ is more convenient than /team⏎hi⏎ [All] /team -> [Team] -> [Team] hi⏎ Inp...

20:12

ah nvm, now i do, the double confirmation

Oy: and especially people who are used to /whisper commands from 0.6 server modifications will enjoy that

20:16

why do i even bother joining irc to ping oy if im using a bridge on freenode anyways :D

never used whisper so far

Oh why not stop server if logging fails?

20:42

i mean this only happens if one provides the logfile option

logging shouldn't raise critical errors?

well on start it is very useful imo

20:46

i crafted a very and messy workaround in my scripts repo that checks if logging failed

20:46

but still

users often use a config they got from someone else, and that could have a logfile command

well

20:49

ok

20:50

imo this change makes it easier for server hosters updating from 0.6

how?

I was really confused the first time i cam in contact with the new system

20:51

even deen a high skilled admin did not understand why logging broke

20:51

this error would explain it in a few seconds

the error is printed to stdout. That should be enough. For a tw server logfiles aren't that crucial that the server should shutdown because of it

note that this is about shutdown when the server is initially started(?)

21:12

i.e. when the admin is looking at it anyway

the log prints a lot of messages it can be easily overseen

overseen is the opposite of "übersehen"

21:14

(like overhear btw)

oh

21:15

overlook then?

21:15

sounds odd

It's not like there are thousands of lines to check at the beginning =\

its not like any one bothers to read them all

what do you think about the point that the admin is looking anyway, @redix

Well I'm just not a big fan of stopping the whole server just because the logfile failed... But as the logfiles use blocking io I prefer other logging methods in general

"stopping the whole server" only means "not starting the server" in this case

then do not use logfile and u wont be affected

21:20

if u use other logging options server wont stop

how many people have a broken logfile? and how many average users will then show up with "my server doesn't start, just a window pops up and closes" (because of a broken logfile)

when restarting different servers a lot i do not bother readong every line

21:20

http://zillyhuhn.com:8080/q9

21:20

it can get get some lines

21:21

hmm yea the config sharing thing. Tbh i did not think about that and just assumed people who know what they are doing use the logfile setting

that logfile error pops right into ur eyes :P

yes because my logpath is hilariously long

the average user has no clue what he's doing and downloads some random config

hm

this warning may be very important to some server hosters, but not critical to others, and that would suck if they are unexperienced

21:23

so I agree with Oy here

an actual problem here is that we concatenate paths btw

no why?

instead of throwing an error when the user passes /abc/def

21:24

the intention of the user is clear, yet we pretend they mean our/path//abc/def

well this could also seen as absolute path starting from dumps dir but i see what u mean

"absolute path starting from" is a relative path

xd

21:25

idk what happens when ../ i used

21:25

probably also fails

21:26

all these things used to work in 0.6

we should forbid it, if it works

it's a security improvement that random server admins cannot take over your server using the teeworlds server

yy ik

Restricting the file access a bit is definitely a good thing

yeah

logfile was restart only i think exec is even worse

Maybe there should be an exception for things that are loaded at server start

how about showing active errors when u log in to rcon?

doesnt solve the issue if you never auth in rcon

21:32

but would be nice yes to put the master server warning there instead of in the logs :p

21:32

in my 0.6 mod i used to track wrong rcon attempts and showed last login and amount of failed attempts on rcon login

it's a pretty important error, means the server isn't running

21:33

should be all over the place

heinrich5991: on windows you have different absolute paths

yes, there's another kind which this doesn't detect, C:\

21:56

I feel this is still an improvement over every file exec (e.g. autoexec.cfg) saying that you can't have absolute paths

21:57

*every failed

21:59

anyway, off for tonight

21:59

good night everyone

gn8