Teeworlds - bridge

https://github.com/teeworlds/teeworlds/blob/68e4a1784bd4f7021634f0cf4198f6e14b711495/src/engine/shared/compression.cpp#L55

02:51

what's the purpose of that loop.

02:51

that does not loop

02:51

ah, I see

02:52

the goto equivalent

02:53

high level rubber duckying

find this kinda not so pretty, as it makes kind of not much sense to use a class if there is no internal state saved at all. https://github.com/teeworlds/teeworlds/blob/master/src/engine/shared/compression.h. might as well save the pointer that is being returned internally and return it when asked via another method. usual use case if ptr = varInt.Unpack(ptr, &integer)

04:46

I think it would look better if the pointer was not used at all here. the VariableInt could be constructed by passing the pointer and the pointer could be returned via a method resulting in an interface that looks like this: integer = varInt.Unpack()

04:46

when one is done with unpacking, one might retrieve the pointer via some method like GetPtr() or GetPos()

04:48

as it's c++, the construction might get a size attribute as well in order not to enter unexplored territory

rubber ducking? http://www.developerduck.com/

08:37

you can click it

the last part is not

-y :'(?

posting in chat rooms is best rubber ducking i agree @jxsl13

12:40

lol the while(0) loop im not sure if that is supirior to goto xxD

there is some crazy stuff going one

12:44

for example this here: https://github.com/teeworlds/teeworlds/blob/68e4a1784bd4f7021634f0cf4198f6e14b711495/src/engine/shared/compression.cpp#L23

12:45

one could write instead

if (i != 0)
  *pDst |= 1<<7; // set extend bit (may branch)
else
  break;

how prevalent are dynamic IPs, and how often do they typically change?

12:53

I used to have dynamic IPs in France but they would only change every router reboot or so

in germany they change about every day at 3am

12:54

and on router restart/resynchronization

so we would have to introduce another single point of failure

12:55

at least it's not critical to playing the game I guess

12:58

I think some games use XMPP

12:58

yeah LoL uses XMPP for exactly that purpose: chat & game invites: https://xmpp.org/uses/gaming.html

effort vs. players that will use it.

a global friend/chat system would be very much used I believe

13:00

it's a fairly recurrent request

i hope its save to unload not loaded or invalid textures

13:18

http://zillyhuhn.com:8080/XN

13:19

yea looks like in all the use cases

nullpointer check :o?

13:20

of passed parameter ._. or does nobody do that?

yea thats what i am wondering

I would suggest caddy a a reverse proxy in order to have ssl for your websites

im afraight i pass a nullpointer

it grabs let's encrypt certificates automatically

13:21

@redix do you know what would happen with https://github.com/teeworlds/teeworlds/pull/2430 go alright with 0.7.4 client and 0.7.5 server and vice versa?

Race: differentiate between personal and map record by axblk · Pu...

This addresses #2389 Replacing the NetBool with NetEnum works because RECORDTYPE_NONE maps to 0 and RECORDTYPE_PLAYER to 1. The modder has to ensure that RECORDTYPE_MAP is only sent to 0.7.5 clients.

0.7.5 client + 0.7.4 server -> it will always display personal record 0.7.5 server + 0.7.4 client -> server must not send RECORDTYPE_MAP

13:48

in 0.7.4 it was meant to be the personal record

0.5.5 server + 0.7.5 client

13:48

0.7.5*

server can tell the client which type of record it was :) none at all, personal record or player record

13:50

or map record*

I was reading some issues from 2011 saying that race will be part of vanilla anyway.

a better solution would be to add another bool... but then 0.7.5 clients would drop 0.7.4 packets -.-

fast forward, 2020, race is not really part of vanilla yet xD

the protocol is not really extensible

rip godfather Sushi Tee

@redix how about another colour for map records for info message?

yeah would be good. what color?

gold? :D

13:57

probably hard to read

pink, everyone loves pink

14:06

?

14:07

i guess gold and pink are too bright =\

or just white

14:09

xd

a simple finish is white

14:10

personal record blue

red?

that color in the screenshot is purple

14:12

14:13

I find that too dark, might be a lighter purple

red is already used for the difference

got a hex value of that purple, @redix ?

14:14

already got it ._.

14:14

#65207C

orange then

#8329A0, #A258BB, #E5ABF9

14:16

#8329A0, #BB307B, #F94D40

try it on the sky @redix

looks good

yeah, looks good

updated the PR

14:33

what about making the network protocol more extensible/less strict?

14:35

e.g. using default values for missing fields... so we can extend net messages. might be useful for the vote thing

like we could add values to netmessages without old clients dropping it?

and ignoring unknown flags instead of dropping the whole packet

14:36

old clients would just ignore the additional fields. but new ones would drop the old messages because of missing fields

ah, yeah sounds good

and for enums: use some default value when the value is unknown

14:38

integers and strings should be fine

another thing that would be useful, if u could send just a diff for netmessages

btw https://www.teeworlds.com/forum/viewtopic.php?pid=123964#p123964

14:43

I have mint cinnamon and cannot reproduce

if i go crazy with automapper rules and make them super complex would that still be megered if it solves a few edge cases?

imo that is fine, as long as the edge cases are isolated in a part of the file

i tried that

14:45

i wasnt able to isolate or comment in the json properly

14:46

it caused some undefined behaviour i think

Dune: some displaymanager thing?

not so sure about that, it could be irrelevant to our flavor

14:47

how comes it works with sudo

14:47

flatpak also works

https://unix.stackexchange.com/questions/108784/running-gui-application-as-another-non-root-user

Running GUI application as another (non-root) user

Let's say I have 2 user accounts user1 and user2. When I login as user1, and then switch to user2 using su, I can execute command-line programs, but GUI programs fail. Example: user1@laptop:~$ su -

ho

14:52

so $DISPLAY is probably ""

oh btw does someone know how to properly activate live automapper? I always have to click around 5 times before i get it running xd

14:54

i guess its not possible in under 3 clicks

godfather, the second, a.k.a LordSk was working on an awesome editor update :'/ gotta wait for next christmas I guess.

15:10

excitement overflow

i dont like changes :/

@ChillerDragon has Teeworlds actually hard-changed anything since 0.7?

wdym by hard changes?

not optional

oh hmm

15:16

not that i know why?

If there's one software that you can't complaining about changing, it's Teeworlds :p

xxxxxxxxxxxxxxxxxxxD

15:17

i need one digit to destory ur statement

15:17

7

15:17

ima make this a meme xd

15:20

teeworlds actually changed that much that i quit playing the game lol

since 0.7

yes ik

15:21

but your statement was general wasnt it

If there's one software that you can't complaining about changing, it's Teeworlds :p

well... what changed? basic gameplay didn't change within the last 10 years :D with 0.7 we have a new menu. there are several details that changed but there havent been any major changes

well the major change is its incompatiblity

yeah, since matricks left I think we only had the ninja change?

also i am not able to correctly aim in 0.7

https://i.imgur.com/GSjMw4v.png

might be a ddnet to vanilla difference not sure

oy: version server still at 0.7.3

today most games break compatibility every few weeks

15:26

you have some time to update... then you might get some problems

yeah, sometimes you can't watch month old replays :p

but big parts of the 0.6 community are used to some ddnet standards so 0.7 can be seen as a heavy downgrade for some

Dune: that's the 0.6 version server, forgot to update that

version server works for me locally

15:28

is the server maybe having some connection issues? =\

works for me too locally

you mean 0.7? @redix

yes

heinrich5991: said he can see incoming data, but nothing is send out

15:30

have to update this for the 0.6 version server https://github.com/teeworlds/teeworlds/blob/0.6/src/versionsrv/versionsrv.cpp#L65

teeworlds/teeworlds

A retro multiplayer shooter. Contribute to teeworlds/teeworlds development by creating an account on GitHub.

I that hash mismatch warning I get on zCatch due to the version server or due to me merging 0.7.4 incorrectly?

what's the message?

on server startup

15:32

Wasning net hash versionmismatch or something like that

15:32

Warning

update https://github.com/teeworlds/teeworlds/blob/master/scripts/cmd5.py#L33 with ur hash, then the warning goes away

teeworlds/teeworlds

A retro multiplayer shooter. Contribute to teeworlds/teeworlds development by creating an account on GitHub.

WARNING: netversion hash differs

15:33

ah ok, thanks

@ChillerDragon just for curiosity... what are the major things that 0.7 is missing compared to ddnet? obviously is does not have all the ddrace specific stuff... antiping

15:42

i used ddnet myself but i hardly used any non vanilla features

@redix well i can speak best for me and i try to find out every day why others do not update but i guess not updating is also a coninience and bubble thing

all I want is to disable the hud completely and read chat in f1 console

For me personally as i already said i can not properly control my mouse in 0.7 idk if ddnet had a influence on that. Also I really depend on demo features like demo cutting and sort by date or name. @redix

well in tw some people even refuse to update because they dont like some colors or such stuff

Does anyone know how I'd find out the include dependency tree on windows without using windows?

other people heavily depend on antiping or the sdl1 version to have a playable teeworlds expiriene @redix

like one of my classes includes stuff on windows which kills my windows build seemingly

things like colors and hud can easily be fixed in custom clients

yeah the demo stuff could use some improvements

also some really like to change their names ingame

15:46

the new name system is really odd

when sdl1 works better than sdl2 your system is probably broken/outdated as fuck

that might be true but unless you buy them new hardware the problem probably wont go away

15:47

also ddnet did a lot with rendering and opengl magic where i have no clue of but seems like some players really profit from that

the opengl 3 backend is actually even slower then the 1.1 one =\

15:48

at least in some situations

15:48

than*

and those were only the things that quickly came to my mind and are non ddrace. But you have to keep in mind that a big part of the player base plays a lot of ddrace and needs the clientside predicition and map editor features etc

well okay =\

any it only takes one reason to not update

15:49

if i wouldnt care i would have never updated because of the slightly off mousesense and played 0.6 until im the last one there

15:51

everytime i advertise 0.7 ingame people ask me "whats new" like "why should i do it" and "what changed". I really lack arguments in these situations. Should i say its a new protocol so ddnet client wont work anymore and this removes antiping and name changing... but you get a new menu (which some people actually dislike).

15:52

you can not advertise a new vanilla gametype to the average ddrace player or fixed anti spoof for people who are save from spooing with ddnet client already.

sounds legit

i think if the 0.7 name system gets fixed (reset to 0.6 state) with a lot of effort we could migrate the community to the new version and restore all the old standards

i dont get why changing the name is so important... changing skin makes sense. especially because some mods rely on it

I like that you can identify people by their name

15:57

I think no one would ask for that feature if it wasn't in teeworlds at some point

yes thats why (1) prefixes make so much sense Dune

I agree

15:58

But changing name is not great

yeah unique names should come back

the 0.7 has undistinguishable names which is annoying in whispering spectating and chatting not to mention modifications where playernames are arguemnts to commands

15:59

well i personally do not care about changing names but seems like others do and thus 0.7 looks like a downgrade. I havent seen a single person saying yay finally i cant change my name anymore.

well you can't always please everyone

16:00

if you do, you will never manage to change anything

16:00

there is still an option to remove double jump indicators because some people disliked that back then iirc

an option yes

16:01

but removing a feature optionless is something else

16:01

what about a server side config

there are benefits to make name changing not an option

ye

16:02

sure options are not too great

whisper is broken as hell in combination with undistinguishable nicks

whisper is broken as hell period

bringing it back would be problematic... it would not work for old clients, so one player would have different names for the other players

ye

16:03

thats a issue

._. installing visual studio 2019 in a vm

that will be fun

16:08

@fokkonaut did you already add the chat commands auto completion to your mod?, mind pointing me to the code :o?

yea i did

16:09

gamecontroller.cpp, at the bottom

ok, thanks

found?

yeah, but not the position where you actually add your commands, as that currently seems to be the stuff from vanilla, that I also added

"add your commands"?

16:12

what do you mean

16:12

So, I didnt understand in general what exactly you are looking for

I wanna send the commands to the clients

16:13

where do you personalized commands, was my question

16:13

that are use din your mod

thats in OnPlayerConnect, in gamecontroller

16:13

I send the commands there

16:13

to the client

ah, ok

Well, thats vanilla

16:14

but the removal of client commands there is from me

16:15

or do you mean, where the code for my commands is?

16:15

like after they got executed

well, took too long to realize that I'm on the vanilla branch.

16:21

xD

xdddd

I found a typo

16:24

harsh open source life you live there

yea fokko is big troll for not making it the default branch

who wants the sweet code, gotta look for it.

std::function<void(class CPlayer *pPlayer, const char *pArgs)> > function pointers ._.

17:32

Ryozuki did a great job so that it's easy to switch between both of them.

17:38

how does one install freetype and sdl on windows?

ddnet libs

17:49

clone with the cmd given in my repo

17:49

in the readme

I'm illiterate when it comes to using windows other than for playing games...

Oy: btw do you think of a way a vanilla server could signal client-sided bots? right now it is not possible without a code modification, which is forbidden

give clients the ability to signal that they are bots x)

19:08

well, ddnet had added some client flags to messages which were used by cheat clients as well to signal that they are such clients

19:09

also ddnet used that to signal that somone used the client

19:09

someone*

I feel like one has to start developing on windows if it is pupposed to run on windows, as other OS don't care that much...

@redix do you know a terrible server i could test my stability indicator on

19:51

alternatively, does anyone have a terrible wifi connection that could host a home server on

is teeworlds ever gonna be put in a proper namespace?

19:55

(unique)

adapt to the codebase, don't wait for the other way around

windows suck

19:59

hard

with lag: https://streamable.com/2y9jx

20:11

without lag: https://streamable.com/z0fc3

20:11

the number above is a badness score

20:11

(that's just for debugging)

20:13

it uses the prediction graph

20:13

yellow spikes = +10 badness, red spikes = +50 badness

20:14

it should be a reliable indicator of stability. I got 5 bars on a 250ping server

can you push the netgraph?

push?

20:30

@Assa

add a netrgraph to game, some options for network monitoring

20:30

like you have in the video

those are in the game

20:31

ctrl shift d g

lul

ctrl shift q for more secret modes

ctrl shift q is my favorite mode

I wonder how heavy the tcp impact due to a 24/7 econ connection is Oo

21:18

on the main thread

impact on what?

21:26

i have 2 econ connections running on the same vps to localhost since months

I mean on the tick delay

21:32

having kinda weird lags

did not notice anything

Dune: we could add a setting for the clients so they could tell the server they're a bot and then the server can propagate it

hm, is that abusable?

well some trolls or nobrains will run around with it 24/7 and thus the filter for actual players is broken

22:07

i suggest that this setting is not possible in vanilla client but the vanilla server expects it. So the client has to be actually edited.

oh yeah it shouldn't be an option by default

22:07

I mean, on the vanilla client

yes

but it would be difficult to enforce

what do you mean?

22:11

what about more than is bot or not. What about a int with flags what type of client it is. Like chatbot/aimbot/spider and the admin can see these flags in status but the vanilla client can not set any of these flags without modifying the source code.

and when u use it u get the bot skin ingame

22:16

would be a flag the client sends on connect and a custom client has to modify the code to set it

and enforce human only player on vanilla game modes

would be stupid to allow everyone to set that via f1 or GUI :0

22:34

as they would play around with it

rand, shouldn't vanilla allow bots?

then they might join without setting the flag