Teeworlds - bridge

I am actually very happy with the 0.7 client

10:07

when i moved away from 0.6 and started almost only playing 0.7 i disliked it but now its nice

i dont see how ddnet destroyed 0.6, it simply got popular, if ppl enjoy playing it i dont see anything wrong, make your awesome mod and im sure ppl will play it if its good

10:09

you could start by investigating why its so popular

I am not able to download maps in 0.7 :/ in 0.6 it works tho

10:24

it gets stuck after a few bytes

@fokkonaut : does your code about tee collisions can be simplified as if(D < PhysSize && D >= 0.f) ?

Thats what I thought too last night while reviewing my commits xd

10:39

But

10:39

I think i tried it and it didnt work iirc

10:39

I can try again later

ok

10:41

“<zcatch> this is a beginner server, you are not allowed to play here” :( I'm a forever beginner !

@oy thanks for merging the spec mouse pr! did you test everything?

yeah, think so

nice

one day i will bring code a new client with all the features iam missing, with matchmaking, twitch support and hookers

hyped

i think i need help with the github actions workflows

15:53

on my current state windows with bam and mac with cmake are not running

there was a mac fix recently I think

I have a new branch (actions2) so i don't spam the tw PR

15:54

can you further explain?

I have a working gh actions workflow for all 3 platforms with bam and cmake. Only the packaging is not working on mac. According to cmake the needed tools are missing. Anybody ever tried building dmg files on Travis or gh actions?

16:01

And the sdl+freetype download often fails with bam on windows

can you send me a link to lookup what you did differently?

https://github.com/axblk/teeworlds/commits/gh_actions

axblk/teeworlds

A retro multiplayer shooter. Contribute to axblk/teeworlds development by creating an account on GitHub.

@redix https://travis-ci.org/ddnet/ddnet/jobs/632954311#L754

Cool stuff @redix

Gh actions has no pkg-config by default. And the findsdl module from tw is buggy when pkg config is missing

on which os?

The windows thing is probably due to gh actions using Powershell as default shell

and in what way buggy?

how do i change that @redix because iam sure you are right

16:05

shell: bash

16:05

okay, will test

You can't. Add python as prefix in the bam script

16:06

https://github.com/axblk/teeworlds/commit/0466d77988102ed4e8a309317cac5ed022b6df3f

Add github actions workflow · axblk/teeworlds@0466d77

16:06

The change in bam.lua

that might break builds on normal windows

@heinrich5991 when the cmake internal fing_package is used pkg-config is still called

big note here:

16:08

https://github.com/actions/setup-python

actions/setup-python

Set up your GitHub Actions workflow with a specific version of python - actions/setup-python

16:08

i already tried this (without success)

It might overwrite the valid paths when pkg-config can't find sdl

16:09

The problem is the file type association on windows. It will internally start a new shell so you can't pipe the output

but the build worked on my system with this bam.lua version, I think

It's only a problem when Powershell is used by default. I think that's not the case on usual windows systems

ah

16:11

I don't see where pkg-config is used on windows (has a default of PREFER_BUNDLED_LIBS=ON) other than a source of hints for find_library

That problem occured on mac. find_package already found sdl but since pkg-config was missing it still did not work

16:13

https://github.com/axblk/teeworlds/commit/09466c7695068b090d64fd53896f8dd5fc8cb299

that's not a problem of pkg-config

16:14

but of the second find_library call

16:14

https://github.com/axblk/teeworlds/commit/09466c7695068b090d64fd53896f8dd5fc8cb299?w=1

True

here is my latest workflow where you can see that mac doesn't find sdl2

16:16

https://github.com/AssassinTee/teeworlds/commit/5bd08c7804884dda911d17b2fbcad38a3ecef4b8/checks?check_suite_id=385066970

AssassinTee/teeworlds

A retro multiplayer shooter. Contribute to AssassinTee/teeworlds development by creating an account on GitHub.

that bam change breaks normal windows build

Only for systems where python is not in the path var

unrelated: the change to is_bundled(SDL2_BUNDLED "${SDL2_LIBRARIES}") looks weird, is_bundled only takes a single path and ${SDL2_LIBRARIES} sounds like it could contain multiple, (but with the current code it can't, so it works)

16:18

yes, that happens with the standard python install

16:18

that python is not in PATH

Hmm... A solution would be to let python handle the file writing stuff

what probably most users do

Then you can also use the file association on gh actions

16:20

@heinrich5991 yeah. This change was rather unintentional

could also do a config check if python is in path and then use the python call, otherwise use it like it's now

is teeworlds careing about python2 or python3?

16:25

*caring

python 2 was EOL 4 days ago, at this point we can treat a python in path as a bug

16:26

a python 2

and when is python 4 coming?

could probably drop python2 now

not at all according to the python community, Assa

The ddnet cmakelist has no output for it but it seems like Travis has the dmgtools installed. That's not the case on gh actions

hm, HDIUTIL seems to be what it needs on mac

16:36

@redix link to the output on gh actions?

Not found according to cmake

16:37

https://github.com/axblk/teeworlds/runs/373101847

axblk/teeworlds

A retro multiplayer shooter. Contribute to axblk/teeworlds development by creating an account on GitHub.

16:38

Packaging was deactivated for mac in this build

16:38

But it says that dmgtools and hdiutil are not installed

16:39

https://github.com/axblk/teeworlds/runs/373078197

axblk/teeworlds

A retro multiplayer shooter. Contribute to axblk/teeworlds development by creating an account on GitHub.

hm. stuff on internet forums implies that hdiutil is always installed on mac systems

Yeah... Seems so. Not sure why cmake does not find it though

so the question is why cmake doesn't find it or why it isn't installed on github's macs

16:42

ye

But ddnet log on Travis says the same

ah