Teeworlds - general

Teeworlds

discord.gg/teeworlds / general

Teeworlds Discord Server.

Between 2019-11-29 00:00:00Z and 2019-11-30 00:00:00Z

builder17 joined the server. 2019-11-29 08:20:26Z

I meant 1<< 12 Kinda didn't see the 2 there, usually it's a 1. (edited)

14:56

I wonder why it's actually even more complicated by using a 2 there. (edited)

14:58

why is the bitshift part more relevant, what would be expressed by 2 << 12 that is not being expressed by 8192? (edited)

realby joined the server. 2019-11-29 15:56:56Z

@qshar @kogadmins wtf?

Image attachment

Thats not 0.6

16:30

Thats 0.7, go on KoG Discord and ask there

16:30

https://discord.gg/NGtK63M

Invite to join a server

|*KoG*| King of Gores

general_chatroom

More infos here https://discord.gg/qcDG8QV

Image attachment

@Dune

Image attachment

19:43

watcha think (edited)

19:43

https://github.com/teeworlds/teeworlds/compare/master...Ryozuki:pr_serverside_cmds?expand=1

teeworlds/teeworlds

A retro multiplayer shooter. Contribute to teeworlds/teeworlds development by creating an account on GitHub.

19:44

here is the changes

19:44

i thought about doing a argument parser but idk a good way to do it and looks complicated, i guess its better to let each modder do it their way

19:46

talking to a wall

@Ryozuki at first glance of the code, looks like some nice work so far, good job

19:52

It's easy to get bugs in this thing though, gotta test it thoroughly

yeah sure :p

the network.py changes need to be put at the end to not break compatibility with older versions afaik

i see

I had started to write something similar a while ago but you did a lot more progress

19:54

One specification there was, was that client commands and server commands should be distinguishable

and it is

19:54

it can be more beutiful but it is xD

19:54

u see, test is blueish

Oh, is that the green background?

ye

I see

if u know a better color feel free to tell me it xd

That's good by my standards :)

so i move the netmsgs to the end

I think there are already some netmsgs with # TODO 0.:8 move up right

yep

19:56

Image attachment

19:56

moved them there

yeah good

19:57

/r doesn't take a playername btw

ops

19:57

a string?

nothing

19:58

just typing /r replies to the last message

19:58

Those chat commands were written hastily before 0.7.3 iirc I wanted to make it so that you don't have to press enter after tabbing a player, but instead that doing space does this

19:59

and maybe some syntax coloring so you can see where the player argument is e.g. All: /w **nameless tee (1)** hey

hmm but maybe that can be done in another pr

oh yeah absolutely

:p

You think it's most intuitive to put server commands on the bottom?

well idk but its easier

20:00

codewise

I see

do you think it lacks something else (other than an argument parser)?

20:01

btw I think server commands should be able to override client commands

20:01

e.g. if server defines /r, then it disables the /r client command

20:01

but that might be confusion inducing

20:01

what do you think?

i wouldnt do it

20:02

actually i need to fix to not have duplicates

20:02

:o

20:02

server has plenty of command names to choose i think

that's true but ddrace stuff tends to use /team and /r right

/r is exactly what it does rn i think

20:04

about team, thats right

20:04

any more opinion on this?

20:04

its not hard to do it anyway

when you press escape it sends commands as raw text

20:05

but it's a bit unclear when it's a command and when it's raw text :/

20:05

teeworlds guidelines go against the use of NULL btw I had to edit a PR for that :p

20:06

thanks for your work

20:06

I'll test it this weekend

ill pr to make it easier

20:08

@Dune do they go against nullptr?

my bad, I think I got it the other way around and it's no nullptr

20:09

lemme grep

20:10

https://github.com/teeworlds/teeworlds/pull/1577

Replace nullptr by NULL, fixing compilation errors; also, correct ...

Compilation is broken since 5ef5a26. Should use NULL instead of nullptr: teeworlds/src/game/client/components/menus_settings.cpp Lines 1186 to 1187 in 5...

20:12

right, I forgot nullptr is C++11

so i should use 0

NULL is fine

20:13

my bad, I think I got it the other way around

i like nullptr tho

me too

20:13

but it doesn't compile :(

it compiles for me

20:14

do u use a old compiler or smth

cause you use some C++11 compiler

20:14

by default the compiler settings do not enable c++11 flags for gcc, for example (edited)

i see

you're on windows? msvc doesn't have an option to be strict c++03. right @LordSk 🦋 ?

windows? never

20:16

im on arch linux

huh, which compiler?

gcc -v
Using built-in specs.
COLLECT_GCC=gcc
COLLECT_LTO_WRAPPER=/usr/lib/gcc/x86_64-pc-linux-gnu/9.2.0/lto-wrapper
Target: x86_64-pc-linux-gnu
Configured with: /build/gcc/src/gcc/configure --prefix=/usr --libdir=/usr/lib --libexecdir=/usr/lib --mandir=/usr/share/man --infodir=/usr/share/info --with-bugurl=https://bugs.archlinux.org/ --enable-languages=c,c++,ada,fortran,go,lto,objc,obj-c++,d --enable-shared --enable-threads=posix --with-system-zlib --with-isl --enable-__cxa_atexit --disable-libunwind-exceptions --enable-clocale=gnu --disable-libstdcxx-pch --disable-libssp --enable-gnu-unique-object --enable-linker-build-id --enable-lto --enable-plugin --enable-install-libiberty --with-linker-hash-style=gnu --enable-gnu-indirect-function --enable-multilib --disable-werror --enable-checking=release --enable-default-pie --enable-default-ssp --enable-cet=auto gdc_include_dir=/usr/include/dlang/gdc
Thread model: posix
gcc version 9.2.0 (GCC)

strange that it builds

why

20:17

i use cmake + ninja

tmp>g++ main.cpp

tmp>g++ main.cpp --std=c++03
main.cpp: In function 'int main()':
main.cpp:3:14: error: 'nullptr' was not declared in this scope
  return (int)nullptr;
              ^~~~~~~

so g++ defaults to c++11 nowadays

20:19

TIL :)

:D

20:19

u sure its c++11 and not 14 or 17?

20:19

i wouldnt be surprised

tmp>g++ -dM -E -x c++  main.cpp | grep -F __cplus
#define __cplusplus 201402L

you're right

g++ -dM -E -x c++ /dev/null | grep -F cplusplus #define cplusplus 201402L

20:20

ye

20:20

xd

;o

201402L is c++17

20:20

iirc

sounds counterintuitive

https://github.com/teeworlds/teeworlds/pull/2297

Add server-side command support by Ryozuki · Pull Request #2297 ...

@Ryozuki btw did I miss something or there is no limit to how many commands the server can set?

there isnt

20:30

should i add a sane limit

20:30

idk

yeah or it'll just glitch the UI

how much is too much

idk 15?

20:30

maybe it'd be good to add a way the server can remove commands

20:30

so that it can replace them contextually

20:31

and only display those that can be executed

true

20:33

client already has 8 cmds

20:33

with 15 it leaves 7 to the server

20:33

but u can always do stuff like

20:33

subcommands

I meant 15 to the server

ok

but that's just a random number better check with the UI I guess

it also depends on the resolution right

yeah..

what about

20:34

making the rect fixed size

20:34

and add a sidebar

20:34

scrollbar*

20:34

im not a ui code pro tho

Image attachment

20:35

even on super small resolutions it just scales down

20:35

this is 640x480

ah

scrollbar works when it's a clickable thing, I think that would be messy

Image attachment

but maybe it's a good idea, not sure

20:37

so 14 is the limit?

14 for server? ye i guess

aight

client side scrolling?

21:50

256 commands would be neat :/

hf doing the UI for that ;)

xD

21:51

never touched the client

21:51

well once

@Ryozuki

@Deleted User what

GWpingSock

3

haahaha

??

@Ryozuki can the server overwrite client commands?

@ChillerDragon not yet

22:57

idk if its useful

well /team and /w might be usefull but could also be nasty if they block the client commands and users depend on that

Embedded image

22:59

could be removed i guess

ik

22:59

the thing needs to be tested

22:59

i left it there for convenience

k

23:00

so pr is not finished yet?

it is

23:00

well if u keep telling me new features then not

xd

23:00

what about argument auto completion

23:01

its posible

23:01

cuz i send flags

wait rly?

i will not do it rn

i wanted to troll u

well its just basic

23:02

client knows how many arguments and their type

23:02

int string playername

yeyeyeye so true btw ye

Exported 179 message(s)