Teeworlds - general

Oh demos are broken? I based my client on latest master and released it :/ @Dune isn’t that what you did as well?

Yeah

10:18

Demos compatibility isn't good at the moment

10:18

https://github.com/teeworlds/teeworlds/issues/2230

Incompatible demos · Issue #2230 · teeworlds/teeworlds

The PR #2129 changed the format of the snapshots. For the client-server communication this does not matter, since the protocol only uses snapshot deltas. The demos however, use complete snapshots f...

Is it planned to break? Or will it be compatible in the next version again?

10:20

Ah i see your comment

10:21

@Dune so we both distribute clients that create broken demos? Sounds bad.

feel free to fix it :p

Yikes

10:21

I failed hello world homework at university... im not sure if I’m the person for the job

or we could revert the change temporarily

I think that would be wise

It is the easy solution

R41NB0W joined the server. 2019-11-08 11:38:38Z

Maybe I find some time to fix it in the next few days

5

11:41

The demo player needs some validation code for the snapshots anyway. Right now it's pretty easy to at least crash the client (edited)

How about when playing? Can weird snapshots crash the client?

Network protocol uses snapshot diffs. These are checked properly.

Alright

It's at least not as easy as with full snaps

Why not?

The snapshots are just copied into the buffer and used without any checking

11:48

They are usually only used internally so that's not a problem. But it wasn't a good idea to store them in demos

I agree

The network protocol starts with a diff from an empty snap. Demos should use this for keyframes aswell

use what, a diff?

Yes

muh compatibility :/

Yep

is it really worth breaking yet another compatibility to have something that works cleaner under the hood

So for now converting and validating the snapshot is probably better

converting? ah, into the optimized version

11:52

it's a problem both for read and write right

Yes

Or we could revert it for now and push this change to 0.8

11:53

And think about how to do it properly then?

Well... Converting mostly means dropping the keys at the beginning when writing and getting them from the items when reading (edited)

Well I clearly won't stop you if you want to implement it

11:55

I'm just thinking

I think if we want something to be improved waiting for 0.8 is not a good idea :p

1

If you can make it work with the current version that would be great!

11:57

Is there a version number though?

11:57

Nevermind actually

11:57

the demo format would not change

0.7 already has some hacky changes... thinking about the skin change

one more would be okay I think

yeah

Btw... The chat still has some seldom overlapping bug. On another machine I also noticed some flickering in the chat when the scoreboard is open. I fixed the overlapping bug but I cannot reproduce the flickering on my laptop

resizing a chat box when a scoreboard is opened sounds absurd to me :/

1

Anybody knows whether these two things appear at the same time?

huh, chat and scoreboard?

Flickering and overlapping

never experienced flickering

TextWidth is inaccurate

In general both only appear with scoreboard and chat opened