Teeworlds - bridge

hey can anyone tell me what kernel()->RequestInterface does?

for many classes, there is only one "global" instance

10:49

this basically allows you to get that instance

what if iam hacking something and have multiple instances?

10:49

i see i need a specified name

not really supported by this system. what class do you duplicate?

Map

perhaps you don't need to register it to the kernel

10:50

src/game/layers.cpp:    m_pMap = pMap ? pMap : pKernel->RequestInterface<IMap>();
src/game/server/gamecontext.cpp:    CTile *pTiles = (CTile *)Kernel()->RequestInterface<IMap>()->GetData(pTileMap->m_Data);
src/engine/server/server.cpp:    m_pMap = Kernel()->RequestInterface<IEngineMap>();
src/engine/client/client.cpp:    m_pMap = Kernel()->RequestInterface<IEngineMap>();
src/game/client/components/mapimages.cpp:    LoadMapImages(Kernel()->RequestInterface<IMap>(), Layers(), MAP_TYPE_GAME);

10:50

eh

yes

10:51

see my problem?

10:51

what happens if i call Kernel()->RequestInterface<IEngineMap>() multiple times?

you get the same instance every time

this breaks everything

you need a different system if you want to have more than one map

i know

perhaps pass it via parameters instead of the interfaces requesting it from the kernel

after loading dm1 my server crashes (while having loaded another map)

what do you want to achieve?

yes, I will do this

loading multiple maps?

multimap, like Kosmo archived

10:53

should I show you?

yea, then do it like described above

okay ^.^

nah, I think I saw it already

this new technique has so much potential

10:55

you could autogenerate maps on the fly

yup

the class CMap is declared in a cpp file (engine/shared/map.cpp), but why? Shouldn't it have a header

the header (src/engine/map.h) contains the "interface", i.e. all the members of the map that are exposed on purpose

11:07

this way you can do whatever you like in the class CMap without accidentally enlarging the interface

I have never seen a class declaration in a cpp, but okay, this makes sense

src/engine/client/text.cpp:class CTextRender : public IEngineTextRender
src/engine/shared/kernel.cpp:class CKernel : public IKernel
src/engine/shared/masterserver.cpp:class CMasterServer : public IEngineMasterServer
src/engine/shared/storage.cpp:class CStorage : public IStorage
src/engine/shared/config.cpp:class CConfig : public IConfig
src/engine/shared/map.cpp:class CMap : public IEngineMap
src/engine/shared/engine.cpp:class CEngine : public IEngine

11:09

these are the instances in teeworlds

11:09

this pattern is also used at the game/engine boundary

11:09

you'll see a few interfaces (e.g. for the gameclient/gameserver and engine client/engine server) in src/engine/*.h

I normally use singletons if i want this behaviour

I don't see how this is related to singletons — this tries to achieve that there is one clear interface which is used for communication (edited)

now it makes sense to me

11:11

a singleton provieds one global instance, too

11:11

but not the clear single interface aspect

ah

I don't see the difference with sigletons

as far as I understand it, "singleton" means that there exists exactly one instance of that class

https://stackoverflow.com/questions/1008019/c-singleton-design-pattern

C++ Singleton design pattern

Recently I've bumped into a realization/implementation of the Singleton design pattern for C++. It has looked like this (I have adopted it from the real life example): // a lot of methods are omit...

the pattern used in teeworlds code means that there is a separation between interface (the IMap class) and the implementation (the CMap class)

11:19

hum, fun. IRC displays my "the pattern used in teeworlds code" below @Assa's stackoverflow link. apparently discord doesn't synchronize order

isn't that the right order? It shows me the same

it doesn't show the same for me in discord

Discord probably has another consistency model

Do i have to include the kernel for using its interfaces?

almost all files already include <kernel.h>, so realistically: no

because i get a runtime crash when calling Kernel()->RequestInterface<IStorage>()

have you checked why?

invalid write of size 8 says valgrind

huh write.

*read

you can put it into gdb to get the exact function where it's crashing

my mistake

11:36

Segmentation fault, IStorage ist ein nullpointer oO

not Kernel()?

doch Kernel ...

you have to use RegisterInterface on your class or stop inheriting from IInterface

Nice, this helped a lot ❤

11:50

thank you

isnt autogen maps on the fly opensoruce already?

12:15

there was this BuggyCrapGores repo once somewhere

perhaps

@heinrich5991 I did it ^.^ I just spawned in the wall outside of dm1 but thats not my business yet

cool

(edited)

Ninslash (the game by siile based on teeworlds) has automaping, and its open source

i will take a look at it, thank you ^^

hey Heinrich, what would happen if i use the same storage for all maps?

16:09

can you explain what the storage does?

@heinrich5991 discord reorders messages a posteriori iirc

@Assa sharing storage is no problem

18:56

storage just handles the logic that teeworlds looks in the data directory next to teeworlds.exe and also in the user profile in %APPDATA%

@Dune doesn't seem like it, @Assa and I had different message orders in discord