Teeworlds - bridge

i would remove the whole browser lol

09:01

am i the only one thinking that the new server browser is confusing af? I never find server.

so much spam

nice

poor @Sonix having to fix our dirty code :P

gotta reduce spam a bit, Oy is too active

10:46

@Fudgy: I hope people will find out they can find demo details there

10:48

I'm not sure if there is a good solution anyway ^^ maybe the ideal would be to display important things such as the length elsewhere, stuff like the crc, the version and what not needn't be displayed by default

Dune, what do you think about auto hiding scrollbars?

10:50

It was actually really easy to check this. The only problem is, that the background is still there and iam looking into it

i think we already improved scrollbars a lot and that's a very minor thing that shouldn't be prioritized :P

10:51

@LordSk 🦋 made a scrollbar API, I think it has yet to be used in the demos menu

what should I prioritize? Which issue do you think is suited for me

10:52

Master, Dobby wants instructions

Oy is the true master :P

10:55

there are a lot of things to do :) we're not lacking in that department

10:56

oh, there is https://github.com/teeworlds/teeworlds/issues/1834

hover over settings make hint appear · Issue #1834 · teeworlds/t...

if you hover over a setting (for example Show social) you should see a little pop up window where your mouse is that prints the text that you would see in f1 (usign the example show social, the hin...

10:56

if you like UI stuff

10:58

if you want something server sided, what about a way to save bans?

we should use the jsons on the serverside too

what jsons?

any :D Bots will need to read the skins, if we will implement ones

11:00

currently there is no native way to read jsons on serverside

bots will need to read the skins, really?

how are you willing to fill the skininfos?

it's just a string right?

11:01

just send "default"

11:02

(or whatever)

what if you want another skin? And you shouldn't hardcode this stuff

well you write "cammo"?

11:03

I mean you don't have to hardcode that stuff but I don't see how reading the jsons help

side note: Zatlines botskins could be implemented on clientside or just be handled as any other skin

They are not really skins, they are decorations on top of skins

11:03

and they're already implemented?

hmm, true :o

11:04

so when doing a permanent banlist, we need file IO

yeah

11:04

this can be saved in a bans.cfg

11:04

isn't there already something like that?

11:04

also I have a bunch of tasks/ideas I'm not doing, if you're interested

tell me :D

for example, we could have a way to save chat text by clicking out of the area or something instead of deleting it

11:05

it would let you resume a long interrupted sentence because you had to do something ingame

11:05

some games do that

11:05

we also need to prevent clients from self wispering

11:05

we could have some visual effects to help playing with no-sound (like the sound notification you get with Ctrl+S, but with a flag when there is a capture for example)

11:06

we could also implement copy, right now there is only paste

copy might simply copy the whole line

we can have something basic that just selects everything from the textarea (chat or text box)

for starters

exactly :)

11:06

don't wanna implement a selection system

i will take a look on the save chat one. It happened to me a lot, that my text is lost because the map changed

oh yeah there's that too, annoying right :p

should that be saved in a variable or a seperate buffer?

11:09

meh, a buffer would make more sense

not sure if I see the difference

It may appear in the settings file, which doesn't make sense

11:10

But i think you had a flag to prevent that

ah, yeah there is a flag for that

11:11

but I didn't think you meant a client variable

11:11

yeah, that doesn't need to be one

11:12

it just needs to survive the disconnect/connect that occurs on map load

shouldn't it be client sided?

yes of course

11:12

but it doesn't have to be accessible from the console

yes

which key is KEY_KP_ENTER ???

I think KP is keypad

11:31

so i think it's the numerical keypad enter?

ahhh :O now it makes sense

Assa: Dune: already fixed: https://github.com/teeworlds/teeworlds/issues/1902 https://github.com/teeworlds/teeworlds/pull/2102

Make it possible to not loose the chat when changing map on a serv...

At the moment when changing the map on the server all the past chat is lost in the normal chat. You have to press f1 in order to see the chat from before the map change and f1 is not as good lookin...

Dont clear chat and current line when changing map by Fudgyking ·...

I cant claim that this doesn't break some weird edge cases so please make sure to check. I didn't put a config setting for this because I think there are no reasons to not want to h...

ah, right, that part is fixed. the task I had in mind was more about saving the chat buffer when you click out of it because you have to do some play for a second

apprently i have fixed both with a few lines of code

12:30

side effect: chat all: "test" Escape -> Team Chat : "test" already written

I guess it should be reset if you change chat mode ^^

then i have to track the chat mode, too

yes

single thread is still fine for bots

highly depends on the bot

Dune, i finished the chat buffer. I used config_variables. Is there a flag, that these variables aren't shown in console?

no, there isn't

I thought you were going to use a buffer instead of a variable?

quote: "not sure if I see a difference"

quote: "I didn't think you meant a client variable"

13:11

I thought you meant a program variable :)

ah ^.^

so yeah it shouldn't be a client variable because it doesn't have to be accessible by the client

hmm, i have an idea

13:18

now its in a Buffer in chat.h

13:18

it even survives leaving the server and rejoining :o

#2118 breaks the nethash

(just remove the nethash ._.)

I broke the nethash ._.

nah, the nethash is broken

#2118 just changed 5 files: collision.h, gamecore.h, gamecore.cpp, collision.cpp, and character.cpp

13:21

one of this must have changed the nethash

gamecore change sthe nethash right

13:21

can't connect anywhere with the master client

how do you handle nethash breaking updates?

by hardcoding the new nethash. see scripts/cmd5.py

yeah that's annoying

13:27

ugh there is a crash that only happens when I don't start teeworlds in a debugger :(

The NetHash usally makes no sense for custom servers. If you want true 64 player support, you will have to overwrite it, due to a change in protocol.h

huh? I think you can just change variables.h, right?

13:36

or is there some other enum you need to change?

MAX_PLAYERS=64

ok :)

13:37

so yeah it's a bit bothersome to have it

SvPlayerSlots, ..., 8, 0, MAX_PLAYERS in variables.h

13:38

if you want more then 16 players you have to change MAX_PLAYERS

I noticed how usefull it is to shoot yourself out of chat

14:14

i will add mouse1, mouse2 and space

space??

*not space

haha

I see my mistake xD

you can also replace MAX_PLAYERS by MAX_CLIENTS in variables.h

unspeakable side effect, i am not sure if everything would work well then

Btw Dune, the demo details always start maximized when you open the client so no one will not see them

oh I reviewed the code and thought it defaulted to 0

14:24

should have tested :)

14:24

my bad

static bool s_DemoDetailsActive = true;

14:24

No prob :p

14:25

I have more changes to the demo list coming in the next few days

cool :)

Assa: well, atm, it is enough since MAX_PLAYERS is only use for clamping or to check vanilla servers

oh you are right :o

how do i call methods in gameclient from the menu?

Assa: the menu is a component

yes, and i want to call a function in another component

You said you need to call the gameclient, every CComponent has a pointer to the game client (m_pClient)

you can probably access the client from that component

14:59

Teeworlds' encapsulation is... a bit weak :D

(Every registered component that is)

Client() is the way to go

m_pClient->m_pChat->DoStuff() is not working

15:00

'incomplete pointer m_pChat'

sounds like you need to #include the declaration of CChat in the cpp file you're currently editing

the across component access sounds like you are doing sth wrong(tm) though :)

what @heinrich said was right

sure

yes, its not nice how I do that, but I want to call a function in chat on disconnect

15:03

And I didn't find a better place, then the ingame menu

OnStateChange sounds like the way to go

which cpp?

CChat

ah obviously

15:05

yeah, this would make totally sense xD

thank you, everything works fine <3

Assa, bnet games even have visual effects for it :) https://puu.sh/DmrOF/6d2e419be3.jpg

Assa: are they not?

@Dune do you want me to do the full program? Resuming with chat button, doing a label for that

probably best to wait for Oy's input :)

@heinsirch: should i reproduce and post a picture?

that's a neat nickname

gameclient.cpp #L151ff probably all are missing Localizations

yeah should be added as far as I can tell

16:15

there is also https://github.com/teeworlds/teeworlds-translation/issues/71

Some strings are missing for translation · Issue #71 · teeworlds...

Hello, There aren't some strings for translation on Transifex: Server body marking decoration hands feet eyes (screenshots on Imgur) If you add them to the .json file manually, translated s...

Assa: nah, if you experienced it, it's fine

Assa: what are you making btw?

do you mean my feature for teeworlds or my last server mod?

17:09

teeworlds feature: You can go out of chat with mouse1/mouse2, things you wrote won't be deleted

17:10

I am just waiting for a response for @Oy, since you could do some visual stuff, too

17:12

@Dune: would a flag for home hosted vs real hosted servers be usefull?

I think most of the servers are hosted anyway

yeah, almost all of them I think

17:13

I don't think that would be too useful (and you would need admins to set that)

Assa: what's the question?

how to do the "don't drop the chat line" feature

17:20

should it be bare-bones, or should it leave the chat message grayed out like on bnet: https://puu.sh/DmrOF/6d2e419be3.jpg

https://github.com/teeworlds/teeworlds/pull/2123

Added chat buffer, now memorizes chat by AssassinTee · Pull Reque...

Chat is memorized, until you send it. If you switch to another chat-mode, the buffer will be cleared

@Dune @Oy I think a visual touch would be very nice for the chat feature

Assa: ooh, cool idea :)

Assa: what kinda visual touch?

what heinrich mentioned

always show that?

yeah, when there is a message that was "soft cancelled"

18:18

can put a 30s timer or something on it

18:18

basically lower alpha

18:18

gj, Assa, that was fast :)

I think we really should do a "soft chat render" when a message is "soft cancelled"

18:20

with lower alpha, no history and stuff

18:20

A Timer sounds good, too ^^

probably not the whole text

you want to truncate the text that was being typed?

I think Oy just want the truncated stuff to be displayed, like "This is a very very long sentence" to "This is a ..."

by the way there is a crash when you cancel a map download and rejoin the server, but very strangely the steps to reproduce it only work when I'm not using my debugger, so I can't trace anything :(

well you can write more than one line, lots of blocking

18:23

it's just a remonder that there'SÂ´s still a message to finish

^.^

18:23

I will play with it

yeah

18:24

blocks a lot

18:24

or maybe just show the chat image?

this is true ^^

Can add ... and truncate. I think it's fine either way (it should be a temporary interruption, you don't play a match liek that)

with the last pr is it still possible to cancel chat with escape?

should be

18:25

right Assa?

yeah

18:25

just doesn't cancel on mouse1/2

18:25

and map change

(mouse1/2 didn't do anything before)

i am not sure about mapchange

18:25

did you test that?

code looks that way

okay

lemme pull again

if OnStateChange is called, it will be lost on map change

just changes to state_loading

18:27

and then ingame again

18:27

Dune: so it happens just in release?

if state_loading <= STATE::CONNECTING, then it will be cleared

yeah

mapchange keeps chat for m

18:28

mapchange keeps chat for me

nice

Dune: was that a map using the new sha256 hash?

wtf is that render function in chat

not sure

18:35

I think not, the server said 0.7.2

18:35

TeeSlayer, your 0.7.2 ddrace servers didn't cherry pick anything after 0.7.3 right

i have a bug, i find servers under Local servers, that aren't in my lan

your neighbors host teeworlds :D

18:38

you can see their IP and check that it isn't yours?

when I find 10+ servers, yes

that sounds hard to reproduce

i spawned my own local server, and everything seems normal now

clicking on those servers sent you to your local serverN

18:39

?

I managed to reproduce it

18:39

br_max_request 1

18:39

Refresh gloab

18:40

switch to Local

18:40

spam refresh

18:40

it says -7300% loaded

18:42

reproduced on windows, too

18:42

with my steam client

18:42

it only seems to happen with br_max_request 1, not with 25

Dune: can you reproduce it all the time?

yes but not never with the debugger Oy

19:37

and never on linux

Dune: so not on the debug version?

19:38

32bit and win?

same binaries

19:43

64 bit debug windows, Oy

About Assa bug. I saw that several times, but it's gone after refresh for me

should open an issue even if we can't reproduce, so we remember

Dune: add the debugger to it after the crash

19:44

open visual studion. attach to process -> pick teeworld.exe

I don't know how to do that, I don't have visual studio :/

19:44

need to install it I guess

ah ok

should we add an own ChatMode for "saving written text"?

that makes sense to me

19:53

but I'd be careful about that

19:54

there's gotta be a lot of places that check chatmode != CHAT_NONE

it would make sense, on the other hand the saved text has a status, too

19:54

when iam rendering it now, iam checking for chatmode == CHAT_NONE

19:54

and m_BufferChatMode != CHAT_NONE

why not

hm, why is the nethash not the one in src/game/generated/nethash.cpp?

hello

how do I end a programm of unix, when Strg C is not working

try ctrl-z and then enter "kill %1"

kill didn't work either

kill -KILL will probably work

i can only do it in the background

20:16

but then i can't find the process

know the process name?

teeworlds

is it in a debugger?

no

killall -KILL teeworlds

thank you ^.^^

20:17

how do I str_copy a bigger string in a smaller one (truncate the rest?

just use str_copy

20:18

it truncates

I wonder why my code crashes then

you gave the wrong size to str_copy?

20:27

if you ever wonder why the code crashes, look at the trace?

char text[29]; str_copy(text, input, sizeof(text));

20:28

the thing is, it is not crashing, it is running into an endless loop

that's weird

20:28

doesn't sound like an issue with str_copy

it crashes exactly, when input is bigger then text

so it crashes, not loop?

it loops

so you don't see a crash (on linux?)

20:31

it just stalls

yes

20:32

client freezes

well gotta figure what loop loops indefinitely cause that's probably not in str_copy

20:33

or is it?

I am just failing to truncate a string ... feels bad

break/dump the client when it freezes?

I found it: it failed later in TextEx

20:41

and was running and endless loop there oO

break and open a debugger to look at what's going on

yeah, just attach gdb or start via gdb

the string I entered was shorter then the length I was giving in the function

20:48

so try TextEx(&Cursor, "test", 42)

well it was reading some random memory stuff, that can't go too well :)

https://i.imgur.com/Jm2HnBN.png

21:09

take a look at the chat ;)

+1 :)

I think it's too dark

21:20

what does it give for other chat modes?

21:20

changing the alpha only might be better

21:22

I would replace the CHAT/TEAMCHAT/WHISPER thing with the keybind, following the pattern of the callvote

21:22

the original screenshot from the idea suggestion says "Press Enter to resume chatting"

it is not finished yet

21:33

i wanted to replace the CHAT/TEAMCHT/WHISPER with the corresponding button, but i don't know how to get button names yet

check out how it's done with votes

21:57

3 images ^.^

going to sleep, gn8

nite