Teeworlds - bridge

[quakenet] <Devile> How to play teewrolds 7.2 on freebsd?

[quakenet] <verdre> Hi everyone, any devs in here?

16:15

[quakenet] <Dune> hi verdre

16:15

[quakenet] <Dune> most are asleep

16:15

[quakenet] <Dune> it's IRC, just ask your question :)

16:16

[quakenet] <verdre> Hi Dune :)

16:17

[quakenet] <verdre> I'm checking in from the gnome community, we found that Teeworlds has a pretty weird behaviour with its window

16:17

[quakenet] <Dune> does it? it uses SDL2

16:17

[quakenet] <verdre> It always uses an override redirect window

16:18

[quakenet] <verdre> Which is a pretty bad idea for general windows

16:19

[quakenet] <verdre> This makes the shell unable to display any popups or important dialogs above the window

16:20

[quakenet] <Dune> that might be somewhere around here https://github.com/teeworlds/teeworlds/blob/f0ebc6272bd64dc0dced77c7e2ad78553f106d20/src/engine/client/backend_sdl.cpp#L674-L704

teeworlds/teeworlds

A retro multiplayer shooter. Contribute to teeworlds/teeworlds development by creating an account on GitHub.

16:21

[quakenet] <Dune> hmm, I'm not really competent to comment on that

16:21

[quakenet] <Dune> pokes Oy

16:22

[quakenet] <verdre> Thanks, it's probably an sdl bug if teeworlds doesn't do more to initialize the window

16:22

[quakenet] <verdre> I'll try out another SDL based game

16:22

[quakenet] <Oy> hm, maybe there's a sdl hint that could help here

16:26

[quakenet] <Oy> doesn't seem that way

16:26

[quakenet] <verdre> Maybe SDL_WINDOW_ALWAYS_ON_TOP?

16:28

[quakenet] <verdre> Ahh, it's the borderless hint: https://github.com/spurious/SDL-mirror/blob/master/src/video/windows/SDL_windowswindow.c#L77

spurious/SDL-mirror

An unofficial, automated SDL2 and SDL1.2 HG mirror. - spurious/SDL-mirror

16:32

[quakenet] <Oy> we don't use SDL_WINDOW_ALWAYS_ON_TOP

16:32

[quakenet] <verdre> Hmm, that file was the code for windows

16:34

[quakenet] <verdre> Ahh, here's the problem, it always uses override_redirect if it's a fullscreen window:https://github.com/spurious/SDL-mirror/blob/master/src/video/x11/SDL_x11window.c#L1260

spurious/SDL-mirror

An unofficial, automated SDL2 and SDL1.2 HG mirror. - spurious/SDL-mirror

16:36

[quakenet] <Oy> :(

16:36

[quakenet] <Dune> so all SDL applications have that issue? huh

16:37

[quakenet] <verdre> I just downloaded tried out TRINE, and it doesn't have the bug

16:37

[quakenet] <verdre> might be because it uses the wayland window: https://github.com/spurious/SDL-mirror/blob/master/src/video/wayland/SDL_waylandwindow.c

spurious/SDL-mirror

An unofficial, automated SDL2 and SDL1.2 HG mirror. - spurious/SDL-mirror

16:38

[quakenet] <verdre> You can easily reproduce the bug by pressing Alt+F2 while you're in the game (with GNOME at least)

16:39

[quakenet] <Dune> alt+f2 works for me in fullscreen

16:40

[quakenet] <verdre> Does it show the dialog?

16:40

[quakenet] <Dune> yes

16:41

[quakenet] <verdre> That's interesting, X11 or Wayland session?

16:41

[quakenet] <Dune> huh, should be X11 (linux mint)

16:41

[quakenet] <verdre> Not sure you're using GNOME when you have Mint

16:41

[quakenet] <Dune> but alt+f2 works somehow

16:42

[quakenet] <verdre> Yeah, there's a possible workaround for this which we discussed earlier today, that workaround would be quite a hack though and might add other bugs

16:43

[quakenet] <verdre> We agreed that it's better to fix the applications since there seems to be such a small amount of apps behaving like this

16:43

[quakenet] <Dune> ah, I see. didn't imagine there'd be a workaround

16:45

[quakenet] <verdre> Workaround would be checking if any override redirect windows occupy the whole screen, and then set the monitors fullscreen state

16:45

[quakenet] <verdre> The problem is that the window manager shouldn't care about override redirect windows at all

16:49

[quakenet] <Dune> not sure if there is a workaround for Teeworlds then

[quakenet] <verdre> Found a 10-year old bug in libsdl about this: https://bugzilla.libsdl.org/show_bug.cgi?id=515

17:04

[quakenet] <Dune> almost as old as Teeworlds :)

17:04

[quakenet] <Oy> :)

17:04

[quakenet] <Oy> too bad they didn't fix it yet

17:04

[quakenet] <Oy> if they would add some flag/hint we would add it

17:05

[quakenet] <verdre> I'm kind of expecting them to answer they'd gladly merge a patch... :)

17:06

[quakenet] <Dune> we should use this line more in our issue tracker :D

17:06

[quakenet] <Oy> :)

17:06

[quakenet] <Oy> https://github.com/spurious/SDL-mirror/blob/master/include/SDL_hints.h#L578

spurious/SDL-mirror

An unofficial, automated SDL2 and SDL1.2 HG mirror. - spurious/SDL-mirror

[quakenet] <verdre> Oy: What's that hint about?

17:23

[quakenet] <verdre> Seems like sdl only sets the override redirect flag when using the legacy path, which it shouldn't

[quakenet] <verdre> Oy: Could you try finding out why the flag is set? I'm starting to think it's a teeworlds issue after all...

17:36

[quakenet] <Dune> good question, why is it legacy

17:36

[quakenet] <Dune> https://github.com/spurious/SDL-mirror/blob/2d3b9ae6a6eac425fcd24c1f46c2033d66e1d6c6/src/video/x11/SDL_x11window.c#L1384-L1387

spurious/SDL-mirror

An unofficial, automated SDL2 and SDL1.2 HG mirror. - spurious/SDL-mirror

17:37

[quakenet] <Oy> sets it during creation too https://github.com/spurious/SDL-mirror/blob/master/src/video/x11/SDL_x11window.c#L514

spurious/SDL-mirror

An unofficial, automated SDL2 and SDL1.2 HG mirror. - spurious/SDL-mirror

17:37

[quakenet] <Oy> verdre: what flag?

17:39

[quakenet] <Dune> https://forums.libsdl.org/viewtopic.php?p=34362

17:39

[quakenet] <Dune> "The legacy fullscreen support is used if the window manager doesn't support the _NET_WM protocol, the XVidTune extension is enabled, or the SDL_VIDEO_X11_LEGACY_FULLSCREEN environment variable is set to 1. "

17:42

[quakenet] <verdre> Oy: The override redirect flag :)

17:43

[quakenet] <verdre> Dune: We do support the protocol, but no idea what xvidtune is

17:44

[quakenet] <verdre> Let me check if the flag is set somewhere in my package

17:46

[quakenet] <verdre> Nope, can't find the environment variable

17:46

[quakenet] <Oy> sdl always sets the override flag when creating a x11 window

17:47

[quakenet] <Dune> where do you see that?

17:48

[quakenet] <Dune> ah, the previous link

17:48

[quakenet] <Dune> is that for non-fullscreen windows only?

17:48

[quakenet] <Dune> I'm not sure if that means it always sets the flag

17:52

[quakenet] <Oy> yeah, looks like always

17:53

[quakenet] <Dune> it sends a &xattr parameter that is set there: https://github.com/spurious/SDL-mirror/blob/2d3b9ae6a6eac425fcd24c1f46c2033d66e1d6c6/src/video/x11/SDL_x11window.c#L428

spurious/SDL-mirror

An unofficial, automated SDL2 and SDL1.2 HG mirror. - spurious/SDL-mirror

17:53

[quakenet] <verdre> Oy: Right, that looks like always

17:53

[quakenet] <Dune> does it?

17:54

[quakenet] <Dune> this line would be useless if it was the case (?)

17:54

[quakenet] <verdre> https://tronche.com/gui/x/xlib/window/XCreateWindow.html

17:54

[quakenet] <Dune> it's a mask

17:54

[quakenet] <verdre> > attributes Specifies the structure from which the values (as specified by the value mask) are to be taken

17:54

[quakenet] <verdre> > valuemask Specifies which window attributes are defined in the attributes argument.

17:55

[quakenet] <Dune> so it's not always, right?

17:55

[quakenet] <verdre> yeah

17:55

[quakenet] <Dune> it depends on xatt.override_redirect, which is ((window->flags & SDL_WINDOW_TOOLTIP) || (window->flags & SDL_WINDOW_POPUP_MENU))

17:56

[quakenet] <Dune> verdre: I might be missing something obvious, but is alt+f2 broken in windowed mode as well?

17:57

[quakenet] <verdre> Dune: no, in the windowed mode the window doesn't use the flag

[quakenet] <Oy> both aren't set

18:11

[quakenet] <Oy> so just the legacy one then

18:15

[quakenet] <verdre> Oy: So teeworlds must be using the legacy path, right?

18:17

[quakenet] <Oy> verdre: it's not specified by teeworlds, can't do sth there. sdl uses what it's supported by the user

18:20

[quakenet] <verdre> Hmm, could you guys try reproducing the issue on a distro with gnome?

[quakenet] <Dune> I don't have any :|

18:30

[quakenet] <verdre> Dune: Time to try it out then :D

18:31

[quakenet] <Dune> what is the end goal?

18:32

[quakenet] <verdre> Finding out if my setup is the problem and causes sdl to set this flag

18:32

[quakenet] <verdre> I'm pretty sure that's not the case though

18:34

[quakenet] <Dune> well one of these if must be true, right? https://github.com/spurious/SDL-mirror/blob/2d3b9ae6a6eac425fcd24c1f46c2033d66e1d6c6/src/video/x11/SDL_x11window.c#L1390-L1394

spurious/SDL-mirror

An unofficial, automated SDL2 and SDL1.2 HG mirror. - spurious/SDL-mirror

18:37

[quakenet] <verdre> well, that's not the case though

18:43

[quakenet] <Oy> hm

18:45

[quakenet] <Oy> always the case https://github.com/spurious/SDL-mirror/blob/master/include/SDL_hints.h#L174

spurious/SDL-mirror

An unofficial, automated SDL2 and SDL1.2 HG mirror. - spurious/SDL-mirror

18:47

[quakenet] <verdre> it should check if the mode is actually available later: https://github.com/spurious/SDL-mirror/blob/17af4584cb28cdb3c2feba17e7d989a806007d9f/src/video/x11/SDL_x11modes.c#L507

spurious/SDL-mirror

An unofficial, automated SDL2 and SDL1.2 HG mirror. - spurious/SDL-mirror

[quakenet] <Oy> yeah, if it is u end up with a legacy window

[quakenet] <verdre> well, xvidmode has been replaced with xrandr a long time ago, check this out: https://i.imgur.com/Spb8pO4.png

[quakenet] <minus> shit, an original X11 GUI

19:39

[quakenet] <Dune> damn