Teeworlds - development

Shame. Makes my awful code at least a bit readable :/

Programming is communicating with other humans, not just the machine

Hmm, that makes me thinking what you really mean.

09:37

If I think my piece of code is a horrible mess, maybe I should better ask for help?

09:37

Or that readability for humans should always have top priority, even over readability for the machine.

09:37

The latter

09:38

"Readability for the machine" is not a thing

09:38

It compiles or it doesn't

Or it compiles bot does something really different, because str_format executes from right to left.

09:39

It is never black or white

Then it's wrong. No readability gradient. It is black and white

09:40

Writing code that is very difficult to understand is not a masterpiece, even though it may feel like one at times

Keeping code SOLID, easy to maintain and readable is hard af.

It is, yeah

Especially, when people dont use and understand SOLID (edited)

Even communicating with yourself is a challenge:D

Using oop (edited)

You can make solid in oop and non-oop

Solid is oop thing

09:45

Was written with oop in mind at least (edited)

09:47

I think only "S", can be used like everywhere. Even in life haha

09:48

"Single responsibility". For a funcition, class

Then I misunderstood:)

Rest are oop stufd

09:48

Like interfaces, dependecy inversion (edited)

09:51

https://en.m.wikipedia.org/wiki/SOLID

SOLID

In object-oriented computer programming, SOLID is a mnemonic acronym for five design principles intended to make software designs more understandable, flexible and maintainable. It is not related to the GRASP software design principles. The principles are a subset of many pri...

09:51

You can check concepts. One is especially hard (edited)

If anyone finds some time, I could need some C++ help with my awful code.

09:54

But it is a mod. (if that matters) (edited)

Just in case: This is the commit with the code I was talking about: https://github.com/teeworlds-domination/domination/commit/5645feb340ca13299d9fdab39cc28c43d7bc3000#diff-a44b0d5a4865a805e58e1a15b75532a8R328 And this is kind of the entry point: https://github.com/teeworlds-domination/domination/blob/5645feb340ca13299d9fdab39cc28c43d7bc3000/src/game/server/gamemodes/dom.cpp#L328-L335 (edited)

Add broadcast overview capture process animation (see #12) · teew...

teeworlds-domination/domination

Domination mod for Teeworlds, a retro multiplayer shooter - teeworlds-domination/domination

snprintf? Prefer functions from src/base/system.h in teeworlds

10:45

You linked the same thing twice btw (?)

?

10:46

The former is the commit, the latter some lines of it.

10:48

I couldn't find any equivalent function for snprintf in src/base/system.h

10:49

The closest would be str_format

yeah

10:50

str_format does not suit you?

With some refactoring it should.

10:52

Wouldn't make things easier, though.

10:56

Actually, my biggest problem is the concatenation of 'broadcast color code' plus character.

10:56

Like: ^900 + "C"

10:56

I don't know a proper way without sacrificing too much performance. Therefore, I went with preprocessor macros.

10:58

But iirc from my study they should be avoided whenever possible...

preprocessor macros

There must be a better way to do this: return BCOLOR_RED "{";

the question is: is the performance loss singificant?

Well, if it would be str_format about 25x per tick, then I guess so.

I don't think that's important at all

At least it would look very stupid to me.

You can define colors as const char*?

11:00

high level programming languages do a lot of more impactful stupid things

11:00

if you'd be coding in java or python this would probably be done on a hidden level anyway

Hmmm

I mean, sure you can use an enum for colors and concatenate them with spaces if you want - as long as it's readable, it's your choice

So, I should better use 25 str_format instead of fixed strings? If the performance impact is negligible, then it could make the code indeed more readable...

I make static analysers for a living, and as soon as I include a printf, the complexity of the program absurdly explodes

When you do printing stuff, you can generally forget about tiny optimizations

11:08

Now 25 str_format in a function looks a bit ugly, it's strange that you have to resort to that

5 spots with 6 variable strings each. My bad, it is 30. (edited)

11:10

Couldn't think of a better way

I still don't see why you would need so many calls :/

Well, maybe I just missed any great alternative.

11:11

But basically, this is one spot: %s%s%s%s%c%s%s%s

11:11

With each %s being one marker, except the %s%c being the ^900 C

I think enum is not handled by the preprocessor btw

And each %s itself gets replaced by %s%s (color + char)

str_format(str, sizeof(str), "%s%s%s%s%c%s%s%s", ...) ?

This is pretty much the line i posted at the beginning.

so you don't need 20 calls or god knows how many

Why not?

11:13

            TextLen += snprintf(aBuf + TextLen, sizeof(aBuf), "%s%s%s%s%c%s%s%s "
                    , GetBroadcastOpen(i, MarkerPos) // Opening Parenthesis
                    , GetBroadcastLine(i, MarkerPos)
                    , GetBroadcastLine(i, MarkerPos)
                    , GetTeamBroadcastColor(m_apDominationSpots[i]->GetTeam()), GetSpotName(i)[0]
                    , GetBroadcastLine(i, MarkerPos)
                    , GetBroadcastLine(i, MarkerPos)
                    , GetBroadcastClose(i, MarkerPos)); // Closing Parenthesis

11:13

With GetBroadcastOpen(i, MarkerPos) and GetBroadcastLine(i, MarkerPos) returning a concatenated string itself.

str_format(str, sizeof(str), "%s%s%s%s%c%s%s%s",
  Colorize(...),
  Colorize(...),
  Colorize(...)
);

11:14

like that?

Pretty much

that's not 20 calls to str_format

but how would colorize work then?

11:14

If it wouldn't use str_format

I don't know how your coloring mechanics work?

11:15

maybe you'd need to, yes

Color: "^900" | "^009" | "^999" Char: < | > | - | { | ( | [ | } | ) | ]

11:16

Always picking one of both sets

11:16

And concatenating them.

o.O

const char* colors[];
str_concat(colors[i], char)

11:16

but that looks readable, it's not 20 calls straight up in a function, so as far as I'm concerned I don't really care if Colorize takes 20 cycles or 500 :D

11:17

I really think it doesn't matter at all

it's not 3D rendering, right

11:17

xD

src/base/system.c doesn't implement str_concat?

huh

11:17

str_cat maybe?

negative.

11:18

str_append maybe

meh just use format :D

11:19

you'd need a buffer anyway, that example code is silly

11:20

iirc teeworlds rendering renders everything twice to eval the size of the text

Well, at least I could reuse the buffer. All colorized chars are 4 chars long.

you don't need to worry so much about str_format calls

11:20

dev time is precious :p machine time isn't

IMO, just make good abstraction for colorizing your text

11:21

and you'll be fine

11:21

^.^

?

dune's

str_format(str, sizeof(str), "%s%s%s%s%c%s%s%s",
  Colorize(...),
  Colorize(...),
  Colorize(...)
);

Colorize() is called abstraction

11:22

actually, generaly functions. It's abstract, anywya

11:22

good, readable functions. You shouldn't care much about performance at first

They don't lack too much readability. Except the preprocessor macro usage could be troublesome.

11:24

They are just hilarious explicit

i don't know, GetBroadcastLine that thing look scary to me (edited)

11:24

and don't know what it does at first

okok, GetColorizedLine would suit better

11:25

But that is just wording.

wording is important

11:25

but if it's your own mod, without contributors. then it's fine

11:25

if you understand

Ye, but it is 1 word that includes 50 more lines for now

11:26

Don't worry, I will PR it once done

iirc, better not use preprocessor macros in C++, you will almost never need them. enum works

Thank you Dune. Really appreciate it!

15:41

I wonder if there should be some restrictions on eyes colors

15:41

like half custom half black?

Uh, Dune, it is not default eyes

17:31

I used zombies' eyes (edited)

17:32

They were yellow by default

are they?

Dominant's, iirc

not sure how skins work

17:33

aren't the eyes black in the data/skins?

Yes, but those are modified

17:33

Vheck yourself, you have these too

so that means you cannot chang e the color of the default eyes, but can change yellow eyes to anything?

I think so yeah

17:35

I didnt try tho, i only used custom eyes i downloaded for ZOMB gamemode

17:35

But i am pretty sure u cannot change color of default eyes

yeah if you slide the cursor only the custom eyes change

ChillerDragon

[teeworlds/teeworlds] Pull request opened: #1949 Remove space xd