DDraceNetwork - developer

why dont the servers use cloudflare or something for ddos protectsons

<ChillerDragon> @Learath2 have you thought of using cloudflare to fix ddos?

00:17

<ChillerDragon> @Learath2 omg new discord names

ws-client

<ChillerDragon> @Learath2 have you thought of using cloudflare to fix ddos?

after like 7 years?

00:53

As if handling traffic was the only problem with it

can someone explain to me why this happens?

00:54

very confused lol

I mean, the error is kind of nudging you to the #include line

00:56

shocker huh

yes i can tell, but i am at a loss for what the issue is, no need to be rude.

rainonwires

yes i can tell, but i am at a loss for what the issue is, no need to be rude.

install clang-format 10 and run ./scripts/fix-style.py

2

Solly

install clang-format 10 and run ./scripts/fix-style.py

appreciate it

have anyone built on mac silicon?

03:04

i think the cmake is a bit wrong

03:07

currently bundled ffmpeg libraries is not used even when no system installation is found

03:12

cmake is so cursed

i now think mac is more cursed

i built.on mac

03:29

uae brew

03:29

use

03:29

to install depa

03:29

deps

03:30

@Pioooooo maybe u need to enable videorecorder for ffmpeg

03:30

i forgor

i changed some cmake script of findffmpeg to use the bundled

03:31

currently the problem is about include dirs

message.txt

2.74 KB

03:41

if i remove the -isystem /Library/Developer/CommandLineTools/SDKs/MacOSX13.sdk/usr/include in the build option it could build

03:41

but i don't know why cmake generated this

03:42

and why it should cause the error...

03:44

it's for curl tho

#  target_include_directories(${target} SYSTEM PRIVATE ${CURL_INCLUDE_DIRS} ${SQLite3_INCLUDE_DIRS} ${ZLIB_INCLUDE_DIRS})

04:28

commented this line and I'm good now

04:29

i dont like it

04:29

2

1

heinrich5991

[ddnet/ddnet] Pull request opened: #9817 Rename LEGACY_MAX_CLIENTS to SERVER_MAX_CLIENTS

LEGACY doesn't tell me about its use. Use 64 explicitly in TEAM_SUPER because it's a protocol invariant and not likely going to change if SERVER_MAX_CLIENTS changes.

Checklist

[ ] Tested the change ingame
[ ] Provided screenshots if it is a visual change
[ ] Tested in combination with possibly related configuration options
[ ] Written a unit test (especially base/) or added coverage to integration test
[ ] Considered possible null pointers and out of bounds arr...

09:17

heinrich5991

[ddnet/ddnet] Pull request closed: #9745 Remove inaccurate copyright notices

heinrich5991

[ddnet/ddnet] Issue opened: #9818 Add an option to disable counting towards view counts

This should be communicated to the server. You'd probably not get a view counter yourself then, like "read notifications" in messengers. I don't like that this feature has shipped without even an opt-out. Perhaps it should be opt-in instead.

heinrich5991

[ddnet/ddnet] Pull request opened: #9819 Sort .clang-tidy

Checklist

[ ] Tested the change ingame
[ ] Provided screenshots if it is a visual change
[ ] Tested in combination with possibly related configuration options
[ ] Written a unit test (especially base/) or added coverage to integration test
[ ] Considered possible null pointers and out of bounds array indexing
[ ] Changed no physics that affect existing maps
[ ] Tested the change with [ASan+UBSan or valgrind's memcheck](https://github.com/ddnet/ddnet/#using-addresssan...

heinrich5991

[ddnet/ddnet] Pull request opened: #9820 Add a comment explaining that game type sniffing should not be extended

It's brittle and a never-ending maintenance overhead.

Checklist

[ ] Tested the change ingame
[ ] Provided screenshots if it is a visual change
[ ] Tested in combination with possibly related configuration options
[ ] Written a unit test (especially base/) or added coverage to integration test
[ ] Considered possible null pointers and out of bounds array indexing
[ ] Changed no physics that affect existing maps
[ ] Tested the change with [ASan+UBSan or valgrind's m...

when do we deploy the fix

11:19

they are cheesing every teaming map

11:20

and save before finish to avoid getting deranked

11:22

this is the worst day to play since i start playing ddnet...

Atleast it seems detectable with some teehistorian parsing

okay

11:23

just make sure also check saves i think

11:23

but guess i cant find a game to play today :/

Idk how this happened practice was disabled, it shouldnt have gotten reenabled without the fix being deployed

11:27

I'll take a look when I can sit down

well i think that's not the case

yea practice has been reenabled

11:45

for some reason

11:47

@Robyt3

Learath2

Idk how this happened practice was disabled, it shouldnt have gotten reenabled without the fix being deployed

are you running some config managers?

11:49

This is how I run into issues like this at work ;_;

Assa

are you running some config managers?

Nope

Learath2

Idk how this happened practice was disabled, it shouldnt have gotten reenabled without the fix being deployed

it also seems like all chn servers whitelist was gone. most newtwcn servers is not registered either.

11:54

did you guys have some rollback issues

Very curious. I wonder what happened again

you did fixed ddnet chn's manually before

11:55

might just be the same thing

11:55

DDNet CHN is fine currently

11:55

i believe newtwcn servers like gores and fng was also whitelisted on request by deen before

11:56

just saying this practice thing seems very sus and might be related to the whilelist thing to me

11:56

like rolling back a really really old config or something

TsPiggy

you did fixed ddnet chn's manually before

But nothing should ever be replacing that masterserver config file automatically

fair

11:57

obviously i can't really tell for sure.

Why would they get unwhitelisted?? Did the ips change again somehow?

i doubt every chn servers would just suddenly change ip

https://github.com/ddnet/ddnet/pull/9805 i still don't get answer here

Fix #9587 by StormAxs · Pull Request #9805 · ddnet/ddnet

The problem when are you playing vanilla/fng or any other gamemode with team the camera button overlap the "record demo button" Checklist Tested the change ingame Provided scr...

I'm only entertaining this insanity because it happened once before

Learath2

I'm only entertaining this insanity because it happened once before

when

like yea the solution might be dumb but at least take a look:D

TsPiggy

when

The time I had to rewhitelist almost every cn server a couple days ago?

Learath2

The time I had to rewhitelist almost every cn server a couple days ago?

nah, i'm pretty sure our ip didn't change at least on our end

11:59

and ddnet chn is still fine since you rewhitelisted them

11:59

i'm saying the non ddnet servers

11:59

has the same issue

11:59

we just didn't fix them

11:59

plus you probably don't have their ips on hand anyway

Aah

12:00

If you gimme ips I can get them whitelisted when I sit down

well

12:01

i don't have them either

12:01

they are just individually whitelisted on request between hosters and deen i believe

12:02

at least i personally don't keep track of the server IPs since i don't manage them

Well lmk as people start complaining and I can check

well they are complaining

12:03

else i wouldn't know

12:03

you know, i don't really open the game

12:03

TsPiggy

well they are complaining

I mean when the hosters are complaining

i guess

If it's a whitelisting issue they will start seeing a spam of check your firewall messages

chn hosters are notorious for just complaining without filing any reports lol

12:05

nothing i can do about it probably.

12:05

well chn in general

12:06

but still, it does seem like weird that all whitelist were just gone. unless you are positive that ips are changed and have a list of the original IPs so we can compare (edited)

TsPiggy

but still, it does seem like weird that all whitelist were just gone. unless you are positive that ips are changed and have a list of the original IPs so we can compare (edited)

The config had all the old ips whitelisted

12:07

And the ones that were still the same as the ips from dns were registering fine

btw we chn did swap servers from 1 - 10 in the past year

12:08

so chn5 isn't chn5 from a year ago

I have a saner guess

12:08

Maybe the ips changed, no one updated the whitelist but it worked fine because the firewall was being lax

possible

12:09

sounds sane to me

Then it's not the ips that randomly changed by a mystery admin that didn't tell anyone

we can wait until April to see what happens to the non ddnet servers (edited)

But it's that the firewall decided it doesnt like our heartbeats

march is the chinese congress meeting so internet is indeed weird around these time

12:10

i just hope we don't just deploy the henan and fujian thing to the entire country

12:10

after the meeting

TsPiggy

i just hope we don't just deploy the henan and fujian thing to the entire country

what is that

Pioooooo

what is that

they are testing whitelisting instead of blacklisting as far as we can tell. obviously no one knows what it does

1

TsPiggy

they are testing whitelisting instead of blacklisting as far as we can tell. obviously no one knows what it does

Hope my proxy won't die or have price increased

12:34

I actually have thought they would lift the restrictions somehow

12:34

Illusions

hope I have less bots trying to hijack my homeserver, but I guess this direction is no problem

12:35

trying to find something positive there ...

hope my proxy doesn't have any issues, or else my happiness is gone. at least it works fine now kek

Pioooooo

Hope my proxy won't die or have price increased

mine already doesn't work as well during march

12:54

@Pioooooo @Zerol Acqua btw, in case you don't know, we log everything said here and they are not deletable.

12:54

12:55

and everything said here is publicly available on the internet and indexed by google

Yeah I know that

13:11

I don't care much

i think even we dont log chat, there are ways to know what we said lol

github-merge-queue[bot]

[ddnet:master] 2 new commits

0b1cf1b Sort .clang-tidy - heinrich5991 a1e9204 Merge pull request #9819 from heinrich5991/pr_ddnet_sort_clangtidy - def-

14:14

def-

[ddnet/ddnet] Pull request closed: #9819 Sort .clang-tidy

github-merge-queue[bot]

[ddnet:master] 2 new commits

1c403a0 Add a comment explaining that game type sniffing should not be extended - heinrich5991 652647e Merge pull request #9820 from heinrich5991/pr_ddnet_game_type_sniffing - def-

14:22

def-

[ddnet/ddnet] Pull request closed: #9820 Add a comment explaining that game type sniffing should not be extended

edg-l

[ddnet/ddnet] Pull request closed: #9817 Rename LEGACY_MAX_CLIENTS to SERVER_MAX_CLIENTS

15:38

github-merge-queue[bot]

[ddnet:master] 3 new commits

0227b8f Revert "Use NUM_DDRACE_TEAMS instead" - heinrich5991 b63e144 Rename LEGACY_MAX_CLIENTS to SERVER_MAX_CLIENTS - heinrich5991 d71b7f8 Merge pull request #9817 from heinrich5991/pr_ddnet_server_max_clients - edg-l

Pioooooo

when do we deploy the fix

what was even wrong with practice?

15:42

oh i see

louis

what was even wrong with practice?

https://github.com/ddnet/ddnet/pull/9816

15:44

after fix was merged practice got reenabled

15:44

when it wasnt on servers yet xd

KebsCS

[ddnet/ddnet] Pull request opened: #9821 Add null movement setting

Adds null movement / null bind / rapid tap / snap tap / snappy tappy (many names for the same thing) When both direction keys are pressed at once, it will prioritize the one that was pressed last. This feature is already available in many newer keyboards. While it doesn’t provide a significant advantage over other players or automatically make you better, it can help deter people from downloading scripts or macros from the internet by including this functionality directly in the client ...

github-merge-queue[bot]

[ddnet:master] 2 new commits

f0e5721 Fix #9587 - StormAxs 4412243 Merge pull request #9805 from StormAxs/master - Robyt3

16:38

Robyt3

[ddnet/ddnet] Pull request closed: #9805 fix camera button overlap the "record demo button" in vanilla

16:38

Robyt3

[ddnet/ddnet] Issue closed: #9587 New camera icon overlaps in small resolutions on team servers

<ChillerDragon> demo files dont contain rcon passwords do they? because i did not find the code that hides it

demo writes everything afaik, should check deeper tho

16:41

nice question chiller

Messages should only be recorded when MSGFLAG_RECORD is set on the client side, which is only used for tunings and sounds AFAICT. On the server side both MSGFLAG_NORECORD and MSGFLAG_RECORD are mixed with different functions though

anyone here ever do websockets in async rust? tokio-tungstenite seems most popular but fastwebsockets seems faster & a little more explicit?

18:04

wondering about the ups and downs of either

you basically said it yourself tokio-tungstenite has the advantage of good docs and a lot of people using it fastwebsockets is a little on the newer site but would be my pick in that regard

@kebs I like snappy tappy

18:28

rappy snappy tappy

murpi

rappy snappy tappy

imagine not having a razer huntsman v3 pro like a normal human being

18:32

what’s a good high polling rate mouse that’s also wireless

(it wasnt worth it, i should've gotten a ducky or smth)

meloƞ

imagine not having a razer huntsman v3 pro like a normal human being

i got steelseries pro tkl and dont use like half of the features

ive seen the logitech wireless charging mouse mats but idk if there are any mice with great sensors that support it

Ewan

what’s a good high polling rate mouse that’s also wireless

that one logitech one was awesome when i used it at a friends house

18:33

the Pro X something

meloƞ

imagine not having a razer huntsman v3 pro like a normal human being

I have 3 BlackWidow V3 Pros, one in use and two as backups, so I won’t be getting a new keyboard anytime soon

2 as backups

18:34

why on earth

18:34

murpi is a true keyboard warrior

18:35

lol

meloƞ

Click to see attachment 🖼️

why is this paced like a hollywood murder scene

meloƞ

why on earth

I got two for free and had to return one because of a strange double-tap issue. When I contacted Razer, they told me to just cut the wire (to make it unusable), and they'd send a replacement immediately. However, since the wire was simple to replace (the keyboard is wireless too xd) and I was able to fix the double-tap issue myself, I ended up with three

1

1

So based

had a similar thing at work "oh it doesnt work huh... can you send me an email that we fucked up packaging? we'll send you a new one"

18:48

it was a small thing and sending it back etc would've been a timewaste on both sides, fun interaction

M0REKZ

[ddnet/ddnet] Issue opened: #9822 Server-Provided Entities

In my server mod i have a extra custom entities layer where i add any kind of tiles i want (since i dont want to have conflicts with DDNet Tiles if a new tile is added), however that makes it impossible to see them in entities mode client-side unless you mod the client and provide a custom client only to be able to see those entities (which is not very nice). So i would like to be able to send the entities from Server for a specific layer (maybe by adding the file directly to the map) and th...

Ewan

what’s a good high polling rate mouse that’s also wireless

g pro superlight ? is what i use

19:31

no reason to have charging mat, it charges to full overnight and lasts like a month or more

nice

19:48

what sensor

19:49

i’m also okay with weight tbh i’d rather have back/fwd buttons than it be as lightweight as possible

i have the first version i think? with microusb charging :(

19:51

i lowkey might upgrade just for usb c, i really want my entire setup on usb c

sounds worth

just phone and mouse left

same actually

I had 2 G703s and then switched to g pro superlight, it's very nice

20:14

the best part for me was unexpected, the thumb side under the back/forward buttons is plastic instead of rubber so it doesn't wear away over time which was my main issue with the g703

20:16

and yeah the battery lasts forever, I charge it for like 1 hr every 2 weeks

KebsCS

[ddnet/ddnet] Pull request opened: #9823 Allow test map locally in subfolders

Fixes #9757

Checklist

[x] Tested the change ingame
[ ] Provided screenshots if it is a visual change
[ ] Tested in combination with possibly related configuration options
[ ] Written a unit test (especially base/) or added coverage to integration test
[ ] Considered possible null pointers and out of bounds array indexing
[ ] Changed no physics that affect existing maps
[ ] Tested the change with [ASan+UBSan or valgrind's memcheck](https://github.com/ddnet/ddnet/...

meloƞ

imagine not having a razer huntsman v3 pro like a normal human being

did you buy it for the snappy tappy?

always

did you buy it for the snappy tappy?

i broke my old keyboard because i raged a bit while playing minecraft

20:49

so i needed a new one

20:49

and idk, i shouldve gotten a different one tbh

btw 45.141.57.31:8334 has practice enabled (edited)

45.141.57.31:8334[

] is an official DDraceNetwork (Type: DDrace) server. Quick join: https://ddnet.org/connect-to/?addr=45.141.57.31:8334/ (edited)

meloƞ

i broke my old keyboard because i raged a bit while playing minecraft

how do u rage on minecraft??

magic

bro is pushing 90 and raging on minecraft gg

90kg on biceps curls

20:52

how much lateral raise

always

how much lateral raise

all

1

okay gymbro (edited)

wow its still finding new paths???

<ChillerDragon> @Robyt3 ah ye i know NORECORD i didnt know client side was opt in. Thats good!

who know how fix that?

Fix what

Solly

Fix what

this error appears when im trying to build client

That's not an error

21:24

That's a file path

Can you translate it to english

незакс solidарный

Click to see attachment 🖼️

consider downloading ddnet-libs or using git correctly with --recursive on clone

he cant open file

you have empty folder 'ddnet-libs' rn i suppose

zhn

consider downloading ddnet-libs or using git correctly with --recursive on clone

dont work, im tried

can you show directory structur

21:26

e

zhn

you have empty folder 'ddnet-libs' rn i suppose

Huh

consider cleaning build folder by visual studios popup window and rebuild again

21:28

seems it didn't try to copy it on second run

<ChillerDragon> Omg I am closing in 10 years of ddnet server side dev and I finally understand a crash i have been seeing multiple times over the years and always thought its undefined behavior!

21:28

<ChillerDragon> thats crazy

21:28

<ChillerDragon> @fokkonaut get this did you know

zhn

seems it didn't try to copy it on second run

I'll try it now

<ChillerDragon> assuming we are in the scope void CCharacter::Tick() is running this line of code safe? m_pPlayer->GetCharacter()->m_Health;

why would you... do it?

21:29

use it directly xd

<ChillerDragon> well this is to simplify the the problem

21:30

<ChillerDragon> when you call functions you can end up passing the character as a pointer

21:30

<ChillerDragon> but technically you are still in the character tick

character can be allocated but not alive and thus not being present in player's pointer i suppose

<ChillerDragon> yes!

im not sure since last time i visited that code was 2018 probably xd

<ChillerDragon> all this time i have been under the misconception that as long as you are in the character class or in a method that was called from within the character tick that the character pointer can not be null because you are inside of the instance!

gcc’s new lifetime checking &/ c++26’s erroneous behavior should help us with a lot of these lifetime/ptr related bugs, but ddnet never gets newest cpp

still the same mistake.

i remember some piece of code making character not alive but it didn't delete anything

<ChillerDragon> so my brain was always GetCharacter() big dangerous UNLESS you are called from character tick

21:31

<ChillerDragon> yes @zhn

21:31

<ChillerDragon> and the biggest troll is that GetCharacter() is not a simple getter

yep

<ChillerDragon> it is not implemented as GetCharacter() { return m_pCharacter; }

незакс solidарный

still the same mistake.

move to my dms pls and send a screenshot of your project tree structure

<ChillerDragon> IT RETURNS A NULLPTR if m_pCharacter is not alive xd

21:32

<ChillerDragon> i mean the idea is totally fair and i like the design and death during the characters tick is a tricky problem

21:32

<ChillerDragon> it just never was aware

21:33

<ChillerDragon> needs a big disclaimer somewhere xd

zhn

move to my dms pls and send a screenshot of your project tree structure

it’s not worth it

ws-client

<ChillerDragon> needs a big disclaimer somewhere xd

yea it’s good that it’s nullptr instead of a dangling pointer (is there such a thing? ptr to deleted memory) but really std::optional would save many asses

zhn

move to my dms pls and send a screenshot of your project tree structure

i send a screenshot

#when threads enabled in #developer and #general

no threads pls

21:36

so hard to keep track of

for things like this

21:36

theres 2 things going on at once

i think he said move to dms because the person above has a paid Minecraft client of some sort

21:37

or something i cant read in russian

~~das ddnet~~ (edited)

so the chances this is a dev with good intent are not good

Solly

~~das ddnet~~ (edited)

deen assisted speedrun

totes

ws-client

<ChillerDragon> assuming we are in the scope void CCharacter::Tick() is running this line of code safe? m_pPlayer->GetCharacter()->m_Health;

I think I've figured this, plus the IsAlive thing hahaha

a?

@jajek

github-merge-queue[bot]

[ddnet:master] 2 new commits

e802393 Allow test map locally in subfolders - KebsCS 60bb32a Merge pull request #9823 from KebsCS/pr-testmaplocally-subfolder - def-

22:12

def-

[ddnet/ddnet] Pull request closed: #9823 Allow test map locally in subfolders

22:12

def-

[ddnet/ddnet] Issue closed: #9757 Test map locally doesn't work with maps in subfolders

22:16

def-

[ddnet-web:master] 1 new commit

59d763a Update settings & commands - def-

Camper-CoolDie

[ddnet/ddnet] Issue opened: #9824 Client crashes when reconnecting keyboard

Disconnect the keyboard in-game and connect it back - segfault Details from gdb ``` (gdb) r Starting program: /home/operand/games/ddnet/build-debug/DDNet This GDB supports auto-downloading debuginfo from the following URLs: Enable debuginfod for this session? (y or [n]) Debuginfod has been disabled. To make this setting permanent, add 'set debuginfod enabled off' to .gdbinit. [Thread debugging using libthread_db enabled] Using host libthread_db library "/usr/lib/libthread_db.so.1". [...

i wonder if this caused by sdl3-compat

gerdoe-jr

[ddnet/ddnet] Pull request opened: #9825 Fix segfault on keyboard hot-plug

Checklist

[ ] Tested the change ingame
[ ] Provided screenshots if it is a visual change
[ ] Tested in combination with possibly related configuration options
[ ] Written a unit test (especially base/) or added coverage to integration test
[ ] Considered possible null pointers and out of bounds array indexing
[ ] Changed no physics that affect existing maps
[ ] Tested the change with [ASan+UBSan or valgrind's memcheck](https://github.com/ddnet/ddnet/#using-ad...