[ddnet/ddnet] Pull request opened: #9800 Ignore cursor movement when spectating others

Checklist

[x] Tested the change ingame
[ ] Provided screenshots if it is a visual change
[ ] Tested in combination with possibly related configuration options
[ ] Written a unit test (especially base/) or added coverage to integration test
[x] Considered possible null pointers and out of bounds array indexing
[x] Changed no physics that affect existing maps
[ ] Tested the change with [ASan+UBSan or valgrind's memcheck](https://github.com/ddnet/ddnet/#using-addresssan...

kebs

@TsPiggy this is your commit, do you remember why you added the fail safe? https://github.com/ddnet/ddnet/commit/500ba7609f065d0df7e313c6acce023b6b0315f7#diff-d76009083687ba43c59dc7bb2c7357457c999c2eb9d913967d598e913c6fd01fR69

the change is just to make sure the behavior is logically unchanged if m_Tuning is not set by any outsider. and the "fail safe" is basically what make the code behave identical to the original code.

00:23

it is made so client can override the tuning so yes the change was made for client only even tho it is in the shared code

00:24

if sometime later server start setting m_Tuning after this change then ye, it is completely useless. i didn't check whether server is doing that, but it probably wasn't doing that when that PR was made (edited)

Yea it works fine without it, I would like to remove tuning from world class since it's flawed

then do it i guess

00:25

and it is probably good that shared code won't rely on g_Config.m_ClDummy at all if you could make that happen too

00:25

not sure if it is related to what you are doing tho (edited)

This is exactly why I want to remove it, and it's also confusing because it's not world tuning but current player's

i mean it is just left over from adding dummy to begin with

Which this "world tuning" isn't used anywhere anyway

someone just doubled up everything

There's one in gameclieny

00:26

Yea I guess

remove world tuning is probably a good idea tho. i remember it being quite useless but i didn't dare to touch it back then

It's values are copied over from gameclient and the fail safe is the only place it's used rn that's why I asked

just double check on server i guess

@TsPiggy heyo can you help me out here? https://github.com/ddnet/ddnet/blame/aecae3f7e51c0a44e45fa94d62bccf8bbfc155f2/src/game/server/player.cpp#L535 this flag appears to be 1<<2, but thats the same as the flag PLAYERFLAG_CHATTING(?)

01:46

and those flags are checked right after each other, maybe my ide is just broke? ^^

https://github.com/ddnet/ddnet/blob/master/datasrc%2Fnetwork.py

ddnet/datasrc/network.py at master · ddnet/ddnet

DDraceNetwork, a free cooperative platformer game. Contribute to ddnet/ddnet development by creating an account on GitHub.

Pioooooo

https://github.com/ddnet/ddnet/blob/master/datasrc%2Fnetwork.py

is that an answer in some way? please elaborate

You can check this file, the flags belong to different fields

Patiga

@TsPiggy heyo can you help me out here? https://github.com/ddnet/ddnet/blame/aecae3f7e51c0a44e45fa94d62bccf8bbfc155f2/src/game/server/player.cpp#L535 this flag appears to be 1<<2, but thats the same as the flag PLAYERFLAG_CHATTING(?)

?

hrmpf my ide is broke I suppose :c

01:56

or the generator broke

01:56

this is part of the code gen

01:56

are you sure your code gen ran properly

Pioooooo

You can check this file, the flags belong to different fields

that wouldn't make much of a difference here

01:56

ig not :/

can you check src/game/generated/protocol.h

well the ide is kinda arguing with itself, saying "well this value doesn't exist" and "btw this value is 4" at the same time xd

01:57

will do

Patiga

well the ide is kinda arguing with itself, saying "well this value doesn't exist" and "btw this value is 4" at the same time xd

might just be you haven't ran the code gen since you pulled yet, since it only run on build, so it doesn't exist. ~~and your IDE is invaded by AI and hallucinated~~

TsPiggy

can you check src/game/generated/protocol.h

huh I don't have that file

then you haven't built yet

01:59

just build it once

01:59

i think

wait I do have it, I didn't look in the build idr

02:00

*dir

ah

its not in there tho

I'll rebuild and check again

have you built

02:00

python error?

02:00

maybe

building

02:02

got it

02:02

what happened before then

weird, I thought I built the client just yesterday

weird

02:03

maybe the we all had AI in us now and we hallucinated memory

1

maybe its also tired Patiga who's weird here pepeW

hey, i'm using vscode on ubuntu with cmake and the c++ extension to debug the map editor. i set some breakpoints, and when one got hit, the game froze. now i want to check the variable info in vscode, but my mouse is stuck too. anyone know how to fix this or any other ways to handle it?

@TsPiggy btw how severe is that CAM commit for input handling?

Patiga

@TsPiggy btw how severe is that CAM commit for input handling?

wdym severe

like, in which cases does it handle input differently to before?

the handling is unaffected.

02:06

nothing changed client side afaik

but server side

then ye, when you unpause it might take sometime for server to start processing input

like, I reimplemented your commit like 3 weeks ago (and did the flag correctly

)

but if it start process early the input are wrong anyway

ah, so it should only affect the end of the pause, not the start of it?

i can't remember

02:08

maybe not?