DDraceNetwork - developer

DDraceNetwork

Development / developer

Development discussion. Logged to https://ddnet.org/irclogs/ Connected with DDNet's IRC channel, Matrix room and GitHub repositories — IRC: #ddnet on Quakenet | Matrix: #ddnet-developer:matrix.org GitHub: https://github.com/ddnet

Between 2025-02-28 00:00 and 2025-03-01 00:00

the game doesnt think so

Image attachment

Patiga

If you got time on your hands, you could alo try to find maps that can crash the library twmap https://gitlab.com/Patiga/twmap. It's in Rust and in general tries to catch all errors and not crash happy

happy

(edited)

does this count as a crash?

I made a fork of ddnet with some features I like n stuff, but for some reason the build workflow is failing. anyone know why it's happening? https://github.com/art0007i/ddnet/actions/runs/13579490208/job/37962767436 it says something about -Wno-error-dev but I have no idea where to put that or if it's a good thing to do

huh · art0007i/ddnet@dccd972

DDraceNetwork, a free cooperative platformer game. Contribute to art0007i/ddnet development by creating an account on GitHub.

art0007i

I made a fork of ddnet with some features I like n stuff, but for some reason the build workflow is failing. anyone know why it's happening? https://github.com/art0007i/ddnet/actions/runs/13579490208/job/37962767436 it says something about -Wno-error-dev but I have no idea where to put that or if it's a good thing to do

Image attachment

02:04

this is odd

i did that to force the workload to re run dont worry

[ddnet-web:master] 1 new commit

6bd25a1 Update masterbans - murpii

art0007i

I made a fork of ddnet with some features I like n stuff, but for some reason the build workflow is failing. anyone know why it's happening? https://github.com/art0007i/ddnet/actions/runs/13579490208/job/37962767436 it says something about -Wno-error-dev but I have no idea where to put that or if it's a good thing to do

that would be on the make command and i beleave it means that you frogot to add some files to the build script

is there a way to turn off lagback?

david loves Jellycar Worlds

does this count as a crash?

errors are cases where the program caught the bad behavior to not crash, panics are Rust's version of crashing. Thanks for exploring :D

so no.

06:39

btw how can i stll parse the file

06:39

as i need to see some stuff about the file to edit it

06:40

is there a way i could change it to a resonable defult texture?

06:40

@Patiga

06:41

or do i just need to look at the datafile without the ddnet parts

I don't understand the 'reasonable default texture'

so like some kind of valid data so it can parse

yea the datafile is the first step of the parsing, so you could actually test those two processes separately

as i need to read the tilemap layers

06:42

for this bug

ah

so i can find what the fuzzing did to trigger this bug

you need some compressed data, with zlib

06:43

if the zlib compression fails, the program will abort with an error

hmm is there a way to tell what the byte offset is that it failed at?

the zlib data additionally needs to be of the size width * height * 4 (in the case of the game layer), at least that should be checked later

yea the main thing is i need to read the width and height of it and the size of it

06:45

got any idea on how i can find that from just the datafile? as the datafile parses fine

david loves Jellycar Worlds

as i need to see some stuff about the file to edit it

the datafile is well documented here https://github.com/heinrich5991/libtw2/blob/6391e05d22aa42b34d191bda377c254c922c81a7/doc/datafile.md the map file here https://github.com/heinrich5991/libtw2/blob/6391e05d22aa42b34d191bda377c254c922c81a7/doc/map.md

yea that much i know but the map file docs dont tell what they look like in the data file realy

the second and third i32 of the image item determine the width and height https://github.com/heinrich5991/libtw2/blob/6391e05d22aa42b34d191bda377c254c922c81a7/doc/map.md#images

oh no i need to read the layers widths and heights

oop layers

06:47

here its the fifth and sixth i32 of the item

wait so they are items not data items?

the meta information of the layers are items

06:49

and the tile data is a data item

06:49

(and in the item it also says which data item to use)

ok but how can i know what item is the layers

06:50

is that what the item-id is for?

06:50

i mean type-id

06:50

and yes i beleave it is

yes, every item has a unique id

06:51

https://ide.kaitai.io/ https://github.com/heinrich5991/libtw2/blob/6391e05d22aa42b34d191bda377c254c922c81a7/doc/map_v4.ksy helps with getting a hex view into how the data is structured

never seen a .ksy file before

06:52

how do i use it?

you can import it in that website

06:53

and then also upload maps and view them using the .ksy file

06:53

(I gtg sadly)

ok thanks

06:53

thanks for the help!

heartw

1

there is also https://github.com/heinrich5991/libtw2/blob/6391e05d22aa42b34d191bda377c254c922c81a7/doc/datafile_v4.ksy for just the datafile

06:54

yw! thanks for trying this!

it just errors

Parse error (EOFError): requested 4 bytes, but only 0 bytes available
Call stack: KaitaiStream.EOFError@https://ide.kaitai.io/lib/_npm/kaitai-struct/KaitaiStream.js:765:17
KaitaiStream.prototype.ensureBytesLeft@https://ide.kaitai.io/lib/_npm/kaitai-struct/KaitaiStream.js:852:11
KaitaiStream.prototype.mapUint8Array@https://ide.kaitai.io/lib/_npm/kaitai-struct/KaitaiStream.js:867:8
KaitaiStream.prototype.readBytes@https://ide.kaitai.io/lib/_npm/kaitai-struct/KaitaiStream.js:540:15
TwMapV4</TwMapV4.I32x3String</I32x3String.prototype._read@https://ide.kaitai.io/js/v1/kaitaiWorker.js line 89 > eval:1102:38
TwMapV4</TwMapV4.GroupItem</GroupItem.prototype._read@https://ide.kaitai.io/js/v1/kaitaiWorker.js line 89 > eval:458:17
TwMapV4</TwMapV4.Item</Item.prototype._read@https://ide.kaitai.io/js/v1/kaitaiWorker.js line 89 > eval:1244:22
TwMapV4</TwMapV4.prototype._read@https://ide.kaitai.io/js/v1/kaitaiWorker.js line 89 > eval:181:16
reparse@https://ide.kaitai.io/js/v1/kaitaiWorker.js:96:17
myself.onmessage@https://ide.kaitai.io/js/v1/kaitaiWorker.js:117:47

(edited)

06:55

@Patiga

when you import the .ksy file?

i copy pasted it

06:56

Image attachment

06:56

and before i imported the map file

can you try to upload the .ksy file as a sanity check

yep still errors

06:58

then agien the game does crash do to a segfault from a oob read so..... mabey the game just doesnt like me

06:58

the datafile one works though so ill just use that for now

david loves Jellycar Worlds

yep still errors

yea sorry then, really gtg

06:59

ah nice :)

its fine

art0007i

I made a fork of ddnet with some features I like n stuff, but for some reason the build workflow is failing. anyone know why it's happening? https://github.com/art0007i/ddnet/actions/runs/13579490208/job/37962767436 it says something about -Wno-error-dev but I have no idea where to put that or if it's a good thing to do

CMake Error (dev) at CMakeLists.txt:374 (message): DATA does not contain every file from directory data Call Stack (most recent call first): CMakeLists.txt:1854 (set_glob)

yep i was right yay

07:11

also what do you need for dev role

07:11

just get a pull requst acsepted?

david loves Jellycar Worlds

also what do you need for dev role

it's assigned to users with accepted pull requests on ddnet main repo

ok so yes

07:12

ok good to know

roles are described in #welcome

btw can anyone add a server to the main server list or is there a aproval prosses

art0007i

I made a fork of ddnet with some features I like n stuff, but for some reason the build workflow is failing. anyone know why it's happening? https://github.com/art0007i/ddnet/actions/runs/13579490208/job/37962767436 it says something about -Wno-error-dev but I have no idea where to put that or if it's a good thing to do

update CMakeLists.txt like so

diff --git a/CMakeLists.txt b/CMakeLists.txt
index df10282a4..4c7725b6d 100644
--- a/CMakeLists.txt
+++ b/CMakeLists.txt
@@ -1392,6 +1392,10 @@ set(EXPECTED_DATA
   countryflags/index.txt
   deadtee.png
   debug_font.png
+  editor/arrow_array_gen/gen_part1.py
+  editor/arrow_array_gen/gen_part2.py
+  editor/arrow_array_gen/input.png
+  editor/arrow_array_gen/readme.md
   editor/audio_source.png
   editor/automap/basic_freeze.rules
   editor/automap/ddmax_freeze.rules
@@ -1851,7 +1855,7 @@ set(EXPECTED_DATA
   wordlist.txt
 )

-set_glob(DATA GLOB_RECURSE "cfg;frag;json;map;otf;png;rules;ttc;ttf;txt;vert;wv" data ${EXPECTED_DATA})
+set_glob(DATA GLOB_RECURSE "cfg;frag;json;map;otf;png;rules;ttc;ttf;txt;vert;wv;py;md" data ${EXPECTED_DATA})

 ########################################################################
 # COPY DATA AND SHARED LIBS

heartw

1

these are my PRs. can i get dev role? @Learath2 https://github.com/ddnet/ddnet/pulls?q=is%3Apr+author%3AZerolAcqua

Pull requests · ddnet/ddnet

DDraceNetwork, a free cooperative platformer game. Contribute to ddnet/ddnet development by creating an account on GitHub.

[ddnet/ddnet] Pull request closed: #9777 Update danish translations

2

08:32

github-merge-queue[bot]

[ddnet:master] 2 new commits

b29e354 Update danish translations - bencie adc07e6 Merge pull request #9777 from bencie/z0rba - def-

std::initializer_list<const char *> vLabels what varibale name should i use for this?

[ddnet/ddnet] Pull request opened: #9778 Fix localization

Checklist

[ ] Tested the change ingame
[ ] Provided screenshots if it is a visual change
[ ] Tested in combination with possibly related configuration options
[ ] Written a unit test (especially base/) or added coverage to integration test
[ ] Considered possible null pointers and out of bounds array indexing
[ ] Changed no physics that affect existing maps
[ ] Tested the change with [ASan+UBSan or valgrind's memcheck](https://github.com/ddnet/ddnet/#using-ad...

someone merge? owo

owo

https://github.com/ddnet/ddnet/pull/9628/ (edited)

add a slider to change prediction margin in the DDNet tab by dropal...

Checklist Tested the change ingame Provided screenshots if it is a visual change Tested in combination with possibly related configuration options Written a unit test (especially base/) or add...

12:14

i wanna delete this repo and make all features in different branches

12:14

shoulda done that before :c

Solly

std::initializer_list<const char *> vLabels what varibale name should i use for this?

strLabel ?

12:21

or labelList or smth

12:22

strptrLabelList! (edited)

meloƞ

strLabel ?

i mean the variable things

12:28

like p for pointer

12:28

a for array

12:28

s_ for static

we use hungarian notation

12:29

DDNet inherited the hungarian notation like prefixes from Teeworlds

m_

Class member

g_

Global variable

s_

Static variable

p

Pointer

a

Fixed array

Combine them appropriately. Class Prefixes

C

Class, CMyClass, This goes for structures as well.

I

Interface, IMyClass

12:29

tho we dont follow it strictly

12:30

https://github.com/ddnet/ddnet/blob/master/CONTRIBUTING.md

ddnet/CONTRIBUTING.md at master · ddnet/ddnet

DDraceNetwork, a free cooperative platformer game. Contribute to ddnet/ddnet development by creating an account on GitHub.

meloƞ

tho we dont follow it strictly

We do follow it pretty strictly. As in your PR won't be accepted if we notice there is a mistake. We just don't have automated tooling to catch it

Learath2

We do follow it pretty strictly. As in your PR won't be accepted if we notice there is a mistake. We just don't have automated tooling to catch it

but then contributing.md is wrong :o

12:31

The ddnet code base does NOT follow the whole hungarian notation strictly. Do NOT use c for constants or b for booleans or i for integers.

12:31

or is this part about the whole

meloƞ

The ddnet code base does NOT follow the whole hungarian notation strictly. Do NOT use c for constants or b for booleans or i for integers.

Ah, that's written weirdly. It's trying to say that we don't use Hungarian notation strictly as you'd find it on wikipedia

12:32

We don't use it to mark bools ints constants etc

ah okay - so in parts where we use it, we enforce it strictly, but we dont use the entirety of it (edited)

guys i pressed fetch info in the demos menu and my game stopped responding is that normal (edited)

meloƞ

ah okay - so in parts where we use it, we enforce it strictly, but we dont use the entirety of it (edited)

Yeah, we strictly enforce our notation which is a subset of hungarian notation

got it chief

github-merge-queue[bot]

[ddnet:master] 2 new commits

6fa499d Fix localization - Pioooooo a104f8a Merge pull request #9778 from Pioooooo/localize-string - Robyt3

12:58

[ddnet/ddnet] Pull request closed: #9778 Fix localization

13:05

[ddnet/ddnet] Issue opened: #9779 tees should be able to face forward

DDNet logo !Image Teeworlds splash thing !Image Teeworlds.com favicon !Image !Image As you can see, tees are able to face forwards Yet in game they cannot face ...

meloƞ

DDNet inherited the hungarian notation like prefixes from Teeworlds

m_

Class member

g_

Global variable

s_

Static variable

p

Pointer

a

Fixed array

Combine them appropriately. Class Prefixes

C

Class, CMyClass, This goes for structures as well.

I

Interface, IMyClass

i thought v was also a thing

vector

meloƞ

DDNet inherited the hungarian notation like prefixes from Teeworlds

m_

Class member

g_

Global variable

s_

Static variable

p

Pointer

a

Fixed array

Combine them appropriately. Class Prefixes

C

Class, CMyClass, This goes for structures as well.

I

Interface, IMyClass

https://wiki.ddnet.org/wiki/Development#Code_conventions

This article aims to introduce you into DDNet development, since it's an open-source game, it relies on random people kind enough to contribute to it on their free time.

13:24

Variable naming

    The names of variables contain 3 parts: qualifier, prefix and name.
    Variable names should start with uppercase unless they are 1 char long without any prefix or qualifier, for example: i, x, y.
    Variables can have more than 1 qualifier (or zero) and more than 1 prefix (or zero).

These are laid out like this: [qualifiers]_[prefixes][Name]


Qualifiers

    m for member variables: m_MyVariable.
    s for static variables: s_MyStaticVariable, ms_MyStaticMemberVariable.
    g for global variables with external linkage: gs_MyGlobalStaticVar.


Prefixes

    p for pointers: pMyPointer, m_pCharacter, ppMyPointerToPointer.
    a for arrays: aMyArray, aBuf.
    v for std::vectors: vMyVector, vpvMyVectorOfPointersToVectors.
    fn for functions: pfnMyCallback, m_papfnMyPointerToArrayOfCallbacks.

sigh

14:46

Image attachment

justatest

1

14:46

its been 30s

[ddnet/ddnet] Issue opened: #9780 bans says "The ban list is empty." and name_bans comes back blank

Would be nice if it had the same response. I like the empty message.

in client.cpp runonjoin is inside if(m_ServerCapabilities.m_ChatTimeoutCode) is this intended?

15:21

                            if(!g_Config.m_ClRunOnJoin[0] && !g_Config.m_ClDummyDefaultEyes && !g_Config.m_ClPlayerDefaultEyes)
                                str_format(aBufMsg, sizeof(aBufMsg), "/timeout %s", m_aTimeoutCodes[Conn]);
                            else
                                str_format(aBufMsg, sizeof(aBufMsg), "/mc;timeout %s", m_aTimeoutCodes[Conn]);

15:21

this is also quite brittle

Image attachment

15:51

clang format is...

15:51

is so dumb

That's a sign that you shouldn't use the ternary there. We haven't figured out how to tame clang-format to not mess with the spaces like this, which is the main reason we are still on clang format 10.

darn

15:55

i dont remember if i used fixstyle.py

15:55

or clang format [most recent version] (edited)

I think clang-format-10, which is used by the script, shouldn't mess with spaces in ternaries like this

i see

15:56

if u cant get clang to just stop it (dont attempt to do anything) thats probably a regression no? (edited)

Maybe something about the underlying parser changed. Maybe it depends on clang parsing internals.

seems like quite an important thing

I haven't found any new option being added that would restore the legacy behavior

yeah but what it spits out now is both wrong (i cant imagine what rules cause this behaviour) and an unreadable mess

16:00

(as much as weird tabbing can make something an unreadable mess)

https://www.reddit.com/r/cpp/comments/1hnps39/has_anyone_figured_out_yet_how_to_get_clangformat/m4450ig/

SirClueless's comment on "Has anyone figured out yet how to get cla...

Explore this conversation and more from the cpp community

16:06

Seems like a design decision. Time to write our own code formatter I guess pepeW

pepeW

monkalaugh

1

Robyt3

Seems like a design decision. Time to write our own code formatter I guess pepeW

pepeW

ChillerDragon: Time for you to write us a 1K LoC bash script for formatting

someone merge? owo

owo

#9628

https://github.com/ddnet/ddnet/pull/9628

add a slider to change prediction margin in the DDNet tab by dropal...

Checklist Tested the change ingame Provided screenshots if it is a visual change Tested in combination with possibly related configuration options Written a unit test (especially base/) or add...

i really wanna delete my repo so i can make 1 feature per branch (edited)

GitHub

Click to see attachment 🖼️

why would we need this in-game

always

i really wanna delete my repo so i can make 1 feature per branch (edited)

dont do it

17:11

ive tried to do that

17:11

git does not like it

[ddnet/ddnet] Pull request closed: #9628 add a slider to change prediction margin in the DDNet tab

17:33

github-merge-queue[bot]

[ddnet:master] 2 new commits

7f4a800 add a slider to change prediction margin - dropalways 2f4ed88 Merge pull request #9628 from dropalways/master - Robyt3

GitHub

Click to see attachment 🖼️

thanks!

Has discord suddenly unlocked nitro for everyone?

18:50

nugget

18:50

why can I do this

ye

18:51

Sticker

18:51

ok last time im sending this in #developer

Sticker

Teero

nugget

wtf

18:52

hasnt updated for mobile yet

I'm on mobile

18:53

Android

Hecta

wtf

Crazy right? A rotating chicken nugget

18:53

That wasn't possible before!

do you think this has to do with it

Image attachment

Teero

I'm on mobile

maybe its for certain users only

Hecta

do you think this has to do with it

nooo

18:57

This will lose me some contacts (edited)

18:57

And lots of memories

discord has become a monopoly in terms of chatting apps

and it's a good way into its enshittification already

watch, you'll only be able to upload 5MB files soon

Teero

This will lose me some contacts (edited)

Image attachment

19:10

did you read the first word only or something

always

did you read the first word only or something

yes

Teero

Has discord suddenly unlocked nitro for everyone?

no fair why dont i get it

Hecta

do you think this has to do with it

mfw teams is just a skype wrapper

i wouldnt be surprised

(it is)

22:38

(source: trust me bro i saw it in pavucontrol while using teams)

Heinrich banned bash

Replying to @meloƞ ChillerDragon: Time for you to write us a 1K LoC bash script for formatt…

chillerdragon

Heinrich banned bash

just use posix shell then

Exported 179 message(s)

Timezone: UTC+0