DDraceNetwork - developer

DDraceNetwork

Development / developer

Development discussion. Logged to https://ddnet.org/irclogs/ Connected with DDNet's IRC channel, Matrix room and GitHub repositories — IRC: #ddnet on Quakenet | Matrix: #ddnet-developer:matrix.org GitHub: https://github.com/ddnet

Between 2025-02-05 00:00 and 2025-02-06 00:00

[ddnet/ddnet] Issue opened: #9649 Updater fails to remove ".old" files on windows

steps to reproduce: download DDNet 18.8.2 use the updater ``` 2025-02-04 23:06:13 I http: task done: https://update.ddnet.org/data/languages/arabic.txt 2025-02-04 23:06:13 I http: task done: https://update.ddnet.org/steam_api-win64.dll 2025-02-04 23:06:13 I http: task done: https://update.ddnet.org/data/languages/portuguese.txt 2025-02-04 23:06:14 I http: task done: https://update.ddnet.org/data/languages/persian.txt 2025-02-04 23:06:14 I http: task done...

#9512 is ready to be reviewd! I had to scrap a major update, because I really don't know how to properly do it. But as of right now, I hope people have fun with this!

https://github.com/ddnet/ddnet/pull/9512

Improving the usability of automappers by VoxelDoesCode · Pull Requ...

Summary As of: Feb. 5, 2025: Previously on Jan. 12, 2025 This PR focuses on making the automapping feature much more manageable and flexible for mappers and map designers. The features included/pla...

poggers2

1

morning parametric polymorphism enjoyers and others

5

xd

@Jupstar ✪ booked my flight 210€ so ill be there hehe

07:13

waiting made me save 100€

[ddnet/ddnet] Pull request opened: #9650 Minor rust warns fixes

Checklist

[ ] Tested the change ingame
[ ] Provided screenshots if it is a visual change
[ ] Tested in combination with possibly related configuration options
[ ] Written a unit test (especially base/) or added coverage to integration test
[ ] Considered possible null pointers and out of bounds array indexing
[ ] Changed no physics that affect existing maps
[ ] Tested the change with [ASan+UBSan or valgrind's memcheck](https://github.com/ddnet/ddnet/#using-ad...

@Ryozuki when the automap pr gets merged i'll go through the entirety of editor_props.cpp and make it all consistant

?

08:04

the lines u changed should be changed now

08:04

its how it works

08:05

u can make also another pr after to fix it all

08:05

oh u made it const in this pr

08:05

ok i thought u didnt want to do it now xD

08:05

nvm

08:07

do u know how to squash it all

like, i'm saying i want to go through EVERY instance of int r = PopupSelect[...]Result(); and make it consistant with the new code format you're having me do

Ryozuki

do u know how to squash it all

yea i've been squashing

Hecta

like, i'm saying i want to go through EVERY instance of int r = PopupSelect[...]Result(); and make it consistant with the new code format you're having me do

yeah, nice

08:07

all variables that arent meant to be changed should be made const

1

08:07

c++ made the bad decision to make stuff non const by default

08:08

it prevents optimizations

right

08:08

im just sad i didnt get guides to work out like i wanted it to but oh well

08:08

feels like another "only me" update

08:08

plus too hard

what do u mean by only me? xD

like, i do not see anyone except for me and maybe souly to use the automapper guides feature

08:10

i did save the progress tho, it's in here: https://github.com/VoxelDoesCode/ddnet/tree/automap_guides

GitHub - VoxelDoesCode/ddnet at automap_guides

DDraceNetwork, a cooperative racing mod of Teeworlds, now with experimental features - GitHub - VoxelDoesCode/ddnet at automap_guides

08:10

i will figure it out. someday

08:13

oh yea when this gets merged i'll try and handle the wiki update too

So far, no merge conflicts with #8644

https://github.com/ddnet/ddnet/pull/8644

Add Include command to automapper by Marmare314 · Pull Request #864...

Draft implementation of #8643. Checklist Tested the change ingame Provided screenshots if it is a visual change Tested in combination with possibly related configuration options Written a uni...

i hope

[ddnet/ddnet] Pull request opened: #9651 Cleanup, add const correctness check

Renamed the longstanding non conformant graphics classes names to be correct. Enabled/disabled some lints newer clang-tidy picks up.

Checklist

[ ] Tested the change ingame
[ ] Provided screenshots if it is a visual change
[ ] Tested in combination with possibly related configuration options
[ ] Written a unit test (especially base/) or added coverage to integration test
[ ] Considered possible null pointers and out of bounds array indexing
[ ] Changed no physics tha...

08:45

github-merge-queue[bot]

[ddnet:master] 2 new commits

b49d5ce Minor rust warns fixes - edg-l 28a1756 Merge pull request #9650 from edg-l/fix_rust_warns - def-

08:45

[ddnet/ddnet] Pull request closed: #9650 Minor rust warns fixes

08:50

[ddnet/ddnet] Pull request closed: #9607 Use c++20

chillerdragon

@Robyt3: I don’t have any windows near by ._.

ChillerDragon: You can run gdb on Windows with MSYS2, but I didn't get any crash to begin with. I can try later if it crashes when compiling with MSVC.

chillerdragon

@Robyt3: I don’t have any windows near by ._.

living in a basement, huh?

3

10:45

kek

jxsl13

living in a basement, huh?

good one xd

<ChillerDragon> thank you @Robyt3

<ChillerDragon> @Ryozuki what is your opinion on keeping pre as small as possible? Imo #9651 could at least be two prs. This reduces discussion per pr and merges it faster. Reduces the git conflicts with other pre. And makes reviewing easier.

https://github.com/ddnet/ddnet/issues/9651

Cleanup, add const to some places by edg-l · Pull Request #9651 · d...

Renamed the longstanding non conformant graphics classes names to be correct. Enabled/disabled some lints newer clang-tidy picks up. Checklist Tested the change ingame Provided screenshots if it...

its not possible with these kind of changes

<ChillerDragon> it is

i dont wanna

<ChillerDragon> I see

owo

<ChillerDragon> I wonder if I am alone with that idea

is anyone working on accounts right now?

tbh i held back a bit, that pr could be 5k lines

<ChillerDragon> you don't have to hold back

11:36

<ChillerDragon> just split it

11:37

<ChillerDragon> for example all the const adds could be one pr that can be merged instantly without any discussion. Now its a bunch of lines that might conflict because the other more controversial changes require discussions.

i guess ur right

11:38

but im lazy now

11:38

maybe ill do it sometime

I wish to know what I can do to make it closer to accounts

<ChillerDragon> yea dw I just wanted to make sure that me splitting up prs is not upsetting anyone

11:39

<ChillerDragon> @Pioooooo there are a bunch of issues about accounts maybe there are some tasks to pick up

i saw there is one by juppey under the ddnet-account repo but that's like general stuff

<ChillerDragon> you can for example help by testing this @Pioooooo https://github.com/ddnet/ddnet-accounts/issues/1

Account system information · Issue #1 · ddnet/ddnet-accounts

This is the very first version of the ddnet account system. I want to quickly go through some points, so common questions are avoided. How does the system work? If you technically want to understan...

11:40

<ChillerDragon> yes try to get it running and test the official instance

11:41

<ChillerDragon> if it is polished enough you could even start already implementing it in ddnet c++

yeah i just want to know if someone is already doing this

<ChillerDragon> i think the only one working on it is jupstar and he is quite busy with other stuff. I doubt he will start to write c++ any time soon or ever

thx i might try to read ddnet-rs impl first

[ddnet/ddnet-web] Pull request opened: #316 Limit amount of skins concurrently downloaded.

I dunno why but my browser completely crashes with the current skin database. I tried to debug this earlier, but if i open the console in chromium it kills my tab. Sometimes it says something about insufficient resources. So my guess is that it simply cannot deal with so many xml requests. Sadly I cannot reproduce this on localhost at all, so this is really just guessing xd

11:56

[ddnet/ddnet-web] Pull request closed: #316 Limit amount of skins concurrently downloaded.

11:56

[ddnet-web:master] 2 new commits

fac151d Limit amount of skins concurrently downloaded. - Jupeyy 6236bcc Merge pull request #316 from Jupeyy/pr_fix_skin_db_download - def-

@ChillerDragon yo ! Do you have a mechanism to ban a player with something else than IP address ? By username or idk ?

12:30

On the machine itself or within your teeworlds servers*

12:33

Hwid ban maybe ?

ws-client

<ChillerDragon> i think the only one working on it is jupstar and he is quite busy with other stuff. I doubt he will start to write c++ any time soon or ever

I don't see any need in it as long as we don't have the technical solution for server-client encryption

Nagi01 {LAN}

On the machine itself or within your teeworlds servers*

you can easily execute bans save after banning someone, then ping the other servers on the network to re-read the bans file

12:38

or using fifo

12:38

might be easier

fokkonaut

you can easily execute bans save after banning someone, then ping the other servers on the network to re-read the bans file

I see, but, is ban save a rcon command or is it at lower level ?

i think it's a rcon command. at least in F-DDrace I made one then

12:40

but I dont have bans syncing

12:40

Just fifo would be ideal

12:41

exec the bans file using fifo after another server has saved the bans after a new ban has been added

12:42

https://github.com/ddnet/ddnet/blob/28a17566a0dcf9b4ca62a648f7919f8146c599e9/src/engine/shared/netban.cpp#L290

ddnet/src/engine/shared/netban.cpp at 28a17566a0dcf9b4ca62a648f7919...

DDraceNetwork, a free cooperative platformer game. Contribute to ddnet/ddnet development by creating an account on GitHub.

12:44

You can trigger the function by calling ExecuteLine() anywhere you want with the bans_save cmd

12:45

https://github.com/fokkonaut/F-DDrace/blob/8db0aa0adba4d791f84deda8e0c226c8c321ab35/src/game/server/gamecontext.cpp#L4537

F-DDrace/src/game/server/gamecontext.cpp at 8db0aa0adba4d791f84deda...

F-DDrace is a server-side modification of Teeworlds, developed by fokkonaut. - fokkonaut/F-DDrace

fokkonaut

exec the bans file using fifo after another server has saved the bans after a new ban has been added

Could be interesting yes

fokkonaut

https://github.com/fokkonaut/F-DDrace/blob/8db0aa0adba4d791f84deda8e0c226c8c321ab35/src/game/server/gamecontext.cpp#L4537

Cool ! But is it implemented on the save fng servers

?

Ah

12:48

nop

Ah, knew it xd

ohh i see you wanted to have it on ddnetinsta

Yep

do a pr

12:49

chiller will approve

But, ban save does not seem to solve my original problem xd

yea needs script setups to actually call fifo

12:50

chillerdragon:

The problem is simple : banned players by ip address that spoof their ip address (edited)

Ahhhhhh

12:50

I think

12:50

ddnet has a name ban system

12:50

so has ddnet insta then, cuz based on ddnet

Thats why i asked this xd https://discord.com/channels/252358080522747904/293493549758939136/1336676136960397442 (edited)

Sowwy

fokkonaut

so has ddnet insta then, cuz based on ddnet

Only by name ? This players dont care about usernames and saved points justatest

justatest

Dm me

K thanks

Nagi01 {LAN}

The problem is simple : banned players by ip address that spoof their ip address (edited)

Set up dnsbl, namebans and IP range bans

meloƞ

Set up dnsbl, namebans and IP range bans

I dont see how dnsbl fix the problem xd, ip range doesnt make sens wtf. Or am i missing something ?

Nagi01 {LAN}

I dont see how dnsbl fix the problem xd, ip range doesnt make sens wtf. Or am i missing something ?

If someone restarts his router to dodge a ban, it absolutely can help :p

13:46

People can easily bypass with dynamic IP, but they most of the time don't exceed ~2K ips

Yes but, in 2025,everybody uses proxies

Which can be handled with proper range bans

Nagi01 {LAN}

Yes but, in 2025,everybody uses proxies

Just blacklist

13:46

monkalaugh

meloƞ

If someone restarts his router to dodge a ban, it absolutely can help :p

Even if we assume this, or do i know a range per player xd ?

13:47

I have to ask internet provider justatest

justatest

?

You just ban the range from 0-255 really 1.1.1.0 - 1.1.1.255

13:48

You could look up the IP range of the ISP, but banning that may have a lot of backlash

Mhmhm yes

14:24

I had another solution but it requires client and server modification

14:24

For now ill just ban by name and ips i guess

where can i change the size of the gameskin

14:25

where the pistol is and stuff

Smaragt

where the pistol is and stuff

$configdir

Smaragt

where the pistol is and stuff

DDNet config directory:

On Windows: Old: %appdata%\Teeworlds New: %appdata%\DDNet On Linux: Old: ~/.teeworlds New: ~/.local/share/ddnet On macOS: Old: ~/Library/Application Support/Teeworlds New: ~/Library/Application Support/DDNet

And in this folder you should find a data folder if i remember good

wait so i dont have to look in the source code?

They want to change how big its actually rendered as xd

Broso56

They want to change how big its actually rendered as xd

yes this right here

Cause I don't think you can increase pistol size much in the image

Broso56

Cause I don't think you can increase pistol size much in the image

thats sadly true

14:36

ive noticed that i (probably placebo idc tho lol) play better with a bigger weapon

14:37

thast why i want to change the actual size of the pistol image to be bigger just to see how it feels

I mean you can maybe increase the size a bit, but it doesn't sound like it's enough for what you want xd

if you mean by making the pistol image bigger then no its no enough haha

just the pistol or all weapons?

15:35

greenthing

meloƞ

Click to see attachment 🖼️

crazy skill

KEKW

1

look for

Graphics()->RenderQuadContainerAsSprite(m_WeaponEmoteQuadContainerIndex, QuadOffset, WeaponPosition.x, WeaponPosition.y);

and change it to something like this:

Graphics()->RenderQuadContainerAsSprite(m_WeaponEmoteQuadContainerIndex, QuadOffset, WeaponPosition.x, WeaponPosition.y, 2.0f, 2.0f);

15:37

my weapon was scaled up to 50.0f, 50.0f - as a reference point

meloƞ

Click to see attachment 🖼️

btw dont blame the gun design, i still suck at inkscape PepeCringe

PepeCringe

its beautiful

hi developas

[ddnet-web:master] 1 new commit

40394e4 RUS5 -> RUS1 - def-

justatest

3

Nagi01 {LAN}

Yes but, in 2025,everybody uses proxies

Yes, but if you have a proper dnsbl you can catch most of the proxies tho

Avolicious

Yes, but if you have a proper dnsbl you can catch most of the proxies tho

True true

meloƞ

Click to see attachment 🖼️

wtf hahahaha

18:17

i mean if you can make the hammer a bit bigger as well sure!

18:19

also thanks

There is no such thing.

Replying to @Nagi01 {LAN} Hwid ban maybe ?

Smaragt

i mean if you can make the hammer a bit bigger as well sure!

sure thing

Hammer time

chillerdragon

Hammer time

chiller, imagine ddnet-rs where the server can just tell the client to render the hammer in this size, and you walk over and banhammer someone

Image attachment

19:12

just imagine

ban hammer is epic

19:13

I wrote a mod once where all players have ban hammer

19:15

@meloƞ: does ddnet-rs feel like ddnet to you? Can you play it without it feeling annoyingly off?

[ddnet/ddnet] Issue opened: #9652 Warning for pnglite incompatible skins doesn't include skins with bKGD and pHYs chunks

The skin DB contains various skins that are not compatible with pnglite anymore: ``` [2025-02-05 11:55:12][game/png]: failed to read image. filename='/Users/deen/Library/Application Support/Teeworlds/skins/FalFy.png', pnglite: Unknown file error. [2025-02-05 11:55:12][game]: failed to load skin from FalFy [2025-02-05 11:55:12][game/png]: failed to read image. filename='/Users/deen/Library/Application Support/Teeworlds/skins/hungary.png', pnglite: Unknown file error. [2025-02-05 11:55:1...

chillerdragon

@meloƞ: does ddnet-rs feel like ddnet to you? Can you play it without it feeling annoyingly off?

funny thing is that ddnet isnt fully implemented yet

19:15

but i can say that playing ctf feels exactly the way you want it to feel like

19:15

fluent

19:15

i had a lot of fun playing ctf against @zhn in ddnet-rs

19:16

like - vanilla is just great

meloƞ

sure thing

this the type of shit terraria calamity is on

KEKW

2

chillerdragon

I wrote a mod once where all players have ban hammer

i rememebr that mode

19:39

rly frustrating

meloƞ

sure thing

double u tee ef

meloƞ

sure thing

extra range when

@meloƞ btw i cannot find the line of code you sent in here on the source code thing website idk im not really a coding god

dont worry - i might just make it a variable you can change in t-client

19:50

its funny after all

i want it now tho

19:51

isnt it just like 1 or 2 line of code where i put in a different number

its 1 line of code per weapon you need to change yes xD

19:51

as mentioned, there are 5 occurances of this code: Graphics()->RenderQuadContainerAsSprite(m_WeaponEmoteQuadContainerIndex, QuadOffset, WeaponPosition.x, WeaponPosition.y for each weapon (edited)

i copy pasted the exact line and tried to find it with ctrl + f

and all you need to do is add 2 float values

but it didnt find it

where did you look?

19:52

like source code thingie website, wdym?

Image attachment

19:53

yes

19:53

the github

meloƞ

as mentioned, there are 5 occurances of this code: Graphics()->RenderQuadContainerAsSprite(m_WeaponEmoteQuadContainerIndex, QuadOffset, WeaponPosition.x, WeaponPosition.y for each weapon (edited)

you gotta compile after that yea?

cyberfighter 2

you gotta compile after that yea?

yes - you need to do it yourself if you want it immediatly

now does that change the entire ddnet folder or just the exe

Image attachment

1

Smaragt

Click to see attachment 🖼️

i dont think that greps (looks through each file) - but rather just searches for.. files

19:57

src/game/client/components/players.cpp at around ~675 (edited)

maybe but ive probably looked into every file that i at least think it would be in

19:57

and it never popped up

19:58

bruh ofc the 1 file i didnt look into

kek

1

Smaragt

maybe but ive probably looked into every file that i at least think it would be in

bros still trying to make a client and he just wants to make the pistol bigger

so do i just download that client and change the number?

i remember this guy from like 7 hrs ago

hahahahaha

Smaragt

so do i just download that client and change the number?

nouis

it sadly doesnt work like that - you need to compile it yourself

give up your dreams if you are not a dev sadly

i'm eepy so idont want to go through this step

20:00

its quite a bit of setup for just a small change like this - i'll PR it to T-Client maybe today/tomorrow (edited)

meloƞ

nouis

it sadly doesnt work like that - you need to compile it yourself

water fak

water fak

water fuck nouis

nouis

wtf

[ddnet/ddnet] Issue closed: #9649 Updater fails to remove ".old" files on windows

meloƞ

sure thing

make it bigger, like i dont even see the hammer

[ddnet/ddnet] Pull request opened: #9653 Fix touch control button's corner bug

It's checked that all corner is acted correctly. And it's complexity is o(n²), n is the amount of button that currently visiable, not related to the amount of visibilities. Checked ingame using a big touch control(1MB) with 999 extra menus. Didn't see FPS drop.

Checklist

[1] Tested the change ingame
[ ] Provided screenshots if it is a visual change
[ ] Tested in combination with possibly related configuration options
[ ] Written a unit test (especially base/) or added c...

Lucky you. For me it’s unplayable ._.

Replying to @meloƞ but i can say that playing ctf feels exactly the way you want it to feel…

louis

when i upload another map i get

[2025-01-27T18:18:24Z INFO  trashmap] 2025-01-27 18:18:24 I host_lookup: host='localhost' port=0 3
[2025-01-27T18:18:24Z INFO  trashmap] 2025-01-27 18:18:24 I net: failed to bind socket with domain 10 and type 1 (98 'Address already in use')
[2025-01-27T18:18:24Z INFO  trashmap] 2025-01-27 18:18:24 I econ: couldn't open socket. port might already be in use
[2025-01-27T18:18:24Z INFO  trashmap] 2025-01-27 18:18:24 I server: server name is 'shroobie'
[2025-01-27T18:18:24Z INFO  trashmap] 2025-01-27 18:18:24 I censorlist: failed to open 'censorlist.txt'
[2025-01-27T18:18:24Z INFO  trashmap] 2025-01-27 18:18:24 I sql: failed to open wordlist, using fallback
[2025-01-27T18:18:24Z INFO  trashmap] 2025-01-27 18:18:24 I server: version 19.0 on linux amd64
[2025-01-27T18:18:24Z INFO  trashmap] 2025-01-27 18:18:24 I server: git revision hash: 00bb74c498992122
[2025-01-27T18:18:24Z INFO  trashmap] 2025-01-27 18:18:24 E server: Failed load announcements from 'announcement.txt'
[2025-01-27T18:18:24Z INFO  trashmap] 2025-01-27 18:18:24 I server: +-------------------------+
[2025-01-27T18:18:24Z INFO  trashmap] 2025-01-27 18:18:24 I server: | rcon password: 'pTSqot' |
[2025-01-27T18:18:24Z INFO  trashmap] 2025-01-27 18:18:24 I server: +-------------------------+
[2025-01-27T18:18:25Z ERROR trashmap] Error in handler: deadline has elapsed

which is weird (edited)

so the problem seemed to be with sv_register somehow

22:36

got some error about curl version being too low to both register in ipv4 and ipv6

22:36

not sure how that even happened

linking system libs?

Exported 219 message(s)

Timezone: UTC+0