DDraceNetwork

Mirfay

happens on every server, latest ddnet client from website.

jipstar

Jupstar ✪

@louis maybe u could check if loading the skin fails in that photoshot client? else dunno

yes, some skins fail to load since they are pnglite incompatible

Mirfay

jipstar

Yeah no idea

deen

yes, some skins fail to load since they are pnglite incompatible

But we have checks to ensure pnglite compatiblity in the new client and also in the skin DB (hopefully?) so are those not correct/working anymore?

https://discord.com/channels/252358080522747904/757720336274948198/1336475772503724083

Robyt3

But we have checks to ensure pnglite compatiblity in the new client and also in the skin DB (hopefully?) so are those not correct/working anymore?

Here's the list:

fail.txt

12.72 KB

b4 the discord skin bot we didn't de & re-encode the pngs

louis

the reason was the db zip doesnt contain all pngs when i download it @Jupstar ✪

i think the code will simply not download at all if one file couldn't be downloaded.. did you maybe have a filter active? xd but i cant even download it, the db is just completely broken in my browser xD

So I fixed a bug in the website now and when I downloaded all skins and looked into the zip it showed exactly as many files as expected

Jupstar ✪

Yeah no idea

p:

how on earth does this happen kekw

18:52

its fine for him which makes it even worse

gg leaking private dms

1

Looks like the only significant difference of those images is that they have additional background color and physical size chunks, I guess pnglite doesn't support the background color:

Background color: white
png:bKGD: chunk was found (see Background color, above)
png:pHYs: x_res=3779, y_res=3779, units=1

Can be checked with magick identify -verbose skin.png and fixed with magick convert -strip in.png out.png. Confirmed with client version 15.7 that the converted skin loads. Can we add a check for this in the upload bot and fix existing skin in the DB?

ABER SIE BLUT

chillerdragon

ABER SIE BLUT

EN