Guild icon
DDraceNetwork
Development / developer
Development discussion. Logged to https://ddnet.org/irclogs/ Connected with DDNet's IRC channel, Matrix room and GitHub repositories — IRC: #ddnet on Quakenet | Matrix: #ddnet-developer:matrix.org GitHub: https://github.com/ddnet
Between 2025-02-02 00:00 and 2025-02-03 00:00
Avatar
Quick question does veto apply per tee or per IP? For example if my dummy has veto and I press F4 while the main tee is selected and the main tee doesn't have veto is the vote going to be aborted?
Avatar
Avatar
Teero
Quick question does veto apply per tee or per IP? For example if my dummy has veto and I press F4 while the main tee is selected and the main tee doesn't have veto is the vote going to be aborted?
I've tried voting as both tees before and it didn't seem to do anything
Avatar
Since there is only 1 vote per IP I think this should be the case but I'm not sure I haven't tested
Avatar
but that's just looking at the vote bar
Avatar
Avatar
risu
I've tried voting as both tees before and it didn't seem to do anything
That's not my question tho
01:30
I know you only have one vote
Avatar
wait, is "having veto" some fancy mechanic I don't know about?
Avatar
Google veto xd
01:32
If you are longer in the race you can abort any vote
Avatar
pulling a chiller and afking in a map midrun i have all the power now
Avatar
Avatar
Teero
Google veto xd
you could have a veto by vote
01:57
by like, a minority
01:57
instead of a singular person
Avatar
man u don't understand my question (edited)
Avatar
Avatar
Teero
Quick question does veto apply per tee or per IP? For example if my dummy has veto and I press F4 while the main tee is selected and the main tee doesn't have veto is the vote going to be aborted?
never tested, lemme check da code
Avatar
Avatar
Teero
man u don't understand my question (edited)
I do understand, I just have no idea I'm more confused over what I thought the veto message in chat meant because my ass was misunderstanding in some really stupid way
Avatar
I also wanted to look into this thing before since the vote UI is sometimes buggy
Avatar
Nevermind, I don't think I can do guide layers for automappers. The current layer structure makes it reaaally hard to dictate how it should work.
04:04
Sucks because I have to revert a lot of code. It was a really solid idea, but it's almost impossible to set it up properly without having to take several sidequests
Avatar
Avatar
GitHub
Click to see attachment 🖼️
^ needs the incomplete label
Avatar
GitHub BOT 2025-02-02 07:17
Change the comma separated in the descriptive text of src/engine/shared/config_variables.h to comma-separated for consistency in #9583.

Checklist

  • [x] Tested the change ingame
  • [ ] Provided screenshots if it is a visual change
  • [ ] Tested in combination with possibly related configuration options
  • [ ] Written a unit test (especially base/) or added coverage to integration test
  • [ ] Considered possible null pointers and out of bounds array indexing
  • [x] Change...
Avatar
GitHub BOT 2025-02-02 08:07
f25043e Unify the description in config_variables - ZerolAcqua b46f30c Merge pull request #9635 from ZerolAcqua/master - heinrich5991
Avatar
GitHub BOT 2025-02-02 09:18
Newer teeworlds also does not send any chat messages from the gameworld anymore. Which to me sound the wrong place to do it anyways. In ddnet there are no teams so they can also never be balanced. Also ddnet forks can just implement it on tick there is no need to access the gameworld for it. Also the method was not virtual so not too interesting for custom controllers. I intentionally kept bool IGameController::CanBeMovedOnBalance(int ClientId) because it is still used in modern tee...
Avatar
GitHub BOT 2025-02-02 10:13
a7552f2 Update romanian translations - Sans3108 1e32391 Fix based on context - Sans3108 0c82212 Remove header as per #9568 - Sans3108 51970cc Merge pull request #9633 from Sans3108/upstream-master - Robyt3
10:16
aa14e01 Remove IsForceBalanced() - ChillerDragon a9c0636 Merge pull request #9636 from ChillerDragon/pr_ddnet_rm_isforcebalanced - heinrich5991
Avatar
GitHub BOT 2025-02-02 10:23
eec4133 Call member method FindFirst() directly - ChillerDragon 99a200e Merge pull request #9637 from ChillerDragon/pr_direct_findfirst - heinrich5991
Avatar
ws-client BOT 2025-02-02 10:25
<ChillerDragon> @Hecta what needs incomplete and why?
Avatar
nothing now, the issue i was talking about got closed by the author
Avatar
GitHub BOT 2025-02-02 10:32
this allows writing tests for things like gameworld, gameserver, character, player and so on. Needed for: https://github.com/ddnet/ddnet/pull/9386#issuecomment-2565477627

Draft

Draft until IS_TEST_TODO_FIND_BETTER_NAME is renamed. Any suggestions? I have the feeling there should already be a define that is set when the tests are compiled. Is there one I can use?
Avatar
ws-client BOT 2025-02-02 11:37
<ChillerDragon> robyte how would remove a file from cmakelist? the glob wants all of the files
11:38
<ChillerDragon> i can only think of ugly solutions
Avatar
I meant the same as heinrich5991, create set without the server main for the tests
Avatar
ws-client BOT 2025-02-02 11:42
<ChillerDragon> yes that much i understood
11:43
<ChillerDragon> but in our cmake we glob directories for file listings
11:43
<ChillerDragon> if i remove a file it throws an error
11:43
<ChillerDragon> if i remove the glob we dontr have a glob
11:43
<ChillerDragon> i have some idea but its not nice
11:46
<ChillerDragon> omg mold: error: undefined symbol: IsInterrupted()
11:46
<ChillerDragon> the compile definition was already working :c
Avatar
hmm, I guess you'd need a server main stub which defines IsInterrupted since it's used in server.cpp (edited)
11:57
technically also FetchAndroidServerCommandQueue for Android, if we'd ever try to compile and run tests on Android
Avatar
ws-client BOT 2025-02-02 11:57
<ChillerDragon> ye figured that out
11:57
<ChillerDragon> got it to build and pushed
11:58
<ChillerDragon> but imo its not very nice
Avatar
GitHub BOT 2025-02-02 15:15
Supersedes #298
@heinrich5991 Can the master bans be moved to it's own file, so I can include it part of the master-server rules webpage?
Otherwise I can just copy paste the banlist from the file, but requires manual edits in the ddnet-web repo everytime we add a new server to it.
Avatar
@TsPiggy Any idea why the index would be wrong in merge.py even though I have total_tile_x and total_tile_y set correctly?
16:25
Clearly I'm doing something wrong. Maybe the screenshot dimensions on macOS are wrong because the borders of the application somehow matter?
16:25
This is with screenshot_batch 500 320 and: total_tile_x = 77 total_tile_y = 90 tile_x = total_tile_x tile_y = total_tile_y source_w = 1920 source_h = 1080 offset_x = 500 offset_y = 320 crop_left = 0 crop_top = 0 feather_radius = 100
16:44
e4d2618 Master server rules - murpii 252d780 Merge pull request #314 from murpii/master-server-rules - def-
Avatar
GitHub BOT 2025-02-02 17:05
7e401bc Remove png include dirs from server - ChillerDragon 783f2e2 Merge pull request #9639 from ChillerDragon/pr_no_png_in_server - def-
Avatar
ws-client BOT 2025-02-02 17:30
<ChillerDragon> ohno did #9638 get stale? i was speedrunning feedback
Avatar
ChillerDragon BOT 2025-02-02 17:30
omg where chilerbot go #7777
Avatar
chillerbot2 BOT 2025-02-02 17:30
How much do we want to support moddability in the DDNet codebase? Note that this doesn't talk about the network protocol but about the actual code.
Avatar
ws-client BOT 2025-02-02 17:30
<ChillerDragon> #7777
17:30
<ChillerDragon> ???
Avatar
Jupstar ✪ 2025-02-02 17:31
what is your problem again chiller
17:31
your bot responded correctly
Avatar
ws-client BOT 2025-02-02 17:31
<ChillerDragon> it ignored #9638
17:31
<ChillerDragon> from webchat
Avatar
Jupstar ✪ 2025-02-02 17:31
it only works from irc
Avatar
ws-client BOT 2025-02-02 17:32
<ChillerDragon> rude
Avatar
Jupstar ✪ 2025-02-02 17:32
or matrix
17:32
you probably checked "is name == chillerdragon"
Avatar
ChillerDragon BOT 2025-02-02 17:32
``if (!isBridge) {
17:33
omg paste is hard
Avatar
ws-client BOT 2025-02-02 17:36
<ChillerDragon> oh jupstar since you are here can u merge my pr
17:36
<ChillerDragon> i can not emotionally handle another pr thats stale for months
Avatar
Jupstar ✪ 2025-02-02 17:49
#9638
Avatar
this allows writing tests for things like gameworld, gameserver, character, player and so on. Needed for: #9386 (comment)
Avatar
Jupstar ✪ 2025-02-02 17:50
too much activity from other devs
17:50
dont want to deal with that xD
Avatar
ws-client BOT 2025-02-02 18:32
<ChillerDragon> fair
18:33
<ChillerDragon> but i responded to all ._.
18:33
<ChillerDragon> prs is like missing people
18:33
<ChillerDragon> if they dont get merged within 74 hours they are probably already dead
Avatar
that's a quick way to ruin a codebase
18:45
nothing should escape proper review just so we meet some arbitrary timeline
Avatar
ws-client BOT 2025-02-02 19:03
<ChillerDragon> @Davide should this open a client? http://45.141.57.52/
Avatar
it does this
Avatar
ws-client BOT 2025-02-02 19:14
<ChillerDragon> do the buttons do something for u?
Avatar
Avatar
ws-client
<ChillerDragon> do the buttons do something for u?
it opens ddnet client
19:23
when it tries to join i get sent to main menu
Avatar
ws-client BOT 2025-02-02 19:24
<ChillerDragon> hrm doesnt do anything for me ._,
Avatar
GitHub BOT 2025-02-02 19:35
Ubuntu 20.04 runners will fully stop working April 1 with some brownouts in March. See https://github.blog/changelog/2025-01-15-github-actions-ubuntu-20-runner-image-brownout-dates-and-other-breaking-changes/

Checklist

  • [ ] Tested the change ingame
  • [ ] Provided screenshots if it is a visual change
  • [ ] Tested in combination with possibly related configuration options
  • [ ] Written a unit test (especially base/) or added coverage to integration test
  • [ ] Considered possibl...
Avatar
PRO_Gaming1921 2025-02-02 20:29
Checklist Tested the change ingame Provided screenshots if it is a visual change Tested in combination with possibly related configuration options Written a unit test (especially base/) or add...
20:30
@Robyt3 it should be done. always helped me with this one👍
Avatar
MilkeeyCat 2025-02-02 20:30
maybe name a commit better?
Avatar
that doesn't look correct
Avatar
MilkeeyCat 2025-02-02 20:31
14 files changed pepeH
Avatar
Avatar
MilkeeyCat
maybe name a commit better?
Koll Potato 2025-02-02 20:32
xD
20:32
commit squash commits
Avatar
Do I have to merge #9640 by bypassing restrictions? Somehow Github wants an non-existent CI run to pass
Avatar
hi melon
Avatar
maybe just temporarily disable the 20.04 build or update the rules temporarily so 20.04 isn't needed to merge
Avatar
hi 🍈
20:40
13af21d Switch from Ubuntu 20.04 to 22.04 in CI - Robyt3 e76c051 Merge pull request #9640 from Robyt3/CI-Ubuntu-22 - Robyt3
Avatar
Avatar
Robyt3
that doesn't look correct
PRO_Gaming1921 2025-02-02 20:45
isnt it correct?
20:45
works in game but maybe stupid
Avatar
look at the diff
Avatar
PRO_Gaming1921 2025-02-02 20:45
alr
20:45
did it via cmd
Avatar
it contains a lot more changes than yours
Avatar
what you did was accidentally pull master into your feature branch there are many ways you could recover from that, but they all require some git magic (edited)
Avatar
Avatar
meloƞ
what you did was accidentally pull master into your feature branch there are many ways you could recover from that, but they all require some git magic (edited)
github memo'ed 2 my dead prs killed that way xdd
Avatar
PRO_Gaming1921 2025-02-02 20:48
no clue how the squash works.
20:48
:)
Avatar
let me see if i can guide you through it in the easiest way possible git log -> shows the last commits and their hash, you want the hash from the last commit you did on your branch you'd then want to hard-reset the state of your feature branch via git reset --hard <commithash> then you'll force push, i guess you should force with lease to be a little bit safer git push --force-with-lease (edited)
20:51
that should theoretically reset the state of your PR - after that you can clean up your history by squashing it again
👍 1
Avatar
Avatar
meloƞ
let me see if i can guide you through it in the easiest way possible git log -> shows the last commits and their hash, you want the hash from the last commit you did on your branch you'd then want to hard-reset the state of your feature branch via git reset --hard <commithash> then you'll force push, i guess you should force with lease to be a little bit safer git push --force-with-lease (edited)
PRO_Gaming1921 2025-02-02 21:01
21:01
just showing that
Avatar
isnt there a way to fetch more commits
Avatar
the problem is he overwrote the history by forcepushing the rebase
Avatar
well that cant be good
21:05
any GG(Git Gods) here?
21:06
might be easier to just start from scratch
Avatar
it was like 5 LoC - not hard to just create new :p
Avatar
Avatar
meloƞ
it was like 5 LoC - not hard to just create new :p
PRO_Gaming1921 2025-02-02 21:07
yea I have most of the code saved
21:07
beginner mistakejustatest
Avatar
MainView.HSplitTop(20.0f, &Button, &MainView); if(DoButton_CheckBox(&g_Config.m_ClShowfps, Localize("Show FPS"), g_Config.m_ClShowfps, &Button)) g_Config.m_ClShowfps ^= 1; GameClient()->m_Tooltips.DoToolTip(&g_Config.m_ClShowfps, &Button, Localize("Renders your frame rate in the top right"));
21:08
no worries owo - happened to me aswell https://github.com/ddnet/ddnet/pull/9231 as you can see in this PR - i managed to fully remove the PR (0 commits, 0 files changed) kekw
i forgot to remove the test ENV variables i didnt intend to push - i also added a small comment to explain the usecase for explicitly looking through the /nix/store. Thanks for noticing @heinrich59...
Avatar
Avatar
meloƞ
no worries owo - happened to me aswell https://github.com/ddnet/ddnet/pull/9231 as you can see in this PR - i managed to fully remove the PR (0 commits, 0 files changed) kekw
git god
Avatar
one of my worst moments on git, 2 lines of code kekw
😂 1
21:10
i forcepushed it.. 3 times
21:11
Aware thats one way to close the PR @PRO_Gaming1921 kek - you couldve just made a new branch!
💀 2
Avatar
Avatar
meloƞ
Aware thats one way to close the PR @PRO_Gaming1921 kek - you couldve just made a new branch!
PRO_Gaming1921 2025-02-02 21:11
always fault
21:11
justatest
Avatar
wasnt me
Avatar
always always fault
f3 1
kek 1
Avatar
PRO_Gaming1921 2025-02-02 21:33
21:33
@meloƞ why doesnt it show?
21:33
its swedish translate
Avatar
do a clean rebuild
Avatar
GitHub BOT 2025-02-02 21:42

Checklist

  • [x] Tested the change ingame
  • [x] Provided screenshots if it is a visual change
  • [ ] Tested in combination with possibly related configuration options
  • [ ] Written a unit test (especially base/) or added coverage to integration test
  • [ ] Considered possible null pointers and out of bounds array indexing
  • [ ] Changed no physics that affect existing maps
  • [ ] Tested the change with [ASan+UBSan or valgrind's memcheck](https://github.com/ddnet/ddnet/#using-ad...
Avatar
PRO_Gaming1921 2025-02-02 21:43
everything should be fixed now. I did a swedish translation
21:43
ty for help. this new for me👍
Avatar
GG(Git God)
Avatar
Avatar
GitHub
Click to see attachment 🖼️
next time keep in mind 1 pr 1 feature but probably its fine for the first time
21:49
maintainers will decide your faith :]
Avatar
it was accepted already, and having the translation in it doesnt hurt, tho.. we kinda need you to do a squash again because we're supposed to change the translation files header kekw (edited)
Avatar
does anyone know of some kind of ascii art generator that can generate it even based on variable width font?
21:55
im cooked im searching for it like 3 days and tried to mess up with 2-3 projects that claim they can do this and end up doing the same ascii art for any other font
Avatar
Avatar
zhn
next time keep in mind 1 pr 1 feature but probably its fine for the first time
PRO_Gaming1921 2025-02-02 21:56
1 pr 1?
Avatar
Avatar
meloƞ
it was accepted already, and having the translation in it doesnt hurt, tho.. we kinda need you to do a squash again because we're supposed to change the translation files header kekw (edited)
PRO_Gaming1921 2025-02-02 21:57
another squash???? hell naw
Avatar
Avatar
PRO_Gaming1921
1 pr 1?
per pr per feature
👍 1
Avatar
Avatar
zhn
im cooked im searching for it like 3 days and tried to mess up with 2-3 projects that claim they can do this and end up doing the same ascii art for any other font
i had a good website
22:21
but i fogor
Avatar
Avatar
meloƞ
it was accepted already, and having the translation in it doesnt hurt, tho.. we kinda need you to do a squash again because we're supposed to change the translation files header kekw (edited)
PRO_Gaming1921 2025-02-02 22:23
Could you give the commands again so always doesnt always mess everything up again as always
Avatar
git rebase -i HEAD~{number of commits you want to put together}
22:25
set the first line to pick the other lines to squash or s
22:25
after saving the opened prompt, another one will open with all commit messages, you can just keep them for history - or change them up then you need to overwrite your git history, you do that with git push --force or git push --force-with-lease (edited)
Avatar
pin it
Avatar
PRO_Gaming1921 2025-02-02 22:25
I fix it tomorrow👍 ty man. What would i do without you
Avatar
Avatar
Teero
pin it
i dont pin stuff in channels outside of #showroom or #town-hall - i think important stuff should be pinned by the respective maintainers :p
Avatar
@Learath2 pin it!
Avatar
Avatar
PRO_Gaming1921
Could you give the commands again so always doesnt always mess everything up again as always
nouis
gigachad 1
Avatar
hey chillerdragon are you there
Avatar
Avatar
always
i had a good website
saddo
Avatar
Avatar
zhn
saddo
Create graphic ASCII text art entering your input. The program will display your text in many styles instantly.
22:47
this i think
22:47
i forgot
22:47
ngl
Avatar
thanks for your support but it's not the thing i was searching for xd
22:57
i need generator that will adjust to any variable width font
22:57
seems like no one did it
Avatar
Avatar
deen
@TsPiggy Any idea why the index would be wrong in merge.py even though I have total_tile_x and total_tile_y set correctly?
offsetx and offsety are pixel values iirc, the merger didn't take camera zoom (based on the aspect ratio) into account. i would just use smaller tiles and guess and find an offset then commit to merge the final big image using the same value (edited)
23:00
you could also grab a few screenshots and manually line them up in photoshop or something to get the offset
Avatar
chillerdragon BOT 2025-02-02 23:17
@barlas: it’s unlikely that you catch me while I have this chat open. Just ask away.
Avatar
i wanna make a map for your score saved fng server
23:18
actually working on it rn
Avatar
chillerdragon BOT 2025-02-02 23:19
Oof sounds like work. I don’t enjoy being picky but I am. Don’t put in too much work I might not use the map ._.
Avatar
ok then thanks
Avatar
chillerdragon BOT 2025-02-02 23:21
You can also create issues here to discuss the map so we don’t have to abuse this ddnet channel https://github.com/ddnet-insta/fng-maps-06
Teeworlds fng maps for 0.6 connections. Contribute to ddnet-insta/fng-maps-06 development by creating an account on GitHub.
Avatar
Avatar
zhn
i need generator that will adjust to any variable width font
nevermind ddnet client renders font glyphs of the same font differently depending on screen resolution
23:35
will not be consistent anyway
Exported 190 message(s)
Timezone: UTC+0