src/game/editor/editor.cpp:4228
, the padding for Ui()->DoPopupMenu() doesn't change when it's selecting a game layer, so it's massive when it shouldn't becryhard.pcap
from 2018 | ^
/home/runner/work/ddnet/ddnet/src/base/log.cpp:526:17: error: 'atomic_load_explicit<ILogger>' is deprecated: use 'std::atomic<std::shared_ptr<T>>' instead [clang-diagnostic-deprecated-declarations,-warnings-as-errors]
526 | pLogger = std::atomic_load_explicit(&m_pLogger, std::memory_order_relaxed);
ddnet/src/game/server/entities/character.cpp:23:1: error: pointer arithmetic on polymorphic object of type 'CCharacter' can result in undefined behavior if the dynamic type differs from the pointer type [bugprone-pointer-arithmetic-on-polymorphic-object,-warnings-as-errors]
23 | MACRO_ALLOC_POOL_ID_IMPL(CCharacter, MAX_CLIENTS)
| ^
/data2/edgar/ddnet/src/game/alloc.h:66:20: note: expanded from macro 'MACRO_ALLOC_POOL_ID_IMPL'
66 | dbg_assert(Id == (POOLTYPE *)pObj - (POOLTYPE *)gs_PoolData##POOLTYPE, "invalid id"); \
| ~~~~~~~~~~~~~~~~~^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
/data2/edgar/ddnet/src/base/system.h:82:38: note: expanded from macro 'dbg_assert'
82 | #define dbg_assert(test, msg) assert(test)
| ~~~~~~~^~~~~
/usr/include/assert.h:100:27: note: expanded from macro 'assert'
100 | (static_cast <bool> (expr) \
| ^~~~
CServer::DistinctClientCount
function a check for the address being nullptr
was missing in the inner loop. Before #9591 this was comparing addresses from uninitialized memory instead. Du...sv_dnsbl_vote 1
since DistinctClientCount
is only used onceRUS2:/home/teeworlds/servers/core_crash
ClientIngame(i)
being gonem_State == STATE_EMPTY
net_addr_comp_noport
ClientIngame
check should ensure CClient::STATE_INGAME
, otherwise the address entry in apAddresses
is nullptr
which is checked in the second loop(gdb) print GIT_SHORTREV_HASH
$10 = 0x564e54c02b5d "9f306fcc712de032"
sv_dnsbl_vote
always enabled?net_addr_comp_noport
doesn't crash onmem_comp
on it* 16
(edited)