Guild icon
DDraceNetwork
Development / developer
Development discussion. Logged to https://ddnet.org/irclogs/ Connected with DDNet's IRC channel, Matrix room and GitHub repositories — IRC: #ddnet on Quakenet | Matrix: #ddnet-developer:matrix.org GitHub: https://github.com/ddnet
Between 2025-01-18 00:00 and 2025-01-19 00:00
Avatar
@deen what would constitute a master-server ban?
Avatar
Avatar
gaypidor
@deen what would constitute a master-server ban?
https://www.teeworlds.com/?page=docs&wiki=rules/server_rules anything here + Faking another server + Hosting illegal content + Advertising bots + Our discretion (e.g. just because I forgot to list something here doesn't mean you can't be ever banned for it, new rules are applied to all servers immediately)
10:01
Honestly, if you even have to think about the rules for the master server, you probably are doing something wrong
Avatar
Avatar
Learath2
Honestly, if you even have to think about the rules for the master server, you probably are doing something wrong
I’m not thinking about it because I break rules, there’s a guy stealing my maps and claiming he made them without proper credit, so I’m investigating what I can do about it.
10:04
I’m thinking he’s doing it to everyone in order to replicate the success.
10:05
He does indeed break a single rule outlined in the Wiki. He hosts a large amount of servers, many of which has little to no players.
Avatar
Avatar
gaypidor
I’m not thinking about it because I break rules, there’s a guy stealing my maps and claiming he made them without proper credit, so I’m investigating what I can do about it.
Hm, we don't really get involved in copyright disputes, especially since a lot of maps are very very derivative
Avatar
Avatar
Learath2
Hm, we don't really get involved in copyright disputes, especially since a lot of maps are very very derivative
I get that, but that’s not the concern I’m addressing, I’m looking at the network from rule-breaking standpoint. Two birds with one stone, you know.
10:08
I myself modify the existing maps, but I do not claim I made them. (Unless heavily modified) (edited)
Avatar
Well you can create an admin mail ticket if you think they are breaking a rule and we can take a look
Avatar
Avatar
Learath2
Well you can create an admin mail ticket if you think they are breaking a rule and we can take a look
Yeah, thanks. I will create a formal complaint in case I fail to establish a direct communication line with the network owner.
Avatar
GitHub BOT 2025-01-18 11:29
This pull request gives #9292 a compatibility for players who don't like spectator cursor Now the spectator cursor is disabled as default. If anyone like it, the spectator cursor could be enabled in HUD settings.

Checklist

  • [ ] Tested the change ingame
  • [ ] Provided screenshots if it is a visual change
  • [ ] Tested in combination with possibly related configuration options
  • [ ] Written a unit test (especially base/) or added coverage to integration test
  • [ ] Considered po...
Avatar
GitHub BOT 2025-01-18 11:53
Replace mostly unused bool return value with assertion to ensure the address has a valid type instead of outputting unknown type as the address. Also test the assertion failure by changing the existing test case to death tests. See https://google.github.io/googletest/advanced.html#death-tests for details. The death test names must end with DeathTest so GoogleTest runs these test cases before all other tests. Fix assertion failure in client due to previous server address being inva...
Avatar
GitHub BOT 2025-01-18 12:06
You can view this files: https://github.com/TeeGlue/teeworlds/blob/teeglue/src/engine/server/netconverter.cpp (sevendown) Although we currently have only a server-side implementation, this translation can be rapidly improved. The most critical issue at the moment is still how to first hand over the packets received to the network translator for translation. So that we can converge all the translation into network translator, making sixup code part more independent. (Maybe this needs to refa...
Avatar
GitHub BOT 2025-01-18 13:00
ddd3e26 Minor refactoring of net_addr_str function - Robyt3 b917b41 Merge pull request #9548 from Robyt3/Base-net_addr_str-Refactoring - heinrich5991
Avatar
GitHub BOT 2025-01-18 14:24
The client should look at the params field the server sends. And if it contains a list of strings those should be added to the tab completion. https://github.com/ddnet/ddnet/blob/b917b410ddc548d4d2817e136cb0a68a7847e30b/src/game/server/gamecontext.cpp#L3820
Avatar
ChillerDragon BOT 2025-01-18 15:00
the new assets menu is only for ddrace?
15:01
or can users pick custom fng assets?
Avatar
Jupstar ✪ 2025-01-18 15:02
wat? xd
15:02
new?
15:02
if u mean the assets tab and specifically mean entities that we have since like 6 years, then yes it can include fng entities too
Avatar
ChillerDragon BOT 2025-01-18 15:05
to me it feels new
15:05
but ye its been there for a while
Avatar
Jupstar ✪ 2025-01-18 15:06
anyway, create a dir, instead of a png with your asset name, inside the dir, put ddnet.png fng.png etc.
Avatar
ChillerDragon BOT 2025-01-18 15:07
ah i see
15:07
nice
15:09
thanks
Avatar
Koll Potato 2025-01-18 15:47
we are so back
15:47
my very own snapshot code is working
15:47
hell yeah
Avatar
ChillerDragon BOT 2025-01-18 16:29
snapchat developer
Avatar
hello darkness my old friend
Avatar
Jupstar ✪ 2025-01-18 16:59
depression kick
Avatar
GitHub BOT 2025-01-18 17:00

Checklist

  • [ ] Tested the change ingame
  • [ ] Provided screenshots if it is a visual change
  • [ ] Tested in combination with possibly related configuration options
  • [ ] Written a unit test (especially base/) or added coverage to integration test
  • [ ] Considered possible null pointers and out of bounds array indexing
  • [ ] Changed no physics that affect existing maps
  • [ ] Tested the change with [ASan+UBSan or valgrind's memcheck](https://github.com/ddnet/ddnet/#using-addres...
Avatar
GitHub BOT 2025-01-18 17:10
b335406 Fix assert in statboard - ChillerDragon 00977e7 Merge pull request #9552 from ChillerDragon/pr_statassrt - Robyt3
Avatar
i'm thinking of just nuking the auto spec cam and just render the cursor screenspace with spectating dyncam but no zoom.
17:32
that would probably annoy less people. i made auto spec cam specifically to make cursor visible on screen by default. since that doesn't work, maybe changing the spec cursor itself to be more visible is better.
Avatar
Avatar
TsPiggy
i'm thinking of just nuking the auto spec cam and just render the cursor screenspace with spectating dyncam but no zoom.
nonono pls
Avatar
finally i can see how ppl play without any external tools i.e stream service
Avatar
how about i don't nuke auto spec cam but make spec cursor behave differently with auto spec cam on or off. since it seems like people want it off by default
17:39
screenspace without auto. worldspace with auto.
17:40
probably not fully screenspace too. just when your zoom is closer than the player you are spectating.
17:40
so cursor can be visible by default even without auto
17:41
i really want the spec cursor experience to be as obvious as possible so as soon as you see it, you can decide whether to turn it off. instead of be annoyed when it show up for a player but not (it's just offscreen) for another.
Avatar
Avatar
TsPiggy
that would probably annoy less people. i made auto spec cam specifically to make cursor visible on screen by default. since that doesn't work, maybe changing the spec cursor itself to be more visible is better.
♂S1mple♂ 2025-01-18 17:42
it's stupid to be annoyed at something that you can disable in 1 click and everyone else enjoys
Avatar
should we poll for whether people are enjoying auto spec cam too
17:43
kek
Avatar
♂S1mple♂ 2025-01-18 17:43
i think that poll was for both?
Avatar
it should be but murpi made is seem like it was for spec cursor only, to me at least. the disscussions are leaning towards spec cursor on, auto off. which defeat the original purpose of auto spec cam. so i'm thinking alternative ways to keep auto off but still make spec cursor do what i originally intended to do. (edited)
17:47
i do think if auto is so easy to turn off it shouldn't really be a problem to leave it as default but i don't think juppey would let that pass
Avatar
master server working fine? i only get 440 servers
Avatar
Avatar
fokkonaut
master server working fine? i only get 440 servers
Avolicious 2025-01-18 17:49
No, they seem broken
Avatar
i see
Avatar
Avatar
TsPiggy
i do think if auto is so easy to turn off it shouldn't really be a problem to leave it as default but i don't think juppey would let that pass
♂S1mple♂ 2025-01-18 17:51
you probably could just leave that already made setting to off by default, i think that's fair
17:51
it looks pretty decent off as is right now
feelsbadman 1
Avatar
catJAM maybe
Avatar
Avatar
♂S1mple♂
it looks pretty decent off as is right now
it's not :<
Avatar
Avatar
zhn
it's not :<
♂S1mple♂ 2025-01-18 17:52
why
Avatar
Avatar
fokkonaut
master server working fine? i only get 440 servers
+++
Avatar
♂S1mple♂ 2025-01-18 17:52
you still can see where cursor is directed
Avatar
i mean it would look ok if most people uses zoom 10 or 9
Avatar
Avatar
♂S1mple♂
you still can see where cursor is directed
i want to see how player plays :P
Avatar
the clamp to screen edge thing is not really that obvious with further zoom
Avatar
Avatar
zhn
i want to see how player plays :P
♂S1mple♂ 2025-01-18 17:53
you will be able to click this setting back on
17:53
in 1 click
17:53
leave off by default to those who complain (edited)
Avatar
it's off by default anyway, isn't it
Avatar
ye it is currently
17:54
which is actually unintended lol
17:54
i PRed it wrong
kek 1
17:54
either way there should be other solutions to pull cursor back so your screen without auto. i think would be worth it to explore
Avatar
Avatar
♂S1mple♂
leave off by default to those who complain (edited)
♂S1mple♂ 2025-01-18 17:54
idk dudes going to complain at anything now, even really neat features
17:55
who didn't dream to see cursors of other players
17:55
like fr
Avatar
or i could also just pr auto to default on and just quit so i don't hear the complains
Avatar
It's not a good thing to have a single in-game list, it's better to have alternative lists.
Avatar
Avatar
Kaya
It's not a good thing to have a single in-game list, it's better to have alternative lists.
we have 4 masters, wdym
Avatar
i think they mean there should be a way for client to modify what master to check. like a third party one.
Avatar
Avatar
TsPiggy
or i could also just pr auto to default on and just quit so i don't hear the complains
♂S1mple♂ 2025-01-18 17:57
add read-a-mind feature so that game reads mind of players and sets setting as they want
Avatar
Avatar
zhn
we have 4 masters, wdym
not that shape I'm talking about things like gametracker
Avatar
♂S1mple♂ 2025-01-18 17:57
cuz it seems to hard
Avatar
ok im lost too
Avatar
Avatar
Kaya
not that shape I'm talking about things like gametracker
what
17:58
i don't get it
Avatar
i don't think people get what auto is actually for. it wasn't really just to let you see cameras for fun. it really was just to make cursor more visible when i made it. but i do think that feature is way pass my intention tho, people use it for different reasons and people hate it for different reasons too.
18:00
i just would prefer to achieve my goal of making spec cursor more visible without auto if auto is off by default. (edited)
Avatar
@heinrich5991 do you know what happened to masters? they handle only 439 servers for whatever reason
Avatar
Avatar
zhn
@heinrich5991 do you know what happened to masters? they handle only 439 servers for whatever reason
i get the following error: 2025-01-18 19:02:58 I register/6/ipv4: registering... 2025-01-18 19:02:58 E register/6/ipv4: ERROR: the master server reports that clients can not connect to this server. 2025-01-18 19:02:58 E register/6/ipv4: ERROR: configure your firewall/nat to let through udp on port 8303.
18:03
sounds to me like the server that validates a server is getting attacked or is down
Avatar
Avatar
zhn
@heinrich5991 do you know what happened to masters? they handle only 439 servers for whatever reason
440*, 439 is id of last one xd
Avatar
Avatar
Swarfey
sounds to me like the server that validates a server is getting attacked or is down
masters should ACK themselves afair
Avatar
iirc there was another server that would ping it itself to make sure it exists
18:04
well maybe that changed since http masterservers
18:04
but it would explain why only ddnet & kog servers are being shown (edited)
18:05
since they are probably whitelisted already id assume. maybe im wrong
Avatar
seems like it
Avatar
Avatar
Swarfey
iirc there was another server that would ping it itself to make sure it exists
*to make sure a port is actually forwarded (edited)
Avatar
http master still ping it iirc.
Avatar
DDraceNetwork, a free cooperative platformer game. Contribute to ddnet/ddnet development by creating an account on GitHub.
Avatar
that challenge also doesn't work in china a lot of the time i think. the old master worked fine before
18:08
a lot of chn servers need to ask to be whitelisted
18:09
i wish im not in bed so i can witness this master issue unfold
18:09
deen_star
Avatar
seems only ddnet and china can register xd
Avatar
seems really interesting that it just died
Avatar
it didn't, just last update broke it
18:10
i should've checked i guess
18:11
meanwhile i'm here thinking: it's not even 2038 yet
Avatar
I leave the house. It breaks...
Avatar
greenthing the maintenance curse
Avatar
I was literally at home the entire day
Avatar
anyone can help me with cfg files?
Avatar
@Jupstar ✪ do i need to have any other files in ddnet-editor-server? hosting doesnt seem to work on vps root@ddnet-sv:~/ddnet-rs# cargo run --release -p editor-server -- ~/.config/ddnet-editor-server/testouly.twmap mapouly 8303 warning: /root/ddnet-rs/Cargo.toml: file `/root/ddnet-rs/src/lib.rs` found to be present in multiple build targets: * `lib` target `ddnet_rs` * `bin` target `ddnet-rs` Finished `release` profile [optimized] target(s) in 0.93s Running `target/release/editor-server /root/.config/ddnet-editor-server/testouly.twmap mapouly 8303` [2025-01-18T18:39:30Z INFO fs] Found config dir in "/root/.config/ddnet-editor-server" ALSA lib confmisc.c:855:(parse_card) cannot find card '0' ALSA lib conf.c:5204:(_snd_config_evaluate) function snd_func_card_inum returned error: No such file or directory ALSA lib confmisc.c:422:(snd_func_concat) error evaluating strings ALSA lib conf.c:5204:(_snd_config_evaluate) function snd_func_concat returned error: No such file or directory ALSA lib confmisc.c:1342:(snd_func_refer) error evaluating name ALSA lib conf.c:5204:(_snd_config_evaluate) function snd_func_refer returned error: No such file or directory ALSA lib conf.c:5727:(snd_config_expand) Evaluate error: No such file or directory ALSA lib pcm.c:2721:(snd_pcm_open_noupdate) Unknown PCM default [2025-01-18T18:39:30Z INFO editor_server] Cert hash: e5693ee06f02d365cdd38bac70b003a8166f7f5e89f61a0489ccf187fdde0bb4
Avatar
Avatar
bencie
@Jupstar ✪ do i need to have any other files in ddnet-editor-server? hosting doesnt seem to work on vps root@ddnet-sv:~/ddnet-rs# cargo run --release -p editor-server -- ~/.config/ddnet-editor-server/testouly.twmap mapouly 8303 warning: /root/ddnet-rs/Cargo.toml: file `/root/ddnet-rs/src/lib.rs` found to be present in multiple build targets: * `lib` target `ddnet_rs` * `bin` target `ddnet-rs` Finished `release` profile [optimized] target(s) in 0.93s Running `target/release/editor-server /root/.config/ddnet-editor-server/testouly.twmap mapouly 8303` [2025-01-18T18:39:30Z INFO fs] Found config dir in "/root/.config/ddnet-editor-server" ALSA lib confmisc.c:855:(parse_card) cannot find card '0' ALSA lib conf.c:5204:(_snd_config_evaluate) function snd_func_card_inum returned error: No such file or directory ALSA lib confmisc.c:422:(snd_func_concat) error evaluating strings ALSA lib conf.c:5204:(_snd_config_evaluate) function snd_func_concat returned error: No such file or directory ALSA lib confmisc.c:1342:(snd_func_refer) error evaluating name ALSA lib conf.c:5204:(_snd_config_evaluate) function snd_func_refer returned error: No such file or directory ALSA lib conf.c:5727:(snd_config_expand) Evaluate error: No such file or directory ALSA lib pcm.c:2721:(snd_pcm_open_noupdate) Unknown PCM default [2025-01-18T18:39:30Z INFO editor_server] Cert hash: e5693ee06f02d365cdd38bac70b003a8166f7f5e89f61a0489ccf187fdde0bb4
Jupstar ✪ 2025-01-18 18:42
well since it doesnt crash, i assume it works and the problem is somehow port related
18:42
but i can quickly check, if u pm me your vps ip (edited)
Avatar
hey guys
Avatar
Avatar
Shibuya
hey guys
Hellou :3
Avatar
can someone help me? again?
18:47
i opened ddnet and normally, it would appear brazil server to me
18:47
but today it didn't apeared
Avatar
We are having technical issues
Avatar
Ohhh, thank you
18:47
do you know when they'll come back?
Avatar
Avatar
Learath2
I was literally at home the entire day
xD
Avatar
Avatar
bencie
@Jupstar ✪ do i need to have any other files in ddnet-editor-server? hosting doesnt seem to work on vps root@ddnet-sv:~/ddnet-rs# cargo run --release -p editor-server -- ~/.config/ddnet-editor-server/testouly.twmap mapouly 8303 warning: /root/ddnet-rs/Cargo.toml: file `/root/ddnet-rs/src/lib.rs` found to be present in multiple build targets: * `lib` target `ddnet_rs` * `bin` target `ddnet-rs` Finished `release` profile [optimized] target(s) in 0.93s Running `target/release/editor-server /root/.config/ddnet-editor-server/testouly.twmap mapouly 8303` [2025-01-18T18:39:30Z INFO fs] Found config dir in "/root/.config/ddnet-editor-server" ALSA lib confmisc.c:855:(parse_card) cannot find card '0' ALSA lib conf.c:5204:(_snd_config_evaluate) function snd_func_card_inum returned error: No such file or directory ALSA lib confmisc.c:422:(snd_func_concat) error evaluating strings ALSA lib conf.c:5204:(_snd_config_evaluate) function snd_func_concat returned error: No such file or directory ALSA lib confmisc.c:1342:(snd_func_refer) error evaluating name ALSA lib conf.c:5204:(_snd_config_evaluate) function snd_func_refer returned error: No such file or directory ALSA lib conf.c:5727:(snd_config_expand) Evaluate error: No such file or directory ALSA lib pcm.c:2721:(snd_pcm_open_noupdate) Unknown PCM default [2025-01-18T18:39:30Z INFO editor_server] Cert hash: e5693ee06f02d365cdd38bac70b003a8166f7f5e89f61a0489ccf187fdde0bb4
why it needs sound and alsa
Avatar
Avatar
Learath2
I leave the house. It breaks...
stop leaving the fucking house
Avatar
you jxsl
Avatar
why do you do that to us
18:56
xd
Avatar
let the man walk
Avatar
he can walk in da house
Avatar
[MOD] *MOD (Page 1) — Modifications — Teeworlds Forum — Everything Teeworlds!
❓ 1
18:58
[MOD] Tee-Strike (Page 1) — Modifications — Teeworlds Forum — Everything Teeworlds!
Avatar
Avatar
jxsl13
stop leaving the fucking house
I won't do it again
👍 1
justatest 1
Avatar
masters fixed, thanks to whoever who did this :*
🔥 1
Avatar
it's getting better, dunno if fully fixed
19:27
do you roughly get 1k+ servers?
Avatar
Avolicious 2025-01-18 19:27
1.7k
Avatar
hm, some Simply servers are not visible online
19:33
even restarting did not help (edited)
19:39
weirdly 2 servers are visible, a third that is based on the same mod is not visible and three 0.7 servers are also not visible. (edited)
Avatar
Only 0.7 servers are not visible
Avatar
Avatar
jxsl13
Only 0.7 servers are not visible
I restarted the masters a couple times, while messing around with it, is it still not working for 0.7 servers?
Avatar
Avatar
Learath2
I restarted the masters a couple times, while messing around with it, is it still not working for 0.7 servers?
I only see few 0.7 servers when filtering for address tw, somehow some DDNet servers have 0.7 addresses now?
20:21
Weird, the latter issue is gone. I only see 4 0.7 servers now
Avatar
I re-enabled the port forwarding ping
Avatar
Avatar
Learath2
I restarted the masters a couple times, while messing around with it, is it still not working for 0.7 servers?
can't see them, yet: tw-0.7+udp://185.254.97.173:8303 tw-0.7+udp://185.254.97.173:8306 tw-0.7+udp://185.254.97.173:8304
Avatar
185.254.97.173:8303 is not a DDraceNetwork or Community server.
Avatar
I wonder if the legacy collector broke too
20:30
These probably register with the old master
Avatar
hm, might be the case
20:35
master1.teeworlds.com 51.161.153.103:8283 master2.teeworlds.com 51.89.37.201:8283 master3.teeworlds.com 161.35.22.91:8283 master4.teeworlds.com 49.12.97.180:8283
20:35
my masters.cfg for 0.7
20:36
[2025-01-18 21:23:00][register]: chose 'master1.teeworlds.com' as master, sending heartbeats
20:38
all of them registered with master1
20:41
servers are visible online
20:41
thanks (Y) (edited)
Avatar
Avatar
jxsl13
thanks (Y) (edited)
Celebrate
🚀 1
🇸 1
🇹 1
🇦 1
🇾 1
🅰️ 1
TT 1
🇭 1
🇴 1
🇲 1
🇪 1
20:52
any ideas how to fix this pipeline?
Avatar
Avatar
fokkonaut
any ideas how to fix this pipeline?
Adjust googletest downloading like on DDNet and thereby update to more recent version of googletest, search for lines if(NOT(GTEST_FOUND) AND DOWNLOAD_GTEST) in both CMakeLists.txt files
Avatar
thank you
20:58
it worked
Avatar
where is the screenshot directory stored in the code
Avatar
You can search the code using a regex like ".*?screenshots.*?" to find strings containing the name
Avatar
Avatar
Robyt3
You can search the code using a regex like ".*?screenshots.*?" to find strings containing the name
using what
Avatar
For example grep or Sublime Text
21:01
Notepad++ can also do it
Avatar
on visual studio?
21:02
think thats correct
Avatar
There's probably a way, yeah
Avatar
it is so slow
21:02
and there is no wway to exclude
21:03
and its just going through translations
21:03
nouis
21:03
hate this
Avatar
you can exclude directories also afair
21:03
don't know how it's done in visual studio tho
Avatar
the only options
21:04
where are all the console commands located
21:04
or wwell the code that handles them
Avatar
Only search the src folder ideally
21:05
Also, the "" are part of the regex
21:05
It should only match the text inside quotes
Avatar
Avatar
always
where are all the console commands located
Console commands are registered in a lot of files, usually where the command behavior is implemented
Avatar
i found auto screenshot
21:08
its in client.cpp if anyone needs in the future
Avatar
@Robyt3 is this valid to suppress a warning about pointer addition comparison to null?
Avatar
This doesn't make sense to me
Avatar
the warning disappeared, i am just afraid i broke somthing because i have no idea what im doing xD
21:15
pPort is a const char*
Avatar
This check is always true if you cast the pointer to an integer zero and add 2
Avatar
Also makes no sense to me, should just check off == 0 instead of src + off == 0
Avatar
yea true
21:17
anyways, how do i make sense of this
21:17
just remove the pport + 2 check? idk.
21:17
i felt it was useful back then
21:18
it's basically parsing the config variable for a specific number in this format: 1:8303,2:8304,3....
21:18
pls dont hate me for the way i made that thing
Avatar
Avatar
fokkonaut
just remove the pport + 2 check? idk.
The condition should always evaluate to true, so you can remove the other branch
21:21
Also, this + 2 probably breaks if the switch number is greater than 9
21:21
You should use str_length(aBuf) instead
Avatar
I think it was a check for when someone types 1:8303,2:3:8304
Avatar
Avatar
Robyt3
You should use str_length(aBuf) instead
Yeah thought so
Avatar
Avatar
fokkonaut
I think it was a check for when someone types 1:8303,2:3:8304
no wait, for when it ends with 2: (edited)
Avatar
Ah, I see, yeah, the str_find already returns a pointer to the match position anyway
Avatar
hmm
21:24
what would you suggest
Avatar
int Port = pPort ? atoi(pPort + 2) : 0; I'd keep the existing + 2 since I don't know how it works and remove the redundant condition (edited)
21:26
pPort can still be nullptr if the string doesn't begin with the prefix
Avatar
oke ty
Avatar
Avatar
fokkonaut
@Robyt3 is this valid to suppress a warning about pointer addition comparison to null?
I think the intention was int Port = pPort && *(pPort + 2) != '\0' ? atoi(pPort + 2) : 0;
21:36
I don't quite remember if it is UB, but I guess whoever wrote it was concerned whether atoi("") is UB or not
21:38
(I don't think it is UB from what I remember, though cba to look at the standard rn)
21:40
I couldn't resist checking, it's not UB. 0 is guaranteed to be returned
Avatar
i see xd yeah i must have had some issue with atoi or smth
Avatar
Avatar
Learath2
I think the intention was int Port = pPort && *(pPort + 2) != '\0' ? atoi(pPort + 2) : 0;
yep
21:48
i think something had crashed
21:48
back then
Avatar
Avatar
fokkonaut
it's basically parsing the config variable for a specific number in this format: 1:8303,2:8304,3....
This kinda breaks with double digits as Robyt suggested. I would probably use str_token_get for this const char *tok; int port = 0, len = 0; while((tok = str_token_get(tok, ",", &len))) { if(str_startswith(tok, aBuf)) { port = atoi(tok + str_length(aBuf)); break; } }
21:49
I just typed it out in discord, might not be correct, but you get the gist of it
Avatar
lul, i just gave a shit about dd
Avatar
Avatar
Learath2
This kinda breaks with double digits as Robyt suggested. I would probably use str_token_get for this const char *tok; int port = 0, len = 0; while((tok = str_token_get(tok, ",", &len))) { if(str_startswith(tok, aBuf)) { port = atoi(tok + str_length(aBuf)); break; } }
thank you
21:49
thats looking good xd
Avatar
I wonder what sort of crack I was smoking while I made str_token_get what a nasty way of tokenizing a string
21:51
Who let me commit this? 😄
21:54
Ah, str_token_get is the internal interface
21:54
You want str_next_token which copies it into a buffer like any sane tokenizer
Avatar
Nameless Me 2025-01-18 22:03
chiller dragon, I would like to ask, is there a listing anywhere, of the settings available in ddnet-insta, I have the files, I have the server running, but I can't find out how to costimize, I was just wondering if there is a way I can see all the commands
Avatar
GitHub BOT 2025-01-18 22:05
cpp(1174): unknown NETADDR type 0 appears when joining dummy and then it crash, seems it happens due to #9548
Avatar
has anyone had serious flickering on linux ?
22:12
weirdly enough, it only starts after i click within the menu
Avatar
Avatar
Chairn
weirdly enough, it only starts after i click within the menu
wayland?
Avatar
works fine with opengl3 though
22:14
22:17
okay, seems to be more random than just backend
Avatar
hm, never had any flickering with x11 maybe update your gpu driver? - maybe it's just vulkan being badly supported by your iGPU
Avatar
looks like it uses the intel gpu rather than the nvidia one
22:17
wasn't there a menu option to change that ?
Avatar
in the graphics tab ingame
Avatar
doesn't show
22:21
only the one for opengl and vulkan
Avatar
Jupstar ✪ 2025-01-18 22:22
it only shows for vk
Avatar
GitHub BOT 2025-01-18 22:22
c1d182e Fix assert when using save_dry server command - Robyt3 b453784 Merge pull request #9553 from Robyt3/Server-dry_save-Assert-Fix - def-
Avatar
Jupstar ✪ 2025-01-18 22:23
opengl does not support that in their api
Avatar
Avatar
Chairn
Click to see attachment 🖼️
Jupstar ✪ 2025-01-18 22:23
new laptop? xd
Avatar
work laptop
22:23
yeah, now it shows because i switched to vk
22:23
and it crashed
22:23
so probably driver issue
Avatar
Jupstar ✪ 2025-01-18 22:25
if you install vk validation layers you can start the client with ./DDNet "dbg_gfx 4" to see if there is any problem in our code
Avatar
for gpu drivers, are they installed thriugh apt ?
Avatar
Jupstar ✪ 2025-01-18 22:26
yes
Avatar
2025-01-18 23:28:59 I vulkan_debug: validation error: Validation Error: [ VUID-vkDestroyDevice-device-00378 ] Object 0: handle = 0x555556efb2d0, type = VK_OBJECT_TYPE_DEVICE; Object 1: handle = 0x3e150000003e15, type = VK_OBJECT_TYPE_SWAPCHAIN_KHR; | MessageID = 0x71500fba | OBJ ERROR : For VkDevice 0x555556efb2d0[], VkSwapchainKHR 0x3e150000003e15[] has not been destroyed. The Vulkan spec states: All child objects created on device must have been destroyed prior to destroying device (https://www.khronos.org/registry/vulkan/specs/1.3-extensions/html/vkspec.html#VUID-vkDestroyDevice-device-00378)
Avatar
Jupstar ✪ 2025-01-18 22:32
oh but that is just a result of the game closing
22:32
the reason why it closes must be a different one
Avatar
the log is quite long
Avatar
Jupstar ✪ 2025-01-18 22:34
yeah the warnings are super annoying xD
22:36
2025-01-18 23:28:58 I vulkan_debug: Validation Warning: [ UNASSIGNED-BestPractices-Error-Result ] Object 0: handle = 0x555556796d10, type = VK_OBJECT_TYPE_INSTANCE; | MessageID = 0x5f379b89 | vkQueueSubmit(): Returned error VK_ERROR_DEVICE_LOST. 2025-01-18 23:28:58 I vulkan: device lost 2025-01-18 23:28:58 I vulkan: vulkan error: Submitting to graphics queue failed.: device lost 2025-01-18 23:28:58 I assert: /nobackup/srcs/ddnet/src/engine/client/backend_sdl.cpp(167): Graphics Assertion: Submitting to graphics queue failed. device lost Submitting the render commands failed. Try to update your GPU drivers.
22:37
this is the interesting part, and also the least saying part
22:37
xD
Avatar
Ah yes, device lost greenthing
Avatar
Jupstar ✪ 2025-01-18 22:37
The good old device lost
Avatar
Best error euw fr
Avatar
any idea how to track it down ?
22:37
it worked fine with the intel gpu though*
22:38
so i can still fallback to that
Avatar
Jupstar ✪ 2025-01-18 22:38
absolutely no idea sadly. nvidia has some tool on windows to track crashes on the gpu
Avatar
it works fine for let's say 2 seconds then crashes
Avatar
Jupstar ✪ 2025-01-18 22:38
Profile, optimize, and debug graphics applications such as Direct3D, Vulkan, and more.
Avatar
Afair device lost means your gpu said fuck u without any proper information because it failed something it wasn't supposed to allow to fail
kek 1
Avatar
Jupstar ✪ 2025-01-18 22:39
yes
Avatar
Anything custom in your data directory ?
22:39
Assets or smth
Avatar
i just cloned and build
Avatar
Jupstar ✪ 2025-01-18 22:43
Typical reasons for device loss will include things like execution timing out (to prevent denial of service), power management events, platform resource management, implementation errors. Applications not adhering to valid usage may also result in device loss being reported, however this is not guaranteed. Even if device loss is reported, the system may be in an unrecoverable state, and further usage of the API is still considered invalid. Whilst logical device loss may be recoverable, in the case of physical device loss, it is unlikely that an application will be able to recover unless additional, unaffected physical devices exist on the system. The error is largely informational and intended only to inform the application that a platform issue has occurred, and should be investigated further. For example, underlying hardware may have developed a fault or become physically disconnected from the rest of the system. In many cases, physical device loss may cause other more serious issues such as the operating system crashing; in which case it may not be reported via the Vulkan API.
From the vulkan spec
Avatar
fucking laptop with * close to enter...
22:45
now, i gotta retrieve files i deleted.....
Avatar
hmm, which "activity" should i chose ?
Avatar
Jupstar ✪ 2025-01-18 23:16
good question, maybe trace profiler?
Avatar
well, either need root or change some setting to allow access to performance counters
Avatar
Jupstar ✪ 2025-01-18 23:17
u have no root? xd
Avatar
i prefer to allow access to perf counters
Avatar
well, seems like it crashes even more severely because it crashed the whole computer...
23:30
sample duration is 2000ns..., i cant find to increase it
Avatar
Jupstar ✪ 2025-01-18 23:31
mh yeah maybe trace is not the correct tool
23:31
but dunno if the shader debuggers or similar can catch crashes
Avatar
seems like no for the moment
Avatar
Jupstar ✪ 2025-01-18 23:33
lmao just as you said that my browser crashed
23:33
welcome to 2025
Avatar
NVIDIA Nsight Developer Tools provide comprehensive access to NVIDIA GPUs and graphics APIs for performance analysis, optimization, and debugging activities. When using advanced rendering techniques…
23:38
oh god, this requires changing the source code...
23:43
well, not tonight...
Avatar
Avatar
Chairn
well, seems like it crashes even more severely because it crashed the whole computer...
Time to attach a kernel debugger 😛
Exported 310 message(s)
Timezone: UTC+0