Guild icon
DDraceNetwork
Development / developer
Development discussion. Logged to https://ddnet.org/irclogs/ Connected with DDNet's IRC channel, Matrix room and GitHub repositories — IRC: #ddnet on Quakenet | Matrix: #ddnet-developer:matrix.org GitHub: https://github.com/ddnet
Between 2024-12-30 00:00 and 2024-12-31 00:00
Avatar
GitHub BOT 2024-12-30 00:19
Install msys2: install pactoys: pacman -Syu git pactoys --needed pacboy -S --needed cmake:p curl:p ffmpeg:p freetype:p glew:p glslang:p gtest:p libnotify:p libpng:p opusfile:p python:p rust:p SDL2:p spirv-tools:p sqlite:p vulkan-headers:p wavpack:p x264:p Unfortunately msys2 doesn't support ssp. But seems removing the SSP line at 555 on CMakeLists.txt builds DDNet-Server.exe under msys2
Avatar
chillerdragon BOT 2024-12-30 06:36
Ok pro
Replying to @Koll Potato was not that hard to implement
06:39
@MilkeeyCat: if the player is already spectating you should be able to control their viewport with this snap item https://chillerdragon.github.io/teeworlds-protocol/06/snap_items.html#obj_spectator_info
06:40
Or do you mean /spec doing /pause? That should be sv_pauseable 0 iirc
Avatar
MilkeeyCat 2024-12-30 06:41
I was trying to do https://github.com/ddnet/ddnet/issues/7097, when you spec 1 person it works fine, but when multi-view is used, when you select a tee, after 2 packets, the servers returns -1 client id :\
Avatar
chillerdragon BOT 2024-12-30 06:44
You are trying to reach 666? @MilkeeyCat such Nobel efforts for the dark lord
Avatar
MilkeeyCat 2024-12-30 06:45
im trying to make more prs which won't be reviewed for months feelsbadman
Avatar
chillerdragon BOT 2024-12-30 06:45
At some point they will overflow to 0
06:46
@fokkonaut: the issue should be fixed yes. But as a hotfix you could remove the click to spec feature for newer ddnet clients because they have the feature client side already.
Avatar
ws-client BOT 2024-12-30 08:34
<ChillerDragon> @Sayın so what exactly do you mean by "the server is yours" :D how long will it be online? And i can really put my stuff on there or what?
Avatar
GitHub BOT 2024-12-30 08:49
Closed #8319 Class member is not to be confused with regular members. The class member only refers to static variables. And for those we want UPPER_CASE without prefix. My local clangd kept tripping on it. Seems like the clang in the CI did not care yet but it is a correct fix either way.
08:55
Fixed this pylint 3.3.3 error: ************* Module seven.content datasrc/seven/content.py:34:1: R0917: Too many positional arguments (7/5) (too-many-positional-arguments) ************* Module content datasrc/content.py:34:1: R0917: Too many positional arguments (7/5) (too-many-positional-arguments) ------------------------------------------------------------------ Your code has been rated at 9.99/10 (previous run: 9.99/10, +0.00) Could also refactor the code to take a ...
09:00
Closed #9426

Checklist

  • [x] Tested the change ingame
  • [ ] Provided screenshots if it is a visual change
  • [ ] Tested in combination with possibly related configuration options
  • [ ] Written a unit test (especially base/) or added coverage to integration test
  • [ ] Considered possible null pointers and out of bounds array indexing
  • [ ] Changed no physics that affect existing maps
  • [ ] Tested the change with [ASan+UBSan or valgrind's memcheck](https://github.com/ddnet/ddnet/#...
Avatar
GitHub BOT 2024-12-30 09:45
So far there are basics tests for 3 tools. For testing the tools we will need some binary files such as images/maps/demos and they should not be in the main repository to avoid growing its size. I thought about using some git submodule but not sure if I like it. For now the script downloads the one demo it needs from github. If we decide to go that way this repo should be moved to the ddnet organization first befor...
Avatar
GitHub BOT 2024-12-30 10:33
Fixes #7097

Checklist

  • [x] Tested the change ingame
  • [ ] Provided screenshots if it is a visual change
  • [ ] Tested in combination with possibly related configuration options
  • [ ] Written a unit test (especially base/) or added coverage to integration test
  • [ ] Considered possible null pointers and out of bounds array indexing
  • [x] Changed no physics that affect existing maps
  • [ ] Tested the change with [ASan+UBSan or valgrind's memcheck](https://github.com/ddnet/ddnet/...
Avatar
GitHub BOT 2024-12-30 10:44
24dede6 Fix dummy swap+connect bind spamming the log - ChillerDragon 8cb2a8c Merge pull request #9440 from ChillerDragon/pr_dummy_swap_spam - def-
10:46
f913696 Disable pylints too many arguments lint - ChillerDragon 877fc20 Merge pull request #9439 from ChillerDragon/pr_pylint_args - def-
Avatar
GitHub BOT 2024-12-30 11:01
60a71f0 Fix clang tidy for static member variables - ChillerDragon e9148f5 Merge pull request #9438 from ChillerDragon/pr_static_member - def-
Avatar
GitHub BOT 2024-12-30 11:18
ad0e6c1 Don't count fire if spec menu is opened - MilkeeyCat 1b5dbe0 Merge pull request #9442 from MilkeeyCat/pr_dont_count_fire_if_spec_menu_is_opened - def-
Avatar
GitHub BOT 2024-12-30 11:38
Closed #8859 https://github.com/user-attachments/assets/d8b99486-16d3-47b0-9e4a-44b80026f1d1 Not all operations that place tiles are covered yet. And the game tiles get out of sync when dragged too fast. The pr is not ready to be merged. But I already opened it to figure out if this would be merged if finished. And also get some input on why the layers might get out of sync when dragging too fast.

Checklist

  • [x] Tested the change ingame
  • [x] Provided screenshots if it is ...
Avatar
GitHub BOT 2024-12-30 13:53

Checklist

  • [ ] Tested the change ingame
  • [ ] Provided screenshots if it is a visual change
  • [ ] Tested in combination with possibly related configuration options
  • [ ] Written a unit test (especially base/) or added coverage to integration test
  • [ ] Considered possible null pointers and out of bounds array indexing
  • [ ] Changed no physics that affect existing maps
  • [ ] Tested the change with [ASan+UBSan or valgrind's memcheck](https://github.com/ddnet/ddnet/#using-ad...
Avatar
GitHub BOT 2024-12-30 14:08
Only compute the result once. This brings down the time spent from 3.5 seconds to 700 milliseconds on my device.

Checklist

  • [x] Tested the change ingame
  • [ ] Provided screenshots if it is a visual change
  • [ ] Tested in combination with possibly related configuration options
  • [ ] Written a unit test (especially base/) or added coverage to integration test
  • [ ] Considered possible null pointers and out of bounds array indexing
  • [ ] Changed no physics that affect exist...
Avatar
Koll Potato 2024-12-30 14:33
ChillerDragon: do snapshot messages have to be compressed for the client to process them?
Avatar
GitHub BOT 2024-12-30 14:43
When sv_destroy_bullets_on_death is 0 the flying projectiles have no effect if the owner left the game and was in a ddrace team. This is caused by the code being a mess. There is ddrace team code in the character but not in the player. This conceptually sounds very wrong to me. If a player dies their projectiles should still be in that ddrace team. So the player code has to be able to handle that. It works quite well in ddnet because respawning is so fast and joining the spectator...
14:46
Closes #7920

Checklist

  • [X] Tested the change ingame
  • [ ] Provided screenshots if it is a visual change
  • [ ] Tested in combination with possibly related configuration options
  • [ ] Written a unit test (especially base/) or added coverage to integration test
  • [ ] Considered possible null pointers and out of bounds array indexing
  • [X] Changed no physics that affect existing maps
  • [ ] Tested the change with [ASan+UBSan or valgrind's memcheck](https://github.com/ddnet/ddnet/#...
Avatar
GitHub BOT 2024-12-30 15:05
https://github.com/ddnet/ddnet/blob/1b5dbe04d95b7375f88b2728749d6ead74b94d0f/src/game/server/entities/projectile.cpp#L125-L126 Hit disabled information should be stored on the projectile and not depend on the character being alive. If sv_destroy_bullets_on_death is 0 and the player touched a "You can't hit others" tile. Then fires a grenade and before it lands disconnects the grenade can hit others.
Avatar
ws-client BOT 2024-12-30 15:06
<ChillerDragon> @Koll Potato you mean huffman compressed? No as a server you can just not compress anything and also not set the compression flag in the packet header and all clients should unpack it just fine
Avatar
Koll Potato 2024-12-30 15:09
alright thanks
15:10
im just trying to find out why client wont process my snapshot
15:10
it decodes just fine by twnet parser
15:10
maybe the ack is wrong
15:10
but it wasnt wrong before xd
Avatar
ws-client BOT 2024-12-30 15:12
<ChillerDragon> is your crc correct?
15:12
<ChillerDragon> does the client log anything in debug mode?
Avatar
Koll Potato 2024-12-30 15:13
ive compared the whole snapshot to what libtw2 would produce
15:13
absolutely the same snapshot
Avatar
ws-client BOT 2024-12-30 15:14
<ChillerDragon> if you suspect ack stuff i would recommend testing with snap empty
Avatar
Koll Potato 2024-12-30 15:14
alright
15:14
havent tried debug yet
Avatar
ws-client BOT 2024-12-30 15:14
<ChillerDragon> the ddnet client will display the map and unlocks the fully working chat if the server only ever sents snap empty
Avatar
Koll Potato 2024-12-30 15:14
is it just debug 1 in the console?
Avatar
ws-client BOT 2024-12-30 15:14
<ChillerDragon> yes
Avatar
Koll Potato 2024-12-30 15:15
alright i will try with snap empty
Avatar
ws-client BOT 2024-12-30 15:15
<ChillerDragon> but i think i moved all useful log prints out of debug already so it might not print more not sure
Avatar
Koll Potato 2024-12-30 15:15
and just send random ack values xD
Avatar
ws-client BOT 2024-12-30 15:15
<ChillerDragon> justatest
Avatar
GitHub BOT 2024-12-30 15:18
CC #7142

Checklist

  • [ ] Tested the change ingame
  • [ ] Provided screenshots if it is a visual change
  • [ ] Tested in combination with possibly related configuration options
  • [ ] Written a unit test (especially base/) or added coverage to integration test
  • [ ] Considered possible null pointers and out of bounds array indexing
  • [ ] Changed no physics that affect existing maps
  • [ ] Tested the change with [ASan+UBSan or valgrind's memcheck](https://github.com/ddnet/ddnet/#usin...
Avatar
Koll Potato 2024-12-30 15:20
ChillerDragon: is this supposed to be the last message before the actual game loads?
15:21
snap empty with random ack values is not working either
15:21
the map loads just fine tho
Avatar
GitHub BOT 2024-12-30 15:22
Only request the notification permission on Android 13 and newer, as on older Android versions it was not a permission but a part of the notification system. The SDLActivity does not use the recommended ContextCompat and ActivityCompat for permissions so requesting the unknown permission fails.

Checklist

  • [X] Tested the change ingame (Android 11, 12, 13, 14)
  • [ ] Provided screenshots if it is a visual change
  • [ ] Tested in combination with possibly related configuration op...
Avatar
Koll Potato 2024-12-30 15:25
there is NETMSG_RCON_CMD message sent by the client
15:26
im not sure if i should acknowledge it or not lol
15:26
well i will do it
15:26
maybe it will work now
Avatar
Today is day of PRs or smth? Like 10 of them already
Avatar
ws-client BOT 2024-12-30 15:52
<ChillerDragon> @Koll Potato yes you have to ack all vital messages. Which is basically everything but player inputs.
16:31
b7dddd2 Fix download link for Android nightly version - Robyt3 d83373f Merge pull request #311 from Robyt3/Downloads-Android-Nightly-Fix - def-
Avatar
GitHub BOT 2024-12-30 16:51
da66e83 Don't re-scan the source tree in scripts/languages/update_all.py - heinrich5991 ebb645a Use ServiceCompat for server service on Android - Robyt3 aa73de2 Fix server not starting on Android 12 and older versions - Robyt3 9ece28e Merge pull request #9450 from Robyt3/Android-Server-Notification-Permission-Fix - def- 0231445 Merge pull request #9445 from heinrich5991/pr_twlang_cache - def-
Avatar
GitHub BOT 2024-12-30 17:14
a701ae8 Add recent tournaments - def-
Avatar
GitHub BOT 2024-12-30 17:27
a1445bd Update christmas2024 - def-
Avatar
and where did teesports go?
Avatar
ярослав 2024-12-30 17:51
забанили че делать
Avatar
Avatar
ярослав
забанили че делать
MilkeeyCat 2024-12-30 17:51
$english
Avatar
Avatar
ярослав
забанили че делать
Hi! Most of us communicate in English. If you’re having trouble with English, use https://www.deepl.com/en/translator to help you out.
Avatar
ярослав 2024-12-30 17:52
I got banned, what do I do?
17:54
help me unban
Avatar
@ярослав #✉-create-a-ticket
Avatar
ярослав 2024-12-30 17:56
where to write
Avatar
Avatar
ярослав
where to write
Avatar
ярослав 2024-12-30 17:57
👍
👍 4
catthumbsup 1
👍🏽 1
18:00
what to put in the first line, where to find it.
Avatar
Avatar
ярослав
what to put in the first line, where to find it.
Avatar
ярослав 2024-12-30 18:07
how long to unban
Avatar
pleaaase i wanna go back to breaking server rules pleeeaaase 🥹
🤣 1
Avatar
Avatar
Voxel
pleaaase i wanna go back to breaking server rules pleeeaaase 🥹
Why cant I react to your messages justatest
Avatar
womp womp
Avatar
Koll Potato 2024-12-30 19:37
ChillerDragon: hmm i think i found the root of the issue but im not sure
19:38
the client sends info packet twice
19:38
but i dont understand why it does that
19:38
i acknowledge that twice
19:38
so it should be correct
19:39
but the client acknowledges one vital chunk less than i have sent
19:39
weird af
21:40
An observation on Software Engineering Put succinctly, the observation is this: With a sufficient number of users of an API, it does not matter what you promise in the contract: all observable behaviors of your system will be depended on by somebody.
XX 1
KK 1
CC 1
DD 1
1️⃣ 1
🇮 1
7️⃣ 1
2️⃣ 1
21:40
this can be applied to ddnet the game itself xD
21:52
f0f1520 its called ger 1 now! - dropalways 58d6c32 Merge pull request #312 from dropalways/patch-1 - def-
21:53
8cb00e0 2025 costs - def- 0a07c59 Remove master2 - def- 745bf59 One UKR - def- 7b80ce9 GER10 -> GER1 - def-
Exported 110 message(s)
Timezone: UTC+0