DDraceNetwork

texnonik

first time seeing 3 bugs with particles

are this really bugs? Looks like your particles are modded. At bottom the player Fabian did a grenade jump and you see 3 damage indicators. Left of Tezcan sb. made a /kill and top right sb. captured the flag. You even see the respawning player in the image (edited)

13:18

hmm maybe there are bugs with your damage indicators

the unique servers are running an old ddnet version, so don't worry

Assa

are this really bugs? Looks like your particles are modded. At bottom the player Fabian did a grenade jump and you see 3 damage indicators. Left of Tezcan sb. made a /kill and top right sb. captured the flag. You even see the respawning player in the image (edited)

No no they stayed for very long time

13:59

It's already for years bug , just first time seeing more then 1

13:59

And it's newest version of ddnet

See #4967. No idea how to reproduce this. Does this also happen if you play the auto demo of this game?

14:08

https://github.com/ddnet/ddnet/issues/4967

Damage stars do not disappear for unknown reasons · Issue #4967 · d...

I don't know why, but for some unknown reason, piles of damage stars can form which take a very long time to disappear, around a minute I guess. I have noticed this more than once. The stars do...

How many FPS do you have on average? (when you had the damage indicator bug) (edited)

are you on vulcan or OpenGL backend? (probably doesn't matter?) (edited)

I'm on Vulkan. I think this might happen with very high FPS because we update various effects like damage indicators based on the time delta between two OnRender calls. If that time delta becomes too small, because rendering is too fast, then the remaining life of damage indicators won't change anymore.

hmm then 2000 fps isn't enough

Yeah, I'm at around 1500 FPS max and the variable LifeAdjustment in damageind.cpp is around 0.000563f. Seems currently unrealistic to reach such high FPS that this would go to zero, so maybe it's something else. But it looks like the time is somehow not advancing anymore for those damage indicators, otherwise they should either change in alpha and rotation or disappear.

yes they appear to be stuck on spawn

14:29

but only on spawn, and other idicators still work

Assa

yes they appear to be stuck on spawn

So they never begin with their normal animation?

maybe they are not getting processed somehow?

14:29

yes, looking at the screenshot

14:29

becasue they are all lumbed together

If the bug was caused by LifeAdjustment being too small then it should affect all damage indicators, but I think only some are stuck

at least on the screenshot from tenonik

yeah, same in the screenshot on the issue

14:30

some indicators are stuck but most of them work

Can reproduce it reliably by connecting dummy as the stars pop out. There's a github issue about it as far back as 2014

They do disappear after about 5 seconds though, which I believe deen implemented

14:46

Not sure what you could do to make them stay for longer, maybe pvp modes?

14:48

This is for freeze stars, ofc. But I'm assuming it has the same core problem

Seems related to time difference between when you joined the server and when connected dummy, it looks like the local time is reset incorrectly

lol imagine a faulty system clock running to fast and then this happens with every self correct

14:52

or can this happen with an overflow?

14:53

imagine the static stime being very high and then the new local time resets to lower values

Assa

imagine the static stime being very high and then the new local time resets to lower values

yes, that's what is happening

14:53

so it needs that much time to catch up until the damage indicator will appear

particles use another system

15:00

Why are damage indicators handled different then particles? (edited)

yeah, the time() function is actually a member of CComponent and also handles video recording differently

15:04

and we cache time_get values for ticks since this seems to improve performance

performance bingo go brrr

21:30

uhh

21:30

https://ddnet.org/skins/index.php?search=twinbop

21:30

whats going on ???

Solly

Click to see attachment 🖼️

just reload the page

oxyzo

just reload the page

happens every time

23:12

and its really slow