Guild icon
DDraceNetwork
Development / developer
Development discussion. Logged to https://ddnet.org/irclogs/ Connected with DDNet's IRC channel, Matrix room and GitHub repositories — IRC: #ddnet on Quakenet | Matrix: #ddnet-developer:matrix.org GitHub: https://github.com/ddnet
Between 2024-11-16 00:00 and 2024-11-17 00:00
Avatar
Avatar
ws-client
<ChillerDragon> @fokkonaut what are you working on?
just a new map project
00:55
check wire
03:42
What to do?
Avatar
I forgot to update the system, we figured it out.
Avatar
sudo apt update sudo apt upgrade
Avatar
ChillerDragon is it possible to implement statistics in voting? For example : Your nickname: nickname Status: there's like an admin player, etc . Killstreak (I'll explain here later) Money: (well, here's the currency) Experience: (experience Like 1/10 before the upgrade) Lvl: (lvl) (left until the next one) Rating: (later) Store: (later) Application for administration: (later) VIP status (later) Administration teams (later) Settings:(later)
05:23
Provided that the player is logged in
Avatar
Pretty good progress so far! I'm learning basic Regex in the process and this is making my entire conversion much easier!
05:26
if this works, it's going to be huge!
05:26
no more stupid texture atlases
Avatar
Voxel: what's the scope of your change?
05:36
also why are you on irc 😹
Avatar
im not joining back on discord yet
05:37
im here for dev talk only
05:37
The scope of my change is... I don't know. But it will remove the ability to change your gameskin, until I get everything working out.
Avatar
MilkeeyCat 2024-11-16 05:38
Morning fearless concurrency enjoyers and others
Avatar
It’s good to hear from you Voxel
Avatar
Avatar
MilkeeyCat
Morning fearless concurrency enjoyers and others
Gm
05:41
How do I write good rust
Avatar
Ask Ryozuki, not me
Avatar
Avatar
Ewan
How do I write good rust
MilkeeyCat 2024-11-16 06:48
Write bad rust, show rust andies, analyze their response
06:49
I did none of that, so I write the way I like it lol
Avatar
Skibidisigma 2024-11-16 06:57
How to make 128 or even more players on my server?
Avatar
ws-client BOT 2024-11-16 07:07
<ChillerDragon> @Evelyn I added 128 player support for you to get it you need to switch branch so go to the build folder and do git pull && git checkout feature_128 && make
Avatar
Avatar
Evelyn
ChillerDragon is it possible to implement statistics in voting? For example : Your nickname: nickname Status: there's like an admin player, etc . Killstreak (I'll explain here later) Money: (well, here's the currency) Experience: (experience Like 1/10 before the upgrade) Lvl: (lvl) (left until the next one) Rating: (later) Store: (later) Application for administration: (later) VIP status (later) Administration teams (later) Settings:(later)
What about this?
Avatar
Avatar
ws-client
<ChillerDragon> @Evelyn I added 128 player support for you to get it you need to switch branch so go to the build folder and do git pull && git checkout feature_128 && make
Should I change max players to 128 in the server config, then insert this command, and restart the server?
Avatar
Avatar
Evelyn
Should I change max players to 128 in the server config, then insert this command, and restart the server?
Everything is working thanks
Avatar
ws-client BOT 2024-11-16 07:57
<ChillerDragon> @Evelyn I added money but I do not have enough motivation to build an entire vote menu now
Avatar
Then how to make at least money
Avatar
ws-client BOT 2024-11-16 07:59
<ChillerDragon> update your server
07:59
<ChillerDragon> there are no configs yet
Avatar
That is, it will immediately appear in the voting?
Avatar
ws-client BOT 2024-11-16 08:04
<ChillerDragon> yup
Avatar
Avatar
MilkeeyCat
Morning fearless concurrency enjoyers and others
You're fearless with concurrency because you write Rust, I'm fearless with concurrency because I'm overconfident. We are not the same.
Avatar
ws-client BOT 2024-11-16 08:07
<ChillerDragon> @Skibidisigma are your servers full? which ones are yours?
Avatar
Avatar
ws-client
<ChillerDragon> @Skibidisigma are your servers full? which ones are yours?
Skibidisigma 2024-11-16 08:09
Is this possible to do 200 players server? We have good hosting and skilled coder
Avatar
ws-client BOT 2024-11-16 08:10
<ChillerDragon> Yes but ddnet clients will only see 64 tees at a time. But your skilled coder can implement 200 slots on the server side.
Avatar
Avatar
ws-client
<ChillerDragon> Yes but ddnet clients will only see 64 tees at a time. But your skilled coder can implement 200 slots on the server side.
Skibidisigma 2024-11-16 08:11
Ty
Avatar
By the way, ChillerDragon, could you give me a text to translate: when a person reaches 5 , 10 , 15 , 20 , 25 kills in a row. And also the texts when a man was killed with these killers in a row
Avatar
ws-client BOT 2024-11-16 08:46
<ChillerDragon> @Evelyn next time you find the strings your self and open the issue ok? -.- https://github.com/DDNetPP/DDNetPP/issues/380
'%s's blocking spree was ended by %s (%d Kills) '%s's killing spree was ended by %s (%d Kills) %s is on a blocking spree with %d kills! %s is on a killing spree with %d kills!
Avatar
ChillerDragon I found a bug on 128 players. Bans , kicks , mutes when I enter the CORRECT id are given to another person
Avatar
ws-client BOT 2024-11-16 08:59
<ChillerDragon> how did you obtain the CORRECT id?
08:59
<ChillerDragon> you have to use status
Avatar
Oh, I'm sorry.
09:02
But still there is 1 bug
09:02
After more than 63 people have entered , the player counter shows 63 and does not rise
09:04
<ChillerDragon> lgtm
09:04
<ChillerDragon> also gogo @Evelyn translations first
Avatar
ws-client BOT 2024-11-16 09:12
<ChillerDragon> @Evelyn i see yea i cba to look into that now. First we finish translations and 128 bugs maybe later.
09:13
<ChillerDragon> still waiting for your response on github
Avatar
Answered
Avatar
hi, how to reload map on client side? what method is responsible for this?
09:43
what is it
09:57
Flying weapons
Avatar
Avatar
idk
hi, how to reload map on client side? what method is responsible for this?
pls help 😭
Avatar
Avatar
Evelyn
what is it
That's how the 128 player translation represents players if there are more than 64
Avatar
Avatar
idk
hi, how to reload map on client side? what method is responsible for this?
What are you trying to do? Initiate the reload from the client or server?
Avatar
i just tried sending a map reload from the server and my lag went away, but then the timer and player position reset. after debugging i realized that there is an error in the client and it fixes it by rebooting the map (edited)
10:31
@Robyt3
Avatar
Avatar
Evelyn
Click to see attachment 🖼️
How did this happen? How to fix it
Avatar
Avatar
Evelyn
How did this happen? How to fix it
send it to channel #bugs (edited)
Avatar
Avatar
idk
i just tried sending a map reload from the server and my lag went away, but then the timer and player position reset. after debugging i realized that there is an error in the client and it fixes it by rebooting the map (edited)
But what are you trying to achieve? To reload the map from the server you should do what the server does, search for // load new map
Avatar
Avatar
Evelyn
How did this happen? How to fix it
It happens because you have more than 64 players and this is not fully supported yet
Avatar
But after a couple of seconds, these weapons turn into ordinary people
Avatar
Old clients can only show at most 64 player at the same time, as long as 64 or less players are visible it works
Avatar
GitHub BOT 2024-11-16 11:25
65d7597 Add 45 € funding for RUS1 by zhn - def-
brownbear 1
Avatar
Avatar
GitHub
Click to see attachment 🖼️
poggers2
Avatar
Koll Potato 2024-11-16 11:30
poggers2
Avatar
Avatar
Robyt3
Old clients can only show at most 64 player at the same time, as long as 64 or less players are visible it works
Does ddnet Support 128 now, or is that f-ddrace?
Avatar
No. The "old clients" wasn't correct, I meant current clients without 128 player support in general
12:09
But I guess we could already add forward compatibility for 128 players to the client
Avatar
ws-client BOT 2024-11-16 12:57
<ChillerDragon> @Evelyn what is the difference between убийственная and убийственной?
12:58
<ChillerDragon> @fokkonaut I merged your ddnet pr into a ddnet++ feature branch for woidless
12:59
<ChillerDragon> @Robyt3 yea adding 128 player client support now without waiting for the server would be really cool
Avatar
I don't russian but I think the difference is grammatical gender? (edited)
Avatar
ws-client BOT 2024-11-16 13:00
<ChillerDragon> so which one do i use for killing spree? -.-
Avatar
yeah I'm not answering that lol
Avatar
ws-client BOT 2024-11-16 13:01
<ChillerDragon> omg or is it differnt in "is on a killing spree" vs "killing spree was ended" i was hoping for reusable word for word translations
Avatar
Sorry there was no light
Avatar
Avatar
ws-client
<ChillerDragon> @fokkonaut I merged your ddnet pr into a ddnet++ feature branch for woidless
ahhhh
Avatar
ws-client BOT 2024-11-16 13:11
<ChillerDragon> @Evelyn light?
Avatar
Avatar
ws-client
<ChillerDragon> omg or is it differnt in "is on a killing spree" vs "killing spree was ended" i was hoping for reusable word for word translations
"совершил серию убийств" and "серия убийств завершена"
Avatar
Electricity
Avatar
ws-client BOT 2024-11-16 13:12
<ChillerDragon> ah
Avatar
There are invisible people on my server
13:12
The Miracle of DDNET
Avatar
ws-client BOT 2024-11-16 13:13
<ChillerDragon> eee @zhn now im confused
Avatar
i don't really think you can introduce reusable translation parts for language like german or russian, they have gender xd
Avatar
Avatar
Evelyn
There are invisible people on my server
How to fix it , it 's related to 128 players
Avatar
ws-client BOT 2024-11-16 13:14
<ChillerDragon> yea fuck german or russian
13:14
<ChillerDragon> english op
13:14
<ChillerDragon> ok so is this okay @zhn ? *** 'ChillerDragon' в блокирующем ерии с 5 убийствами! Убийственная серия 'ChillerDragon' была прервана ''ChillerDragon.*'' (7 убийств).
Avatar
Avatar
Evelyn
How to fix it , it 's related to 128 players
It's a bug in my algorithm, it's not perfect :)
Avatar
ws-client BOT 2024-11-16 13:15
<ChillerDragon> @fokkonaut ideally it wouldnt happen to close players right?
Avatar
Either use it or not, or fix it and propose a fix to F-DDrace aswell
Avatar
Avatar
ws-client
<ChillerDragon> @fokkonaut ideally it wouldnt happen to close players right?
There is a bug that 1 tee can somehow gain the status of not being translated
Avatar
ws-client BOT 2024-11-16 13:16
<ChillerDragon> i saw a few
Avatar
If you move away from him and go back, it fixes itself
Avatar
Avatar
ws-client
<ChillerDragon> i saw a few
shouldnt
13:16
idk tho
Avatar
ws-client BOT 2024-11-16 13:16
<ChillerDragon> yea i think proper client support is the way to go anyways
Avatar
Tried Debugging this a lot, not interested anymore currently
Avatar
ws-client BOT 2024-11-16 13:16
<ChillerDragon> sad to hear :c
Avatar
I have people on the server, invisible for a couple of seconds. This is after I have put 128 slots
Avatar
ws-client BOT 2024-11-16 13:16
<ChillerDragon> i was looking forward to 128 ddnet servers
Avatar
Avatar
ws-client
<ChillerDragon> ok so is this okay @zhn ? *** 'ChillerDragon' в блокирующем ерии с 5 убийствами! Убийственная серия 'ChillerDragon' была прервана ''ChillerDragon.*'' (7 убийств).
xd, not really
Avatar
Avatar
Evelyn
I have people on the server, invisible for a couple of seconds. This is after I have put 128 slots
Revert it, you dont need it anyways
13:17
It only makes things more complicated
Avatar
is that an actual translation?
Avatar
ws-client BOT 2024-11-16 13:17
<ChillerDragon> @zhn -.- why do i hire a native speaker as translator if my end result is google translate level
Avatar
Avatar
zhn
i don't really think you can introduce reusable translation parts for language like german or russian, they have gender xd
and cases*, for whatever reason i can't redact this one
Avatar
ws-client BOT 2024-11-16 13:17
<ChillerDragon> @zhn this is what i tried to make work give then mess of a code base and what woidless sent me
Avatar
Avatar
fokkonaut
Revert it, you dont need it anyways
Need
Avatar
Avatar
ws-client
<ChillerDragon> ok so is this okay @zhn ? *** 'ChillerDragon' в блокирующем ерии с 5 убийствами! Убийственная серия 'ChillerDragon' была прервана ''ChillerDragon.*'' (7 убийств).
send original sentence chiller
Avatar
ws-client BOT 2024-11-16 13:18
<ChillerDragon> *** 'ChillerDragon' is on a blocking spree with 5 kills!
Avatar
Avatar
Evelyn
Need
Then learn how to code and fix it xd
13:18
Ty
Avatar
ws-client BOT 2024-11-16 13:18
<ChillerDragon> *** 'ChillerDragon's killing spree was ended by ''ChillerDragon.*'' (7 kills)
Avatar
Avatar
fokkonaut
Then learn how to code and fix it xd
I really need it.
Avatar
Avatar
ws-client
<ChillerDragon> *** 'ChillerDragon' is on a blocking spree with 5 kills!
Серия убийств игрока '%s' была завершена игроком '%s'
Avatar
Avatar
ws-client
<ChillerDragon> *** 'ChillerDragon' is on a blocking spree with 5 kills!
'%s' совершил серию из 5 убийств!
13:21
do you have a %d on this one? the last word can have different form if so
Avatar
ws-client BOT 2024-11-16 13:22
<ChillerDragon> yes but i say "1 kills" in english too thats fine :D
Avatar
Don't you just love how easy localization is? :P
Avatar
ws-client BOT 2024-11-16 13:22
<ChillerDragon> or is it worse in russian?
Avatar
1 kill(s)
Avatar
nah, not really
Avatar
ws-client BOT 2024-11-16 13:22
<ChillerDragon> cool thanks @zhn
Avatar
then again, I don't think 1 kill counts as a killing spree
Avatar
ye, you can put 'убийств(а)', i guess
Avatar
ws-client BOT 2024-11-16 13:23
<ChillerDragon> oh right its 5+ anyways lmao
13:25
<ChillerDragon> omg but with that order of words I have to rewrite all the string formatting somehow
Avatar
GitHub BOT 2024-11-16 13:28
I've found an inconsistency when using sv_rescue 1 and the /r command, when playing in a team/no team. Steps to Reproduce: 1. No Team / "t0"
  • No /r used: Can finish the map.
  • Use /r after start to reset to a position after the start line: Can finish the map.
  • Use /r after start to reset to a position before the start line: Can finish the map.
2. In Team
  • No /r used: Can finish the map.
  • Use /r after start to reset to a positi...
owo 2
Avatar
ChillerDragon can you help me with something?
Avatar
ws-client BOT 2024-11-16 13:30
<ChillerDragon> no i am busy translating
Avatar
ws-client BOT 2024-11-16 13:41
<ChillerDragon> so this is perfect russian? https://paste.zillyhuhn.com/49
Avatar
ws-client BOT 2024-11-16 13:42
<ChillerDragon> ok that was ass. Translations done. Enough for today.
Avatar
Avatar
Evelyn
ChillerDragon can you help me with something?
And now?
Avatar
ws-client BOT 2024-11-16 13:44
<ChillerDragon> Now I sleep and you can pull and update if you want new translations. Polishing 128 is a bit of a bigger task. I am not sure if i will do it.
Avatar
stand
13:45
My request is not related to 128 , and translations
13:45
I want to pick up the actions that need to be done with the tune group to slow down/speed up
13:45
But I can't do it myself.
13:45
It will take 10 minutes, please
Avatar
ws-client BOT 2024-11-16 13:48
<ChillerDragon> What can you not do? Don't you already have the tunes?
Avatar
They are there , but they are not very good. I'll send it now
13:49
inverse = 1 / factor square = factor * factor print(f"{prefix} ground_control_speed {10.0 * factor :.3f}") print(f"{prefix} ground_control_accel {2.0 * square :.3f}") print(f"{prefix} ground_friction {0.5 ** factor :.3f}") print(f"{prefix} ground_jump_impulse {13.2 * factor :.3f}") print(f"{prefix} air_jump_impulse {12.0 * factor :.3f}") print(f"{prefix} air_control_speed {5.0 * factor :.3f}") print(f"{prefix} air_control_accel {1.5 * square :.3f}") print(f"{prefix} air_friction {0.95 ** factor :.3f}") print(f"{prefix} hook_drag_accel {3.0 * square :.3f}") print(f"{prefix} hook_drag_speed {15.0 * factor :.3f}") print(f"{prefix} gravity {0.5 * square :.3f}") print(f"{prefix} velramp_start {550 * factor :.3f}") print(f"{prefix} velramp_range {2000 * factor :.3f}")
13:50
Here are the actions that are taking place now for this or that deceleration/acceleration
13:50
Maybe you can fix something here to make it work better?
Avatar
me waiting patiently for the day evelyn listens and uses code blocks in discord - day 7 (edited)
Avatar
And what is it
Avatar
``` code block ```
Avatar
three backticks (`) for multi-line text
Avatar
this
Avatar
You can even have syntax highlighting if you specify the language like this ```py print(f"Look at me I'm using f strings! a + b = {a + b}") ``` print(f"Look at me I'm using f strings! a + b = {a + b}")
Avatar
I got it, but it doesn't change what I asked ChillerDragon about.
Avatar
You can't improve the slow motion simply by changing the tunes, you need to modify the server A simple way to start would be making the server accept higher precision tunes
Avatar
How?
Avatar
ws-client BOT 2024-11-16 14:00
<ChillerDragon> @Evelyn yea no im not doing tunes
14:02
<ChillerDragon> @Robyt3 are there stats on the amount of mobile players? I have the feeling all those russians are playing the new android version.
14:02
<ChillerDragon> That is why slow mo servers are so popular they make gores with touch controls accessible for beginners.
14:04
<ChillerDragon> If that is the case we should probably invest more in easy maps. To keep them entertained after they finished Linear.
Avatar
Yeah to a beginner Novice contains like the entire range from doable to super hard
14:11
and things that are plain easy barely exist
14:12
which does set this game apart in a nice way... if you're a bit of an elitist
Avatar
Avatar
ws-client
<ChillerDragon> @Robyt3 are there stats on the amount of mobile players? I have the feeling all those russians are playing the new android version.
I don't have any stats about mobile usage
Avatar
when 128 players client-side support? (edited)
Avatar
Is it "fake" that I use DDNetPP but I specified SlowNet in the server type?
💀 1
Avatar
Avatar
ws-client
<ChillerDragon> so this is perfect russian? https://paste.zillyhuhn.com/49
ye, perfect
Avatar
Avatar
Evelyn
Is it "fake" that I use DDNetPP but I specified SlowNet in the server type?
not really if you modified anything in source code, otherwise ask chiller about his attitude to this :P
Avatar
GitHub BOT 2024-11-16 16:53
Closes #9247

Checklist

  • [x] Tested the change ingame
  • [ ] Provided screenshots if it is a visual change
  • [ ] Tested in combination with possibly related configuration options
  • [ ] Written a unit test (especially base/) or added coverage to integration test
  • [ ] Considered possible null pointers and out of bounds array indexing
  • [ ] Changed no physics that affect existing maps
  • [ ] Tested the change with [ASan+UBSan or valgrind's memcheck](https://github.com/ddnet/ddnet/#...
Avatar
GitHub BOT 2024-11-16 17:28

Checklist

  • [x] Tested the change ingame
  • [x] Provided screenshots if it is a visual change
  • [ ] Tested in combination with possibly related configuration options
  • [ ] Written a unit test (especially base/) or added coverage to integration test
  • [ ] Considered possible null pointers and out of bounds array indexing
  • [x] Changed no physics that affect existing maps
  • [ ] Tested the change with [ASan+UBSan or valgrind's memcheck](https://github.com/ddnet/ddnet/#using-ad...
17:34
why this happens on master
17:34
never seen it before
17:34
crashes when joining server
Avatar
if(Direction.x < 0) Graphics()->QuadsSetRotation(-pi / 2 - State.GetAttach()->m_Angle * pi * 2); else Graphics()->QuadsSetRotation(-pi / 2 + State.GetAttach()->m_Angle * pi * 2); in all the code that determines the hammer rotation
18:09
this is all that is needed
18:09
the rest is dead code
18:09
bruh
18:10
(first and foremost)
18:10
(and secondly bruh (a second time)) (edited)
18:11
i dont know how the bashing animation is done but its not here
Avatar
GitHub BOT 2024-11-16 18:40
Because of #9226 the stack size was too small, causing the game to instantly crash when joining any server if compiled with Visual Studio on Windows. This PR increases the stack size from 1 MB to 2 MB, which prevents the crash, but not sure if this amount of memory will be enough in all cases, as this doesn't make the C6262 warnings go away Before: !image ![image](https://github.com/user-attachments/asset...
Avatar
Avatar
Solly
i dont know how the bashing animation is done but its not here
probably spawns a particle effect on hit
Avatar
GitHub BOT 2024-11-16 18:52
Previously, when rendering text with a maximum width that is too small for a single glyph then the text rendering would loop indefinitely trying to advance the cursor to the next line where the glyph will also not fit.

Checklist

  • [X] Tested the change ingame
  • [ ] Provided screenshots if it is a visual change
  • [ ] Tested in combination with possibly related configuration options
  • [ ] Written a unit test (especially base/) or added coverage to integration test
  • [ ] Considered ...
Avatar
GitHub BOT 2024-11-16 18:59
1361a44 Fix colors on repeated client msg - SollyBunny 95d6d99 Merge pull request #9256 from SollyBunny/fix_colors_on_repeated_client_msg - def-
Avatar
Avatar
louis
probably spawns a particle effect on hit
ew
19:01
no but it works with my rotate thing
19:01
ie the bash happens at the custom angle
19:05
mem_zero(m_aapKeyBindings, sizeof(m_aapKeyBindings));
19:05
lmao no way
19:06
wait what
19:06
what the heck are special binds?
19:08
it looks unused (edited)
Avatar
MilkeeyCat 2024-11-16 19:38
Fun fact, it's possible to make a tree sitter grammar which will eat all of your ram pepeW
Avatar
Avatar
MilkeeyCat
Fun fact, it's possible to make a tree sitter grammar which will eat all of your ram pepeW
fun fact: rm -rf /* will remove any french language pack installed on your system AND remove your system
19:41
19:41
lmao
Avatar
MilkeeyCat 2024-11-16 19:41
Will system crash if it runs out of memory or there's something that will kill some processes? 0_o
Avatar
linux will kill the process with the most memory usage
Avatar
Avatar
Solly
fun fact: rm -rf /* will remove any french language pack installed on your system AND remove your system
does the wildcard bypass —no-preserve-root?
Avatar
wawow
Avatar
str_append(pBuf, ModifierName, BufSize); str_append(pBuf, "+", BufSize);
20:01
modifiers are unused but this code doesnt work does it?
20:01
pBuf isn't modified
20:01
so it will do "+trl"
Avatar
jesus christ the whole
20:09
everything is a mess
20:09
guess it hasnt been touched since 0.6
20:09
lmao
Avatar
Koll Potato 2024-11-16 20:27
i have written my first proc macro in rust
20:27
the best 30 minutes of my life
20:35
if(g_Config.m_ClSubTickAiming) { if(str_comp("+fire", pBind) == 0 || str_comp("+hook", pBind) == 0) m_MouseOnAction = true; }
20:35
most people dont have mouse 1 bound to +fire?
20:35
they have it +fire; some other shit aswell
20:36
if(g_Config.m_ClSubTickAiming && m_Binds.m_MouseOnAction) { m_Controls.m_aMousePosOnAction[g_Config.m_ClDummy] = m_Controls.m_aMousePos[g_Config.m_ClDummy]; m_Binds.m_MouseOnAction = false; }
20:36
and this is its only usage?
20:38
why not just
20:38
g_Config.m_ClSubTickAiming
20:38
?
20:38
since its only used on said mouse action
20:39
im not even meant to be doing stuff with any of this i should just leave it as is xddd
Avatar
it compiled???
20:59
nvm
20:59
Avatar
segfault :D
Avatar
Avatar
Solly
what the heck are special binds?
Special binds are a workaround for bindable keys that can also be used in the menus, i.e. F1-F24
Avatar
i see
21:12
is it possible to get traceback on asserts?
Avatar
Either run with a debugger to begin with or install a post-mortem debugger that will be called when the program dies
21:13
I use https://github.com/jrfonseca/drmingw as post-mortem debugger on Windows (edited)
Postmortem debugging tools for MinGW. Contribute to jrfonseca/drmingw development by creating an account on GitHub.
Avatar
eh i just need to know the line number x-x
Avatar
That's what DrMingw does
21:15
wait i can just do a segfault inside the dbg assert and asan will tell me
Avatar
Does ASAN not break on the dbg_break?
21:16
well i have asan on (hopefuly)
21:16
and it creates an illegal instruction
21:16
which asan doesnt catch
21:18
2024-11-16 21:18:41 I assert: /home/solly/Games/ddnet/src/game/client/components/binds.h(36): ModifierMask invalid Segmentation fault (core dumped)
21:19
oh i guess not...
21:20
uhhh why is asan not asaning
21:22
just had to nuke my builddir
Avatar
Q: Why didn't ASan report an obviously invalid memory access in my code? A1: If your errors is too obvious, compiler might have already optimized it out by the time Asan runs.
Avatar
optimize out an error?
21:24
ive heard of compiler going "ah yes these things have been asserted thus i can optimize like etc etc"
21:24
but it just was that asan wasnt enabled
Avatar
GitHub BOT 2024-11-16 21:24
c3bcf57 Fix client hanging when rendering text with small maximum width - Robyt3 9c02194 Merge pull request #9258 from Robyt3/Textrender-Newline-Loop-Fix - def-
Avatar
i just forgot to check for null somewehre
21:24
in the spaghetti that is CBinds::oninput
Avatar
https://github.com/ddnet/ddnet/issues/5710 the jumping code in reference to this is so confusing xd
It also cannot hit if it has no hit. I think super should always be able to perform these actions, otherwise it's only half super.
21:30
we have m_Jumps, m_TotalJumps, and m_Jumped but seems like m_Jumped is a 2-bit mask for an odd reason
Avatar
You know what would also be cool for the future? Some way to make automappers communicate with each other. Like, you run one automapper, and then that one can send certain tile info, and recievers can get it and proceed to do their own stuff using the info it has.
Avatar
// handle key presses Input()->ConsumeEvents([&](const IInput::CEvent &Event) { for(auto &pComponent : m_vpInput) { // Events with flag `FLAG_RELEASE` must always be forwarded to all components so keys being // released can be handled in all components also after some components have been disabled. if(pComponent->OnInput(Event) && (Event.m_Flags & ~IInput::FLAG_RELEASE) != 0) break; } }); apparently pComponenet is null?
23:55
0 0x5918ce7c1ed8 in CBinds::CBindsSpecial::OnInput(IInput::CEvent const&) /home/solly/Games/ddnet/src/game/client/components/binds.cpp:24:20 #1 0x5918cf03f115 in CGameClient::OnUpdate()::$_0::operator()(IInput::CEvent const&) const /home/solly/Games/ddnet/src/game/client/gameclient.cpp:456:19
23:55
==179819==ERROR: AddressSanitizer: SEGV on unknown address 0x000000000000 (pc 0x5918ce7c1ed8 bp 0x7ffd2cbbe5d0 sp 0x7ffd2cbbe4d0 T0) ==179819==The signal is caused by a READ memory access.
23:57
ah yes
23:57
i deleted some code that i didnt mean 2
Exported 281 message(s)
Timezone: UTC+0