DDraceNetwork - developer

DDraceNetwork

Development / developer

Development discussion. Logged to https://ddnet.org/irclogs/ Connected with DDNet's IRC channel, Matrix room and GitHub repositories — IRC: #ddnet on Quakenet | Matrix: #ddnet-developer:matrix.org GitHub: https://github.com/ddnet

Between 2024-06-23 00:00:00Z and 2024-06-24 00:00:00Z

What's the best way to check if a server with a specific IP and port is running, in LAN and in Internet? For Internet I assume just fetch the master json, and for LAN? Maybe send a serverinfo request?

00:02

Is there maybe something that can be used for both equally?

00:03

E.g. serverinfo request might not work if a server uses whitelist (such as ger10 or my srv)

00:03

(I think)

00:03

oh wait actually, i can just use 0.7 protocol serverinfo || master json entry existing

00:05

or well, i just dont care about LAN maybe

chillerdragon: I think you have to create a seperate loop here, there's a break: https://github.com/ddnet/ddnet/blob/123a21bb016f5fd8e6b65819cb6a255313f49f11/src/engine/server/server.cpp#L2975-L2985

00:27

or dont break troll

troll

https://x.com/arktypeio/status/1802050539376595303

What's new about them

06:14

oh it's a quote tweet

06:15

Image attachment

<ChillerDragon> i dont get it fokko xd

06:19

<ChillerDragon> you mean if two players are being redirected at the same time only one at a time is being dropped?

06:21

<ChillerDragon> can't even remember writing that code i just remember its something heinrich pushed maybe i just copy pasted his recommendation

Tater

What's new about them

ye, sorry, I posted the link at a level hight than you understand

06:30

kek

what script is used to add a new translation?

Does the server know it's own address?

fokkonaut

Does the server know it's own address?

no

thought so

you can specify one in 0.7 iirc, but that's just a configuration thing.

yea

i believe master knows your IP if you register, but i'm not sure if master tells you what your ip is

[ddnet/ddnet] Pull request opened: #8512 Add missing translations

If I understood correctly, #8499 added a new translation but didn't add in translation files, so I ran ./scripts/languages/update_all.py and it updated these files.

Checklist

[ ] Tested the change ingame
[ ] Provided screenshots if it is a visual change
[ ] Tested in combination with possibly related configuration options
[ ] Written a unit test (especially base/) or added coverage to integration test
[ ] Considered possible null pointers and out of bounds a...

[ddnet/ddnet] Pull request closed: #8512 Add missing translations

can sb explain, how spectate_multiview works? I am selecting a client ID with select_multiview id, but the spectator view doesn't change, I am still in freeview

we have multiview now?

ah, i need to set multi-view in the spectator view, okay

08:30

hmm, it doesn't split the screen tho

Any ideas about client members leaks? https://steamcommunity.com/app/412220/discussions/0/4344365857079682566/?tscn=1719080070

Game crash :: DDNet General Discussions

Game crash 30-40min after i open it, when i open the game it consume 500mb of ram and it keep growing after 10min it consume like 2gb of ram and after 30-40min it consume 10gb of ram and my whole pc crashes, does anyone have a solution?

memory?

deen

Any ideas about client members leaks? https://steamcommunity.com/app/412220/discussions/0/4344365857079682566/?tscn=1719080070

cc: https://www.youtube.com/watch?v=-fnV_o2j0BE

AssassinTee

hmm, it doesn't split the screen tho

Multi-view doesn't split the screen, it dynamically changes the camera position and zoom to cover multiple tees

1

deen

Any ideas about client members leaks? https://steamcommunity.com/app/412220/discussions/0/4344365857079682566/?tscn=1719080070

i already talked to him here on discord, we even tried a clean client. this must be outside of ddnet i guess. it could still be caused by ddnet, e.g. with a plugged in controller. But could aswell be some weird overlay or other stuff.

08:54

@!D0c do you have a controller plugged in? did you already try to reinstall windows? xd

Was the chat message leak fixed in the newest version? (edited)

08:59

If there's some error message spamming the console every frame it will cause that on old versions

Yes, the leak when no logfile is set should be fixed in 18.3

The timing of 30-40 minutes for 10gb is pretty similar to what I was getting with 1 message per frame at 2000fps (edited)

09:03

you could just ask him to check f1 to see really quick

he said it allocates 5gb already when starting here in discord

The entire console log would be useful

!D0c

started with the fresh client and ram is now at 5gb

at least that was way to quick after just starting a fresh client

@!D0c Please load this map in the editor (it should crash the client) and send the latest crash dump (.RTP file) from the dumps folder in your config directory. That should list all the loaded modules so we can see if any overlays or other 3rd party tools are involved.

2.1 KB

When does this script get executed? https://github.com/ddnet/ddnet-scripts/blob/5c10e4ec7424c51954b33b02a44e4ee1e78f9883/servers/scripts/recalculate-points.py

ddnet-scripts/servers/scripts/recalculate-points.py at 5c10e4ec7424...

The magic scripts that make DDNet run. Contribute to ddnet/ddnet-scripts development by creating an account on GitHub.

09:16

I cannot find anywhere within the scripts themselves where it would be executed

archimede67

I cannot find anywhere within the scripts themselves where it would be executed

It's executed automatically I guess once a night, or manually after renames

Robyt3

It's executed automatically I guess once a night, or manually after renames

Well that was my guess, but looking at https://github.com/ddnet/ddnet-scripts/blob/5c10e4ec7424c51954b33b02a44e4ee1e78f9883/crontab and https://github.com/ddnet/ddnet-scripts/blob/5c10e4ec7424c51954b33b02a44e4ee1e78f9883/servers/scripts/update-everything.sh, it does not seem to get called

ddnet-scripts/crontab at 5c10e4ec7424c51954b33b02a44e4ee1e78f9883 ·...

The magic scripts that make DDNet run. Contribute to ddnet/ddnet-scripts development by creating an account on GitHub.

Jupstar ✪

@!D0c do you have a controller plugged in? did you already try to reinstall windows? xd

i have a controller allways plugged in

!D0c

i have a controller allways plugged in

and have you tried to see if the problem is gone if the controller is not plugged in?

wait a sec

09:21

what is the normal ram usage

archimede67

Well that was my guess, but looking at https://github.com/ddnet/ddnet-scripts/blob/5c10e4ec7424c51954b33b02a44e4ee1e78f9883/crontab and https://github.com/ddnet/ddnet-scripts/blob/5c10e4ec7424c51954b33b02a44e4ee1e78f9883/servers/scripts/update-everything.sh, it does not seem to get called

Not sure, but I guess the crontab file in the repository is outdated

!D0c

what is the normal ram usage

Around 250 MB

09:22

(when starting)

i think the problem is done the game does not go above 320

was it fixed by you unplugging the controller? or smth else

umpluging the controller

should/could be related to #8509

https://github.com/ddnet/ddnet/issues/8509

[Windows] Steering wheel can crash the client · Issue #8509 · ddnet...

I am honestly not sure if this isn't some weird driver issue, but I think it's still worth an issue, maybe someone with steering wheel can also reproduce it. просто погафкай on discord said...

Robyt3

Not sure, but I guess the crontab file in the repository is outdated

Hmm that would explain, is it possible to update the scripts then? I'm trying to figure out how the record_points table gets filled and used

!D0c

umpluging the controller

Please try downloading https://github.com/libsdl-org/SDL/releases/download/release-2.30.4/SDL2-2.30.4-win32-x64.zip, unpack it, and replace the SDL2.dll in your game folder with the downloaded file, so we can test if this is fixed by the latest SDL version

& plug in controller xd

in this folder? DDNet-18.3-win64

!D0c

in this folder? DDNet-18.3-win64

yes, copy SDL2 from SDL2-2.30.4-win32-x64 to DDNet-18.3-win64

09:28

then plug in the controller and check if the problem still happens

ok

also check in the console (F1) that it shows version 2.30.4 as SDL version

Image attachment

Image attachment

ok, does the memory keep increasing or is it fixed now?

its fixed

does the controller work in the controls settings?

yes

ok, thanks for testing. you can keep playing with the replaced SDL2.dll or without the controller for now

09:35

@deen we should update SDL for next release, looks like the memory leak is fixed by updating

DDNet

https://github.com/ddnet/ddnet/issues/8509

this issue is likely also fixed by updating SDL

Robyt3

also check in the console (F1) that it shows version 2.30.4 as SDL version

but i just tryed the controller in the steam version with this same version and didnt crashed

@!D0c also if you encounter memory going up again, please report it

1

!D0c

but i just tryed the controller in the steam version with this same version and didnt crashed

but does RAM go up?

no

mh ok

09:36

so it only happens sometimes?

Before it always happened but now it doesn't happen anymore and I'm not using the new SDL

Maybe new SDL version fixed the bad driver behavior, or by opening the controls settings and using the controller it fixed the driver-hiccup thonk

thonk

or he restarted windows which restarted the driver

Jupstar ✪

or he restarted windows which restarted the driver

na

You could try restarting and see if that brings the problem back justatest

justatest

ok

(on the Steam version)

ye now is growing the ram

!D0c

ye now is growing the ram

Does the controller work in Steam version?

if i plug in the controller the game crash

09:58

but if i plug in before starting the game it increase the ram usage

ok, thanks for confirming, so it's definitely seems like updating SDL is necessary

кто играть пойдет? (edited)

valera

кто играть пойдет? (edited)

russian is not a common spoken language

что?

english

no

then #off-topic

Is deprecated code marked as such?

no

it’s not always cut and dry

everything is a huge mess

12:35

let's face it

12:35

xdd

gm

good afternoon

12:35

ga

no

good evening to all asians

12:35

ge

i just woke up from sleeping in 40 degree weather

gogigagagagigo

don’t tell me it’s afternoon

Embedded image

12:36

xD

12:36

best card

Ewan

i just woke up from sleeping in 40 degree weather

40 degree celsius?

no

muricans always use wrong metrics

12:37

thats why i am asking

fahrenheit

w r o n g

ok

shit metric

12:38

delete it from muricans school system xD

12:38

but real chads use kelvin

Ewan

i just woke up from sleeping in 40 degree weather

so why is it so cold where u live?

12:41

$weather new york

This command was not found.

not so bad with the sun out now

12:58

mountains

Image attachment

github-merge-queue[bot]

[ddnet:master] 2 new commits

31966d5 feat: trim strings in search & exclude inputs - MilkeeyCat 80ff515 Merge pull request #8504 from MilkeeyCat/pr_ddnet_trim_strings_in_search_and_exclude_inputs - Robyt3

13:31

[ddnet/ddnet] Pull request closed: #8504 Trim Strings on Search/Exclude Filter & Add Tooltip

13:31

[ddnet/ddnet] Issue closed: #8411 (Server Browser) Trim Strings on Search/Exclude Filter & Add Tooltip

What is triggering events like showing the freeze bar?

APFFF

What is triggering events like showing the freeze bar?

In the extended character snap object, we have the tick when the character will be unfrozen

14:01

If that tick is after the current tick, we render a freeze bar

Learath2

In the extended character snap object, we have the tick when the character will be unfrozen

Thats where say RenderFreezeBar() is being called?

14:02

Just trying to figure out the project, sorry if the answer to my question might be obvious

RenderFreezeBar() is always called in CFreezeBars::OnRender() if the character is on the screen and has extended information available

14:03

Then inside RenderFreezeBar() we check if the character is currently frozen using m_FreezeEnd m_FreezeStart and the current tick

Ah, so CFreezeBars is the one who's checking for conditions?

That's how all our CComponents are. They get called by a series of hooks and they handle on their own whether they need to do something or not

1

ah nice, exactly the information i was looking for!

src/game/client/component.h for all the hooks available to you within a component

1

<ChillerDragon> @jxsl13 srsly

14:34

<ChillerDragon> casually dropping 2k line pr bruv

it's mostly the same

<ChillerDragon> but epic stuff

14:35

<ChillerDragon> if it was properly separated prs i would already have merged half of it

broke some test, currently don't have time to investigate

14:36

might have forgottenn to append to some byte slice or so

<ChillerDragon> i for sure would love to merge parts of it any chance you could split it up into separate prs so i can merge it tomorrow morning (for me)

the problem is that once you start introduce error handling and error responses, everything start to become red

<ChillerDragon> im all sleepy head now but i will continue working on the project in around 10 hours

will try to separate a little bit either today in the evening or tomorrow

<ChillerDragon> amazing thanks if you won't make it till evening i might manually cherry pick tomorrow :D

<Mazty> .

Matzy hacked our pw chiller

<Mazty> yes

but it was so fcking secure

<Mazty> muahahaha

14:47

<Mazty> easy to hack

14:49

<ChillerDragon> yikes

[ddnet/ddnet] Pull request opened: #8513 fix: add context to translations & add removed translations

This pr fixes translation files. These 2 files had missing [Graphics error] context and because of this python script was destroying the translations. For example https://github.com/ddnet/ddnet/commit/2498d392dbf1ef496e647f8bdbbb406e22f7fe62#diff-3edb39080aa69131efe333703ea6a07b9a8556c8e82674d24c276ee7e0599ffe Also I added a few translation which were removed by script.

Checklist

[ ] Tested the change ingame
[ ] Provided screenshots if it is a visual change
[ ] Te...

[ddnet/ddnet] Pull request opened: #8514 Minor cleanup of updater and HTTP client

Checklist

[X] Tested the change ingame
[ ] Provided screenshots if it is a visual change
[ ] Tested in combination with possibly related configuration options
[ ] Written a unit test (especially base/) or added coverage to integration test
[ ] Considered possible null pointers and out of bounds array indexing
[ ] Changed no physics that affect existing maps
[ ] Tested the change with [ASan+UBSan or valgrind's memcheck](https://github.com/ddnet/ddnet/#using-addres...

<ChillerDragon> @jxsl13 if you won't make it to split the pr until I wake up are you cool with me making up commit messages yoinking parts of the code and setting you as the commit author and then pushing straight to master?

that's cool

15:26

fine with me

[ddnet/ddnet] Pull request opened: #8515 fix: correct arguments highlighting after removing entry

Fixes #8485. I don't know if it's the way it has to be done but it works xd. Also I added an else statement which clears the text input it the last command was deleted.

Checklist

[x] Tested the change ingame
[ ] Provided screenshots if it is a visual change
[ ] Tested in combination with possibly related configuration options
[ ] Written a unit test (especially base/) or added coverage to integration test
[ ] Considered possible null pointers and out of bounds array...

github-merge-queue[bot]

[ddnet:master] 2 new commits

cdfe451 fix: correct arguments highlighting after removing entry - MilkeeyCat 76b53d7 Merge pull request #8515 from MilkeeyCat/pr_ddnet_fix_browser_settings_argument_highlighting - archimede67

18:20

[ddnet/ddnet] Pull request closed: #8515 Correct arguments highlighting after removing entry

18:20

github-merge-queue[bot]

[ddnet/ddnet] Pull request closed: #8515 Correct arguments highlighting after removing entry

18:20

[ddnet/ddnet] Issue closed: #8485 Server settings argument highlighting incorrect after removing entry

github-merge-queue[bot]

[ddnet:master] 3 new commits

c4b9924 Use named enum EUpdaterState instead of int - Robyt3 51b37aa Fix HTTP progress values being above 100 if total size is unknown - Robyt3 62c3c42 Merge pull request #8514 from Robyt3/Updater-Cleanup - archimede67

18:37

[ddnet/ddnet] Pull request closed: #8514 Minor cleanup of updater and HTTP client

github-merge-queue[bot]

[ddnet:master] 2 new commits

635f91b fix: add context to translations & add removed translations - MilkeeyCat 248a248 Merge pull request #8513 from MilkeeyCat/pr_ddnet_fix_da_translations - def-

18:49

[ddnet/ddnet] Pull request closed: #8513 Add context to translations & add removed translations

18:49

github-merge-queue[bot]

[ddnet/ddnet] Pull request closed: #8513 Add context to translations & add removed translations

uh, why github messages are echoed twice ?

because one is from the bot

[ddnet/ddnet] Issue opened: #8516 Zoomed target is not sent when playerflag_chat or _inmenu

wasnt it documented already

19:40

didn't find issue, nvm

19:40

seems it just went thru #developer as always

How can you start a debug session (For Debug Logs) ?

is differents profils in player section is a thing in development ?

<ChillerDragon> @APFFF I don't think I understand your question. But when running a ddnet client or server you can set the config stdout_output_level 1 to print all dbg_msg() calls to the console

23:30

<ChillerDragon> By console i mean your terminal log. If you want the in game console to be more verbose you can set console_output_level 1

[ddnet/ddnet] Pull request opened: #8517 Fix gcc format-security warnings on build

BTW no-nullability-completeness flag seems is not recognized anymore and can be dropped after this patch applied ``` FAILED: CMakeFiles/game-client.dir/src/game/client/components/hud.cpp.o /usr/bin/g++ -DCONF_BACKEND_VULKAN -DCONF_INFORM_UPDATE -DCONF_OPENSSL -DCONF_WAVPACK_CLOSE_FILE -DCONF_WAVPACK_OPEN_FILE_INPUT_EX -DGAME_RELEASE_VERSION="18.3" -DGLEW_STATIC -D_FORTIFY_SOURCE=2 -I/builddir/build/BUILD/ddnet-18.3/redhat-linux-build/src -I/builddir/build/BUILD/ddnet-18.3/src -I/builddi...

<ChillerDragon> Or if you need a backtrace on crash you can enable debug builds. That depends on your tooling. If you are using cmake it would be cmake .. -DCMAKE_BUILD_TYPE=Debug if you are using visual studio there has to be some button somewhere that says Debug instead of Release

visitOP

is differents profils in player section is a thing in development ?

It's available in tclient currently, I don't think there's any plans to add it to ddnet.

Exported 198 message(s)