Guild icon
DDraceNetwork
Development / developer
Development discussion. Logged to https://ddnet.org/irclogs/ Connected with DDNet's IRC channel, Matrix room and GitHub repositories — IRC: #ddnet on Quakenet | Matrix: #ddnet-developer:matrix.org GitHub: https://github.com/ddnet
Between 2024-06-09 00:00:00Z and 2024-06-10 00:00:00Z
Avatar
_N00P_ 2024-06-09 00:56:57Z
so its a generic callback signature where the object to be passed is determined at runtime
00:59
i dont see why though because every callback casts it to CGameContext *
00:59
unless i missed some
Avatar
GitHub BOT 2024-06-09 01:50:03Z
Author icon
github-merge-queue[bot]
[ddnet:master] 3 new commits
13fea24 Sort Compare Not Case Sensitive - Emilcha 24ea8d8 Consistancy, #8468 - Emilcha 31211c3 Merge pull request #8468 from Emilcha/nocase_friendlist_sort - def-
01:50
Author icon
def-
[ddnet/ddnet] Pull request closed: #8468 Server browser friend list: sort not case sensitive
Avatar
GitHub BOT 2024-06-09 02:05:05Z
Author icon
github-merge-queue[bot]
[ddnet:master] 2 new commits
eb8cd8c Update Swedish translations for 18.3 - furo321 805b23e Merge pull request #8470 from furo321/swedish-18.3 - def-
02:05
Author icon
def-
[ddnet/ddnet] Pull request closed: #8470 Update Swedish translations for 18.3
Avatar
APFFF 2024-06-09 02:23:35Z
hi, whats the best way to check if I have set up my local ddnet project correctly?
Avatar
Ewan 2024-06-09 02:32:35Z
wdym
Avatar
louis 2024-06-09 03:22:44Z
i guess if you're able to build it without problems and if it's up to date with the master branch of the github
03:22
what os are you on @APFFF ?
Avatar
chillerdragon BOT 2024-06-09 03:24:51Z
What do you need it for? You can use the official client if you don’t mind editing a bigger C++ code base. Then there is also headless clients in JavaScript, ruby and python.
Replying to @welcom Does anyone know how to create a bot that can receive chat messages from…
Avatar
Ewan 2024-06-09 04:10:30Z
hi chiller
04:10
wanna gores
Avatar
Avatar
welcom
Does anyone know how to create a bot that can receive chat messages from a DDNet server? I don't want you to do it for me; I just need some guidance on how to do it, and I'll handle the rest.
fokkonaut 2024-06-09 07:16:29Z
F-DDrace has that: https://github.com/fokkonaut/F-DDrace/blob/de3299d92ed85bd7c64c1f098ae7990d2b5155d6/src/engine/server/server.cpp#L3844
F-DDrace/src/engine/server/server.cpp at de3299d92ed85bd7c64c1f098a...
F-DDrace is a server-side modification of Teeworlds, developed by fokkonaut. - fokkonaut/F-DDrace
Thumbnail
07:17
https://github.com/fokkonaut/F-DDrace/blob/de3299d92ed85bd7c64c1f098ae7990d2b5155d6/src/game/variables.h#L291
F-DDrace/src/game/variables.h at de3299d92ed85bd7c64c1f098ae7990d2b...
F-DDrace is a server-side modification of Teeworlds, developed by fokkonaut. - fokkonaut/F-DDrace
Thumbnail
Avatar
Ryozuki 2024-06-09 07:31:46Z
morning europeans and others
07:31
vote day justatest
Avatar
Sedonya 2024-06-09 07:32:17Z
morning
Avatar
Avatar
Ryozuki
vote day justatest
fokkonaut 2024-06-09 07:34:21Z
Yea dont remind me
07:34
I'll have to drive half an hour just to vote
Avatar
Avatar
fokkonaut
I'll have to drive half an hour just to vote
meloƞ 2024-06-09 08:35:54Z
fr? lol - its only like 5 minutes for me
Avatar
jxsl13 2024-06-09 08:39:45Z
fokko living in the woods
Avatar
Avatar
Ryozuki
vote day justatest
AssassinTee 2024-06-09 08:41:13Z
voted by letter days ago
Avatar
Avatar
fokkonaut
I'll have to drive half an hour just to vote
AssassinTee 2024-06-09 08:41:52Z
then vote by letter, "Briefwahl"?
Avatar
Avatar
Ryozuki
vote day justatest
zhn 2024-06-09 09:03:56Z
what day
Avatar
Avatar
fokkonaut
I'll have to drive half an hour just to vote
Chairn 2024-06-09 09:12:07Z
don't live in the middle of nowhere trollet
09:12
my vote office is in the same street
Avatar
Avatar
iMilchshake
hayo! Is there a good way to render a .demo directly from the terminal? I wanna use it for batch processing of a large folder with many small demos. I noticed that you can run DDNet some.demo and it will immediately start the demo viewer of that demo. But can i also somehow immediately start a video export via start_video? I tried DDNet some.demo "start_video out.mp4" but it runs the start video command before running the demo so i get videorecorder: Video can only be recorded in demo player. Any ideas? (edited)
Robyt3 2024-06-09 09:14:04Z
Not right now. See #5797
Avatar
DDNet BOT 2024-06-09 09:14:04Z
https://github.com/ddnet/ddnet/issues/5797
'Render all' button for demos · Issue #5797 · ddnet/ddnet
Is it possible to implement a 'render all' button in demos section? Similar to current 'render' button, but it will render all the demos in the current folder one by one. Lumpy ◐ω◑
Thumbnail
Avatar
fokkonaut 2024-06-09 09:19:43Z
I was too late for Briefwahl, so now I have to drive to my old town in order to grab my confirmation so I can go vote
Avatar
jxsl13 2024-06-09 09:36:40Z
don't need no confirmation. just your ID
09:36
better with that letter but not necessary
Avatar
Avatar
Robyt3
Not right now. See #5797
iMilchshake 2024-06-09 09:48:33Z
Thanks :)
Avatar
jxsl13 2024-06-09 10:08:43Z
Robyt3 is on a killing spree on GitHub 👍
Avatar
GitHub BOT 2024-06-09 10:42:33Z
Author icon
Emilcha
[ddnet/ddnet] Pull request opened: #8471 French translation for new version,
Was not able to test ingame just now but ill be able to do il in the evening today.

Checklist

  • [ ] Tested the change ingame
  • [ ] Provided screenshots if it is a visual change
  • [ ] Tested in combination with possibly related configuration options
  • [ ] Written a unit test (especially base/) or added coverage to integration test
  • [ ] Considered possible null pointers and out of bounds array indexing
  • [ ] Changed no physics that affect existing maps
  • [ ] Tested the c...
Avatar
Learath2 BOT 2024-06-09 11:00:48Z
Just noticed I broke my update script while messing around with it a couple months ago... Now I have 94 upgrades, 2 new and 73 reinstalls pending :D
Avatar
Avatar
Learath2
Just noticed I broke my update script while messing around with it a couple months ago... Now I have 94 upgrades, 2 new and 73 reinstalls pending :D
meloƞ 2024-06-09 11:47:44Z
what kind of update script?
Avatar
Learath2 2024-06-09 11:53:43Z
It's my gentoo rolling upgrade script
Avatar
Avatar
louis
what os are you on @APFFF ?
APFFF 2024-06-09 12:09:13Z
Windows
Avatar
GitHub BOT 2024-06-09 12:10:24Z
Author icon
github-merge-queue[bot]
[ddnet:master] 3 new commits
3bb6026 Consistent value selector behavior, support double-clicking - Robyt3 ef7bebc Remove CUi::MouseButtonReleased function - Robyt3 7741309 Merge pull request #8447 from Robyt3/UI-ValueSelector-Consistency-DoubleClick - archimede67
12:10
Author icon
archimede67
[ddnet/ddnet] Pull request closed: #8447 Consistent value selector behavior, support double-clicking
Avatar
Avatar
APFFF
Windows
_N00P_ 2024-06-09 12:10:57Z
i use msys2 for most development on windows. can only recommend
Avatar
APFFF 2024-06-09 12:12:11Z
I barely ever use windows for coding. Usually macOS. Im a little lost
12:12
I had to install Python3 and Rust for this XD
Avatar
_N00P_ 2024-06-09 12:12:44Z
msys2 gives you a linux style cli environment with all the tools but its all windows native compiled
Avatar
APFFF 2024-06-09 12:12:50Z
ah cool
Avatar
_N00P_ 2024-06-09 12:13:06Z
and it uses pacman as package manager so its easy to get all dependencies
Avatar
APFFF 2024-06-09 12:13:07Z
does this exists as a VS Code extention?
Avatar
_N00P_ 2024-06-09 12:13:31Z
i use vscode for editing the code and then compile with the terminal
12:13
i dont know if there is an extension
12:13
is just use them in parallel
Avatar
APFFF 2024-06-09 12:13:57Z
Are there no scripts in the ddnet project for building?
Avatar
_N00P_ 2024-06-09 12:14:24Z
cmake -B build -S . cmake --build build/ -j
Avatar
Learath2 BOT 2024-06-09 12:23:09Z
I would rather code on my phone with a keyboard before going back to windows
Avatar
Avatar
Learath2
I would rather code on my phone with a keyboard before going back to windows
APFFF 2024-06-09 12:23:43Z
reddit ahh answer
12:23
true tho
Avatar
Avatar
_N00P_
cmake -B build -S . cmake --build build/ -j
APFFF 2024-06-09 12:24:14Z
first i gotta make cmake work justatest
Avatar
TsFreddie 2024-06-09 12:53:25Z
did Lerato dove into the shadow realm.
Avatar
louis 2024-06-09 13:34:15Z
@APFFF i would just recommend VS Studio
13:34
errr not vs studio i guess its' just VS (Visual Studio)
Avatar
MilkeeyCat 2024-06-09 13:35:26Z
i recommend neovim
Avatar
louis 2024-06-09 13:35:59Z
lots of support since its a widely used ide and as long as you're choosing the correct packages on installation, getting ddnet to compile is super straightforward
13:37
https://github.com/ddnet/ddnet?tab=readme-ov-file#building-on-windows-with-the-visual-studio-ide
13:39
then open up visual studio, clone the project if you don't already have it locally installed, then just press the beautiful green button and ur done
Avatar
Teero 2024-06-09 13:54:54Z
on linux its just install dependencies git clone https://github.com/ddnet/ddnet.git && cd ddnet && mkdir build && cd build && cmake .. && make -j$(nproc)
Avatar
Avatar
louis
then open up visual studio, clone the project if you don't already have it locally installed, then just press the beautiful green button and ur done
Teero 2024-06-09 13:55:51Z
first you have to install 50gb of VS and then start it up (which takes another 10 min)
Avatar
louis 2024-06-09 13:58:16Z
takes me 10 seconds from windows search to running the project 😁
Avatar
Avatar
louis
takes me 10 seconds from windows search to running the project 😁
Peter0x44 2024-06-09 14:00:24Z
As if that's acceptable either
Avatar
louis 2024-06-09 14:02:38Z
ah yes you need it done in 2 seconds so you can use the other 8 seconds thanking richard stallman
Avatar
Avatar
louis
ah yes you need it done in 2 seconds so you can use the other 8 seconds thanking richard stallman
Learath2 2024-06-09 14:17:21Z
Actually 2 seconds thanking stallman, 2 seconds praying to torvalds and the remaining 4 for mocking windows users
👍 1
Avatar
MilkeeyCat 2024-06-09 14:19:32Z
uh oh, i was writing code for last 30 mins without checking because I though I "knew" what I was doing. I didn't pepeW
Image attachment
Avatar
Avatar
louis
ah yes you need it done in 2 seconds so you can use the other 8 seconds thanking richard stallman
Peter0x44 2024-06-09 14:27:02Z
That's not where the slowness ends
Avatar
Avatar
louis
@APFFF i would just recommend VS Studio
APFFF 2024-06-09 15:01:34Z
yeah but trouble getting MSVS Build Tools to work
Avatar
APFFF 2024-06-09 15:37:27Z
Does DDNet.exe run the local Client?
Avatar
GitHub BOT 2024-06-09 15:42:00Z
Author icon
def-
[ddnet-web:master] 1 new commit
5c429a5 Update translation stats - def-
Avatar
egyt BOT 2024-06-09 15:50:59Z
:gigachad:
Replying to @Learath2 Learath2: I would rather code on my phone with a keyboard before going b…
Avatar
GitHub BOT 2024-06-09 15:53:45Z
Author icon
GokturkTalha
[ddnet/ddnet] Pull request opened: #8472 Update Turkish translations
15:54
Author icon
GokturkTalha
[ddnet/ddnet] Pull request opened: #8473 Update Azerbaijanese translation
15:56
Author icon
github-merge-queue[bot]
[ddnet:master] 4 new commits
253fd92 new french translation - Emilcha e0ce722 merge into translation file + credits - Emilcha 3a1c301 Changement - Emilcha c87ddfc Merge pull request #8471 from Emilcha/french-translation - def-
15:56
Author icon
def-
[ddnet/ddnet] Pull request closed: #8471 French translation for new version,
Avatar
APFFF 2024-06-09 15:58:59Z
I got my build folder now in VS Code. Can I now build the local client?
Avatar
MilkeeyCat 2024-06-09 16:25:01Z
aaaay, I almost did basic aah function generation owo
Image attachment
Image attachment
Avatar
GitHub BOT 2024-06-09 16:29:35Z
Author icon
def-
[ddnet/ddnet] Pull request closed: #8472 Update Turkish translations
16:29
Author icon
github-merge-queue[bot]
[ddnet:master] 2 new commits
e993434 Update Turkish translations - GokturkTalha 7383d74 Merge pull request #8472 from GokturkTalha/patch-6 - def-
Avatar
GitHub BOT 2024-06-09 16:39:24Z
Author icon
def-
[ddnet/ddnet] Pull request closed: #8473 Update Azerbaijanese translation
16:39
Author icon
github-merge-queue[bot]
[ddnet:master] 2 new commits
a0125f7 Update Azerbaijanese translation - GokturkTalha e80d1ab Merge pull request #8473 from GokturkTalha/patch-7 - def-
Avatar
meloƞ 2024-06-09 16:59:35Z
im in my first coding session with furo - kinda nervous wish me luck!
Avatar
ReiTW 2024-06-09 17:08:26Z
damn next doom trailer released, ig magnus still workin at machinegames
17:08
DOOM the dark ages
Avatar
APFFF 2024-06-09 17:15:15Z
"couldnt find libfreetype.dll" when executing DDNet.exe. Anyone familiar with this Error? (edited)
Image attachment
17:15
as well as: libpng16-16.dll, SDL2.dll, avformat-60.dll
Avatar
meloƞ 2024-06-09 17:20:53Z
are you using msvc? - i had that issue with msvc .. :D
Avatar
APFFF 2024-06-09 17:22:14Z
yes
Avatar
meloƞ 2024-06-09 17:22:21Z
visual studio code i assume?
Avatar
APFFF 2024-06-09 17:22:24Z
VS Code yes
17:22
It seems to build fine tho
Avatar
meloƞ 2024-06-09 17:22:45Z
visual studio / clion will move the deps correctly, the .dll files are built and exist - you just have to put them into the same folder as DDNet
17:22
i used a script for it - let me see if i can find it
Avatar
APFFF 2024-06-09 17:23:03Z
what folder do they have to be in?
17:23
ah, overread
Avatar
meloƞ 2024-06-09 17:24:23Z
import os import shutil source_dirs = [ ('c:/Users/Anwender/Projects/ddnet/build/Debug', 'c:/Users/Anwender/Projects/ddnet/build/'), ] for source_dir, destination_dir in source_dirs: if not os.path.exists(source_dir): print(f"Source directory {source_dir} does not exist. Skipping.") continue os.makedirs(destination_dir, exist_ok=True) for filename in os.listdir(source_dir): if filename == 'DDNet.exe' or filename == 'steam_api.dll' or filename == 'DDNet-Server.exe': source_file = os.path.join(source_dir, filename) destination_file = os.path.join(destination_dir, filename) try: shutil.copy(source_file, destination_file) print(f"Moved {source_file} to {destination_file}") except FileExistsError: print(f"{destination_file} already exists. Skipping.") input("Done...") change the source_dirs to yours, the rest should just work
17:24
(please dont hate on the script, i suck at python) (edited)
Avatar
APFFF 2024-06-09 17:25:36Z
That script can be executed anywhere?
Avatar
meloƞ 2024-06-09 17:25:43Z
yes, it takes the absolute path
17:29
im now using msys2, and i highly recommend it for ease of use - (thanks Ewan), no idea how clion and/or visual studio moves them, once i find out i will update the github Readme with neccessary steps lmao
Avatar
APFFF 2024-06-09 17:30:56Z
I'm happy it works xD
17:31
not making changes rn
17:31
thx for the script
Avatar
meloƞ 2024-06-09 17:31:12Z
glad it worked!
Avatar
APFFF 2024-06-09 17:31:43Z
what command do you use to build
Avatar
meloƞ 2024-06-09 17:32:16Z
cmake .. and cmake --build . -j or cmake --build . -j --clean-first
Avatar
APFFF 2024-06-09 17:32:42Z
cmake -B build -S . cmake --build build/ -j
17:32
ups
Avatar
meloƞ 2024-06-09 17:33:19Z
just go into the build folder - that way you can remove the -S definition and your cmake --build command looks cleaner :P (edited)
17:33
but yes
Avatar
APFFF 2024-06-09 17:34:16Z
Just copy pasted those justatest
17:34
i have never done anything with cmake ever
17:34
nor have I touched C++ ever
17:34
owo
Avatar
meloƞ 2024-06-09 17:34:50Z
:P thats fair ngl - but you followed the readme?
Avatar
APFFF 2024-06-09 17:34:56Z
yeah
17:35
at least for the Building
Avatar
meloƞ 2024-06-09 17:35:07Z
so it still isnt clear enough.. - god damn it!
17:35
rewrote it twice now!
17:35
XD
Avatar
APFFF 2024-06-09 17:35:19Z
I had to use a lot of ChatGPT
17:35
getting MSVC Build Tools to work was a little headache
Avatar
meloƞ 2024-06-09 17:36:10Z
feelsbadman mind dropping me a DM for things that were unclear ? (you can type those in german) - so i might update the readme once more if its something i can elaborate further (edited)
Avatar
APFFF 2024-06-09 17:36:11Z
Some environment PATH variables were wrong
Avatar
Avatar
APFFF
Some environment PATH variables were wrong
meloƞ 2024-06-09 17:36:26Z
oh the installer should set those correctly...
Avatar
Avatar
meloƞ
feelsbadman mind dropping me a DM for things that were unclear ? (you can type those in german) - so i might update the readme once more if its something i can elaborate further (edited)
APFFF 2024-06-09 17:36:39Z
omg I already lowkey forgot maybe I can look into my chatgpt logs
Avatar
meloƞ 2024-06-09 17:36:47Z
kek
Avatar
APFFF 2024-06-09 17:36:55Z
VS Installer confusing af
17:37
The README for Visual Studio was straight forward tho
Avatar
meloƞ 2024-06-09 17:38:15Z
yeah heinrich suggested i re-add it but it was a little flawed so i rewrote it
Avatar
APFFF 2024-06-09 17:38:45Z
Visual Studio lowkey the worst IDEA I've ever seen
17:39
.dll files still not found
17:39
:/
17:39
even though your script moved them
Avatar
meloƞ 2024-06-09 17:39:52Z
(same imo) :P - but heinrich was right with what he said
Someone knowing their IDE can already do what they need. The README is for people who need help with the compilation process. I don't think that adding choices is a good idea there. We also don't explain how to set up various IDEs on Linux, we just get the user to a point where they can compile the project.
Image attachment
Avatar
Avatar
APFFF
even though your script moved them
meloƞ 2024-06-09 17:40:40Z
o rly? thats odd - are the .dll's and the .exe files in the same directory?
17:40
maybe the source and destination path is the wrong way
Avatar
APFFF 2024-06-09 17:40:54Z
.exe are in Release
Avatar
meloƞ 2024-06-09 17:41:21Z
oh did you specify build/Release ?
17:41
or build/Debug
17:41
i always compile with Debug :P
Avatar
APFFF 2024-06-09 17:41:37Z
ah i did Debug
17:41
whats the difference?
17:42
Does it not log with Release?
17:42
Still not workling
feelsbadman 1
Avatar
meloƞ 2024-06-09 17:42:39Z
from what i know, release optimizes it to the point that debugging will/can be harder (edited)
Avatar
APFFF 2024-06-09 17:43:34Z
my tree: D:/Coding/DDnet_coding/ddnet/..
17:43
.dll files are actually in ../DDnet_coding (edited)
Avatar
meloƞ 2024-06-09 17:44:27Z
but is the .exe in the same directory?
17:44
the .exe file and the .dll files have to be in the same directory for it to work
Avatar
APFFF 2024-06-09 17:44:42Z
exe is in DDnet_coding/debug
17:44
ok
Avatar
meloƞ 2024-06-09 17:44:59Z
huuuh you have debug AND release? thats odd - move it out to the .dll files
Avatar
APFFF 2024-06-09 17:45:01Z
ima move them manually
Avatar
meloƞ 2024-06-09 17:45:04Z
ye
Avatar
APFFF 2024-06-09 17:45:10Z
yeah
Avatar
zhn 2024-06-09 17:45:54Z
what's wrong with win setup :P
Avatar
APFFF 2024-06-09 17:46:03Z
message.txt
9.97 KB
17:46
there is DIR Release and DIR debug
17:46
both gut executables like DDNet.exe
Avatar
meloƞ 2024-06-09 17:48:08Z
open a terminal in there - do the following: rm -Force debug // change to the folder name debug rm -Force Release // change to the folder name release mkdir build cd build cmake .. cmake --build . -J
Avatar
APFFF 2024-06-09 17:48:26Z
in /DDnet_coding ?
Avatar
meloƞ 2024-06-09 17:48:51Z
i guess
Avatar
APFFF 2024-06-09 17:49:12Z
ah whats the windows cmd for rm
17:52
rmdir /S /Q debug rmdir /S /Q release mkdir build //already exists cd build cmake .. cmake --build . -j (edited)
17:52
is what i did
17:53
ok what now
17:54
ok, /Release and /Debug are gone now
Avatar
meloƞ 2024-06-09 17:58:49Z
rm is a windows command :o
justatest 1
17:59
wait build dir exists already? ah gg redo
17:59
but remove build folder and recreate it
Avatar
Avatar
meloƞ
rm is a windows command :o
APFFF 2024-06-09 18:06:06Z
thats remove tho, right? justatest
Avatar
meloƞ 2024-06-09 18:06:37Z
yes
18:06
Image attachment
Avatar
APFFF 2024-06-09 18:08:48Z
PS D:\Coding\DDnet_coding> cmake .. CMake Warning: Ignoring extra path from command line: ".." CMake Error: The source directory "D:/Coding" does not appear to contain CMakeLists.txt. Specify --help for usage, or press the help button on the CMake GUI.
18:09
i skipped cmake .. (edited)
Avatar
Avatar
meloƞ
rm is a windows command :o
Teero 2024-06-09 18:11:34Z
powershell xd
Avatar
meloƞ 2024-06-09 18:11:56Z
omg cmd doesnt have rm
18:11
kek
Avatar
GitHub BOT 2024-06-09 18:20:44Z
Author icon
Robyt3
[ddnet/ddnet] Issue closed: #8417 Sort friends list ignoring case
Avatar
Avatar
fokkonaut
F-DDrace has that: https://github.com/fokkonaut/F-DDrace/blob/de3299d92ed85bd7c64c1f098ae7990d2b5155d6/src/engine/server/server.cpp#L3844
welcom 2024-06-09 18:22:39Z
thx
Avatar
fokkonaut 2024-06-09 18:23:07Z
np
Avatar
Avatar
meloƞ
rm is a windows command :o
Ewan 2024-06-09 18:25:28Z
i told u already it's a powershell alias
18:25
it just wraps powershell's equivalent command
18:25
Remove-Item
Avatar
fokkonaut 2024-06-09 18:26:00Z
hi ewan
Avatar
meloƞ 2024-06-09 18:26:03Z
catxplosion
Avatar
Ewan 2024-06-09 18:26:03Z
hi
18:26
Embedded image
Avatar
fokkonaut 2024-06-09 18:26:53Z
hi 🍈
Avatar
Ewan 2024-06-09 18:27:07Z
🍉
Avatar
Avatar
fokkonaut
hi 🍈
meloƞ 2024-06-09 18:32:09Z
hi fokko
🥳 1
Avatar
Avatar
Ewan
🍉
meloƞ 2024-06-09 18:32:17Z
Avatar
Ewan 2024-06-09 18:32:43Z
18:33
why is he bald
18:34
https://www.youtube.com/watch?v=gax35QKkiag
Eloy Casagrande
ELOY CASAGRANDE - I CANNOT BELIEVE IT’S TRUE (PHIL COLLINS)
Avatar
GitHub BOT 2024-06-09 19:34:56Z
Author icon
Robyt3
[ddnet/ddnet] Pull request opened: #8474 Fix percentage not being used for console command progress spinner
The percentage of received console commands was not being shown with the progress spinner because the variable ProgressProps was not passed to the RenderProgressSpinner function. !image

Checklist

  • [X] Tested the change ingame
  • [X] Provided screenshots if it is a visual change
  • [ ] Tested in combination with possibly related configuration options
  • [ ] Written a unit test (especially ba...
Avatar
fokkonaut 2024-06-09 19:38:54Z
Any ideas what I can do about this? https://github.com/fokkonaut/F-DDrace/actions/runs/9439012628/job/25996628598
Avatar
Avatar
fokkonaut
Any ideas what I can do about this? https://github.com/fokkonaut/F-DDrace/actions/runs/9439012628/job/25996628598
zhn 2024-06-09 19:40:44Z
https://stackoverflow.com/questions/27736618/why-are-sem-init-sem-getvalue-sem-destroy-deprecated-on-mac-os-x-and-w looks liek this
Why are sem_init(), sem_getvalue(), sem_destroy() deprecated on Mac...
When I compile a program using the POSIX sem_init() function, I get a compilation warning (error because I normally use -Werror) that the function has been deprecated when I compile on Mac OS X 10....
Thumbnail
19:40
like*
Avatar
fokkonaut 2024-06-09 19:41:19Z
how does ddnet handle this?
Avatar
zhn 2024-06-09 19:41:41Z
better ask why macos doesn't support posix semaphores xddd
Avatar
Robyt3 2024-06-09 19:41:41Z
You are somehow compiling for macOS but not setting CONF_PLATFORM_MACOS (edited)
19:42
Our implementation of semaphores doesn't use those functions on macOS only on other Unix
Avatar
fokkonaut 2024-06-09 19:42:51Z
How can it happen that it's not defined?
Avatar
Avatar
Robyt3
You are somehow compiling for macOS but not setting CONF_PLATFORM_MACOS (edited)
fokkonaut 2024-06-09 19:43:04Z
^
Avatar
zhn 2024-06-09 19:44:17Z
something is wrong with cmakelists i guess (sorry for prone answer)
Avatar
Robyt3 2024-06-09 19:45:05Z
I'd first try dropping in the latest ddnet system.cpp/h instead
Avatar
fokkonaut 2024-06-09 19:45:45Z
impossible, im based on 0.7
Avatar
Robyt3 2024-06-09 19:49:04Z
You mixed CONF_PLATFORM_MACOSX and CONF_PLATFORM_MACOS macros in your code
19:49
Replace all with CONF_PLATFORM_MACOS
19:50
And replace your detect.h with ours, I think that should simply work if you do the MACOSX -> MACOS change
Avatar
fokkonaut 2024-06-09 19:54:14Z
Thanks
20:00
Any ideas about this one? xD https://github.com/fokkonaut/F-DDrace/actions/runs/9439097943/job/25996814112
Avatar
Robyt3 2024-06-09 20:02:41Z
Copy str_format_v from ddnet so you don't need to pragma ignore the warning which doesn't seem to work
Avatar
fokkonaut 2024-06-09 20:03:03Z
its the same
Avatar
Robyt3 2024-06-09 20:03:06Z
In particular, copy also the part in the header file and add GNUC_ATTRIBUTE
20:03
It's not?
Avatar
fokkonaut 2024-06-09 20:03:43Z
https://github.com/ddnet/ddnet/blob/master/src/base/system.cpp#L2767
Avatar
Avatar
Robyt3
In particular, copy also the part in the header file and add GNUC_ATTRIBUTE
fokkonaut 2024-06-09 20:04:14Z
wdym?
Avatar
Avatar
fokkonaut
https://github.com/ddnet/ddnet/blob/master/src/base/system.cpp#L2767
Robyt3 2024-06-09 20:04:32Z
And your system.h as additional pragma clang diagnostic push, not sure why that causes the warning though
Avatar
Avatar
fokkonaut
wdym?
Robyt3 2024-06-09 20:04:45Z
nvm, about that, looks like you also have the attribute in the header
Avatar
fokkonaut 2024-06-09 20:04:51Z
xd
Avatar
Robyt3 2024-06-09 20:05:38Z
#ifndef __USE_GNU #define __USE_GNU #endif
troll 1
20:05
Looks like you don't have this
20:05
No idea if that's the magic you need
Avatar
fokkonaut 2024-06-09 20:06:00Z
where?
Avatar
Robyt3 2024-06-09 20:06:07Z
Same as in upstream
20:06
system.h
Avatar
fokkonaut 2024-06-09 20:10:10Z
Doesnt work
20:10
xD
Avatar
Robyt3 2024-06-09 20:10:29Z
You also need to add the declaration for str_format_v to system.h: int str_format_v(char *buffer, int buffer_size, const char *format, va_list args) GNUC_ATTRIBUTE((format(printf, 3, 0)));
20:10
With the correct GNUC_ATTRIBUTE attribute
20:10
Then you don't need to suppress the warning for clang and the CI shouldn't complain
Avatar
fokkonaut 2024-06-09 20:11:45Z
funny enough, there was no declaration of it at all
20:11
haha
Avatar
egyt BOT 2024-06-09 20:15:00Z
Appreciated by Richard Matthew Stallman himself!
Replying to @Robyt3 ``` […]
Avatar
fokkonaut 2024-06-09 20:19:07Z
https://github.com/fokkonaut/F-DDrace/actions/runs/9439204893/job/25997057320
20:19
Do I have to fix all of these?
Avatar
fokkonaut 2024-06-09 20:44:39Z
@Robyt3 https://github.com/fokkonaut/F-DDrace/actions/runs/9439360736/job/25997386575
Avatar
Avatar
fokkonaut
Do I have to fix all of these?
Robyt3 2024-06-09 20:44:49Z
Would be better I guess since it can find bugs
👍 1
Avatar
Avatar
fokkonaut
@Robyt3 https://github.com/fokkonaut/F-DDrace/actions/runs/9439360736/job/25997386575
fokkonaut 2024-06-09 20:45:35Z
ninja: error: 'package_dmg', needed by 'CMakeFiles/package_default', missing and no known rule to make it
Avatar
Avatar
fokkonaut
ninja: error: 'package_dmg', needed by 'CMakeFiles/package_default', missing and no known rule to make it
Robyt3 2024-06-09 20:46:40Z
Looks like you need to copy the package_dmg related stuff from ddnet's CMakeLists (edited)
20:46
It's missing in yours
Avatar
fokkonaut 2024-06-09 20:47:06Z
thanks
Avatar
APFFF 2024-06-09 20:47:28Z
How can I run the tests on my branch?
Avatar
fokkonaut 2024-06-09 20:47:56Z
You need to add .github/workflows/build.yaml
20:48
but you need to maintain it every once in a while
Avatar
Nice🌙 2024-06-09 20:48:46Z
Image attachment
20:48
-17 - 10
20:48
-17 ??
20:48
Idk how to reproduct it
Avatar
meloƞ 2024-06-09 20:49:22Z
You can enable it on your fork somewhere @APFFF, cant Check myself where exactly tho
Avatar
Avatar
Robyt3
Looks like you need to copy the package_dmg related stuff from ddnet's CMakeLists (edited)
fokkonaut 2024-06-09 20:51:39Z
Do you know which stuff containing dmg I need?
Avatar
Avatar
fokkonaut
Do you know which stuff containing dmg I need?
Robyt3 2024-06-09 20:53:16Z
I'd start by copying every line/block containing dmg
20:53
Or look at the diff between your CMakeLists and ddnet
Avatar
fokkonaut 2024-06-09 20:53:35Z
what even is dmg? do i need "dmgbuild"?
Avatar
Robyt3 2024-06-09 20:54:00Z
I think it's like an application package
20:54
So like zip file that can be installed with a fancy icon
Avatar
fokkonaut 2024-06-09 20:55:01Z
it's some client stuff no? I could remove it entirely
20:55
it's a server repo only
20:55
if(CLIENT AND DMGBUILD)
20:55
that's where it's inside
Avatar
Robyt3 2024-06-09 20:56:01Z
Not sure if there's a .dmg separately for the server on macOS
Avatar
fokkonaut 2024-06-09 21:00:27Z
dmg only occurs in scripts/dmg.py and the few lines in my cmakelists.txt
21:00
i think it's useless
21:00
oh wait
21:00
or does the CI need it for packaging?
Avatar
Avatar
fokkonaut
ninja: error: 'package_dmg', needed by 'CMakeFiles/package_default', missing and no known rule to make it
fokkonaut 2024-06-09 21:01:10Z
^
Avatar
Robyt3 2024-06-09 21:03:44Z
dmg.py is an old file, ddnet only has dmgsettings.py
21:04
maybe still from bam
Avatar
fokkonaut 2024-06-09 21:04:15Z
ah
Avatar
fokkonaut 2024-06-09 21:12:20Z
pip3 install --break-system-packages dmgbuild
21:12
This probably does the trick
Avatar
ReiTW 2024-06-09 21:12:54Z
ddnet/other projects should definetly make a virtual env for that lol
21:12
instead of doing stuff like that
21:13
(I said ddnet, idk if they requires to do that)
Avatar
Avatar
fokkonaut
pip3 install --break-system-packages dmgbuild
fokkonaut 2024-06-09 21:15:39Z
ok, did not
21:16
Image attachment
Avatar
Robyt3 2024-06-09 21:17:52Z
If you don't want to package dmg files for macOS you should remove the set(PACKAGE_DEFAULT dmg)
Avatar
fokkonaut 2024-06-09 21:18:10Z
what does that do? i dont really understand that
Avatar
Robyt3 2024-06-09 21:18:47Z
Otherwise you need to add add_custom_target(package_dmg DEPENDS ${CPACK_PACKAGE_FILE_NAME}.dmg) list(APPEND PACKAGE_TARGETS package_dmg) and probably more to add the package_dmg CMake target if you want to support building dmg files
Avatar
fokkonaut 2024-06-09 21:19:04Z
What is a dmg file
21:19
xD
Avatar
Avatar
Robyt3
If you don't want to package dmg files for macOS you should remove the set(PACKAGE_DEFAULT dmg)
Robyt3 2024-06-09 21:19:13Z
Like an APK but for macOS
Avatar
Avatar
fokkonaut
What is a dmg file
Robyt3 2024-06-09 21:19:28Z
meant to reply to this
Avatar
fokkonaut 2024-06-09 21:19:50Z
ah
Avatar
Robyt3 2024-06-09 21:19:56Z
It's an archive that macOS users can share to distribute the game
Avatar
fokkonaut 2024-06-09 21:20:19Z
ahhh okay
21:20
i see
21:20
thanks a lot
Avatar
Avatar
fokkonaut
what does that do? i dont really understand that
Robyt3 2024-06-09 21:20:47Z
This sets a variable, which is used in add_custom_target(package_default DEPENDS package_${PACKAGE_DEFAULT}) to set the other target as a dependency
21:21
so it depends on package_dmg target for macOS, or package_zip for Windows
Avatar
fokkonaut 2024-06-09 21:22:11Z
ah okay, i dont own any apple devices. is that convenient? whats the best way to fix it for this server-only repo?
21:22
I think adding package_dmg is the way to go
21:23
But i'm confused, as it's only used in if(CLIENT) in ddnet
21:23
https://github.com/ddnet/ddnet/blob/master/CMakeLists.txt#L3139C1-L3219C1
Avatar
Robyt3 2024-06-09 21:24:54Z
I think it bundles client and server into one dmg-file and there are metadata files so a launcher is shown to start either
Avatar
fokkonaut 2024-06-09 21:25:17Z
So if I only have a server, is it required?
Avatar
Robyt3 2024-06-09 21:26:04Z
We don't bundle zip files with only server either for ddnet only for client+server. but if you only have server then I guess you should still bundle it
Avatar
fokkonaut 2024-06-09 21:26:24Z
okay
21:27
I have no idea how all of that apple stuff works
21:27
think i wont figure it out today anymore lol
Avatar
Avatar
fokkonaut
I have no idea how all of that apple stuff works
Robyt3 2024-06-09 21:27:49Z
I don't have either, I usually look at the diff to ddnet to figure out what's missing 😄
Avatar
fokkonaut 2024-06-09 21:28:03Z
:D
21:28
i'll just try smth
21:32
hmmm
21:32
if(DMG) add_custom_target(package_dmg DEPENDS ${CPACK_PACKAGE_FILE_NAME}.dmg) list(APPEND PACKAGE_TARGETS package_dmg) endif()
21:32
tried adding that but didnt work yxd
Avatar
Robyt3 2024-06-09 21:42:11Z
That will add a dependency for a target ${CPACK_PACKAGE_FILE_NAME}.dmg so you'll also need to add add_custom_command(OUTPUT ${CPACK_PACKAGE_FILE_NAME}.dmg etc.
Avatar
fokkonaut 2024-06-09 21:48:52Z
never really touched cmake a lot
21:50
can i disable the macos build for now?
21:50
without deleting it from build.yaml
Avatar
Ewan 2024-06-09 21:54:51Z
how does build.yaml play into this
Avatar
fokkonaut 2024-06-09 21:55:03Z
I just don't trigger the macOS CI then
Avatar
Ewan 2024-06-09 21:55:08Z
well
Avatar
fokkonaut 2024-06-09 21:55:11Z
windows and linux works
Avatar
Ewan 2024-06-09 21:55:25Z
you can have it silently fail on macos
Avatar
fokkonaut 2024-06-09 21:55:29Z
and apple users probably ™️ know how to compile
Avatar
Ewan 2024-06-09 21:55:34Z
but it might fail because there’s no symbol
Avatar
Avatar
fokkonaut
and apple users probably ™️ know how to compile
Ewan 2024-06-09 21:55:40Z
fat chance
Avatar
fokkonaut 2024-06-09 21:55:57Z
xd
21:57
i'll just add some comments
21:58
https://github.com/fokkonaut/F-DDrace/commit/51f1a230c6248cb13bd85d666120749e61cf5104
21:58
how does this still trigger macOS
Avatar
Ewan 2024-06-09 21:59:39Z
Image attachment
Avatar
fokkonaut 2024-06-09 21:59:55Z
OH
Avatar
GitHub BOT 2024-06-09 22:59:31Z
Author icon
dobrykafe
[ddnet/ddnet] Pull request opened: #8475 Update Czech and Slovak translations for 18.3

Checklist

  • [ ] Tested the change ingame
  • [ ] Provided screenshots if it is a visual change
  • [ ] Tested in combination with possibly related configuration options
  • [ ] Written a unit test (especially base/) or added coverage to integration test
  • [ ] Considered possible null pointers and out of bounds array indexing
  • [ ] Changed no physics that affect existing maps
  • [ ] Tested the change with [ASan+UBSan or valgrind's memcheck](https://github.com/ddnet/ddnet/#using-ad...
Avatar
GitHub BOT 2024-06-09 23:58:31Z
Author icon
Sedonya
[ddnet/ddnet] Pull request opened: #8476 Update arabic.txt
Now I know 99% Arabic

Checklist

  • [x] Tested the change ingame
  • [ ] Provided screenshots if it is a visual change
  • [ ] Tested in combination with possibly related configuration options
  • [ ] Written a unit test (especially base/) or added coverage to integration test
  • [ ] Considered possible null pointers and out of bounds array indexing
  • [ ] Changed no physics that affect existing maps
  • [ ] Tested the change with [ASan+UBSan or valgrind's memcheck](https://github.com/ddne...
Avatar
chillerdragon BOT 2024-06-09 23:59:09Z
Sedonya speaks Arabic? (edited)
Avatar
Sedonya 2024-06-09 23:59:44Z
No, but this change does not require a high knowledge of Arabic
23:59
sippin
Embedded image
Exported 338 message(s)