DDraceNetwork - developer

ChillerDragon

[ddnet/ddnet] Pull request opened: #8296 Remove tools camel case style exception

Fixes https://github.com/ddnet/ddnet/pull/8151#discussion_r1586357561

ChillerDragon

[ddnet/ddnet] Issue opened: #8297 warning: 3 uninitialized fields at the end of the constructor call

``` /home/chiller/Desktop/git/ddnet/src/game/client/components/menus.h:7...

ChillerDragon

[ddnet/ddnet] Issue closed: #8292 Add clang tidy include cleaner

sjrc6

[ddnet/ddnet] Issue opened: #8298 Add motion blur with frame stacking to demo recorder.

Since higher fps videos are not really supported by youtube or most other online video streaming it would be very convenient for the client to apply "frame rate down sampling" or "motion blur" or "frame stacking" whatever you want to call it. Basically you render at 60*n fps and every n frames get averaged into 1 frame, the more frames you average the better it looks. The output video file should be 60fps. It's possible to implement with a simple shader and 2 frame buffers. Just add each f...

05:38

github-merge-queue[bot]

[ddnet:master] 2 new commits

f788a04 Remove tools camel case style exception - ChillerDragon 43c03c4 Merge pull request #8296 from ChillerDragon/pr_camel_tools - def-

05:38

def-

[ddnet/ddnet] Pull request closed: #8296 Remove tools camel case style exception

Bobtiz

[ddnet/ddnet] Issue opened: #8299 add mention-only chat

This may seem very unnecessary, but when there are a lot of people on a server or they don't stop talking, sometimes the chat becomes very long and difficult to read, that's why I wanted to propose adding a mention-only chat, which would be almost the same Same as the friends-only chat but instead of just messages from friends, only the mentions appear, so only important things appear. Also, I don't think it's something difficult to do, I'm not a programmer or anything like that so I don't k...

Jupeyy

[ddnet/ddnet] Issue opened: #8300 Skin name is not valid: xxx is not a good error message

Someone asked me why his skin isn't working: Skin name is not valid: cf_glowcontrastcoalabopp Better say exactly what is wrong: The name of the skin exceeds the 24 character limit

ChillerDragon

[ddnet/ddnet] Pull request opened: #8301 Improve skin name validation error message (Closed #8300)

Closed https://github.com/ddnet/ddnet/issues/8300 !image

Checklist

[x] Tested the change ingame
[x] Provided screenshots if it is a visual change
[ ] Tested in combination with possibly related configuration options
[ ] Written a unit test (especially base/) or added coverage to integration test
[ ] Considered possible null pointers and out of bounds array indexing
[ ] Changed...

<ChillerDragon> 2 more and we hit #8303

xdd

09:39

make an issue "change server port to 8304"

<ChillerDragon> lmao

09:51

<ChillerDragon> Genius idea actually. Then you can run a ddnet server and a teeworlds server at the same time on their default ports.

i wonder if errors should be part of the ui.. then they could at least not be overseen

10:39

especially since it's basically impossible to forbid how a user names their local files

Chilleeeeer how can i run the ddnet CI locally?

Jupstar ✪

i wonder if errors should be part of the ui.. then they could at least not be overseen

I wouldn't show the wrong filenames in the list, then you'd need extra memory to store the longer filenames. If it should be more obvious, we could emit a warning popup for every skin that failed to load.

Robyt3

I wouldn't show the wrong filenames in the list, then you'd need extra memory to store the longer filenames. If it should be more obvious, we could emit a warning popup for every skin that failed to load.

what extra memory. you mean that the invalid skins are loaded?

Jupstar ✪

what extra memory. you mean that the invalid skins are loaded?

I mean we currently use m_aName[24] for skins names, so if you want to even show the longer names you'd need to increase the size or use std::string

Robyt3

I mean we currently use m_aName[24] for skins names, so if you want to even show the longer names you'd need to increase the size or use std::string

mh right that's how the ddnet client is doing it

11:16

i changed the skin container for dd-pg like this:

potentially loadable skins are in a "index"-list, this can include skins that are downloaded over http
skins are always lazy loaded, since the list knows all names it automatically triggers the loading of the skin
skins are unloaded if unused for a certain amount of time

Lazy skin loading is also on my list, but then I decided to first rewrite the image loader so it's usable for that, that should be ready soon. Right now the downloadedskins folder is write-only, we always download the skins from the internet again even if the skin already exists in the folder. My idea would be to load the skin from the local storage first and at the same time download the skin again and only write it to the storage and reload it if it changed.

Robyt3

Lazy skin loading is also on my list, but then I decided to first rewrite the image loader so it's usable for that, that should be ready soon. Right now the downloadedskins folder is write-only, we always download the skins from the internet again even if the skin already exists in the folder. My idea would be to load the skin from the local storage first and at the same time download the skin again and only write it to the storage and reload it if it changed.

ah yeah that was the part i thought about the most. dd-pg will require http resources to have an index. Actually when i implemented the skin database i already thought about the same: https://skins.ddnet.org/skin/skins.json Sadly i forgot to include file hashes. Additionally i'd change that the json is per dir, so community etc. have their own index.

11:22

that way you only need to download the json and never the real file, as long as the file + hash exist locally

Even better would be if there was a downloadable skin index json which contained the hashes of the current skin files, so downloading the entire skin would be unnecessary to check if it's unchanged

Robyt3

[ddnet/ddnet] Pull request opened: #8302 Video recorder: improve error handling and log messages, fix crashes, refactoring

See commit messages. Closes #6375.

Checklist

[X] Tested the change ingame
[ ] Provided screenshots if it is a visual change
[ ] Tested in combination with possibly related configuration options
[ ] Written a unit test (especially base/) or added coverage to integration test
[X] Considered possible null pointers and out of bounds array indexing
[X] Changed no physics that affect existing maps
[ ] Tested the change with [ASan+UBSan or valgrind's memcheck](https:/...

github-merge-queue[bot]

[ddnet:master] 2 new commits

8b0b09f Improve skin name validation error message (Closed #8300) - ChillerDragon 9336b4c Merge pull request #8301 from ChillerDragon/pr_skin_warn - Jupeyy

13:15

Jupeyy

[ddnet/ddnet] Pull request closed: #8301 Improve skin name validation error message (Closed #8300)

13:15

Jupeyy

[ddnet/ddnet] Issue closed: #8300 Skin name is not valid: xxx is not a good error message

<ChillerDragon> @meloƞ which part of the CI? I just copy pasted the parts I need from the workflows into a shell script and run that https://github.com/ddnet/ddnet/tree/master/.github/workflows

ddnet/.github/workflows at master · ddnet/ddnet

DDraceNetwork, a free cooperative platformer game. Contribute to ddnet/ddnet development by creating an account on GitHub.

13:55

<ChillerDragon> there is also tools to replicate the CI environment using containerization but i don't like containers so i just run the raw commands bare metal.

ws-client

<ChillerDragon> there is also tools to replicate the CI environment using containerization but i don't like containers so i just run the raw commands bare metal.

i see - just want to see if CI is happy before doing a PR and having to fix it lol ty

<ChillerDragon> The ci runs on git push btw

14:03

<ChillerDragon> pr or not

14:04

<ChillerDragon> but yea i usually run just ./scripts/fix_style.py before commit. And if I am extra motivated i run my script that runs like 90% of the CI tests but it takes a long time.