DDraceNetwork - developer

<ChillerDragon> ryo C enjoyer

00:44

<ChillerDragon> https://zillyhuhn.com/cs/.1714524214.png

ChillerDragon

[ddnet/ddnet] Issue closed: #8282 CreateTextContainer does not change the cursor y on line breaks

ChillerDragon

[ddnet/ddnet] Pull request opened: #8288 Add contribution guidelines (closed #8142)

ws-client

<ChillerDragon> https://zillyhuhn.com/cs/.1714524214.png

he is someone different now

https://zju3dv.github.io/LoG_webpage/

LoG

This paper targets high-fidelity and real-time view synthesis of dynamic 3D scenes at 4K resolution.

07:30

@Learath2 the worst news possible

07:30

https://mastodon.social/@pid_eins/112353324518585654

Lennart Poettering

Lennart Poettering (@pid_eins@mastodon.social)

5️⃣ Here's the 5th installment of my series of posts highlighting key new features of the upcoming v256 release of systemd. I am pretty sure all of you are well aware of the venerable "sudo" tool that is a key component of most Linux distributions since a long time. At the surface it's a tool that allows an unprivileged user to acquire privileg...

07:30

Run0, a systemd based alternative to sudo, announced (mastodon.social)

07:31

https://news.ycombinator.com/item?id=40205714

CoolCold

Run0, a systemd based alternative to sudo, announced

Why...

Unannounce it

github-merge-queue[bot]

[ddnet:master] 2 new commits

740aada Add str_isnum - ChillerDragon 952d3f6 Merge pull request #8286 from ChillerDragon/pr_str_isnum - Robyt3

09:07

Robyt3

[ddnet/ddnet] Pull request closed: #8286 Add str_isnum

github-merge-queue[bot]

[ddnet:master] 2 new commits

3c45134 Fix ddnet ex snap item registration (closed #8271) - ChillerDragon 2cd877f Merge pull request #8272 from ChillerDragon/pr_fix_snap_uuid_register - heinrich5991

10:14

heinrich5991

[ddnet/ddnet] Pull request closed: #8272 Fix ddnet ex snap item registration (closed #8271)

10:14

github-merge-queue[bot]

[ddnet/ddnet] Pull request closed: #8272 Fix ddnet ex snap item registration (closed #8271)

+KZ

@heinrich5991 i was trying to download this map from the collection but i get a 403 error, maybe you could help me? please xD: https://www.heinrich5991.de/teeworlds/maps/maps/Hot%20Beach_f09f84ce00ce67b216b6e122a75fdbbf59803f4266f18477be693907b8a100d0.map

should be fixed now

Davide

Seems like the request is being blocked by some sort of firewall, maybe modsecurity or anything similar

simply no read access for the web server

rewind time everybody

heinrich5991

[ddnet/ddnet] Issue closed: #8159 games-action/ddnet-18.1 fails to compile: jobs.cpp:108:58: error: find is not a member of std (gentoo GCC-14)

ws-client

<ChillerDragon> @heinrich5991 what purpose does gtest have? Imo the failing test output is so annoying to read. The assert_eq macros do not look hard to self roll. Why dont we drop that annoying dependency?

C++ doesn't have a test runner. feel free to replace it if you find something better than gtest

ws-client

<ChillerDragon> dependencies are always bad and gtest was a bit annoying but it kinda worked. But now that I saw that they reject all patches unless the authors privacy is violated i think we should not depend on it anymore

dependencies are only bad in languages that cna't manage them properly… like c++…

Learath2

What is this about privacy?

you need to sign a cla with your real name to contribute

Headshot

Click to see attachment 🖼️

that should absolutely not be necessary. we're not doing an endian conversion there

jxsl13

so that they are not completely lost from wherever I just scraped them from

thanks, added to my backup

zhn

if you only care about the redirect itself you could add some message box with "do you agree to redirect and connect to x.x.x.x:xxxx" with yes/no and checkbox with "i trust server x.x.x.x:xxxx"

no. messages like that are stupid. what is the user supposed to do? click no?

heinrich5991

you need to sign a cla with your real name to contribute

Oh, hm, yeah not really an option for you as you don't associate this name to your real name

heinrich5991

no. messages like that are stupid. what is the user supposed to do? click no?

exactly - the redirect would happen either from rcon, a vote or game tile - whatever it is, we should give the user the possibility to decline said redirect ? or am i understanding your point wrong here - because i'd personally like the possibility to decline. Say you have a server "lobby" with 10 game tiles redirecting to different servers (like a hub) - you'd want to cancel a redirect if you picked the wrong one or you didnt intend to go there. (edited)

heinrich5991

no. messages like that are stupid. what is the user supposed to do? click no?

I think that comment was in context with a discussion Jupstar started about the redirects potentially violating gdpr

Ryozuki

Click to see attachment 🖼️

we count the 0 twice in that case

I disagree that it's our responsibility to care about that though, but that was the context

Patiga

For the Rust crowd: I created twstorage (https://crates.io/crates/twstorage), its mostly functionality from storage.cpp You can use it to find the local data and config directory of ddnet/teeworlds. It also provides methods (for now only open_file) to access these directories, with logic to first scan the config directory and then afterwards the data directory

https://docs.rs/twstorage/0.1.1/twstorage/enum.Version.html you should probably mark this as #[non_exhaustive] in the next incompatible version so you can add more variants later

Version in twstorage - Rust

API documentation for the Rust Version enum in crate twstorage.

Robyt3

[ddnet/ddnet] Pull request opened: #8289 Remove unnecessary check excluding packets from wrong server

This is already checked for all connection-oriented packets when feeding the connection in https://github.com/ddnet/ddnet/blob/952d3f6631cc0a1e6902ebf79b1cacca1e19ac72/src/engine/shared/network_conn.cpp#L260-L266 Closes #8285.

Checklist

[ ] Tested the change ingame
[ ] Provided screenshots if it is a visual change
[ ] Tested in combination with possibly related configuration options
[ ] Written a unit test (especially base/) or added coverage to integration t...

Original message was deleted or could not be loaded.

I'm not sure there's anything async-able in there

Original message was deleted or could not be loaded.

hello from the past

Learath2

I disagree that it's our responsibility to care about that though, but that was the context

i see - i saw the message as a direct response to zhn's message about giving people the possiblity to decline a redirect and i personally didnt see a reason to call such option "stupid"

meloƞ

exactly - the redirect would happen either from rcon, a vote or game tile - whatever it is, we should give the user the possibility to decline said redirect ? or am i understanding your point wrong here - because i'd personally like the possibility to decline. Say you have a server "lobby" with 10 game tiles redirecting to different servers (like a hub) - you'd want to cancel a redirect if you picked the wrong one or you didnt intend to go there. (edited)

the server can just disconnect you if you don't want to disconnect on your own. not much you can do at this point

meloƞ

i see - i saw the message as a direct response to zhn's message about giving people the possiblity to decline a redirect and i personally didnt see a reason to call such option "stupid"

what I want to say is that these messages don't empower the user to actually do anything

11:40

whatsapp doesn't get access to the contact book if you decline it. but then whatsapp declines to allow you to contact new people

11:40

the user didn't win here

11:41

the server redirects you. you get a popup. you click no. great, you're now in the main menu

11:41

you didn't get anything from your choice

what if the server only disconnects after you agreed? that way my point still stands if its used in the context of an ingame server hub (edited)

then the server can also ask you beforehand

11:43

the problem with such mandatory popup is that the user doesn't win anything but everyone is annoyed

heinrich5991

you didn't get anything from your choice

I guess you didn't get your ip and player name transferred to a server you did not consent to process that information

because you now have to click somewhere

Learath2

I guess you didn't get your ip and player name transferred to a server you did not consent to process that information

I can just as well illegaly transfer your name and IP address without asking you

heinrich5991

I can just as well illegaly transfer your name and IP address without asking you

That was my argument aswell

not sure what this is about. if it's illegal, the server has to notify you beforehand anyway

11:44

in either case

11:44

no need for a client side extra message box (edited)

meloƞ

what if the server only disconnects after you agreed? that way my point still stands if its used in the context of an ingame server hub (edited)

If you want to confirm the user's choice in an ingame server hub you could add a separate room after selecting each server where it shows the IP in chat/broadcast/map and you choose by navigating to a teleport/redirect tile ingame, which seems much less disruptive than a popup message (edited)

heinrich5991

I'm not sure there's anything async-able in there

open_file, he wants to mimic ddnet's storage system

Jupstar ✪

open_file, he wants to mimic ddnet's storage system

ah, fair

Learath2

Why...

I like the explanation of why. it doesn't rely on setuid binaries

It instead relies on a monolithic blackbox with so many lines of code that auditing it would be a gargantuan task. That's so much better

12:00

Setuid binaries are a very well understood vector. They have been part of the attacker model since the very start. I trust the decades of scrutiny that part of the linux kernel went through far more than I trust systemd

12:04

I did not even notice that it was Poettering himself that announced it. When will people see that this narcissist is just trying to create a world in which everything depends on his mess of an init system?

12:06

We would literally not tolerate this from anyone else. Not a person not a corporation. Everyone understands that this sort of hyperdependence is extremely bad. How would you feel if neovim depended on libreoffice being installed? Or if firefox depended on chromium?

On WSL Ubuntu getting this errors when trying to compile DDNet

/usr/bin/ld.gold: error: /mnt/g/Dev/Curl/lib/libz.a: plugin failed to claim member compress.c.obj at 4144
/usr/bin/ld.gold: error: /mnt/g/Dev/Curl/lib/libz.a: plugin failed to claim member crc32.c.obj at 5748
/usr/bin/ld.gold: error: /mnt/g/Dev/Curl/lib/libz.a: plugin failed to claim member inflate.c.obj at 64708
/usr/bin/ld.gold: error: /mnt/g/Dev/Curl/lib/libz.a: plugin failed to claim member uncompr.c.obj at 118466
/usr/bin/ld.gold: error: /mnt/g/Dev/Curl/lib/libz.a: plugin failed to claim member zutil.c.obj at 119780
collect2: error: ld returned 1 exit status
make[2]: *** [CMakeFiles/game-server.dir/build.make:1185: DDNet-Server] Error 1
make[1]: *** [CMakeFiles/Makefile2:287: CMakeFiles/game-server.dir/all] Error 2
make: *** [Makefile:156: all] Error 2

(edited)

why is the path dev curl lib

12:41

xd

no idea

12:41

it was fix and now I can't compile and debug server on WSL

it seems like it finds a very weird libz or smth can u do:

sudo apt install build-essential cargo cmake git glslang-tools google-mock libavcodec-extra libavdevice-dev libavfilter-dev libavformat-dev libavutil-dev libcurl4-openssl-dev libfreetype6-dev libglew-dev libnotify-dev libogg-dev libopus-dev libopusfile-dev libpng-dev libsdl2-dev libsqlite3-dev libssl-dev libvulkan-dev libwavpack-dev libx264-dev python3 rustc spirv-tools

then remove CmakeCache.txt and try to compile again

already did with --reinstall and without that and still the same

12:44

ohh I find out what's going on

12:44

/mnt/g/ is my drive G on windows wtf

12:44

why should it link curl by using that path

(edited)

Learath2

Setuid binaries are a very well understood vector. They have been part of the attacker model since the very start. I trust the decades of scrutiny that part of the linux kernel went through far more than I trust systemd

I don't think setuid binaries are a good security concept (especially not for the sole reason that they've been around for a long time)

12:49

I won't comment on the merits of systemd itself

12:50

but this particular point resonated with me

Okay, and I don't think massive unauditable monoliths that have been around even shorter are any better. That's all

Peakies

On WSL Ubuntu getting this errors when trying to compile DDNet

/usr/bin/ld.gold: error: /mnt/g/Dev/Curl/lib/libz.a: plugin failed to claim member compress.c.obj at 4144
/usr/bin/ld.gold: error: /mnt/g/Dev/Curl/lib/libz.a: plugin failed to claim member crc32.c.obj at 5748
/usr/bin/ld.gold: error: /mnt/g/Dev/Curl/lib/libz.a: plugin failed to claim member inflate.c.obj at 64708
/usr/bin/ld.gold: error: /mnt/g/Dev/Curl/lib/libz.a: plugin failed to claim member uncompr.c.obj at 118466
/usr/bin/ld.gold: error: /mnt/g/Dev/Curl/lib/libz.a: plugin failed to claim member zutil.c.obj at 119780
collect2: error: ld returned 1 exit status
make[2]: *** [CMakeFiles/game-server.dir/build.make:1185: DDNet-Server] Error 1
make[1]: *** [CMakeFiles/Makefile2:287: CMakeFiles/game-server.dir/all] Error 2
make: *** [Makefile:156: all] Error 2

(edited)

fixed by removing curl's library and include folder of windows environment variables

(edited)

Robyt3

[ddnet/ddnet] Pull request opened: #8290 Remove CCommandProcessorFragment_GLBase::Resize delegate

Use ResizeImage function directly instead.

Checklist

[ ] Tested the change ingame
[ ] Provided screenshots if it is a visual change
[ ] Tested in combination with possibly related configuration options
[ ] Written a unit test (especially base/) or added coverage to integration test
[ ] Considered possible null pointers and out of bounds array indexing
[ ] Changed no physics that affect existing maps
[ ] Tested the change with [ASan+UBSan or valgrind's memcheck](...

The github ddnet/ddnet repository reached 500 stars owo

6

6

4

501 now!

2

502 now

1

heinrich5991

that should absolutely not be necessary. we're not doing an endian conversion there

what to do then

Headshot

what to do then

the code as-is wasn't working?

no

the problem is here: https://github.com/ddnet/ddnet/blob/2cd877f0cef1a821544437a37760b28e2a08f088/src/engine/shared/network.cpp#L140

ddnet/src/engine/shared/network.cpp at 2cd877f0cef1a821544437a37760...

DDraceNetwork, a free cooperative platformer game. Contribute to ddnet/ddnet development by creating an account on GitHub.

14:46

we dump the variable in memory-order onto the network

14:46

I'll provide a fix

1

heinrich5991

no. messages like that are stupid. what is the user supposed to do? click no?

if you click no, client will not automatically redirect you next time, if you click yes, server will be listed as verified on client side until player modify it itself so they will have no need in seeing this msgbox ever again

github-merge-queue[bot]

[ddnet:master] 2 new commits

dd62cda Remove CCommandProcessorFragment_GLBase::Resize delegate - Robyt3 7f73ca1 Merge pull request #8290 from Robyt3/Graphics-Backend-Resize-Delegate - def-

15:17

def-

[ddnet/ddnet] Pull request closed: #8290 Remove CCommandProcessorFragment_GLBase::Resize delegate

message like this will prevent auto-redirect, and will allow to auto-redirect if ita intended

15:18

its*

zhn

if you click no, client will not automatically redirect you next time, if you click yes, server will be listed as verified on client side until player modify it itself so they will have no need in seeing this msgbox ever again

I don't get what this message box adds

its like http redirect in browsers

15:23

you have additional step to connect

15:23

if you want to connect to this server without this annoying msgbox you can just tick a checkbox

but https redirect doesn't have this msgbox

15:26

and adding it wouldn't make browsers more secure either, IMO

github-merge-queue[bot]

[ddnet:master] 2 new commits

5f784cb Make sixup TriggeredEvents reliable - ChillerDragon 70785eb Merge pull request #8281 from ChillerDragon/pr_fix_triggeredevents7 - def-

15:33

def-

[ddnet/ddnet] Pull request closed: #8281 Make sixup TriggeredEvents reliable

heinrich5991

[ddnet/ddnet] Pull request closed: #8289 Remove unnecessary check excluding packets from wrong server

15:42

github-merge-queue[bot]

[ddnet:master] 2 new commits

20c28f7 Remove unnecessary check excluding packets from wrong server - Robyt3 213222b Merge pull request #8289 from Robyt3/Client-Address-Check-Cleanup - heinrich5991

15:42

heinrich5991

[ddnet/ddnet] Issue closed: #8285 Network layer should not be reporting packets from addresses other than server we connected to

BlaiZephyr

[ddnet/ddnet] Pull request opened: #8291 fix up readme on building with MSVC (Visual Studio)

re-added and updated building with Visual Studio. reason

Checklist

[ ] Tested the change ingame
[ ] Provided screenshots if it is a visual change
[ ] Tested in combination with possibly related configuration options
[ ] Written a unit test (especially base/) or added coverage to integration test
[ ] Considered possible null pointers and out of bounds array indexing
[ ] Changed no physics that affe...

@heinrich5991 will auto-merge break if i squash the commits? or does it do that automatically

heinrich5991

should be fixed now

thanks

meloƞ

@heinrich5991 will auto-merge break if i squash the commits? or does it do that automatically

oh god pls i have a wife and kids

16:41

but still, will auto-merge break if i squash? XD

I guess it does because of Missing write Access

meloƞ

but still, will auto-merge break if i squash? XD

yes, but I can just press the merge button again

heinrich5991

[ddnet/ddnet] Pull request closed: #8291 fix up readme on building with MSVC (Visual Studio)

18:10

github-merge-queue[bot]

[ddnet:master] 2 new commits

a822fb4 fix up readme on building with MSVC (Visual Studio) - BlaiZephyr ab86990 Merge pull request #8291 from BlaiZephyr/update-readme - heinrich5991

@meloƞ nub

ReiTW

@meloƞ nub

how can i use m_pClient-> in game/client/prediction/entities/character.cpp? (edited)

20:15

i get this when i wanna use it: error: ‘m_pClient’ was not declared in this scope;

you're attempting to access a member (m_pClient) of a class which does not have it