DDraceNetwork

xd the map sadly was mapped for vanilla since the quad change it didnt became darker, now probably doesnt work at all without entities (back in time it was completely spammed with switches)

ScReeNy

The Map Cavings I, which features an effect with a lamp in the middle and the rest ist just dark is somewhat bugged? For me and my friend the whole map was just pitch black. He deleted the map and rejoined and had the same issue. When i changed Render engines and restarted the map worked as intended(restart was probably enough). He was on openGL3 i on vulcan. (edited)

my guess is that the envelopes are not 'synchronized'. the envelopes turn the screen darker over time till it is just black. If they would be synchronized, they would use the server time, so on map change, the screen would be bright again. But since they are not synchronized, they use the client time. The client time is simply how long the client has been open for, so when you restarted your client to change the rendering engine, you reset your client time as a side effect.

ScReeNy

The Map Cavings I, which features an effect with a lamp in the middle and the rest ist just dark is somewhat bugged? For me and my friend the whole map was just pitch black. He deleted the map and rejoined and had the same issue. When i changed Render engines and restarted the map worked as intended(restart was probably enough). He was on openGL3 i on vulcan. (edited)

The map doesn't render correctly because it uses color envelopes with values outside the 0.0-1.0 range

@Jupstar ✪ Is it possible to make Vulkan behave the same as OpenGL? Or can we perform whatever clamping/scaling/etc. is happening here already separately in a way that mostly preserves appearance?

Robyt3

@Jupstar ✪ Is it possible to make Vulkan behave the same as OpenGL? Or can we perform whatever clamping/scaling/etc. is happening here already separately in a way that mostly preserves appearance?

how does vulkan not behave like opengl?

Jupstar ✪

how does vulkan not behave like opengl?

https://discord.com/channels/252358080522747904/757720336274948198/1211081150693380157

the clamping should only happen in older versions

10:06

opengl 3.3 & vk should do the same thing

Robyt3

@Jupstar ✪ Is it possible to make Vulkan behave the same as OpenGL? Or can we perform whatever clamping/scaling/etc. is happening here already separately in a way that mostly preserves appearance?

we should remove the clamping in the other versions

Clamping for all color components?

10:08

I don't directly see why this clamping only applies to OpenGL 3.3 but not other other versions

ScReeNy

The Map Cavings I, which features an effect with a lamp in the middle and the rest ist just dark is somewhat bugged? For me and my friend the whole map was just pitch black. He deleted the map and rejoined and had the same issue. When i changed Render engines and restarted the map worked as intended(restart was probably enough). He was on openGL3 i on vulcan. (edited)

Which client version are you using? Nightly or 18.0.3?

Robyt3

Clamping for all color components?

but clamping creates the undesirable effect that alpha blending is changed depending on the clamp. e.g. alpha of 2 would multiply all color values by 2. i don't think that's the task for the graphics to handle correctly. If you think envelops should not do this behavior, then clamp it in the envelope calculation i guess

Robyt3

I don't directly see why this clamping only applies to OpenGL 3.3 but not other other versions

bcs someone added a random clamp in graphics_threaded.cpp

10:09

i guess in CGraphics_Threaded::SetColorVertex

It's in NormalizeColorComponent at this point

10:10

If colors above 1.0 don't cause issues we could allow it again

10:10

Editor currently limits the range to 0.0-1.0

tbh the problem is already that streamed colors are u8

Jupstar ✪

tbh the problem is already that streamed colors are u8

What's the alternative?

Robyt3

What's the alternative?

yeah that's the problem, generally this is good. I think the problem is simply that the newer backends take a float color for the envelope colors, but the older backends calculate that thing on the CPU already and clamp it so newer backends calculate the same on the GPU without the clamp clamping on GPU is undesirable => clamp should happen on the CPU, but if we clamp the value on the CPU u get a different result. old versions: tile layer color: (0.5, 0.0, 0.0, 1.0) env color: (3.0, 0.0, 0.0, 1.0) => it will be FULL red (bcs the 3.0 * 0.5 happens before the clamp) new versions: same setup => without clamp 1.5 on the GPU (will be FULL red) with clamp of the env value: 0.5 on the GPU NOT full red

10:16

for colors this is generally not a problem, but for alpha values.. bcs alpha values will affect color too, at the alpha blending stage

10:17

the best would be to simply fix the maps

Jupstar ✪

the best would be to simply fix the maps

Are the same map effects still possible if values are limits to 0-1 range?

10:19

Would probably be possible for this map, but maybe the limit for envelopes should also be removed again

Robyt3

Would probably be possible for this map, but maybe the limit for envelopes should also be removed again

yes that's the hardest question to answer