DDraceNetwork

The CHN8 servers are down

07:08

same with CHN12

Yes, there was a DoS attack earlier

09:20

They should be back in 1-2 days

i have to reconnect dummy 3-4 times before this bug goes away, except dummy hammer also copy moves lags, started about a month ago or so

Mugi-chan✰

i have to reconnect dummy 3-4 times before this bug goes away, except dummy hammer also copy moves lags, started about a month ago or so

Maybe related to this change: https://github.com/ddnet/ddnet/pull/7720

Fix automatic hammer on release when cl_dummy_control is set to 1 b...

Fixes #5077 Let's say you have this bind: bind x +toggle cl_dummy_hammer 1 0 and you set cl_dummy_control to 1. When you press the bind i mentioned above, and then release, the dummy will hamme...

not done or not done

not done

like not started or not finished

17:03

xd

17:03

@Learath2 enlighten us

I don’t think this is a message I added. I’m guessing something is using the result before checking the request is done

MilkeeyCat

Click to see attachment 🖼️

Do you have a backtrace? Does it happen consistently?

Robyt3

Do you have a backtrace? Does it happen consistently?

2 out of 10 times

17:04

or smth

Yeah, I added this assertion. It means CHttpRequest::Result is called when the job is not done

not done or not done

MilkeeyCat

2 out of 10 times

Just while playing? While starting, while quitting?

Robyt3

Just while playing? While starting, while quitting?

just when started

when not done

17:06

MilkeeyCat

just when started

r u on latest master code?

17:07

or nightly?

Jupstar ✪

r u on latest master code?

pulled master today at morning

17:07

aaand again few mins ago

okay

MilkeeyCat

pulled master today at morning

looks easy to fix though, if you want to become a developer

Robyt3

looks easy to fix though, if you want to become a developer

just remove assertion santatrollet

2

Result, ResultJson and ResultSha256 should only be called when the state is EHttpState::DONE, so there is a wrong condition somewhere

Robyt3

looks easy to fix though, if you want to become a developer

im better at making useless pull requests, and here's da backtrace

MilkeeyCat

im better at making useless pull requests, and here's da backtrace

Thanks, that should make it pretty clear where the incorrect check is

MilkeeyCat

im better at making useless pull requests, and here's da backtrace

the dummy one was great owo

Robyt3

Maybe related to this change: https://github.com/ddnet/ddnet/pull/7720

how do i know

17:37

i dont use dummy control

Mugi-chan✰

how do i know

Do you use some of the dummy settings described in this pull request in your binds?

17:37

I see, would somewhat fit the timing of around 1 month ago

wook

the dummy one was great owo

the "improve performance" one was my favourite

rcon left/right doesn't work now? or i missed something

21:11

up/down works just fine

1

1

fixed in the next release

Thanks

bencie

fixed in the next release

Fix mapping problem that is still in editor ...

what mapping problem

bencie

what mapping problem

https://discord.com/channels/252358080522747904/757720336274948198/1199825884199268542 this 2 problems

texnonik

https://discord.com/channels/252358080522747904/757720336274948198/1199825884199268542 this 2 problems

Can you please describe them better and if possible show a recording of the bugs? (edited)