

libtw2-gamenet-ddnet vs libtw2_gamenet_ddnet (https://github.com/heinrich5991/libtw2/issues/53#issuecomment-1930996865)






1














Run scripts/fix_style.py --dry-run
src/engine/client/client.cpp:3894:50: error: code should be clang-formatted [-Wclang-format-violations]
Graphics()->GetCurrentVideoMode(s_aMode, Index); 
scripts/fix_style.py && git diff










ddnet_hui ?





1














































































Map Name Time Timestamp
Stronghold cauldron 2203.8 2022-11-19 22:17:01
Actually like the race table in the ddnet.sqlite dump. Columns explained:











































































vk/core.hpp:26:14: note: candidate: ‘template<class R> requires (range<R>) && (is_convertible_v<typename std::__detail::__iter_traits_impl<typename std::remove_cvref<decltype(std::ranges::__cust_access::__begin((declval<_Container&>)()))>::type, std::indirectly_readable_traits<typename std::remove_cvref<decltype(std::ranges::__cust_access::__begin((declval<_Container&>)()))>::type> >::__iter_traits<typename std::remove_cvref<decltype(std::ranges::__cust_access::__begin((declval<_Container&>)()))>::type, std::indirectly_readable_traits<typename std::remove_cvref<decltype(std::ranges::__cust_access::__begin((declval<_Container&>)()))>::type> >::value_type, const char*>) bool lvkge::vk::CCore::CheckValidationLayers(R)’
26 | bool CheckValidationLayers(R WantedLayers)
Look at this mess, if only it went back to the original declaration and returned that to me this would be readable



vk/core.hpp:26:14: note: candidate: ‘template<class R> requires (range<R>) && (is_convertible_v<typename std::__detail::__iter_traits_impl<typename std::remove_cvref<decltype(std::ranges::__cust_access::__begin((declval<_Container&>)()))>::type, std::indirectly_readable_traits<typename std::remove_cvref<decltype(std::ranges::__cust_access::__begin((declval<_Container&>)()))>::type> >::__iter_traits<typename std::remove_cvref<decltype(std::ranges::__cust_access::__begin((declval<_Container&>)()))>::type, std::indirectly_readable_traits<typename std::remove_cvref<decltype(std::ranges::__cust_access::__begin((declval<_Container&>)()))>::type> >::value_type, const char*>) bool lvkge::vk::CCore::CheckValidationLayers(R)’
26 | bool CheckValidationLayers(R WantedLayers)
Look at this mess, if only it went back to the original declaration and returned that to me this would be readable 


template <std::ranges::range R> requires(std::is_convertible_v<std::ranges::range_value_t<R>, const char *>) like this is the real template declaration











std:: namespace

























auto AvailableExtensions = UTIL_VK_ENUMERATE_HELPER([](auto c, auto d){ return vkEnumerateInstanceExtensionProperties(nullptr, c, d); }, VkExtensionProperties);
I think there is something in this line that offends every single one of you















auto AvailableExtensions = UTIL_VK_ENUMERATE_HELPER([](auto c, auto d){ return vkEnumerateInstanceExtensionProperties(nullptr, c, d); }, VkExtensionProperties);
I think there is something in this line that offends every single one of you 








std::vector<VkExtensionProperties> 


std::vector

let in 90% of all cases


let in 90% of all cases 






std::pmr::monotonic_buffer_resource

auto AvailableExtensions = UTIL_VK_ENUMERATE_HELPER([](auto c, auto d){ return vkEnumerateInstanceExtensionProperties(nullptr, c, d); }, VkExtensionProperties);
I think there is something in this line that offends every single one of you 
























VkInstanceCreateInfo CreateInfo{
.sType = VK_STRUCTURE_TYPE_INSTANCE_CREATE_INFO,
.pApplicationInfo = &AppInfo,
.enabledLayerCount = static_cast<uint32_t>(WantedLayers.size()),
.ppEnabledLayerNames = WantedLayers.size() ? WantedLayers.data() : nullptr,
.enabledExtensionCount = GLFWRequiredExtensionCount,
.ppEnabledExtensionNames = GLFWRequiredExtensions,
};
metoo



. before the name kinda sucks xd









