

6a12e20 Fix readability-make-member-function-const - Robyt3
aacd37b Fix readability-static-accessed-through-instance - Robyt3
bab382f Fix modernize-use-emplace - Robyt3
f50eeab Fix performance-inefficient-vector-operation - Robyt3
a333d72 Merge pull request #7653 from Robyt3/Clang-Tidy-Cleanup - def-






















92f2788 Revert "Add flags for compatibility with Windows 8 - 11" - def-




struct posD {
int pos;
int digit;
};
struct posD pds[9] = { { -1, -1 } }; but only the first element of the array aka pds[0] is initialized to pos==-1 and digit==-1






struct posD pds[9] = { [0 ... 9] = { -1, -1 } }; (edited)




struct posD pds[9] = { [0 ... 9] = { -1, -1 } }; (edited)




































2



























1





















1














btop
































test test::parse_constant_definition ... ok
test test::parse_constant ... ok
test test::parse_enumerated_type ... ok
test test::parse_simple_type ... ok
test test::parse_type ... ok
test test::parse_number ... ok
test test::parse_enumerated_type_panic - should panic ... ok
test test::parse_type_def ... ok
Default on error













check(
"array [1..100, Boolean] of real",
ast::Type::Array {
index: vec![
ast::Type::SubRange {
start: ast::Constant::Number(ast::Number::Integer("1")),
end: ast::Constant::Number(ast::Number::Integer("100")),
},
ast::Type::Simple(ast::SimpleType::Boolean),
],
component: Box::new(ast::Type::Simple(ast::SimpleType::Real)),
packed: false,
},
);














char in C is essentially a byte




char) array






C++
CHAT_COMMAND("rankteam", "?r[player name]", CFGFLAG_CHAT | CFGFLAG_SERVER, ConTeamRank, this, "Shows the team rank of player with name r (your team rank by default)")
CHAT_COMMAND("teamrank", "?r[player name]", CFGFLAG_CHAT | CFGFLAG_SERVER, ConTeamRank, this, "Shows the team rank of player with name r (your team rank by default)")
Now we can do this
```C++
CHAT_COMMAND("rankteam", "?r[player name]", CFGFLAG_CHAT | CFGFLAG_SERVER, ConTeamRa...








array [Boolean] of array [size] of real




















































only took me a whole month doing these. not complicated at all




















































































bool Rainbow = g_Config.m_ClRainbow;
IsRainbowBody = Rainbow;
IsRainbowFeet = Rainbow;






bool IsRainbowBody = g_Config.m_ClRainbow;
bool IsRainbowFeet = g_Config.m_ClRainbow; (edited)
bool IsRainbowBody = g_Config.m_ClRainbow;
bool IsRainbowFeet = g_Config.m_ClRainbow;
if(g_Config.m_ClRainbow == 1)
{
IsRainbowBody = true;
IsRainbowFeet = true;
}
else
{
IsRainbowBody = false;
IsRainbowFeet = false;
}





























bool Local = m_pClient->m_Snap.m_LocalClientID == ClientID;


(m_pClient->m_aClients[pInfo->m_ClientID].m_aName,
m_pClient->m_aClients[GameClient()->m_aLocalIDs[g_Config.m_ClDummy]].m_aName) == 0)
bool IsRainbowBody {g_Config.m_ClRainbow},
IsRainbowFeet {g_Config.m_ClRainbow};

(m_pClient->m_aClients[pInfo->m_ClientID].m_aName,
m_pClient->m_aClients[GameClient()->m_aLocalIDs[g_Config.m_ClDummy]].m_aName) == 0) 




SetColor clamps the color components to 0-1


uint8_t seems more obvious (edited)







uint8_t seems more obvious (edited)SetColor isn't fun, also vec4/ColorRGBA use floats as well





FAILED: DDNet.exe
cmd.exe /C "cd . && C:\PROGRA~1\JETBRA~1\CLION2~1.1\bin\mingw\bin\G__~1.EXE -g -mwindows @CMakeFiles\game-client.rsp -o DDNet.exe -Wl,--out-implib,libDDNet.dll.a -Wl,--major-image-version,0,--minor-image-version,0 && cd ."
C:\Program Files\JetBrains\CLion 2023.3.1\bin\mingw\bin/ld.exe: cannot find debug/libddnet_engine_shared.a: No such file or directory
i hate windows 


mingw from the log above, so you need the *-gnu rust toolchain (edited)
rustup default stable-x86_64-pc-windows-gnu fixed it - thanks
C:\Program Files\JetBrains\CLion 2023.3.1\bin\mingw\bin/ld.exe: cannot find debug/libddnet_engine_shared.a: No such file or directory
Running
rustup default stable-x86_64-pc-windows-gnu
or
rustup default stable-x86_64-pc-windows-msvc
depending on the used compiler should fix the issue.
This should be detected in CMakeLists.txt already.









apt install bam

