DDraceNetwork - developer

DDraceNetwork

Development / developer

Development discussion. Logged to https://ddnet.org/irclogs/ Connected with DDNet's IRC channel, Matrix room and GitHub repositories — IRC: #ddnet on Quakenet | Matrix: #ddnet-developer:matrix.org GitHub: https://github.com/ddnet

Between 2023-12-02 00:00:00Z and 2023-12-03 00:00:00Z

[ddnet-maps:master] 1 new commit

91c6f84 M run_as_a_pro - ddnet-maps

Benchmark 1: ./target/release/rust-aoc Time (mean ± σ): 359.9 µs ± 40.6 µs [User: 241.1 µs, System: 68.8 µs] Range (min … max): 301.5 µs … 1480.2 µs 10000 runs

09:34

part 2

[ddnet/ddnet] Issue closed: #7569 BUG 17.4 version tees are missed in spec mode

[ddnet/ddnet] Issue closed: #6623 Collision problem on server

[ddnet/ddnet] Pull request opened: #7572 Stop all recording of server demos on shutdown.

Previously if you did DDNet-Server "record a; shutdown". You would get the following assert src/engine/shared/demo.cpp(47): Demo recorder was not stopped. It now stops any recording demos on shutdown.

Checklist

[x] Tested the change ingame
[ ] Provided screenshots if it is a visual change
[ ] Tested in combination with possibly related configuration options
[ ] Written a unit test (especially base/) or added coverage to integration test
[ ] Considered possible n...

11:05

[ddnet/ddnet] Issue opened: #7573 sv_auto_demo_record 1 doesn't do anything.

Due to DemoRecorder_HandleAutoStart() being called from StartRound(), it won't actually start the demo recording as DDNet doesn't call StartRound() anywhere except if you manually do the command restart. So maybe the starting of a recording should be moved somewhere else?

github-merge-queue[bot]

[ddnet:master] 2 new commits

d9a726e Stop all recording of server demos on shutdown. - furo321 f9fc859 Merge pull request #7572 from furo321/fix-server-demos - Robyt3

11:46

[ddnet/ddnet] Pull request closed: #7572 Stop all recording of server demos on shutdown.

any1 else havin a redefinition error on ddnet latest when building on MSVS? redefinition of IStorage in objidl.h previously declared in src/engine/storage.h ? (edited)

Are you building DDNet master or a mod?

own modified

12:11

happened after merging latest

You added #include <Windows.h> somewhere but forgot to add #define WIN32_LEAN_AND_MEAN before the include, so the windows header defines its own interface IStorage that collides with our name. The latest DDNet merge incidentally added an include for storage.h somewhere I guess. (edited)

12:13

Or you included objidl.h directly, then the same applies, but that should be unlikely

hm - every windows.h include is properly defined with #define WIN32_LEAN_AND_MEAN, latest merge did not include storage.h anywhere, and yea objidl.h is not included anywhere, weird. thanks ofc

Maybe a different header including objidl.h indirectly

couldn't find any

12:21

will look into it - thanks

Shouldn't the error message tell you where the build failed?

12:22

It should at least tell you the file that adds the definition for IStorage

12:22

Do a non-parallel build

crythumbsup

1

dude new openbox is bloated af

13:39

jopsti it now has a background

13:39

it became insanely usable maybe i ditch gnome xd

13:39

sadly i have tearing in ddnet now in openbox .-.

13:42

Embedded image

13:42

looks hot somehow

wtf

13:52

bloattest

@Robyt3 it might be dumb but... isn't main problem discord.cpp?

14:00

C:\Program Files (x86)\Windows Kits\10\Include\10.0.22621.0\um\objidl.h(10694,14): error C2011: 'IStorage': 'class' type redefinition (compiling source file C:\Users\storm\CLionProjects\StormAcl\src\engine\client\discord.cpp) [C:\Users\storm\CLionProjects\StormAcl\cmake-build-debug-visual-studio\game-client.vcxproj]

If the compilation stops there, then yeah, I guess it has to do with Discord integration. Maybe one of the discord header files includes the Windows header. Adding #define WIN32_LEAN_AND_MEAN before the discord includes should fix it then

Robyt3

You added #include <Windows.h> somewhere but forgot to add #define WIN32_LEAN_AND_MEAN before the include, so the windows header defines its own interface IStorage that collides with our name. The latest DDNet merge incidentally added an include for storage.h somewhere I guess. (edited)

this feels like a joke LOL WIN32_LEAN_AND_MEAN sounds so unserious

Embedded image

14:04

over 1k fps in 4k Back In Time 3 full zooz

14:05

veri pog

14:05

but regular zooz is so full of ghosting and tearing its unplayable xd

14:06

this new screen is ass maybe it only works on windows

gigachad

1

why do u need to zoom out that far

to flex on us regular peasants (edited)

i dont feel flexed on

14:07

i can just, play the game normally

Voxel

this feels like a joke LOL WIN32_LEAN_AND_MEAN sounds so unserious

lean

[ddnet/ddnet] Pull request opened: #7574 Remove telecursor. Don't scale TargetXY by zoom.

Remove scaling of TargetX and TargetY by zoom, as it completely breaks ShowDistance and /tp. Also removed /telecursor, as it won't be accurate after this change. Closes #7569.

Checklist

[x] Tested the change ingame
[ ] Provided screenshots if it is a visual change
[ ] Tested in combination with possibly related configuration options
[ ] Written a unit test (especially base/) or added coverage to integration test
[ ] Considered possible null pointers and out of bound...

to see the entire map? There is people who ask in chat how far the finish is and there is people who prefer to zoom out and see for them selfs

jaouis

Robyt3

If the compilation stops there, then yeah, I guess it has to do with Discord integration. Maybe one of the discord header files includes the Windows header. Adding #define WIN32_LEAN_AND_MEAN before the discord includes should fix it then

same problem, but now compiling stops on checksum.cpp with the same problem

Does unmodified DDNet master compile successfully?

lets see

i just tried to compile ddnet

14:43

https://i.imgur.com/oOlYWh5.png

Embedded image

14:43

xd

Please send the crash log

[ddnet/ddnet] Pull request opened: #7575 Properly initialize all CClient member variables, improve integration test script

Closes #7553.

Checklist

[X] Tested the change ingame
[ ] Provided screenshots if it is a visual change
[ ] Tested in combination with possibly related configuration options
[ ] Written a unit test (especially base/) or added coverage to integration test
[ ] Considered possible null pointers and out of bounds array indexing
[ ] Changed no physics that affect existing maps
[ ] Tested the change with [ASan+UBSan or valgrind's memcheck](https://github.com/ddnet/ddnet/...

murpi

Do you have one?

from the wiki artwork article, i forgot authorship sry:

Image attachment

Image attachment

Image attachment

Third looks like insanity

15:57

Xd

it says insanity ye

Nice

@Insanity hi

Hi we need ur art work xd

xd

16:01

@Jupstar ✪ i suggest this

Image attachment

Image attachment

santatrollet

NekoEvil

16:09

https://docs.rs/contracts/0.6.3/contracts/

contracts - Rust

A crate implementing “Design by Contract” via procedural macros.

16:09

@Jupstar ✪ saturday rust crate

Ryozuki

https://docs.rs/contracts/0.6.3/contracts/

Oh this is cool

with require and ensures u can have quite a solid logic

16:11

at comp time

Ryozuki

Benchmark 1: ./target/release/rust-aoc Time (mean ± σ): 359.9 µs ± 40.6 µs [User: 241.1 µs, System: 68.8 µs] Range (min … max): 301.5 µs … 1480.2 µs 10000 runs

Seems there isn't much to be optimized in this round, I get 382 us

hey, is there any way that the master server list region can be changed? my server is being shown as being from asia, while it is located in germany (the ip is 176.116.18.87)

Image attachment

Image attachment

Aha, actually I can do better

17:01

https://paste.pr0.tips/55E?c lots of assumptions made about the sanity of the input

17:03

cc -O3 -static -flto gives me about 250us, that's 130us shaved off my initial naive attempt

Ryozuki

@Insanity hi

Hi!

Jupstar ✪

Hi we need ur art work xd

woahh

[ddnet/ddnet] Pull request opened: #7576 Fix bug when using favourites in combination with prefixes.

Let's say you have twinbop as a favourite. and then use one of the prefixes. It will then bug out and select both of them when hovered. https://github.com/ddnet/ddnet/assets/141338449/7bbf0242-abb2-4f4a-8e5b-b2c17eb1ac3c

Checklist

[x] Tested the change ingame
[ ] Provided screenshots if it is a visual change
[ ] Tested in combination with possibly related configuration options
[ ] Written a unit test (especially base/) or added coverage to integration test
[ ...

[ddnet/ddnet] Pull request opened: #7577 Added search in console (ctrl+f)

Closes #5815. Highlights all occurrences in red. https://github.com/ddnet/ddnet/assets/13364635/cf681e87-6afb-462c-9b2a-e4eec2afac4b

Checklist

[x] Tested the change ingame
[x] Provided screenshots if it is a visual change
[ ] Tested in combination with possibly related configuration options
[ ] Written a unit test (especially base/) or added coverage to integration test
[x] Considered possible null pointers and out of bounds array indexing
[x] Changed no physics...

[ddnet/ddnet] Issue reopened: #7569 BUG 17.4 version tees are missed in spec mode

[ddnet/ddnet] Issue opened: #7578 HTTP serverlist showing wrong region

My server is being shown from a different region than it is - it is located in germany, yet it is being shown as being from ASIA (expected EUR) - The IP from the server is 176.116.18.87. Sadly, because of this newer players (that have the serverlist sorted by players & ping) cant see my server in the top. !image ![image](https://github.com/ddnet/ddnet/assets/135431730/6cca4685-56fe-4567-accb-6275c4eb8c...

[ddnet-web:master] 1 new commit

cc5d767 Add 100 € donation by archimede67 - def-

https://en.wikipedia.org/wiki/Galactic_algorithm

Galactic algorithm

A galactic algorithm is one with world-beating theoretical (asymptotic) performance, but which is never used in practice. Typical reasons are that the performance gains only appear for problems that are so large they never occur, or the algorithm's complexity outweighs a relatively small gain in performance. Galactic algorithms were so named by...

@archimede67 Thanks for the huge donation!

heartw

3

github-merge-queue[bot]

[ddnet:master] 3 new commits

b352545 Improve integration test script - Robyt3 d70fc84 Properly initialize all CClient member variables - Robyt3 e0d0daa Merge pull request #7575 from Robyt3/Client-MemZero-Fix - def-

22:46

[ddnet/ddnet] Pull request closed: #7575 Properly initialize all CClient member variables, improve integration test script

22:46

[ddnet/ddnet] Issue closed: #7553 Valgrind finds many uninitialized member variables

22:52

github-merge-queue[bot]

[ddnet:master] 2 new commits

732b213 Fix bug when using favourites in combination with prefixes. - furo321 07fd8c1 Merge pull request #7576 from furo321/favourite-with-prefix - def-

22:52

[ddnet/ddnet] Pull request closed: #7576 Fix bug when using favourites in combination with prefixes.

Exported 90 message(s)