DDraceNetwork

on last beta hook disappears some time, and always when hold under block

deen

@] @影 Can you check if https://ddnet.org/ddnet-7508.zip works fine?

@! xlays_ ^ can you test that client to see if that fixes your FPS? would be really neat

lolkildal

on last beta hook disappears some time, and always when hold under block

@trml related to https://github.com/ddnet/ddnet/pull/7506 ? (edited)

Make prediction margin take effect instantanously by trml · Pull Re...

This also simplifies the code a bit, and further separates ping calculations from the the margin (e.g. so it does not count towards ping spikes calculated in CSmoothTime). Checklist Tested the ch...

Don't think so, but will test later today, not immediately sure what could have caused it (edited)

I couldn't reproduce the issue @lolkildal is it only on some maps, at some locations?

deen

I couldn't reproduce the issue @lolkildal is it only on some maps, at some locations?

I don't think so, it happens on any map anywhere. the only thing that must be met is that they must be under each other, the difference in coordinates must not be more than .03. i checked this with strong and weak.

Difficult_2.demo

330.27 KB

]

@Jupstar ✪ Hi moderators and admins, I'm having problems running the DDraceNetwork game, since and yesterday. My game is running at 10 fps, as if the video driver was not recognized, can you help me?

it happens to me too

12:35

i normally get 10k fps but sometimes it gets 10fps max

12:36

i reopen the game a couple times then it fixes

@Rotarite Can you check if it works fine with https://ddnet.org/ddnet-7508.zip ?

Rotarite

i normally get 10k fps but sometimes it gets 10fps max

If it's only sometimes it's a different problem

13:10

The guys here never have more than 10

13:10

Literally

hi after update i have so many micro lag how its fix fps is stable ping too (edited)

Learath2

It's in the console, you can enable it by doing cl_show_console 1 on windows and restarting the game

what now? xd??

wats

what now? xd??

https://github.com/ddnet/ddnet/pull/5155

Remove cl_show_console and -c / --console command line options, att...

Alternative to #5154. Closes #5150. If you want to open the client with a console window, instead create a new shortcut with the following target: cmd /c "C:\path\to\your\DDNet.exe" You ...

Oh ok, then just show us the logs in f1

idk

why does my game crash in skin loading? after the newest update

Nooback

why does my game crash in skin loading? after the newest update

crash = closing, or does it say "crash" is there a crash dump in %appdata%/ddnet/dumps?

@Jupstar ✪ there is a crash report

Nooback

@Jupstar ✪ there is a crash report

can u share it here

DDNet_win64-steam_crash_log_2023-11-20_17-15-49_20852_d1310c22731891a3874ff52a83443f7cdd57842f.RTP

10.38 KB

wats

idk

You need to show one where a slow download happens

Nooback

Click to see attachment 🖼️

0x000000073e524452: ?? ??:0
0x0000000140031c82: CGraphics_Threaded::CopyTextureFromTextureBufferSub(unsigned char*, unsigned long long, unsigned long long, unsigned char*, unsigned long long, unsigned long long, unsigned long long, unsigned long long, unsigned long long, unsigned long long, unsigned long long) at src/engine/client/graphics_threaded.cpp:707
 (inlined by) CGraphics_Threaded::LoadSpriteTextureImpl(CImageInfo&, int, int, unsigned long long, unsigned long long) at src/engine/client/graphics_threaded.cpp:370
0x0000000140031dbc: CGraphics_Threaded::LoadSpriteTexture(CImageInfo&, CDataSprite*) at src/engine/client/graphics_threaded.cpp:383
[...]
src/game/client/components/skins.cpp:308
0x00000001400ea112: CGameClient::OnInit() at src/game/client/gameclient.cpp:272
0x0000000140028a1d: CClient::Run() at src/engine/client/client.cpp:2853
0x000000014033a2bf: main at src/engine/client/client.cpp:4580
0x00000001400013b1: __tmainCRTStartup at src/mingw-w64-v10.0.0/mingw-w64-crt/crt/crtexe.c:323
0x00000001400014c6: WinMainCRTStartup at src/mingw-w64-v10.0.0/mingw-w64-crt/crt/crtexe.c:178
0x000000073e777344: ?? ??:0
0x000000073f5526b1: ?? ??:0

16:37

seems like one of your skins causes a segfault i dunno why, I also dunno what changed lately, @Robyt3 BUT, if you only have few custom skins, you could maybe send then

I have exactly 3428 skin files...

1

1

uff

binary search!

Or do a bisect basically, move your skin files to a different folder, then keep adding half of the remaining skins

after deleting duplicates(by name)

Robyt3

Or do a bisect basically, move your skin files to a different folder, then keep adding half of the remaining skins

so no idea what caused it?

16:39

I mean it was working before latest update

I can take a closer look later, but if this is caused by a single skin then it would be very helpful to have it

16:40

Maybe it's just out of memory though?

no skins work

Robyt3

Maybe it's just out of memory though?

Out of memory have crash handler, no?

Nooback

no skins work

Have you tried without any skins? Do you get the same crash log when you start without skins?

Nooback

no skins work

just said it

Mʎɹ シ

Out of memory have crash handler, no?

Not sure, but it's possible that the crash handler can't run due to out of memory either

Nooback

just said it

u can also compress the skins and upload them if u want

I'm adding the skins rn, seems like no problems, I'm at Q now

ok

https://github.com/ddnet/ddnet/pull/7283

16:49

this may be the culprit

it is one of the skins

crashes when loading a Grayscale image

it crashes from W to Z

16:52

in my skins

it would also be fine if u send this subset

one of the W skins

TWCRASH.zip

938.3 KB

17:06

I'm lazy to go through those

17:06

but one of these causes the crash

ty

17:07

"WhiteD"

took me so long to take for real that .zip file is only 1/10 smaller than the folder

Nooback

took me so long to take for real that .zip file is only 1/10 smaller than the folder

PNGs are already very well compressed

17:08

and zip also isnt the best compressing format

Jupstar ✪

"WhiteD"

^ this is the skin btw

does someone has the invisible hook bug?

Cøke

does someone has the invisible hook bug?

i heard it before

17:09

maybe bcs stopper?

17:10

very hard to play like this

i could swear i read this today

17:10

but cant find rn

i had it last night

lolkildal

on last beta hook disappears some time, and always when hold under block

^

Jupstar ✪

^ this is the skin btw

you were right, also no problem rn since I have same skin, just with different name

Jupstar ✪

^

ok good

@Robyt3 in case u want to debug is indeed greyscale

Cøke

Click to see attachment 🖼️

@deen map : flux

@] @影 @! xlays_ @sceinders https://discord.com/channels/252358080522747904/757720336274948198/1175933063730053160 one of you has to test this, nobody from the dev team has a computer where it happens. Thanks

Jupstar ✪

@Robyt3 in case u want to debug is indeed greyscale

Looks like this skin was previously considered unsupported and failed to load cleanly, now it crashes because either we don't handle greyscale correctly or 16 bit color depth

Robyt3

Looks like this skin was previously considered unsupported and failed to load cleanly, now it crashes because either we don't handle greyscale correctly or 16 bit color depth

he defs don't handle greyscale at all xd i think i wrote a converter once

17:39

to convert anything to RGBA

17:39

in graphics class

Can you set libpng to convert to RGBA maybe? (edited)

can't remember tbh

17:41

png_set_gray_to_rgb

The crash log is weird though, it crashes in free for me

well thats not rgba tho xd

png_set_expand() shall set transformation in png_ptr such that paletted images are expanded to RGB, grayscale images of bit-depth less than 8 are expanded to 8-bit images and tRNS chunks are expanded to alpha channels.

17:43

Not for this image with 16 bit depth though

i could have thought i told libpng to only use 8bit depth

17:45

png_set_strip_16(pPNGStruct);

LibPNGGetImageFormat returns IMAGE_FORMAT_RGBA for the greyscale image so we get random memory corruption because the size 4 is used instead of 2, as we simply don't handle greyscale (2 channels) right now

Robyt3

LibPNGGetImageFormat returns IMAGE_FORMAT_RGBA for the greyscale image so we get random memory corruption because the size 4 is used instead of 2, as we simply don't handle greyscale (2 channels) right now

mh was that changed?

18:51

there should have been this call LibPNGSetImageFormat(ImageFormat, ColorType);

That doesn't seem to handle channels=2 either

18:52

https://github.com/ddnet/ddnet/commit/dab88177dd61864fdddf27f22ed4c9057db790f3

Fix images using indexed color palette not being loadable · ddnet/d...

The wrong color channel count was being used for loading images that use an indexed color palette, which was causing the loading to fail with the error "bytes in row incorrect". N...

what even is the second channel for?