chillerdragon BOT 2023-11-19 02:54:09Z

!info

chillerdragon

!info

Command not found!

https://github.com/ChillerDragon/ddnet-bot-irc eth0= commands: !mods, !ping, !p (hex traffixc), !sh (bash)

Omg eth0= is empty. I forgot my raspberry pi ip again

github-merge-queue[bot]

[ddnet:master] 2 new commits

becffb9 Add sv_gametype and sample mod - ChillerDragon d4713cb Merge pull request #7475 from ChillerDragon/pr_gametype_mod - heinrich5991

03:22

heinrich5991

[ddnet/ddnet] Pull request closed: #7475 Add sv_gametype and sample mod

03:22

heinrich5991

[ddnet/ddnet] Issue closed: #7127 Add support for multiple game controllers

03:23

heinrich5991

[ddnet/ddnet] Pull request closed: #7476 Overload GetCharacter with const version

03:23

github-merge-queue[bot]

[ddnet:master] 2 new commits

d42513e Overload GetCharacter() with const version - ChillerDragon 9b024fc Merge pull request #7476 from ChillerDragon/pr_const_char - heinrich5991

Seems like my prognosis was too pessimistic. Still got controller in this weekend :) thanks

Replying to @heinrich5991 why weeks?

heinrich5991

[ddnet/ddnet] Pull request opened: #7495 Allow more complex interaction with the antibot via the console

Allows the antibot to receive arbitrary console commands.

Checklist

[ ] Tested the change ingame
[ ] Provided screenshots if it is a visual change
[ ] Tested in combination with possibly related configuration options
[ ] Written a unit test (especially base/) or added coverage to integration test
[ ] Considered possible null pointers and out of bounds array indexing
[ ] Changed no physics that affect existing maps
[ ] Tested the change with [ASan+UBSan or valgrind...

5

ddnet-maps

[ddnet-maps:master] 1 new commit

16e80dc A Azure - ddnet-maps

def-

[ddnet/ddnet-web] Pull request closed: #274 Version 17.4

08:18

def-

[ddnet-web:master] 2 new commits

71e42f0 Version 17.4 - def- 2a58812 Merge pull request #274 from ddnet/pr-17.4 - def-

heinrich5991

went through all the PRs

thanks a lot!

def-

[ddnet/ddnet] Pull request closed: #7495 Allow more complex interaction with the antibot via the console

09:01

github-merge-queue[bot]

[ddnet:master] 2 new commits

28b0089 Allow more complex interaction with the antibot via the console - heinrich5991 d369238 Merge pull request #7495 from heinrich5991/pr_ddnet_antibot_command - def-

09:06

def-

[ddnet/ddnet] Issue closed: #7494 Serverbrowser unusable with invalid communities JSON

Robyt3

[ddnet/ddnet] Pull request closed: #6279 Try to fix code coverage upload (fixes #6277)

09:43

github-merge-queue[bot]

[ddnet:master] 2 new commits

5ea8a0f Try to fix code coverage upload (fixes #6277) - def- 5ab96de Merge pull request #6279 from def-/pr-headless-cov - Robyt3

@Jupstar ✪ What is benchmark_quit used for? I like to change it so the file is written to the dumps folder in the config dir instead of being an absolute path. I also think it would be easier to use as a CSV file, so instead of printing Frametime %d us to each line I would only print %d so it can be used as a number.

it used for the benchmark suite

10:54

https://openbenchmarking.org/test/pts/ddnet

10:54

i think the format was done on purpose

10:54

but deen did it, better ask him

Robyt3

[ddnet/ddnet] Pull request opened: #7496 Add missing <cstring> include for memset to system.h

Fix compilation with MinGW due to memset call added to system.h in #6256.

Checklist

[X] Tested the change ingame
[ ] Provided screenshots if it is a visual change
[ ] Tested in combination with possibly related configuration options
[ ] Written a unit test (especially base/) or added coverage to integration test
[ ] Considered possible null pointers and out of bounds array indexing
[ ] Changed no physics that affect existing maps
[ ] Tested the change with [AS...

Robyt3

[ddnet/ddnet] Issue opened: #7497 Codecov should not fail PR runs

See #7496.

cyberFighter

I HATE THE EDITOR GRAHHHHH

why do i have to make a new group to change the position of layers

def-

[ddnet/ddnet] Pull request opened: #7498 coverage: Don't complain on PRs (fixes #7497)

Checklist

[ ] Tested the change ingame
[ ] Provided screenshots if it is a visual change
[ ] Tested in combination with possibly related configuration options
[ ] Written a unit test (especially base/) or added coverage to integration test
[ ] Considered possible null pointers and out of bounds array indexing
[ ] Changed no physics that affect existing maps
[ ] Tested the change with [ASan+UBSan or valgrind's memcheck](https://github.com/ddnet/ddnet/#using-ad...

Robyt3

[ddnet/ddnet] Pull request closed: #7498 coverage: Don't complain on PRs (fixes #7497)

11:59

github-merge-queue[bot]

[ddnet:master] 2 new commits

3d485a9 coverage: Don't complain on PRs (fixes #7497) - def- f9464d8 Merge pull request #7498 from def-/pr-codecov-prs - Robyt3

11:59

Robyt3

[ddnet/ddnet] Issue closed: #7497 Codecov should not fail PR runs

someone ran into the same issue when mergin ddnet? in demo.cpp there's if(io_read(File, pDemoHeader, sizeof(CDemoHeader)) != sizeof(CDemoHeader) || !pDemoHeader->Valid()) which screams at me that there's no member named 'valid' (couldnt find it aswell) my problem is that i only ever changed server-side, so i never touched demo.cpp or anything related to it.

Then you are missing some changes that added the CDemoHeader::Valid function in src/engine/demo.h

that would be weird, i merged, accepting all incoming git merge DDNet/master --strategy-option theirs

12:09

but i'll take a look, thanks

ChillerDragon

[ddnet/ddnet] Issue opened: #7499 Naming collision discussion. (chat/local console/remote console)

In this comment robsti asked me to add a "broadcast" command to the client. So I was wondering how bad conflicting names are and if we want to avoid them or not. As far as I know there is no overlap between chat commands, local console commands and remote console commands right now. Yes there are shared commands such as exec but then they do the same thing and have the same command description. Even quit client side...

meloƞ

that would be weird, i merged, accepting all incoming git merge DDNet/master --strategy-option theirs

Why not use the default merging strategy and solve conflicts manually? You are throwing away arbitrary changes with theirs strategy.

i tried doing it manually, but even then the error happened (with even more happening on the src/engine/client/backend/* stuff for some reason

If our changes cause compile errors in your new code then you also need to fix that, throwing your code away in case of conflicts seems suboptimal

true - thanks tho!

ChillerDragon

[ddnet/ddnet] Pull request opened: #7500 Add 0.7 client broadcast feature

Where is this coming from?

Robsti suggested this could be a separate pr. And I welcome every chance of getting pieces of https://github.com/ddnet/ddnet/pull/5949 merged and discussed separately. So this used to be part of the 0.7 client support pr and now is extracted into this one.

What is a client broadcast?

0.7 moved the broadcast to the bottom of the screen. And at the 0.6 location there now sometimes are mess...

7500

1

heinrich5991

[ddnet/ddnet] Issue reopened: #7494 Serverbrowser unusable with invalid communities JSON

Does anyone have xp with bug bounties?

why is there neither a ddnet filter nor an official checkmark in the server browser now

13:11

on the latest nightly

13:12

i really do hope this is just a bug or something

bug

heinrich5991

[ddnet/ddnet] Pull request closed: #7496 Add missing <cstring> include for memset to system.h

13:22

github-merge-queue[bot]

[ddnet:master] 2 new commits

2e7cb9e Add missing <cstring> include for memset to system.h - Robyt3 4d00e8c Merge pull request #7496 from Robyt3/Base-cstring-Include-Fix - heinrich5991

@heinrich5991 isn't there a risk since merging #6256 to have uninitialized vec2 somewhere ?

https://github.com/ddnet/ddnet/pull/6256

Typesafe mem_zero function by heinrich5991 · Pull Request #6256 ·...

My preferred alternative to #6219. Thanks to @Chairn for laying the groundwork for making this safer. This PR simply doesn't allow to call mem_zero on nontrivial types. I like that better than ...

Ooh, I missed the merge of #7325 while I was away. That's exciting

https://github.com/ddnet/ddnet/pull/7325

Add community server filter and icons, remove DDNet and KoG tabs by...

Remove the DDNet and KoG tabs and replace them with a community filter, which works like the country and type filters. Community information (ID, name, icon SHA256, countries, types, servers, ranke...

I predict this one will cause the long awaiting fork

1

Chairn

@heinrich5991 isn't there a risk since merging #6256 to have uninitialized vec2 somewhere ?

yes

Learath2

I predict this one will cause the long awaiting fork

so we all wait that ddnet kills itself, or what?

heinrich5991

[ddnet/ddnet] Pull request opened: #7501 Allow antibot to kick people

Checklist

[x] Tested the change ingame
[ ] Provided screenshots if it is a visual change
[ ] Tested in combination with possibly related configuration options
[ ] Written a unit test (especially base/) or added coverage to integration test
[ ] Considered possible null pointers and out of bounds array indexing
[ ] Changed no physics that affect existing maps
[ ] Tested the change with [ASan+UBSan or valgrind's memcheck](https://github.com/ddnet/ddnet/#using-addresssan...

Jupstar ✪

so we all wait that ddnet kills itself, or what?

ddnet killing itself is not in my expectations at all, so no, I'm not waiting for that

heinrich5991

ddnet killing itself is not in my expectations at all, so no, I'm not waiting for that

what is so horrible about the idea to ask the community first?

13:53

all guys here always say its a community game

13:53

but whenever you and deen have an idea you go all ego

I mean asking the community would probably prevent vulkan, too. showing that not in all questions, the community's opinion is best

Jupstar ✪

so we all wait that ddnet kills itself, or what?

Kill itself? No I expect a couple people to go off on a fork because they are pissed, then it'll be maintained for a while, then they'll get bored of it and disappear or they'll change their mind and come back

well a huge majority

13:54

i bet 75% of the community likes more FPS

do we have stats?

13:54

on community feedback to community browser

Jupstar ✪

i bet 75% of the community likes more FPS

I bet most of the community doesn't care as long as it's stable and reasonably high

probably hard to get because even asking people if they like it results in random responses

heinrich5991

I bet most of the community doesn't care as long as it's stable and reasonably high

so you agree

no, I do not agree

i know

13:55

u always against anything i say

I wouldn't object to asking the community as long as you keep it in mind that people that don't care won't show up

Jupstar ✪

u always against anything i say

that's incorrect

when i say: this change will be liked you say "no i dont like it"

13:56

i understand your way to argument

13:56

it's not logic based

you seem to only remember the instances where we disagree

@Learath2 people not caring not showing up is a good think right? So only the people that care have a voice

u the poor person, that has no chance oh no

thing*

ChillerDragon: not really. sometimes there are good changes that are welcomed by the community, but get held up by few

13:57

yet the people who like it won't show up on the discord

so the people that dont care miss out on stuff they dont care about? :D

There is a silent bulk of players that just don't care all that much as long as things aren't broken, then there is a group of people that like any change but will only react with a

and disappear (which will always look weaker than the 8 paragraphs that people who don't like it will write)

1

ah okay but thats not what i understood from leratos message

13:58

i though everyone who has a opinion might show up and the rest does not

Then there is the Chinese community which makes up 50% of this game that everyone that speaks english is completely okay in not even taking the opinions of because they came after the steam release

I am big fan of asking the community and then letting a dictator decide anyways

13:59

So everyone has a chance to give feedback

I'm okay with asking with opinions on it aswell, just need to keep the factors at play in mind when polling for stuff

Yea you can always overrule poll results

e.g. look at chat tees

14:00

I'd expect the vote to come out as a "no"

14:00

if you suggested the feature before it was in the client

heinrich5991

I'd expect the vote to come out as a "no"

I think it did come out as a "no" and then a config option was added for it as a compromise

yea that was a intense change

14:01

remember emojis? xd

I wonder how many people still use the config option, some sort of telemetry on configuration would actually be pretty cool

Learath2

Kill itself? No I expect a couple people to go off on a fork because they are pissed, then it'll be maintained for a while, then they'll get bored of it and disappear or they'll change their mind and come back

my problem is rather: in the pr i said, we could at least make custom tabs.. i don't really care about the community feature itself. but completely objective, the UI is worse for persons that play: kog, ddnet, fng sadly got ignored, maybe bcs it's too hard. and yes maybe only 25% of the community play these 3 like me and dont need tabs but then heinrich with his absurf backward compability acts like it would kill ppl, even tho it probably affects less ppl i simply dislike the weird argumentations i propose useful ideas, fixing it for all ppl's opinions/needs. try to stay logical, describe my problems with the changes... complete ignore

i think newtee and fokkonaut still play with the old gun position

I think my cute ideas for that PR were also ignored

Jupstar ✪

my problem is rather: in the pr i said, we could at least make custom tabs.. i don't really care about the community feature itself. but completely objective, the UI is worse for persons that play: kog, ddnet, fng sadly got ignored, maybe bcs it's too hard. and yes maybe only 25% of the community play these 3 like me and dont need tabs but then heinrich with his absurf backward compability acts like it would kill ppl, even tho it probably affects less ppl i simply dislike the weird argumentations i propose useful ideas, fixing it for all ppl's opinions/needs. try to stay logical, describe my problems with the changes... complete ignore

I think a PR to allow people to add tabs by themselves would be accepted

yes, but for now it's getting worse

14:02

there is no hurry to merge this community stuff pr

we could aswell wait 6 months and implement all missing features

14:03

now i either use old client or do this PR i dont want to do

There is no way custom tabs ever has decent UX for the layman

14:05

Moving the community filter buttons up top right below the tabs could make it more palatable for people who think the filter ui on the rhs is not friendly

14:06

Which I do kinda agree with, such an important thing hidden away in a sidebar that most people forget exists isn't really the best idea

1

to me filters are smth u rarely change, in any UI

Hm, depends on the sort of UI, on steam I use filters alot

@fokkonaut https://zillyhuhn.com/cs/.1700402971.png

14:09

cl_old_gun_position 1 be like

heinrich5991

I mean asking the community would probably prevent vulkan, too. showing that not in all questions, the community's opinion is best

90% of the community doesn't know what vulkan is, or whether it'll affect their game experience. xd

doesn't stop people from having an opinion ^^

It stops people from caring, so your example isn't really a good comparison to a major change like the server browser one

14:12

(it directly affects all players, the graphics api does not)

I guess that makes sense

Learath2

I wonder how many people still use the config option, some sort of telemetry on configuration would actually be pretty cool

rgpd says hello

Learath2

I wonder how many people still use the config option, some sort of telemetry on configuration would actually be pretty cool

I mean it was probably an insignificant amount of people from the start

I'm already used to the new server browser tbh, so it didn't take very long to adjust

Chairn

rgpd says hello

GDPR doesn't ban all sorts of telemetry outright, as long as we anonymize it properly it should be fine, no?

Chairn

rgpd says hello

ohhhh, that's the french abbreviation?

14:14

no idea about that, just saying that if we go into that direction, we need to look into it

14:14

yeah, RGPD "Règlement Général sur la Protection des Données"

GDPR in english DSGVO in german

is that me or is this completely unused, always written, but never read: https://github.com/ddnet/ddnet/blob/4d00e8c0e3d899b7a77e89e7c8f51d251ba7ef3c/src/game/server/entities/character.h#L206 (edited)

Is there any way to kick out people who use ddos??

@heinrich5991 sometimes it feels you will not accept a no from the community so you just lobby against asking them, making a public announcement, gathering opinions and deciding on that later among active devs is probs better than doing changes blindly and waiting for a reaction

$ rg m_Intersection | cat
src/game/server/gameworld.cpp:                pChr->m_Intersection = IntersectPos;
src/game/server/entities/character.h:    vec2 m_Intersection;

14:18

looks like it

it ia objectively better to ask the community and then take that into account when making the decision

14:18

rather than not doing ao

why pipe into cat?

so

try without

my 5 cents (edited)

interesting

14:19

it gets rid of the interactive mode

14:19

truely minimal

14:19

i like it

*truly btw

forgot who the proper term for the pipe environment is called

14:19

not interactive is it?

14:20

how

14:20

omg

tty ?

wanted to say that too

14:20

but that sounds wrong xd

14:21

@Chairn burn it with fire

14:21

bloat variable

doing it

pog

i also think ddnet needs to consider the opinions of the community more

14:45

referring to jupstar

14:46

at least with ui stuff

could someone take a look at https://github.com/ddnet/ddnet/pull/7501 and merge it if it's okay?

Allow antibot to kick people by heinrich5991 · Pull Request #7501 ·...

Checklist Tested the change ingame Provided screenshots if it is a visual change Tested in combination with possibly related configuration options Written a unit test (especially base/) or add...

14:54

I'd like to deploy an antibot update, but this would require another one, so I'd like to do both in one

Robyt3

[ddnet/ddnet] Pull request opened: #7502 Prevent community filters excluding all elements, fix server browser update on community filter change via console

Ensure that community/country/type filters do not exclude all allowed elements, which can happen when a previously selected community is not available anymore or when arbitrary community filter values are set with the console. Also update server browser filtering/sorting when changing the community/country/type filter config variables with the console. Clean the filter config variables when they are changed instead of only when the community filter is rendered. Closes #7494. ## Ch...

15:20

Robyt3

[ddnet/ddnet] Pull request closed: #7501 Allow antibot to kick people

15:20

github-merge-queue[bot]

[ddnet:master] 2 new commits

a5b72fe Allow antibot to kick people - heinrich5991 9a652ec Merge pull request #7501 from heinrich5991/pr_ddnet_antibot_kick - Robyt3

15:23

ChillerDragon

[ddnet/ddnet] Pull request opened: #7503 Move m_pLoadBestTimeResult to IGameController

Gets rid of more CGameControllerDDRace casts. Those did not show up during compile time only during runtime of another active controller when asan is active.

Checklist

[ ] Tested the change ingame
[ ] Provided screenshots if it is a visual change
[ ] Tested in combination with possibly related configuration options
[ ] Written a unit test (especially base/) or added coverage to integration test
[ ] Considered possible null pointers and out of bounds array indexing
[...

Robyt3

[ddnet/ddnet] Issue reopened: #7497 Codecov should not fail PR runs

def-

[ddnet/ddnet] Pull request opened: #7504 codecov: Also disable annotations (fixes #7498)

Checklist

[ ] Tested the change ingame
[ ] Provided screenshots if it is a visual change
[ ] Tested in combination with possibly related configuration options
[ ] Written a unit test (especially base/) or added coverage to integration test
[ ] Considered possible null pointers and out of bounds array indexing
[ ] Changed no physics that affect existing maps
[ ] Tested the change with [ASan+UBSan or valgrind's memcheck](https://github.com/ddnet/ddnet/#using-ad...

TIL watching memory in gdb is super nice for detecting UB

welcome in 1990

:c

but pro

16:06

not ez to detect it reading memory xd

you can use rwatch to break everytime memory is accessed

16:07

it broke twice on my debug prints

16:07

and the third time was in score.cpp which should not access my variable

16:07

ez

so u run it in production?

nono locally

why not simply use sanitizers then xD

actually i went with sanitziers first they also got the issue instantly xd

16:08

but with gdb i felt more under control

16:08

and verified that the asan stuff was not just a warning or unrelated

xdd

but yeah asan is super pog